Debian Bug report logs - #871357
packaging-tutorial: FTBFS: Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/\\end{ <-- HERE document}/ at /usr/share/perl5/Locale/Po4a/TransTractor.pm line 643.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Lucas Nussbaum <lucas@debian.org>

To: submit@bugs.debian.org

Subject: packaging-tutorial: FTBFS: Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/\\end{ <-- HERE document}/ at /usr/share/perl5/Locale/Po4a/TransTractor.pm line 643.

Date: Mon, 7 Aug 2017 11:58:29 -0400

Source: packaging-tutorial
Version: 0.20
Severity: serious
Tags: buster sid
User: debian-qa@lists.debian.org
Usertags: qa-ftbfs-20170807 qa-ftbfs
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part (hopefully):
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> # version check
> if [ 0.20 != 0.20 ]; then echo "Wrong version in .tex: 0.20 != 0.20"; exit 1; fi
> #translate source files before building pdf
> po4a po4a/po4a.cfg --verbose --keep 50
> Updating po4a/po//packaging-tutorial.pot:
>  (628 entries)
> Updating po4a/po//de.po: 
> ................................................................................................................ done.
> po4a/po//de.po: 628 translated messages.
> Updating po4a/po//es.po: 
> ................................................................................................. done.
> po4a/po//es.po: 453 translated messages, 112 fuzzy translations, 63 untranslated messages.
> Updating po4a/po//fr.po: 
> .............................................................................................. done.
> po4a/po//fr.po: 628 translated messages.
> Updating po4a/po//ja.po: 
> .......................................................................................... done.
> po4a/po//ja.po: 540 translated messages, 66 fuzzy translations, 22 untranslated messages.
> Updating po4a/po//pt.po: 
> ............................................................................................. done.
> po4a/po//pt.po: 628 translated messages.
> Updating po4a/po//ru.po: 
> ....................................................................................................................... done.
> po4a/po//ru.po: 628 translated messages.
> Updating po4a/po//zh_TW.po: 
> ............................................................................................... done.
> po4a/po//zh_TW.po: 628 translated messages.
> packaging-tutorial.de.tex is 100% translated (731 strings).
> debiantutorial.de.sty is 100% translated (1 strings).
> Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/\\end{ <-- HERE document}/ at /usr/share/perl5/Locale/Po4a/TransTractor.pm line 643.
> debian/rules:13: recipe for target 'override_dh_auto_build' failed
> make[1]: *** [override_dh_auto_build] Error 255

The full build log is available from:
   http://aws-logs.debian.net/2017/08/07/packaging-tutorial_0.20_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.

Message #16 received at 871357@bugs.debian.org (full text, mbox, reply):

From: gregor herrmann <gregoa@debian.org>

To: Lucas Nussbaum <lucas@debian.org>, 871357@bugs.debian.org, packaging-tutorial@packages.debian.org

Subject: Re: Bug#871357: packaging-tutorial: FTBFS: Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/\\end{ <-- HERE document}/ at /usr/share/perl5/Locale/Po4a/TransTractor.pm line 643.

Date: Tue, 8 Aug 2017 16:13:47 -0400

[Message part 1 (text/plain, inline)]

Control: tag -1 + patch

On Mon, 07 Aug 2017 11:58:29 -0400, Lucas Nussbaum wrote:

> > Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/\\end{ <-- HERE document}/ at /usr/share/perl5/Locale/Po4a/TransTractor.pm line 643.
> > debian/rules:13: recipe for target 'override_dh_auto_build' failed
> > make[1]: *** [override_dh_auto_build] Error 255

That's an interesting bug.

The error is in /usr/share/perl5/Locale/Po4a/TransTractor.pm:643
which is
    my $found = scalar grep { /$position/ } @{$self->{TT}{doc_out}};
and $position (comes from addendum_parse() in the same file and)
contains '\\end{document}' at that point.

And this '\\end{document}' itself comes from files in the
packaging-tutorial po4a directory.

So I don't know if po4a needs a generic fix, or packaging-tutorial
needs to change how it uses it.

I'm attaching a patch for the second option.


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at/ - Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   

[871357.diff (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 871357@bugs.debian.org (full text, mbox, reply):

From: Martin Quinson <martin.quinson@ens-rennes.fr>

To: gregor herrmann <gregoa@debian.org>, 871357@bugs.debian.org

Cc: Lucas Nussbaum <lucas@debian.org>, packaging-tutorial@packages.debian.org

Subject: Re: Bug#871357: packaging-tutorial: FTBFS: Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/\\end{ <-- HERE document}/ at /usr/share/perl5/Locale/Po4a/TransTractor.pm line 643.

Date: Tue, 8 Aug 2017 23:55:26 +0200

[Message part 1 (text/plain, inline)]

Hello,

Thanks for investigating this bug.

On Tue, Aug 08, 2017 at 04:13:47PM -0400, gregor herrmann wrote:
> Control: tag -1 + patch
> 
> On Mon, 07 Aug 2017 11:58:29 -0400, Lucas Nussbaum wrote:
> 
> > > Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/\\end{ <-- HERE document}/ at /usr/share/perl5/Locale/Po4a/TransTractor.pm line 643.
> > > debian/rules:13: recipe for target 'override_dh_auto_build' failed
> > > make[1]: *** [override_dh_auto_build] Error 255
> 
> That's an interesting bug.
> 
> The error is in /usr/share/perl5/Locale/Po4a/TransTractor.pm:643
> which is
>     my $found = scalar grep { /$position/ } @{$self->{TT}{doc_out}};
> and $position (comes from addendum_parse() in the same file and)
> contains '\\end{document}' at that point.
> 
> And this '\\end{document}' itself comes from files in the
> packaging-tutorial po4a directory.
> 
> So I don't know if po4a needs a generic fix, or packaging-tutorial
> needs to change how it uses it.

I would be unable to generate a patch for the first option. My perl is
rather rotten nowadays. I think that the second option is sensible:
packaging-tutorial is providing some code that is interpreted by po4a,
so it should ensure that it provides correct code.

> I'm attaching a patch for the second option.

Many thanks for that. It looks great to me.

Bye, Mt.

-- 
The most exciting phrase to hear in science, the one that heralds new
discoveries, is not "Eureka!" (I found it!) but "That's funny ..."
          --- Isaac Asimov

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 871357@bugs.debian.org (full text, mbox, reply):

From: gregor herrmann <gregoa@debian.org>

To: Martin Quinson <martin.quinson@ens-rennes.fr>

Cc: 871357@bugs.debian.org, Lucas Nussbaum <lucas@debian.org>, packaging-tutorial@packages.debian.org

Subject: Re: Bug#871357: packaging-tutorial: FTBFS: Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/\\end{ <-- HERE document}/ at /usr/share/perl5/Locale/Po4a/TransTractor.pm line 643.

Date: Sun, 13 Aug 2017 12:25:54 -0400

[Message part 1 (text/plain, inline)]

On Tue, 08 Aug 2017 23:55:26 +0200, Martin Quinson wrote:

> Thanks for investigating this bug.

Thanks for looking into this issue.
 
> > The error is in /usr/share/perl5/Locale/Po4a/TransTractor.pm:643
> > which is
> >     my $found = scalar grep { /$position/ } @{$self->{TT}{doc_out}};
> > and $position (comes from addendum_parse() in the same file and)
> > contains '\\end{document}' at that point.
> > 
> > And this '\\end{document}' itself comes from files in the
> > packaging-tutorial po4a directory.
> > 
> > So I don't know if po4a needs a generic fix, or packaging-tutorial
> > needs to change how it uses it.
> 
> I would be unable to generate a patch for the first option. My perl is
> rather rotten nowadays. 

I also think it would be difficult; all tha po4a sees at this point
is a string, and it's probably impossible to preprocess it into a
regexp.

What po4a could maybe do is to mention in the documentation that the
string in "position=something" in addendums will be interpreted as a
Perl regexp later.

> I think that the second option is sensible:
> packaging-tutorial is providing some code that is interpreted by po4a,
> so it should ensure that it provides correct code.

I tend to agree. (And it aleady escapes the backslash.)
 

Lucas, what do you think?


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at/ - Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   

[signature.asc (application/pgp-signature, inline)]

Message #33 received at 871357@bugs.debian.org (full text, mbox, reply):

From: Martin Quinson <martin.quinson@ens-rennes.fr>

To: gregor herrmann <gregoa@debian.org>

Cc: 871357@bugs.debian.org, Lucas Nussbaum <lucas@debian.org>, packaging-tutorial@packages.debian.org

Subject: Re: Bug#871357: packaging-tutorial: FTBFS: Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/\\end{ <-- HERE document}/ at /usr/share/perl5/Locale/Po4a/TransTractor.pm line 643.

Date: Mon, 14 Aug 2017 01:04:36 +0200

[Message part 1 (text/plain, inline)]

On Sun, Aug 13, 2017 at 12:25:54PM -0400, gregor herrmann wrote:

> What po4a could maybe do is to mention in the documentation that the
> string in "position=something" in addendums will be interpreted as a
> Perl regexp later.

It's already the case:

position (mandatory)
    a Perl regexp. The addendum will be placed near the line matching
    this regexp. Note that we're speaking about the translated
    document here, not the original. If more than a line match this
    expression (or none), the addition will fail. It is indeed better
    to report an error than inserting the addendum at the wrong
    location. 

(I just added "Perl" in the first sentence, but the doc is otherwise
unchanged) If it's not explicit enough, please tell me how I could
improve it.

Thanks, Mt.

-- 
If Java had true garbage collection, most programs would delete
themselves upon execution.           -- Robert Sewell

[signature.asc (application/pgp-signature, inline)]

Message #38 received at 871357@bugs.debian.org (full text, mbox, reply):

From: gregor herrmann <gregoa@debian.org>

To: Martin Quinson <martin.quinson@ens-rennes.fr>

Cc: 871357@bugs.debian.org, Lucas Nussbaum <lucas@debian.org>, packaging-tutorial@packages.debian.org

Subject: Re: Bug#871357: packaging-tutorial: FTBFS: Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/\\end{ <-- HERE document}/ at /usr/share/perl5/Locale/Po4a/TransTractor.pm line 643.

Date: Mon, 14 Aug 2017 11:10:58 +0200

[Message part 1 (text/plain, inline)]

On Mon, 14 Aug 2017 01:04:36 +0200, Martin Quinson wrote:

> On Sun, Aug 13, 2017 at 12:25:54PM -0400, gregor herrmann wrote:
> > What po4a could maybe do is to mention in the documentation that the
> > string in "position=something" in addendums will be interpreted as a
> > Perl regexp later.
> It's already the case:
> 
> position (mandatory)
>     a Perl regexp. The addendum will be placed near the line matching
>     this regexp. Note that we're speaking about the translated
>     document here, not the original. If more than a line match this
>     expression (or none), the addition will fail. It is indeed better
>     to report an error than inserting the addendum at the wrong
>     location. 

Excellent, thanks, and sorry for not checking beforehand.
 
> (I just added "Perl" in the first sentence, but the doc is otherwise
> unchanged) If it's not explicit enough, please tell me how I could
> improve it.

I think it's fine this way.


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at/ - Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Fleetwood Mac: Don't Stop

[signature.asc (application/pgp-signature, inline)]

Message #43 received at 871357-close@bugs.debian.org (full text, mbox, reply):

From: Lucas Nussbaum <lucas@debian.org>

To: 871357-close@bugs.debian.org

Subject: Bug#871357: fixed in packaging-tutorial 0.21

Date: Tue, 15 Aug 2017 10:49:04 +0000

Source: packaging-tutorial
Source-Version: 0.21

We believe that the bug you reported is fixed in the latest version of
packaging-tutorial, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 871357@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Lucas Nussbaum <lucas@debian.org> (supplier of updated packaging-tutorial package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 15 Aug 2017 12:06:37 +0200
Source: packaging-tutorial
Binary: packaging-tutorial
Architecture: source
Version: 0.21
Distribution: unstable
Urgency: medium
Maintainer: Lucas Nussbaum <lucas@debian.org>
Changed-By: Lucas Nussbaum <lucas@debian.org>
Description:
 packaging-tutorial - introduction to Debian packaging
Closes: 871357
Changes:
 packaging-tutorial (0.21) unstable; urgency=medium
 .
   * Point to Guide for Debian Maintainers.
   * Fixes "FTBFS: Unescaped left brace in regex is illegal here in regex":
     escape braces in addendums. (Closes: #871357)
     Patch from gregor herrmann <gregoa@debian.org>
Checksums-Sha1:
 8e036766d016a6166327fc167da6d85be1791284 1944 packaging-tutorial_0.21.dsc
 5a141e3f929090f53fc3612da18e3a2e5932fc5c 276032 packaging-tutorial_0.21.tar.xz
 56e07cbfb168524ed9e37b4262475d9f45d17888 10700 packaging-tutorial_0.21_source.buildinfo
Checksums-Sha256:
 751ec4c454fa6f2e8fa55693d3db2baa72ff46e0960c9302c4b9d7c099e080de 1944 packaging-tutorial_0.21.dsc
 11d886bae0078b369e36bb31bf8327ba038a5da827f18adaa8a72ea7ca4fbaf8 276032 packaging-tutorial_0.21.tar.xz
 334471930429e5c49bde32a266ca179b08455cd425856dc0546aea4a509c411d 10700 packaging-tutorial_0.21_source.buildinfo
Files:
 6e30f280eb6799769c4d1945ea178fe7 1944 doc extra packaging-tutorial_0.21.dsc
 b2d3ae58d33827d1fb5295c7b532911a 276032 doc extra packaging-tutorial_0.21.tar.xz
 6bbf25d505d1e20d775d129029f371f5 10700 doc extra packaging-tutorial_0.21_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE/t7ByzN7z1CfQ8IkORS1MvTfvpkFAlmSzw8ACgkQORS1MvTf
vpkIHhAAjWTL2R8tjImQu3fVOSQkvzUpvjkUzzQzU+O8WkGV2CP7SYW9LYnMnpKH
fzisMyuQoTyslbKjUTHKvR1VBrgRUAaySvyKiD2VFcZkSehjr+rFR1b2IKW6NhAx
sQaYNZ63Z7NUE1wpJZUeQQsdZMoqhi3e4pNPXP12VX0VAHGMe2hWz/EIlJeFPQ4O
4yLEKaiJOo6hntTVzOFCV2acbnX+/FcEc+X2A6QzDCjU5jWj0xa6+ceF1Rok4TR1
JLyIDPnoyeeBd1o9lg3NEULw1TX2Vv98dZRW+NanSqd07aVS6sySwNtnX1u1uA5Y
isOe7KNVuxZCHnn3tREcUHpL83NcnZsLDnRoxKS65vO3JuV7NXB4q3+HqRD8EzLt
qvkklbEBJOdpqLzTe0ojzYj+yBgNcgmLM9LZfmrNN2CHQeEhnGG69nJs6WZjMOwR
vwS3UHZMnofLi4YdiG8QvofqCSdnlSpJnGK1svgLXEucnKSKQZvqhdYydlKWkxL5
VlFlaLUlOwxRhnznQ5gcvB7V2lbTNf0bjwsjegEh2CLa/wCrJbJCqsOMp3l7g1aw
A0EP1UUUyfra7bDK7IHV/fCR+napyqxBAg9V0Gv1w/YAKcCMBuWxilVdU9FOdlpH
h2eHgcA6iJyAUyi78cRc75NJ6OI2OSXeqDAx1ix+OxGb9CkAwQs=
=jrmB
-----END PGP SIGNATURE-----

Message #48 received at 871357@bugs.debian.org (full text, mbox, reply):

From: Lucas Nussbaum <lucas@debian.org>

To: gregor herrmann <gregoa@debian.org>

Cc: 871357@bugs.debian.org

Subject: Re: Bug#871357: packaging-tutorial: FTBFS: Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/\\end{ <-- HERE document}/ at /usr/share/perl5/Locale/Po4a/TransTractor.pm line 643.

Date: Tue, 15 Aug 2017 12:38:47 +0200

On 08/08/17 at 16:13 -0400, gregor herrmann wrote:
> Control: tag -1 + patch
> 
> On Mon, 07 Aug 2017 11:58:29 -0400, Lucas Nussbaum wrote:
> 
> > > Unescaped left brace in regex is illegal here in regex; marked by <-- HERE in m/\\end{ <-- HERE document}/ at /usr/share/perl5/Locale/Po4a/TransTractor.pm line 643.
> > > debian/rules:13: recipe for target 'override_dh_auto_build' failed
> > > make[1]: *** [override_dh_auto_build] Error 255
> 
> That's an interesting bug.
> 
> The error is in /usr/share/perl5/Locale/Po4a/TransTractor.pm:643
> which is
>     my $found = scalar grep { /$position/ } @{$self->{TT}{doc_out}};
> and $position (comes from addendum_parse() in the same file and)
> contains '\\end{document}' at that point.
> 
> And this '\\end{document}' itself comes from files in the
> packaging-tutorial po4a directory.
> 
> So I don't know if po4a needs a generic fix, or packaging-tutorial
> needs to change how it uses it.
> 
> I'm attaching a patch for the second option.

Thanks, patch applied and package uploaded!

Lucas

Send a report that this bug log contains spam.