Debian Bug report logs -
#871254
pcp missing autopkgtests and debian/watch
Reported by: Dariusz Gadomski <dariusz.gadomski@canonical.com>
Date: Mon, 7 Aug 2017 10:09:01 UTC
Severity: normal
Found in version pcp/3.12.0
Fixed in version pcp/3.12.1
Done: Nathan Scott <nathans@debian.org>
Bug is archived. No further changes may be made.
Toggle useless messages
Report forwarded
to debian-bugs-dist@lists.debian.org, PCP Development Team <pcp@groups.io>:
Bug#871254; Package pcp.
(Mon, 07 Aug 2017 10:09:04 GMT) (full text, mbox, link).
Acknowledgement sent
to Dariusz Gadomski <dariusz.gadomski@canonical.com>:
New Bug report received and forwarded. Copy sent to PCP Development Team <pcp@groups.io>.
(Mon, 07 Aug 2017 10:09:04 GMT) (full text, mbox, link).
Message #5 received at submit@bugs.debian.org (full text, mbox, reply):
Package: pcp
Version: 3.12.0
There is an effort ongoing to make pcp included in the main component
of the Ubuntu 17.10 release (this may be tracked at [1]).
As a part of this effort we want to improve the quality of the
packaging by integrating autopkgtest and debian/watch file for this
package.
Please consider integrating the proposed patch into Debian packaging.
[1] http://bugs.launchpad.net/bugs/1700827
Information forwarded
to debian-bugs-dist@lists.debian.org, PCP Development Team <pcp@groups.io>:
Bug#871254; Package pcp.
(Mon, 07 Aug 2017 10:15:03 GMT) (full text, mbox, link).
Acknowledgement sent
to Dariusz Gadomski <dariusz.gadomski@canonical.com>:
Extra info received and forwarded to list. Copy sent to PCP Development Team <pcp@groups.io>.
(Mon, 07 Aug 2017 10:15:03 GMT) (full text, mbox, link).
Message #10 received at 871254@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
Adding patch proposal.
[pcp_3.12.0-1.debdiff (text/plain, attachment)]
Information forwarded
to debian-bugs-dist@lists.debian.org, PCP Development Team <pcp@groups.io>:
Bug#871254; Package pcp.
(Thu, 10 Aug 2017 06:27:02 GMT) (full text, mbox, link).
Acknowledgement sent
to Ken McDonell <kenj@kenj.id.au>:
Extra info received and forwarded to list. Copy sent to PCP Development Team <pcp@groups.io>.
(Thu, 10 Aug 2017 06:27:03 GMT) (full text, mbox, link).
Message #15 received at 871254@bugs.debian.org (full text, mbox, reply):
Dariusz,
There is an extensive PCP QA infrastructure included in the PCP source distribution (it is below the top-level qa directory).
Rather than writing more unit tests in Python, I would recommend using a subset of the existing QA tests ...
kenj@bozo:~/src/pcp/qa$ cloc .
4233 text files.
3891 unique files.
2713 files ignored.
http://cloc.sourceforge.net v 1.60 T=19.32 s (78.1 files/s, 13378.6 lines/s)
--------------------------------------------------------------------------------
Language files blank comment code
--------------------------------------------------------------------------------
XML 32 125 25 101264
Bourne Shell 1139 14451 15459 76548
C 205 4749 2444 33380
Python 22 581 485 2194
C++ 10 463 113 1743
make 60 541 210 1721
Perl 11 128 84 672
Bourne Again Shell 3 62 74 422
ASP.Net 8 19 0 207
IDL 10 0 0 140
C/C++ Header 7 10 32 70
NAnt scripts 1 1 0 8
--------------------------------------------------------------------------------
SUM: 1508 21130 18926 218369
within this arsenal of tests, there is a "sanity" group that might fit the bill.
I am unfamiliar with autopkgtests, could you please describe:
- the goals of autopkgtests (specifically what level of testing confidence is aimed for)
- the environment it runs in (post build, with all PCP packages installed?)
- the way it is invoked and the results it must pass back
I'll bet a thin wrapper between the autopkgtests test harness and the existing PCP QA infrastructure will more than match the requirements and keep the test maintenance effort with the upstream PCP development community.
Cheers, Ken.
Information forwarded
to debian-bugs-dist@lists.debian.org, PCP Development Team <pcp@groups.io>:
Bug#871254; Package pcp.
(Wed, 16 Aug 2017 14:51:05 GMT) (full text, mbox, link).
Acknowledgement sent
to Dariusz Gadomski <dariusz.gadomski@canonical.com>:
Extra info received and forwarded to list. Copy sent to PCP Development Team <pcp@groups.io>.
(Wed, 16 Aug 2017 14:51:05 GMT) (full text, mbox, link).
Message #20 received at 871254@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
Hello Ken.
Thank you for looking into this issue. I fully agree with the approach
to reuse as much of the existing QA infrastructure as possible.
> I am unfamiliar with autopkgtests, could you please describe:
> - the goals of autopkgtests (specifically what level of testing confidence is aimed for)
The slightly different purpose of the autopkgtests is the reason for me
making the effort of providing the additional tests.
Autopkgtests are intented to be a suite of rather light-weight
integration/acceptance level tests rather than functionality tests.
Their goal is usually to smoke-test the system integration pieces
after any changes done to the packaging (including the software dependencies),
init script management, security policies.
Hence, one of the tests provided checks if e.g. pmcd has been started
correctly, no default firewall policies prevent it from being accessed
(including those introduced in the future) etc.
> - the environment it runs in (post build, with all PCP packages installed?)
It runs in a clean, minimal environment - usually in a VM or a container.
I'm not sure how does it look in Debian, but in case of
Ubuntu it is run every time a Stable Release Update is being prepared for
release to the -proposed pocket. Only packages listed as 'Depends:' in
debian/tests/control are installed on top of the minimal environment.
A clean environment is used for every 'Test:' listed in the control
file, so ideally they should not depend on each other.
> - the way it is invoked and the results it must pass back
The test scripts are run as a non-root user with debian/tests set as CWD. They
are considered successful as long as nothing is written to stderr and return 0.
There are some configuration options changing this behaviour (more info at [1]).
> I'll bet a thin wrapper between the autopkgtests test harness and the existing PCP QA infrastructure will more than match the requirements and keep the test maintenance effort with the upstream PCP development community.
I believe it would a a good idea to include the sanity group as an additional
step of autopkgtests. Moreover, I have already done some tests in that area.
Sadly, I noticed that the test 354 fails consistently while running
in a lxd container with lxd exec <container> /bin/bash. Running on metal or
in a KVM seems to be perfectly fine).
Looks like its result depends on pipe fd numbering assingned by the system
which seems to differ slightly in this case (please check the attached diff).
Thanks,
Dariusz
[1] http://anonscm.debian.org/cgit/autopkgtest/autopkgtest.git/tree/doc/README.package-tests.rst
[354.diff (text/x-diff, attachment)]
Reply sent
to Nathan Scott <nathans@debian.org>:
You have taken responsibility.
(Wed, 16 Aug 2017 23:36:06 GMT) (full text, mbox, link).
Notification sent
to Dariusz Gadomski <dariusz.gadomski@canonical.com>:
Bug acknowledged by developer.
(Wed, 16 Aug 2017 23:36:06 GMT) (full text, mbox, link).
Message #25 received at 871254-close@bugs.debian.org (full text, mbox, reply):
Source: pcp
Source-Version: 3.12.1
We believe that the bug you reported is fixed in the latest version of
pcp, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 871254@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Nathan Scott <nathans@debian.org> (supplier of updated pcp package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 16 Aug 2017 12:03:42 +1000
Source: pcp
Binary: pcp pcp-conf libpcp3-dev libpcp3 libpcp-gui2-dev libpcp-gui2 libpcp-mmv1-dev libpcp-mmv1 libpcp-pmda3-dev libpcp-pmda3 libpcp-trace2-dev libpcp-trace2 libpcp-import1-dev libpcp-import1 libpcp-web1-dev libpcp-web1 python-pcp python3-pcp libpcp-pmda-perl libpcp-import-perl libpcp-logsummary-perl libpcp-mmv-perl pcp-import-sar2pcp pcp-import-ganglia2pcp pcp-import-mrtg2pcp pcp-import-sheet2pcp pcp-import-iostat2pcp pcp-import-collectl2pcp pcp-export-pcp2graphite pcp-export-pcp2influxdb pcp-export-zabbix-agent pcp-doc pcp-testsuite pcp-manager pcp-webapi pcp-gui
Architecture: source
Version: 3.12.1
Distribution: unstable
Urgency: low
Maintainer: PCP Development Team <pcp@groups.io>
Changed-By: Nathan Scott <nathans@debian.org>
Description:
libpcp-gui2 - Performance Co-Pilot graphical client tools library
libpcp-gui2-dev - Performance Co-Pilot graphical client tools library and headers
libpcp-import-perl - Performance Co-Pilot log import Perl module
libpcp-import1 - Performance Co-Pilot data import library
libpcp-import1-dev - Performance Co-Pilot data import library and headers
libpcp-logsummary-perl - Performance Co-Pilot historical log summary module
libpcp-mmv-perl - Performance Co-Pilot Memory Mapped Value Perl module
libpcp-mmv1 - Performance Co-Pilot Memory Mapped Value client library
libpcp-mmv1-dev - Performance Co-Pilot Memory Mapped Value library and headers
libpcp-pmda-perl - Performance Co-Pilot Domain Agent Perl module
libpcp-pmda3 - Performance Co-Pilot Domain Agent library
libpcp-pmda3-dev - Performance Co-Pilot Domain Agent library and headers
libpcp-trace2 - Performance Co-Pilot application tracing library
libpcp-trace2-dev - Performance Co-Pilot application tracing library and headers
libpcp-web1 - Performance Co-Pilot data import library
libpcp-web1-dev - Performance Co-Pilot web tooling
libpcp3 - Performance Co-Pilot library
libpcp3-dev - Performance Co-Pilot library and headers
pcp - System level performance monitoring and performance management
pcp-conf - Performance Co-Pilot runtime configuration
pcp-doc - Documentation and tutorial for the Performance Co-Pilot
pcp-export-pcp2graphite - Tool for exporting data from PCP to Graphite
pcp-export-pcp2influxdb - Tool for exporting data from PCP to InfluxDB
pcp-export-zabbix-agent - Module for exporting PCP metrics to Zabbix agent
pcp-gui - Visualisation tools for the Performance Co-Pilot toolkit
pcp-import-collectl2pcp - Tool for importing data from collectl into PCP archive logs
pcp-import-ganglia2pcp - Tool for importing data from ganglia into PCP archive logs
pcp-import-iostat2pcp - Tool for importing data from iostat into PCP archive logs
pcp-import-mrtg2pcp - Tool for importing data from MRTG into PCP archive logs
pcp-import-sar2pcp - Tool for importing data from sar into PCP archive logs
pcp-import-sheet2pcp - Tool for importing data from a spreadsheet into PCP archive logs
pcp-manager - Performance Co-Pilot (PCP) manager daemon
pcp-testsuite - Performance Co-Pilot (PCP) Test Suite
pcp-webapi - Performance Co-Pilot (PCP) web API service
python-pcp - Performance Co-Pilot Python PMAPI module
python3-pcp - Performance Co-Pilot Python3 PMAPI module
Closes: 871254
Changes:
pcp (3.12.1) unstable; urgency=low
.
* New release (full details in CHANGELOG).
* Added autopkgtests and d/watch. (closes: #871254)
Checksums-Sha1:
e12056c2ef71e43a14d7b089e0c49439f2d0a875 4235 pcp_3.12.1.dsc
57ce12602e400e874c474fadf76d68d6bf3ff308 12171096 pcp_3.12.1.tar.xz
49e0e8e5f8faa08eb584f0bdd3c4f048c5e67eb5 12699 pcp_3.12.1_source.buildinfo
Checksums-Sha256:
f97d8c1e8e174bf0ef34ac7327f6e690cc83105f198da0f52998949e7e7844f9 4235 pcp_3.12.1.dsc
96ee960d3d21c5102592c9920a4a9fed6826f2b736e9673f01db6e69e4711c01 12171096 pcp_3.12.1.tar.xz
1eb58e0fed9a825f9994d0d46b10cd599119c99e5e33dc40be00b37cf1125165 12699 pcp_3.12.1_source.buildinfo
Files:
91e9d37944423c240a666e2b765b8f4d 4235 utils extra pcp_3.12.1.dsc
ae6efe1b435613fc2d942ce2fbd75764 12171096 utils extra pcp_3.12.1.tar.xz
efe779088e9e42b61a27114fe7ccd40b 12699 utils extra pcp_3.12.1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAEBCAAGBQJZlMwsAAoJEP4IQu423YwMCU8P/jKVxNW8BNgImh3JkZ/Ruv6l
69X2S76EAVx/RxTyBoucOEvHbCHyAnsbg7mkw7RXLHsdCPldYM7PIUdPuy1Z+hhZ
j+XwSI6rmEJ8bAs1152EJL3FiYH7EH9Rf/vVhC/THfFAP1Wtu21gYA+2Xry+hSJP
CAiZUr7s6wR2kOjPBB4c6GBy57Yg/GlMPoBhpxKddFkA+qlkbShkWRwTj4zfFiMY
33RdleI1Ey3y7uF8mnYSrLw6r2JWo+S+vM8NtphJpiHqohzLSyruaW3lYtQ3uYXa
328Lhlbu0O3Tgs/j3Wap4dRux/8KassQUouCEXL5R7T/VxF0rvRLHhc9s981P0TK
O7aO4Huakor5Idgv4Kh6JmgDvNxbPSkhiFlFFcbL6LUoGQSYGidqaDnIa5L72z30
uA+lA5NSPaxuGmS7CcMjaizwZvr9sU6ytwprcEGf3DAok6HoxbdhmmRqfqyVnV33
TBSBbcQZBC+Hws/QXMBrcHMrvpmqI1mXHsGPqa3dU8BVsCDumQHzC7CIAd1hbrEl
MdzwLx4BpAk+p0OK98P1gkcBkJNJieHW2bgcZ6VSsP/BtchsBbHP893pl9bdq+en
pHTYDkvvvGyz8dyPqO8ukmDleXXV1+VNJgHylhV4E8nECFZpg8uMcL5haW7/3RCm
FtUi4NmjACC55sAnxFw1
=AEt9
-----END PGP SIGNATURE-----
Bug archived.
Request was from Debbugs Internal Request <owner@bugs.debian.org>
to internal_control@bugs.debian.org.
(Fri, 15 Sep 2017 07:28:18 GMT) (full text, mbox, link).
Send a report that this bug log contains spam.
Debian bug tracking system administrator <owner@bugs.debian.org>.
Last modified:
Wed Jan 10 06:40:19 2018;
Machine Name:
beach
Debian Bug tracking system
Debbugs is free software and licensed under the terms of the GNU
Public License version 2. The current version can be obtained
from https://bugs.debian.org/debbugs-source/.
Copyright © 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson,
2005-2017 Don Armstrong, and many other contributors.