Debian Bug report logs - #871114
widelands: FTBFS: game_settings.h:52:8: error: 'newuser.UserSettings::position' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Lucas Nussbaum <lucas@debian.org>

To: submit@bugs.debian.org

Subject: widelands: FTBFS: game_settings.h:52:8: error: 'newuser.UserSettings::position' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Date: Sun, 6 Aug 2017 17:36:47 -0400

Source: widelands
Version: 1:19+repack-3
Severity: serious
Tags: buster sid
User: debian-qa@lists.debian.org
Usertags: qa-ftbfs-20170805 qa-ftbfs
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part (hopefully):
> cd /<<BUILDDIR>>/widelands-19+repack/obj-x86_64-linux-gnu/src/network && /usr/bin/c++   -I/<<BUILDDIR>>/widelands-19+repack/src -I/<<BUILDDIR>>/widelands-19+repack/obj-x86_64-linux-gnu/src -isystem /usr/include/SDL2 -isystem /usr/include/minizip -isystem /usr/include/GL  -g -O2 -fdebug-prefix-map=/<<BUILDDIR>>/widelands-19+repack=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG    -std=c++11 -fext-numeric-literals -g -O3 -DNDEBUG -DNOPARACHUTE -Wall -Wpedantic -Wdeprecated-declarations -Wextra -Wformat -Wformat-nonliteral -Wformat-security -Wformat-y2k -Winit-self -Winvalid-pch -Wlogical-op -Wmissing-include-dirs -Wno-undef -Wold-style-cast -Woverlength-strings -Wpacked -Wpointer-arith -Wredundant-decls -Wsign-promo -Wsync-nand -Wtrampolines -Wundef -Wunused -Wunused-macros -Werror=format-security -Werror=return-type -Werror=shadow -Werror=uninitialized -o CMakeFiles/network.dir/network_player_settings_backend.cc.o -c /<<BUILDDIR>>/widelands-19+repack/src/network/network_player_settings_backend.cc
> In file included from /<<BUILDDIR>>/widelands-19+repack/src/network/network.h:29:0,
>                  from /<<BUILDDIR>>/widelands-19+repack/src/network/network.cc:20:
> /<<BUILDDIR>>/widelands-19+repack/src/network/network.h: In member function 'virtual const char* ProtocolException::what() const':
> /<<BUILDDIR>>/widelands-19+repack/src/base/wexception.h:63:90: warning: throw will always call terminate() [-Wterminate]
>  #define NEVER_HERE() throw WException(__FILE__, __LINE__, "Unreachable code was reached.")
>                                                                                           ^
> /<<BUILDDIR>>/widelands-19+repack/src/network/network.h:184:3: note: in expansion of macro 'NEVER_HERE'
>    NEVER_HERE();
>    ^~~~~~~~~~
> In file included from /<<BUILDDIR>>/widelands-19+repack/src/network/network.h:29:0,
>                  from /<<BUILDDIR>>/widelands-19+repack/src/network/internet_gaming.h:34,
>                  from /<<BUILDDIR>>/widelands-19+repack/src/network/internet_gaming.cc:20:
> /<<BUILDDIR>>/widelands-19+repack/src/network/network.h: In member function 'virtual const char* ProtocolException::what() const':
> /<<BUILDDIR>>/widelands-19+repack/src/base/wexception.h:63:90: warning: throw will always call terminate() [-Wterminate]
>  #define NEVER_HERE() throw WException(__FILE__, __LINE__, "Unreachable code was reached.")
>                                                                                           ^
> /<<BUILDDIR>>/widelands-19+repack/src/network/network.h:184:3: note: in expansion of macro 'NEVER_HERE'
>    NEVER_HERE();
>    ^~~~~~~~~~
> In file included from /<<BUILDDIR>>/widelands-19+repack/src/scripting/lua_errors.h:25:0,
>                  from /<<BUILDDIR>>/widelands-19+repack/src/scripting/lua_table.h:32,
>                  from /<<BUILDDIR>>/widelands-19+repack/src/logic/map_objects/tribes/tribe_basic_info.h:29,
>                  from /<<BUILDDIR>>/widelands-19+repack/src/logic/game_settings.h:28,
>                  from /<<BUILDDIR>>/widelands-19+repack/src/network/nethost.h:24,
>                  from /<<BUILDDIR>>/widelands-19+repack/src/network/nethost.cc:20:
> /<<BUILDDIR>>/widelands-19+repack/src/network/network.h: In member function 'virtual const char* ProtocolException::what() const':
> /<<BUILDDIR>>/widelands-19+repack/src/base/wexception.h:63:90: warning: throw will always call terminate() [-Wterminate]
>  #define NEVER_HERE() throw WException(__FILE__, __LINE__, "Unreachable code was reached.")
>                                                                                           ^
> /<<BUILDDIR>>/widelands-19+repack/src/network/network.h:184:3: note: in expansion of macro 'NEVER_HERE'
>    NEVER_HERE();
>    ^~~~~~~~~~
> In file included from /<<BUILDDIR>>/widelands-19+repack/src/scripting/lua_errors.h:25:0,
>                  from /<<BUILDDIR>>/widelands-19+repack/src/scripting/lua_table.h:32,
>                  from /<<BUILDDIR>>/widelands-19+repack/src/logic/map_objects/tribes/tribe_basic_info.h:29,
>                  from /<<BUILDDIR>>/widelands-19+repack/src/logic/game_settings.h:28,
>                  from /<<BUILDDIR>>/widelands-19+repack/src/network/netclient.h:25,
>                  from /<<BUILDDIR>>/widelands-19+repack/src/network/netclient.cc:20:
> /<<BUILDDIR>>/widelands-19+repack/src/network/network.h: In member function 'virtual const char* ProtocolException::what() const':
> /<<BUILDDIR>>/widelands-19+repack/src/base/wexception.h:63:90: warning: throw will always call terminate() [-Wterminate]
>  #define NEVER_HERE() throw WException(__FILE__, __LINE__, "Unreachable code was reached.")
>                                                                                           ^
> /<<BUILDDIR>>/widelands-19+repack/src/network/network.h:184:3: note: in expansion of macro 'NEVER_HERE'
>    NEVER_HERE();
>    ^~~~~~~~~~
> In file included from /<<BUILDDIR>>/widelands-19+repack/src/network/netclient.h:25:0,
>                  from /<<BUILDDIR>>/widelands-19+repack/src/network/netclient.cc:20:
> /<<BUILDDIR>>/widelands-19+repack/src/logic/game_settings.h: In member function 'void NetClient::receive_one_user(uint32_t, StreamRead&)':
> /<<BUILDDIR>>/widelands-19+repack/src/logic/game_settings.h:52:8: error: 'newuser.UserSettings::position' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>  struct UserSettings {
>         ^~~~~~~~~~~~
> cc1plus: some warnings being treated as errors
> src/network/CMakeFiles/network.dir/build.make:113: recipe for target 'src/network/CMakeFiles/network.dir/netclient.cc.o' failed
> make[3]: *** [src/network/CMakeFiles/network.dir/netclient.cc.o] Error 1

The full build log is available from:
   http://aws-logs.debian.net/2017/08/05/widelands_19+repack-3_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.

Message #10 received at 871114@bugs.debian.org (full text, mbox, reply):

From: Hans Joachim Desserud <debian@desserud.org>

To: 871114@bugs.debian.org

Subject: Re: widelands: FTBFS: game_settings.h:52:8: error: 'newuser.UserSettings::position' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Date: Wed, 23 Aug 2017 21:56:59 +0200

Control: tags -1 confirmed
Control: forwarded -1 https://bugs.launchpad.net/widelands/+bug/1695879

Hello

We ran into the same issue upstream a while back when attempting to 
build with GCC7,
see [1] for details. The issue was fixed, and since we expected distros 
would switch to GCC7
as the default compiler at some point the changes was also backported to 
our build19 branch.
You can find the specific patch at [2] or [3] for the whole branch. 
(Note that the branch
also includes a fix for the wrong en_GB translations [4], so you might 
want to include that at
the same time)

Hope this helps. Let us know if you have any comments or questions. :)

[1] https://bugs.launchpad.net/widelands/+bug/1695879
[2] 
http://bazaar.launchpad.net/~widelands-dev/widelands/b19/revision/8149
[3] https://code.launchpad.net/~widelands-dev/widelands/b19
[4] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=853052

-- 
mvh / best regards
Hans Joachim Desserud
http://desserud.org

Message #19 received at 871114@bugs.debian.org (full text, mbox, reply):

From: Markus Koschany <apo@debian.org>

To: Hans Joachim Desserud <debian@desserud.org>

Cc: 871114@bugs.debian.org

Subject: Re: widelands: FTBFS: game_settings.h:52:8: error: 'newuser.UserSettings::position' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Date: Wed, 23 Aug 2017 22:14:34 +0200

[Message part 1 (text/plain, inline)]

Hi Hans Joachim,

it appears you are involved in upstream development for Widelands. The
game currently fails to build from source with GCC 7. I discovered this
[1] merge commit which shall resolve GCC 7 issues but unfortunately it
doesn't apply cleanly for the recent 1.19 release of Widelands.

Do you know if a targeted fix for 1.19 exists already or are there any
plans to release a new version of Widelands to resolve this issue?

Thanks,

Markus


[1] https://code.launchpad.net/~widelands-dev/widelands/gcc7/+merge/323576

[signature.asc (application/pgp-signature, attachment)]

Message #24 received at 871114@bugs.debian.org (full text, mbox, reply):

From: Markus Koschany <apo@debian.org>

To: Hans Joachim Desserud <debian@desserud.org>

Cc: 871114@bugs.debian.org

Subject: Re: Bug#871114: widelands: FTBFS: game_settings.h:52:8: error: 'newuser.UserSettings::position' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Date: Thu, 24 Aug 2017 00:20:08 +0200

[Message part 1 (text/plain, inline)]

Control: tags -1 pending

Am 23.08.2017 um 21:56 schrieb Hans Joachim Desserud:
> Control: tags -1 confirmed
> Control: forwarded -1 https://bugs.launchpad.net/widelands/+bug/1695879
> 
> Hello
> 
> We ran into the same issue upstream a while back when attempting to
> build with GCC7,
> see [1] for details. The issue was fixed, and since we expected distros
> would switch to GCC7
> as the default compiler at some point the changes was also backported to
> our build19 branch.
> You can find the specific patch at [2] or [3] for the whole branch.
> (Note that the branch
> also includes a fix for the wrong en_GB translations [4], so you might
> want to include that at
> the same time)
> 
> Hope this helps. Let us know if you have any comments or questions. :)
> 
> [1] https://bugs.launchpad.net/widelands/+bug/1695879
> [2] http://bazaar.launchpad.net/~widelands-dev/widelands/b19/revision/8149
> [3] https://code.launchpad.net/~widelands-dev/widelands/b19
> [4] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=853052

Funny. It seems we worked on this bug at the same time. I can confirm
that [2] resolved the FTBFS with GCC 7. However it was not clear to me
how [3] could fix [4]. I suggest to add a simple patch to bug reports
next time which tremendously simplifies things for non-regular uploaders
of Widelands.

Anyway I believe this bug should be fixed in a couple of minutes. Thank
you for your assistance.

Regards,

Markus

[signature.asc (application/pgp-signature, attachment)]

Message #31 received at 871114-close@bugs.debian.org (full text, mbox, reply):

From: Markus Koschany <apo@debian.org>

To: 871114-close@bugs.debian.org

Subject: Bug#871114: fixed in widelands 1:19+repack-4

Date: Wed, 23 Aug 2017 22:39:13 +0000

Source: widelands
Source-Version: 1:19+repack-4

We believe that the bug you reported is fixed in the latest version of
widelands, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 871114@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Markus Koschany <apo@debian.org> (supplier of updated widelands package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 24 Aug 2017 00:05:16 +0200
Source: widelands
Binary: widelands widelands-data
Architecture: source
Version: 1:19+repack-4
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <pkg-games-devel@lists.alioth.debian.org>
Changed-By: Markus Koschany <apo@debian.org>
Description:
 widelands  - fantasy real-time strategy game
 widelands-data - fantasy real-time strategy game (data files)
Closes: 861043 871114
Changes:
 widelands (1:19+repack-4) unstable; urgency=medium
 .
   * Team upload.
   * Remove empty gbp.conf file.
   * Switch to compat level 10.
   * Declare compliance with Debian Policy 4.1.0.
   * Vcs-Browser: Use canonical Vcs-URI.
   * Do not convert png files to xpm anymore. Drop imagemagick from B-D.
   * Move font dependencies from widelands to widelands-data. (Closes: #861043)
   * Add gcc7.patch and fix FTBFS with GCC 7. (Closes: #871114)
   * Drop -dbg package and use the automatically provided -dbgsym package
     instead.
   * Install appdata file into canonical /usr/share/metainfo directory.
Checksums-Sha1:
 320af519dd50d31ed75c06fe647c3c5f59226751 2440 widelands_19+repack-4.dsc
 cd23f78126a674371a8dbffa8c4367444128f72f 29520 widelands_19+repack-4.debian.tar.xz
 937cd7469671dc2018de0c578410cf0a06ae2c81 12384 widelands_19+repack-4_source.buildinfo
Checksums-Sha256:
 55c93fcf8aa64be9ff6d4c451ae5d03d0a0b6bb97a2fbb057f9fea866d0229b8 2440 widelands_19+repack-4.dsc
 5945ff446d52e209949fd5ecf45f2c8ed598646543fb069ea1bd83976a5bf15e 29520 widelands_19+repack-4.debian.tar.xz
 296757db876f8b76ea2d09c5ee1ebf56d9c75af2146254d62f5c66126215d16b 12384 widelands_19+repack-4_source.buildinfo
Files:
 7e18cfb2d8d6617c3af9826486bb364a 2440 games extra widelands_19+repack-4.dsc
 52baf6f119204a1907018f96a0d2361a 29520 games extra widelands_19+repack-4.debian.tar.xz
 c852b45ebe45bf6c3c32a853d1b00eb1 12384 games extra widelands_19+repack-4_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQKjBAEBCgCNFiEErPPQiO8y7e9qGoNf2a0UuVE7UeQFAlmd/jtfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEFD
RjNEMDg4RUYzMkVERUY2QTFBODM1RkQ5QUQxNEI5NTEzQjUxRTQPHGFwb0BkZWJp
YW4ub3JnAAoJENmtFLlRO1HkPRMP/0thE6sT95HLuxeoxj54o8c9FbCNk+WfuEll
+RoCoN2ZeZHRxeT6veWbOtUatJNJl9CUOge9sAg28u+9Gfm4ZbZ2s5I4pDjluzBD
oYYiogZaajcp+C2pFN5CqXtVkIKWa5Zz6Q1rR/uH1BVqvcgALrrrqBcS76jQLB+w
hWaOi/QTxPSSjFl68h3DXga+3qscl2oY2F2KNLp5+iX20mM5ceraAL7nVjEwIvIp
V30Jr7vVfiDot2M8zdftVUstfnVEExUNQ35T4O5URD/mYgahuE82iO2ewZJKmrFQ
yd5HKKEBET5245NtbocDtuXDV1pCcRCoQwc5Pnt7SgoXRjVInkTjoPn0yUVsImn5
4DVQneEbM8xmA1R6yqYdvUGbvR9mVGl/3aMu9bTRBkIAHjUPi0FVV230cWKOVTUk
NEwfGzMABXyobw7BkOICUdWw334KRHS0J9I6RnWpKzp30XUqJI6CzyKu4AVBZm2r
w0gJdKVANYhRrISFbk1iwdSPOKuNnOH0hlK5Y3HM17u4XkLs3IoQRM6w9cTeRb+p
dfac8U30LOr8kWdLwh2R1CGbnL2O19l+SWVUmSwOB0uEg3/DSk77UHaVjsTMbcYn
DtG+XYatQxt+wb5dIPVg9Cffsb+MM/b6v5Gib5mx29CBjf3u4pK29exPxiSCfirM
69clQhQ7
=9FQw
-----END PGP SIGNATURE-----

Message #36 received at 871114@bugs.debian.org (full text, mbox, reply):

From: Hans Joachim Desserud <debian@desserud.org>

To: apo@debian.org

Cc: 871114@bugs.debian.org

Subject: Re: Bug#871114: widelands: FTBFS: game_settings.h:52:8: error: 'newuser.UserSettings::position' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Date: Sun, 27 Aug 2017 22:04:36 +0200

> Funny. It seems we worked on this bug at the same time. I can confirm
> that [2] resolved the FTBFS with GCC 7.

Looks like it. :) Thanks for uploading the patch and the other packaging
changes. (I've already picked it up and integrated it into the packaging
we do upstream for our PPA [1])

I've also added a short description and pointing to the backported patch
in the original GCC7-merge proposal for others who may come across it.

> I suggest to add a simple patch to bug reports
> next time which tremendously simplifies things for non-regular 
> uploaders
> of Widelands.

Yes, I considered adding a patch. The main reason I didn't is that I use
quilt too seldom to really remember how it works from time to time. So
I would need to look up the commands, which is not neccessarily hard, 
but
takes time and I knew I would be busy the following days. Since I didn't
know when I'd have the time to prepare a proper patch, I figuered I 
could
at least point to the existing patch, so that no one would need to add
GCC7 support from scratch. If it hadn't been picked up, I would have
prepared a patch when I got the time, but it seemed quicker to add a 
link
and let someone who knew the toolchain integrate it.

If I find the time, there will be a proper patch next time ;)

[1] https://code.launchpad.net/~hjd/widelands/debian-merge/+merge/329686

---
mvh / best regards
Hans Joachim Desserud
http://desserud.org

Send a report that this bug log contains spam.