Debian Bug report logs - #869385
higan: FTBFS on arm64, mips* - error: unknown type name 'thread_local'

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: James Cowgill <jcowgill@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: higan: FTBFS on arm64, mips* - error: unknown type name 'thread_local'

Date: Sat, 22 Jul 2017 23:34:45 +0100

[Message part 1 (text/plain, inline)]

Source: higan
Version: 103-1
Severity: serious
Tags: sid buster

Hi,

higan FTBFS on arm64, mips* and some ports architectures with the error:
> In file included from ../libco/libco.c:22:0:
> ../libco/sjlj.c:30:8: error: unknown type name 'thread_local'
>  static thread_local cothread_struct co_primary;
>         ^~~~~~~~~~~~

This appears to be because the code uses C11's "thread_local" storage
type without including "threads.h" where it's declared.

Note I haven't done a test rebuild yet - I'm just guessing that this is
the cause.

Thanks,
James

[signature.asc (application/pgp-signature, attachment)]

Message #10 received at 869385@bugs.debian.org (full text, mbox, reply):

From: Adrian Bunk <bunk@debian.org>

To: James Cowgill <jcowgill@debian.org>, 869385@bugs.debian.org

Subject: Re: Bug#869385: higan: FTBFS on arm64, mips* - error: unknown type name 'thread_local'

Date: Sun, 23 Jul 2017 14:44:09 +0300

[Message part 1 (text/plain, inline)]

Control: tags -1 patch

On Sat, Jul 22, 2017 at 11:34:45PM +0100, James Cowgill wrote:
>...
> > In file included from ../libco/libco.c:22:0:
> > ../libco/sjlj.c:30:8: error: unknown type name 'thread_local'
> >  static thread_local cothread_struct co_primary;
> >         ^~~~~~~~~~~~
> 
> This appears to be because the code uses C11's "thread_local" storage
> type without including "threads.h" where it's declared.
> 
> Note I haven't done a test rebuild yet - I'm just guessing that this is
> the cause.

higan actually has an own header settings.h that defines an own thread_local
(to __thread or empty).

The attached patch fixes the FTBFS by including that header just like 
the arch-specific implementations do.

These thread_local #define's in libco/settings.h should also be replaced 
with an #include <threads.h>, but that's a separate issue.

> Thanks,
> James

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

[sjlj-ftbfs.patch (text/x-diff, attachment)]

Message #17 received at 869385-close@bugs.debian.org (full text, mbox, reply):

From: Tobias Hansen <thansen@debian.org>

To: 869385-close@bugs.debian.org

Subject: Bug#869385: fixed in higan 103-2

Date: Sun, 23 Jul 2017 21:18:51 +0000

Source: higan
Source-Version: 103-2

We believe that the bug you reported is fixed in the latest version of
higan, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 869385@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Tobias Hansen <thansen@debian.org> (supplier of updated higan package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 23 Jul 2017 21:46:27 +0100
Source: higan
Binary: higan
Architecture: source
Version: 103-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <pkg-games-devel@lists.alioth.debian.org>
Changed-By: Tobias Hansen <thansen@debian.org>
Description:
 higan      - Accurate multi-system emulator
Closes: 869385
Changes:
 higan (103-2) unstable; urgency=medium
 .
   * Apply sjlj-ftbfs.patch from Adrian Bunk (Closes: 869385)
     (Include settings.h for thread_local.)
Checksums-Sha1:
 73989d90cc25ebbe796446b9772ea7eaa05d09b0 2043 higan_103-2.dsc
 7c68037f744f37ed19c1cf920b477472f5a0cce7 525920 higan_103-2.debian.tar.xz
 74fbb3479e9d6d91a6006f03187db94a8c65b424 12443 higan_103-2_source.buildinfo
Checksums-Sha256:
 8b372880642b3cdc0f421baa79b3147c3e4627b01615c9b26ee21a7bb3b08e1c 2043 higan_103-2.dsc
 483922bd03d78455a28459e26bfee3551f866fe384dfb89c4c9601b7ed6b7cdd 525920 higan_103-2.debian.tar.xz
 3f801810ca6739a17e6a87dc0ec72f07104db6edbdb3cba7e1fa25699be226ff 12443 higan_103-2_source.buildinfo
Files:
 816b0b9cfc65b5a525e9deb962ea1a8c 2043 otherosfs optional higan_103-2.dsc
 9fa7d974183b5f9ac5c2ae2a1f9cab5d 525920 otherosfs optional higan_103-2.debian.tar.xz
 3f93b18b95769ba4b7e3a93f64382397 12443 otherosfs optional higan_103-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEoH46ol3M2u2mYo0kjIIWnY7OzSoFAll1C/EACgkQjIIWnY7O
zSpLRA//b4zVDIzuHkzh1GKtcSMg9eK0ZC6ESPMqlkghmMq/fdSkGW8Qylo/zYna
BD6Yzzrvq/jz3Rt0rSfudHavILRpLOxCWdw8fceFhUaR0SArvd4GDNKwgp2t1jV2
3sORjPPoaadWxakgKr4wsskQLKlAc6DbRVQi9oJoEeozIR628osH4yU3oZgoZcJg
D57gBRpmGQLuzmPyxqUK+BS4iqFPXpj33O/UQnM5zn9RD2W8dU+O4XglGUETxW3F
IklA2pqruDwoguLdktKQGJRbruSy3NT4MOON5SXiinObK0iTlXmx6SW0/PF6Y1/G
ktn9efJRz3pLux+pxTyI2AU2TdMDqBnH6daIrVpE8f4SvXc/lqDmFwTFwKJofjcx
nMgb8t3lLdEHlEG3pdFvnyt5wqW6D4qoxYq0qKjE0dr7/reCPbKUMObmBFQv7Sob
ItLDZ0oamE8ShzsJle2wEuQBu5NPAkdJlCeznDQlbuGt2JKaBKfPsq0VZZeC2Iwh
wRBBjodVEH4aWTta2gDAI7aWG5ApSNjSCtBw4GXteDUPkZSxOP7UDxOGzmPMp7n9
mbxu0doyd27/gEhMQRmWNiG5q7YwYHDYPE3gqtYk5MOszNuUSqIRFfdOL9GQii+s
8XLwgFLFQLm7B/yAhI3VbdEghX3dMXW6y7zljkbCYifewMUFlEc=
=xg8s
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.