Debian Bug report logs - #869086
dsniff sometimes FTBFS due to missing Makefile dependency

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Adrian Bunk <bunk@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: dsniff sometimes FTBFS due to missing Makefile dependency

Date: Thu, 20 Jul 2017 14:57:46 +0300

[Message part 1 (text/plain, inline)]

Source: dsniff
Version: 2.4b1+debian-26
Severity: serious
Tags: patch

dsniff sometimes FTBFS in parallel builds:

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/dsniff.html

...
rpcgen -h mount.x -o mount.h
...
./decode_mountd.c: In function 'decode_mountd':
./decode_mountd.c:35:18: error: storage size of 'fhstat' isn't known
  struct fhstatus fhstat;
                  ^~~~~~
./decode_mountd.c:45:29: error: 'MOUNTPROG' undeclared (first use in this function)
      msg.rm_call.cb_prog == MOUNTPROG &&
                             ^~~~~~~~~
./decode_mountd.c:45:29: note: each undeclared identifier is reported only once for each function it appears in
./decode_mountd.c:46:29: error: 'MOUNTPROC_MNT' undeclared (first use in this function)
      msg.rm_call.cb_proc == MOUNTPROC_MNT) {
                             ^~~~~~~~~~~~~
./decode_mountd.c:50:41: error: 'MOUNTVERS' undeclared (first use in this function)
    xid_map_enter(msg.rm_xid, MOUNTPROG, MOUNTVERS,
                                         ^~~~~~~~~
In file included from /usr/include/x86_64-linux-gnu/sys/types.h:25:0,
                 from ./decode_nntp.c:14:
/usr/include/features.h:148:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp]
 # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE"
   ^~~~~~~
./decode_mountd.c:61:8: warning: implicit declaration of function 'xdr_fhstatus' [-Wimplicit-function-declaration]
    if (xdr_fhstatus(&xdrs, &fhstat)) {
        ^~~~~~~~~~~~
gcc -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -D_BSD_SOURCE -D_BSD_SOURCE -D__BSD_SOURCE -D__FAVOR_BSD -DHAVE_NET_ETHERNET_H -DDSNIFF_LIBDIR=\"/usr/lib/x86_64-linux-gnu/\" -Wdate-time -D_FORTIFY_SOURCE=2 -I. -I/usr/include -I/usr/include -I/usr/include -I/usr/include -I/usr/include  -I./missing -c ./decode_pop.c
./decode_mountd.c:68:22: error: 'FHSIZE' undeclared (first use in this function)
      for (i = 0; i < FHSIZE; i++) {
                      ^~~~~~
Makefile:78: recipe for target 'decode_mountd.o' failed
make[1]: *** [decode_mountd.o] Error 1
...
rpcgen -c mount.x -o mount.c
make[1]: Leaving directory '/build/1st/dsniff-2.4b1+debian'
dh_auto_build: make -j16 returned exit code 2
debian/rules:7: recipe for target 'build' failed
make: *** [build] Error 2


The problem is a race condition where decode_mountd.c includes
mount.h before rpcgen has finished generating it.

A fix is attached.

[36_fix-parallel-ftbfs.patch- (text/plain, attachment)]

Message #10 received at 869086-submitter@bugs.debian.org (full text, mbox, reply):

From: Lukas Schwaighofer <lukas@schwaighofer.name>

To: 869086-submitter@bugs.debian.org

Subject: Bug#869086 marked as pending

Date: Thu, 20 Jul 2017 18:36:07 +0000

tag 869086 pending
thanks

Hello,

Bug #869086 reported by you has been fixed in the Git repository. You can
see the changelog below, and you can check the diff of the fix at:

    https://anonscm.debian.org/cgit/pkg-security/dsniff.git/commit/?id=f4fd74d

---
commit f4fd74d3fe207d1b7d74ca0e26c60bc466af3fdf
Author: Lukas Schwaighofer <lukas@schwaighofer.name>
Date:   Thu Jul 20 20:34:54 2017 +0200

    Fix a parrallel FTBFS
    
    Another case of missing Makefile dependencies, improve on the Makefile
    patch that was used to fix another FTBFS previously already.  Thanks to
    Adrian Bunk.

diff --git a/debian/changelog b/debian/changelog
index 70d574c..19babf7 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+dsniff (2.4b1+debian-27) unstable; urgency=high
+
+  * Fix a parallel FTBFS due to missing Makefile dependencies.  Thanks to
+    Adrian Bunk (Closes: #869086).
+
+ -- Lukas Schwaighofer <lukas@schwaighofer.name>  Thu, 20 Jul 2017 20:00:38 +0200
+
 dsniff (2.4b1+debian-26) unstable; urgency=medium
 
   * Team upload.

Message #15 received at 869086@bugs.debian.org (full text, mbox, reply):

From: Lukas Schwaighofer <lukas@schwaighofer.name>

To: Adrian Bunk <bunk@debian.org>

Cc: 869086@bugs.debian.org

Subject: Re: Bug#869086: dsniff sometimes FTBFS due to missing Makefile dependency

Date: Thu, 20 Jul 2017 20:43:18 +0200

[Message part 1 (text/plain, inline)]

Hi Adrian,

On Thu, 20 Jul 2017 14:57:46 +0300
Adrian Bunk <bunk@debian.org> wrote:

> dsniff sometimes FTBFS in parallel builds: (...)
> The problem is a race condition where decode_mountd.c includes
> mount.h before rpcgen has finished generating it.

Indeed.

> A fix is attached.

Thanks a lot for debugging this already.  I had another FTBFS with your
patch applied, because `make` was trying to build mount.o without having
generated mount.h first.  I ended up inserting another dependency

     mount.o: mount.h

so that the ".c.o" rule would not try to build mount.o before
generating mount.h.  I also found another similar dependency between
nfs_prot.h and filesnarf.o which I resolved in the same way.

Hopefully that fixes all the parallel FTBFS now…

Thanks & Regards
Lukas

[Message part 2 (application/pgp-signature, inline)]

Message #20 received at 869086-close@bugs.debian.org (full text, mbox, reply):

From: Lukas Schwaighofer <lukas@schwaighofer.name>

To: 869086-close@bugs.debian.org

Subject: Bug#869086: fixed in dsniff 2.4b1+debian-27

Date: Thu, 20 Jul 2017 19:19:13 +0000

Source: dsniff
Source-Version: 2.4b1+debian-27

We believe that the bug you reported is fixed in the latest version of
dsniff, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 869086@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Lukas Schwaighofer <lukas@schwaighofer.name> (supplier of updated dsniff package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 20 Jul 2017 20:00:38 +0200
Source: dsniff
Binary: dsniff
Architecture: source
Version: 2.4b1+debian-27
Distribution: unstable
Urgency: high
Maintainer: Debian Security Tools Packaging Team <pkg-security-team@lists.alioth.debian.org>
Changed-By: Lukas Schwaighofer <lukas@schwaighofer.name>
Description:
 dsniff     - Various tools to sniff network traffic for cleartext insecurities
Closes: 869086
Changes:
 dsniff (2.4b1+debian-27) unstable; urgency=high
 .
   * Fix a parallel FTBFS due to missing Makefile dependencies.  Thanks to
     Adrian Bunk (Closes: #869086).
Checksums-Sha1:
 4d31b51a7d33be9f6fbd0923dde0eef5827fd7e1 2079 dsniff_2.4b1+debian-27.dsc
 4d4113a1642e86f2b92436a7b30b8d0b722abb44 29264 dsniff_2.4b1+debian-27.debian.tar.xz
Checksums-Sha256:
 033937e15e4de22399099b7343b3004db1b58703febdf7b7b4b6ef6cb0d06569 2079 dsniff_2.4b1+debian-27.dsc
 19b39de307d798706f0a610f5e2f68df1520b1fc3efca144800ede71bd4315bf 29264 dsniff_2.4b1+debian-27.debian.tar.xz
Files:
 a5d7794426507333fee666bf70d77fd1 2079 net optional dsniff_2.4b1+debian-27.dsc
 a71f4b53e428d460743ab4e227d97f4a 29264 net optional dsniff_2.4b1+debian-27.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJZcP/rAAoJEPNPCXROn13Zv78P/3PBxHUu34RH1rdWzbKn/tBQ
rjeGjtbNGQGM5bkjt1P/P9wd8wpXLWAWxm6AJdXAPQJ1uJR56T0ZpLQXRJ5cMdCc
UvdeXrjwu5EZDpLG7UpzEVZ+g/tcSDmnIS+hkwtkXEogPYWAi0WcnpY7tdwqmMS9
op5vt3XUNqeIVAUZ2Oa5TujRtdMsIVd7QkOPwqFZzJQUCpZfxMgnTIZkGJOaJyoa
Cm/8vk0JGevt5DbCN61fBlrfiSxn7EDW0Pz63Dl2vkGEHjUVYfBkRGOgbqRsojSo
4RH6Ad/JZqPzZwLuRRCE/zNtagfDACjbN17kcT/Q+f+cirXkd4p3ScTgwdbcnLId
wTPsUpzjlkIXePJ6WIunxISrntpGQB4vyI/0M1UokUyK1EJfKOeYt17xKAsX94g5
qVs5MhcF1YLidvYIwAJ6dZHQaq21GBSDNr9FmGhAnqsg3sJ/rcDEdElK2k9p1Twq
qrnVNd2gn7QM6yO6uNC/XoqHbRFu/+OXSSAB372TZm83s/Ud7NE1I6KUcfFW0iq5
mu/ZHLtslyzfdOIlDwEXW6C4SqQ+9AAbpLQ08GVBp/jKoDdBVDmdUVdS9GsCLdgC
HRRBKJH50qOLWB5OD2neNLwrXpEBiwPS2pCH4yRBGAEZAicPN1BIJKqSPbuFWEs+
miiyAdN8/xKRu+BgAGnW
=dojq
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.