Debian Bug report logs - #868790
castle-game-engine: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: submit@bugs.debian.org

Subject: castle-game-engine: please make the build reproducible

Date: Tue, 18 Jul 2017 18:00:15 +0100

[Message part 1 (text/plain, inline)]

Source: castle-game-engine
Version: 6.2+dfsg1-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that castle-game-engine could not be built reproducibly.

This is because it uses the current year when generating a "Copyright"
string.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb, Debian Project Leader
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[castle-game-engine.diff.txt (text/plain, attachment)]

Message #10 received at 868790@bugs.debian.org (full text, mbox, reply):

From: Michalis Kamburelis <michalis.kambi@gmail.com>

To: Chris Lamb <lamby@debian.org>, 868790@bugs.debian.org, Project developers <pkg-pascal-devel@lists.alioth.debian.org>

Subject: Re: [Pkg-pascal-devel] Bug#868790: castle-game-engine: please make the build reproducible

Date: Sun, 23 Jul 2017 07:19:44 +0200

2017-07-18 19:00 GMT+02:00 Chris Lamb <lamby@debian.org>:
> Whilst working on the Reproducible Builds effort [0], we noticed
> that castle-game-engine could not be built reproducibly.
>
> This is because it uses the current year when generating a "Copyright"
> string.
>
> Patch attached.

Hi,

I have applied a modified version of your patch upstream, see
https://github.com/castle-engine/castle-engine/commit/35a19832b84c396c6c5d3521e8afd50f8055d492
(I only moved the logic to a separate function CopyrightYears, used 2
times). Thank you!

Regards,
Michalis

Message #15 received at 868790@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: Michalis Kamburelis <michalis.kambi@gmail.com>, 868790@bugs.debian.org, Project developers <pkg-pascal-devel@lists.alioth.debian.org>

Subject: Re: [Pkg-pascal-devel] Bug#868790: castle-game-engine: please make the build reproducible

Date: Sun, 23 Jul 2017 09:02:39 +0100

Dear Michalis,

> I have applied a modified version of your patch upstream, see
> https://github.com/castle-engine/castle-engine/commit/35a19832b84c396c6c5d3521e8afd50f8055d492

Hurrah, thanks!

> I only moved the logic to a separate function CopyrightYears

Good idea! In my defense (!), I try and keep my diffs as minimal as
possible so:

 - They apply more-easily to newer versions (in case the patch never
   makes it upstream, obviously not applicable here)
 
 - They more easily demonstrate the problem to the maintainer, even
   if its done in a dumb way.

 - My Pascal is very very rusty! I last used it in 2004!

Anyway, thanks again for merging :)


Best wishes,

-- 
      ,''`.
     : :'  :     Chris Lamb, Debian Project Leader
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #20 received at 868790-close@bugs.debian.org (full text, mbox, reply):

From: Paul Gevers <elbrus@debian.org>

To: 868790-close@bugs.debian.org

Subject: Bug#868790: fixed in castle-game-engine 6.2+dfsg1-2

Date: Sun, 28 Jan 2018 12:50:26 +0000

Source: castle-game-engine
Source-Version: 6.2+dfsg1-2

We believe that the bug you reported is fixed in the latest version of
castle-game-engine, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 868790@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Paul Gevers <elbrus@debian.org> (supplier of updated castle-game-engine package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 28 Jan 2018 13:09:54 +0100
Source: castle-game-engine
Binary: fp-units-castle-game-engine castle-game-engine-doc castle-game-engine-src
Architecture: source
Version: 6.2+dfsg1-2
Distribution: unstable
Urgency: medium
Maintainer: Pascal Packaging Team <pkg-pascal-devel@lists.alioth.debian.org>
Changed-By: Paul Gevers <elbrus@debian.org>
Description:
 castle-game-engine-doc - Castle Game Engine - Developer's Documentation
 castle-game-engine-src - Castle Game Engine - Source code for Lazarus integration
 fp-units-castle-game-engine - Castle Game Engine - 3D game engine for FreePascal / Lazarus
Closes: 868790 887575
Changes:
 castle-game-engine (6.2+dfsg1-2) unstable; urgency=medium
 .
   * Don't set FPCDIR in d/rules (Closes: #887575)
   * Add patch for reproducible builds (Closes: #868790) Thanks Lamby.
   * Bump dephelper compat level to 11 and set Rules-Requires-Root to no
Checksums-Sha1:
 7d826b22697674692267615aae84e1c48b0a499d 2312 castle-game-engine_6.2+dfsg1-2.dsc
 a434cc1fb63fa75f072347925e48510af1635b84 23312 castle-game-engine_6.2+dfsg1-2.debian.tar.xz
Checksums-Sha256:
 8f19d6d46120b559611db7bf34042c74d6970bb58f3b57fa2d7d0a710ff2435b 2312 castle-game-engine_6.2+dfsg1-2.dsc
 7d3b7e83f6c353e7b1fc726c64db5a9a13098ce48da2170611054a5edbd8d5b8 23312 castle-game-engine_6.2+dfsg1-2.debian.tar.xz
Files:
 5437d05c7ee415deb02a050b2a4ae4cc 2312 misc optional castle-game-engine_6.2+dfsg1-2.dsc
 9c5c089c55846e755c87d2053d865a1e 23312 misc optional castle-game-engine_6.2+dfsg1-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEWLZtSHNr6TsFLeZynFyZ6wW9dQoFAlptviYACgkQnFyZ6wW9
dQq0yAgAzZpd1xZuNqrjOdbAQvDnBT1If37VwgHg6N/iu5St9a4xeEbotA4bUd+d
DTotVLFVxkpv+aOV1Jf+houF1QeZ0FlLIrVw6RBgWsEuRxxNqiWtSLcPjdKU3mGG
HsSgBHV9QHsX4J2fGA5Qc9Zqtl9TpEfctTWJUeJtDHeXUat9QVaID4HtgPfjnuhq
/B8q10Aqbb/xLr03hm8Z8szp5evAZP8PuuFnvn0G2zp2Rb5MZ99Vjwgg4PKJnH1T
WU1FuSyQVYx4LTB+sEvq/9Sp7j3nkRMlaG5wjh/k/UnsmHV09RmX1fsfBJnBxnc8
Ur63Il9MAmhHJvOQ9mcjIz7Bbo8JEQ==
=DEnX
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.