Debian Bug report logs - #866713
dh_compress: symlink(webalizer.1.gz, debian/webalizer/usr/share/man/man1/webazolver.1.gz) failed: File exists

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Adrian Bunk <bunk@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: dh_compress: symlink(webalizer.1.gz, debian/webalizer/usr/share/man/man1/webazolver.1.gz) failed: File exists

Date: Sat, 01 Jul 2017 10:01:56 +0300

Source: debhelper
Version: 10.6.1
Severity: serious
Control: affects -1 src:webalizer

The new debhelper causes a FTBFS in webalizer:

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/webalizer.html

...
  dh_compress
dh_compress: symlink(webalizer.1.gz, debian/webalizer/usr/share/man/man1/webazolver.1.gz) failed: File exists
dh_compress: Aborting due to earlier error
debian/rules:7: recipe for target 'binary' failed
make: *** [binary] Error 25

Message #14 received at 866713@bugs.debian.org (full text, mbox, reply):

From: Sven Joachim <svenjoac@gmx.de>

To: 866713@bugs.debian.org

Cc: Adrian Bunk <bunk@debian.org>

Subject: Re: Bug#866713: dh_compress: symlink(webalizer.1.gz, debian/webalizer/usr/share/man/man1/webazolver.1.gz) failed: File exists

Date: Sat, 01 Jul 2017 17:04:06 +0200

[Message part 1 (text/plain, inline)]

Control: found -1 10.5.1
Control: tags -1 + patch

On 2017-07-01 10:01 +0300, Adrian Bunk wrote:

> Source: debhelper
> Version: 10.6.1
> Severity: serious
> Control: affects -1 src:webalizer
>
> The new debhelper causes a FTBFS in webalizer:
>
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/webalizer.html
>
> ...
>   dh_compress
> dh_compress: symlink(webalizer.1.gz, debian/webalizer/usr/share/man/man1/webazolver.1.gz) failed: File exists

Previous versions of debhelper had used "ln -sf" to create the symlink,
but since version 10.5.1 dh_compress uses perl's own symlink() function
and fails to remove the target beforehand.  The attached patch fixes
this for me.

Cheers,
       Sven

[0001-dh_compress-Remove-target-before-creating-fixup-syml.patch (text/x-diff, inline)]

From a159f5404b0a43bf66062cb3ac67ae4316a89dca Mon Sep 17 00:00:00 2001
From: Sven Joachim <svenjoac@gmx.de>
Date: Sat, 1 Jul 2017 16:52:52 +0200
Subject: [PATCH] dh_compress: Remove target before creating fixup symlink

The target might already exist, possible because it had been created
by dh_link before.

Regression introduced by the switch to make_symlink_raw_target in
commit ee8fd59af61fa4739cdd536ecbb492cc8520df40.
---
 dh_compress | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dh_compress b/dh_compress
index 89c23f8a..21503c6a 100755
--- a/dh_compress
+++ b/dh_compress
@@ -212,7 +212,7 @@ on_pkgs_in_parallel {
 				my ($directory) = $link =~ m:(.*)/:;
 				my $linkval = readlink($link);
 				if (! -e "$directory/$linkval" && -e "$directory/$linkval.gz") {
-					rm_files($link);
+					rm_files($link, "$link.gz");
 					make_symlink_raw_target("$linkval.gz","$link.gz");
 					delete $links{$link};
 					$changed++;
-- 
2.13.2

Message #25 received at 866713-close@bugs.debian.org (full text, mbox, reply):

From: Niels Thykier <niels@thykier.net>

To: 866713-close@bugs.debian.org

Subject: Bug#866713: fixed in debhelper 10.6.2

Date: Wed, 05 Jul 2017 09:06:54 +0000

Source: debhelper
Source-Version: 10.6.2

We believe that the bug you reported is fixed in the latest version of
debhelper, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 866713@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Niels Thykier <niels@thykier.net> (supplier of updated debhelper package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 05 Jul 2017 08:40:00 +0000
Source: debhelper
Binary: debhelper dh-systemd
Architecture: source
Version: 10.6.2
Distribution: unstable
Urgency: medium
Maintainer: Debhelper Maintainers <debhelper-devel@lists.alioth.debian.org>
Changed-By: Niels Thykier <niels@thykier.net>
Description:
 debhelper  - helper programs for debian/rules
 dh-systemd - debhelper add-on to handle systemd unit files - transitional pack
Closes: 866713
Changes:
 debhelper (10.6.2) unstable; urgency=medium
 .
   * Refactor test suite and support running tests in parallel.
   * Add a test case for #866570.
   * dh_compress: Apply patch from Sven Joachim to fix a
     regression in 10.5.1.  (Closes: #866713)
   * dh_installman: Fix regression introduced in 10.5.1 that
     caused a "file not found" error when using -P with an
     absolute argument.  Thanks to Adrian Bunk for reporting
     it over IRC.
Checksums-Sha1:
 3c2d4a074469f6608dc8fbd1ecd60ba49b3d2dcc 1733 debhelper_10.6.2.dsc
 e49d5bb8d402e27050a29256c2dfb483d388057d 410348 debhelper_10.6.2.tar.xz
 14b576ebeb010f1ace679b1db9be5b8c79f839c5 4612 debhelper_10.6.2_source.buildinfo
Checksums-Sha256:
 e1eb8ccb374e2f02c90d808576e22cfbc632662e4291276d2c65680eb94e6b91 1733 debhelper_10.6.2.dsc
 d90e1d98a3cdf05b27be6b789f96014ce80e96ffbc711112dcff3c211cf68653 410348 debhelper_10.6.2.tar.xz
 246d3ab8a6077befa9934da370125de91a25282ca144f1a2d36043044bcb3e23 4612 debhelper_10.6.2_source.buildinfo
Files:
 e9dc67574be10ce1bf2fcb3440fac242 1733 devel optional debhelper_10.6.2.dsc
 c6d416ebfe1d5ad22fef40e9afb2bae1 410348 devel optional debhelper_10.6.2.tar.xz
 c2050239d0cbaba222f6fd91b04603f1 4612 devel optional debhelper_10.6.2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEsxMaRR2/33ygW0GXBUu7n32AZEIFAllcpugACgkQBUu7n32A
ZEIrMA/+MY2bBJNeJl5XQrtuUSshtbHbPIH3ZDNRbSqWX3TBRtJUvsS7xvzTPL56
g7LxJrllcl0pEUh0nV02R1thY+305kgr3FRkK6F82Rojwf4RmungxsiibLJiAdQh
fCYQc4ijuxONuAAts/ivK96PIoVdgZh5q281MRtOT9rza9aDEaPIs7JcFHwp7AOS
GiLT8IHwDdzG13kgCItWxlEg5n8vRArtGbbgbqaeMYEehjhCU3zt1yzYf/jygX4j
ri1UtcjWlikKnlvCyyKXqU0WFYXojhmY9BrsfP+NmXUipumj+pWNdEzdXwfXaQyQ
xmjr/d0TXrloPK8By6WciYK2NijWZpYim+M45LkVoMNSx7P3uWuHzKfXZ1QyChFw
nXl3QhXdrLHD5FLczx/g6+RXIOcATjjjDqXWYL7b6d0pOMxVSeysIX1l2DYqxemw
CpKYdbh57cV59zYlWB3XCOVhWjg6esyedsl44sTsB4Wdxp3yAF2RGv1DceGjaQDZ
EYNIEtx13VkiHha9U6qUJq6UeRzEU4+Yjcx+GlSTt1wsvFkZo1jLCAuWNm/KEkzc
3LqhoD9nZUpgG60ZNrVSu532rwM6dYuXU60jDVkgVFOyq3gLmel5x7mjId6AQr/N
LyGE6XK8x2eNsZ1qalSxdzNznisicHFbKwecCU6NZUup/WRklNw=
=SSPN
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.