Debian Bug report logs - #862003
debhelper: Regression in dh_fixperms causing packages to be non-reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: submit@bugs.debian.org

Subject: debhelper: Regression in dh_fixperms causing packages to be non-reproducible

Date: Sun, 07 May 2017 11:15:30 +0100

[Message part 1 (text/plain, inline)]

Source: debhelper
Version: 10.3
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: umask toolchain
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

There is a regression in debhelper 10.3 which is making packages
unreproducible as dh_fixperms it no longer resets permissions with
respect to the current umask.

As debhelper "self-hosts", debhelper 10.3 is itself not reproducible.
For example:

│ │ │ │ --rwxr-xr-x   ./
│ │ │ │ +-rwxrwxr-x   ./
[…]
│ │ │ │ --rwxr-xr-x   ./usr/share/doc/debhelper/examples/rules.tiny
│ │ │ │ +-rwxrwxr-x   ./usr/share/doc/debhelper/examples/rules.tiny

The issue is that we are now generating invalid find(1) calls (ie.
`find … -a  -a`) — curiously we mask the resulting error with
`2>/dev/null` for some reason. I believe this was a regression in:

  https://anonscm.debian.org/git/debhelper/debhelper.git/commit/?id=8c29b1a738fc3a22ccf6fd6b2bbe5e9544a62199

Patch attached.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[debhelper.diff.txt (text/plain, attachment)]

Message #12 received at 862003@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 862003@bugs.debian.org

Subject: Re: debhelper: Regression in dh_fixperms causing packages to be non-reproducible

Date: Sun, 07 May 2017 12:35:16 +0100

tags 862003 + pending
thanks

Fixed in Git:

 https://anonscm.debian.org/git/debhelper/debhelper/commit/?id=8c8de49dc1e11855de241bef59c4eebbc0f4a096


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #17 received at 862003-close@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <biebl@debian.org>

To: 862003-close@bugs.debian.org

Subject: Bug#862003: fixed in debhelper 10.4

Date: Fri, 26 May 2017 21:03:55 +0000

Source: debhelper
Source-Version: 10.4

We believe that the bug you reported is fixed in the latest version of
debhelper, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 862003@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Biebl <biebl@debian.org> (supplier of updated debhelper package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 26 May 2017 22:08:37 +0200
Source: debhelper
Binary: debhelper dh-systemd
Architecture: source
Version: 10.4
Distribution: experimental
Urgency: medium
Maintainer: Debhelper Maintainers <debhelper-devel@lists.alioth.debian.org>
Changed-By: Michael Biebl <biebl@debian.org>
Description:
 debhelper  - helper programs for debian/rules
 dh-systemd - debhelper add-on to handle systemd unit files - transitional pack
Closes: 862003 862049 863387
Changes:
 debhelper (10.4) experimental; urgency=medium
 .
   * Team upload.
 .
   [ Niels Thykier ]
   * meson.pm: Pass --wrap-mode=nodownload to meson (requires meson
     0.40-1 or later).
   * dh_install: Fix initialized warning when --sourcedir is absent
     on the cmd-line.
   * dh_missing: Accept --sourcedir (given it is passed by dh_install).
     (Closes: #862049)
   * Dh_Lib.pm: Fix a bug in pkgfile that caused dh to skip helpers
     that had configuration files.  Thanks to Michael Biebl for finding
     and reporting.  (Closes: #863387)
 .
   [ Chris Lamb ]
   * dh_fixperms: Fix regression where dh_fixperms would fail to correct
     permissions because it used an invalid find expression.
     (Closes: #862003)
Checksums-Sha1:
 588a85b41001964164cbf0a3fe21fd4e8f97b93c 1725 debhelper_10.4.dsc
 8e3c1757021ad71849163d672fc8a29596ae2b8e 399940 debhelper_10.4.tar.xz
 b0ccc18dbe3eeb7bfa60d216e31632b4da97436e 4687 debhelper_10.4_source.buildinfo
Checksums-Sha256:
 5e547e267cffcdddccc1eee583da70aef3916bebfb820d6f0bbb2076acb4db8c 1725 debhelper_10.4.dsc
 c57f2813d84a5372e9aea6dca663cd4a04837adc0f2625114d172bcd1fa543b2 399940 debhelper_10.4.tar.xz
 e89b256c0d1ca03123c7d7508e64c8c94fcf4cdbad80d03d728a4d187e4f95fe 4687 debhelper_10.4_source.buildinfo
Files:
 c3d9043474ac72ca1f592b47a11fd7be 1725 devel optional debhelper_10.4.dsc
 215db670c39ec164c1827691a7ecca56 399940 devel optional debhelper_10.4.tar.xz
 456ce2b196d8d457c2b412d40b45df1d 4687 devel optional debhelper_10.4_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEECbOsLssWnJBDRcxUauHfDWCPItwFAlkojJYACgkQauHfDWCP
ItzuzQ//cnV5eRnwMbNTvynP+0Lvpd5zcllg/8x75E1JbxSUYjnOjhtmeUegmkrY
dg8G5CY/srcesD5KdYL550DX7116gy2BsxGpFL0IWqgjTtjVOTzymoOsE2QlUb4D
Zm66/bKK+U7Aa5i8roJNRKb8+MhBtJwOzmJsA/MAMIJgCBpLr9iN3fTPmgC0Gm/2
MlvvBpfW6PtMGIsKOpF2Abq3wOFoBedSQqQFirq9K14SPKiD1QD9BHEXz0mlRJJK
SaX0SVIFb/wca0W4Gry6XEmHG2cm++I1jo9dgwXMkgU94oqcErR9l01Z5y0u1FLq
F6P5quJyvbICz3fAzksXVHQFRaMYKGSPbevYBl7v7ZfvJ426uoUliTa/CqscC3gW
5r662PIBZ4RD7sLZqK4YsbUNpvAgoVEZoQ+vuh3U5nT0yXXmLU0ZUXYA67Zpkbnj
Nojcl3RHkAueenfZNVOmCY5mwx2wbj9j7XcJ02Q5PRPix8fDyC/NSfmaZ6XxJpUq
2a4g0KhsAJxlXlE5Z3ya4pewzZCpRpKTfLFQe9iVTRI8puYvtlKCELwskG+Tv6Ag
DP/+UoqHlFPItJbxVj8x3vxfkPq2xposAy737DtXtHNPQiCkOJvWsmauVoKaDAVI
ZkhvCRI9UJ3lCgK/IJ7OsS+tAaIrCrv0I65GAymN8Ddewg9UWjE=
=rk5Z
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.