Debian Bug report logs - #861443
ora2pg: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: submit@bugs.debian.org

Subject: ora2pg: please make the build reproducible

Date: Sat, 29 Apr 2017 09:08:22 +0100

[Message part 1 (text/plain, inline)]

Source: ora2pg
Version: 18.0-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that ora2pg could not be built reproducibly.

This is because it encodes the build process's current PID in the
default configuration file.


Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[ora2pg.diff.txt (text/plain, attachment)]

Message #10 received at 861443@bugs.debian.org (full text, mbox, reply):

From: Niels Thykier <niels@thykier.net>

To: 861443@bugs.debian.org, Chris Lamb <lamby@debian.org>

Subject: Re: ora2pg: please make the build reproducible

Date: Thu, 04 May 2017 17:35:00 +0000

Control: tags -1 moreinfo

On Sat, 29 Apr 2017 09:08:22 +0100 Chris Lamb <lamby@debian.org> wrote:
> Source: ora2pg
> Version: 18.0-1
> Severity: wishlist
> Tags: patch
> User: reproducible-builds@lists.alioth.debian.org
> Usertags: randomness
> X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org
> 
> Hi,
> 
> Whilst working on the Reproducible Builds effort [0], we noticed
> that ora2pg could not be built reproducibly.
> 
> This is because it encodes the build process's current PID in the
> default configuration file.
> 
> 
> Patch attached.
> 
>  [0] https://reproducible-builds.org/
> 
> 
> Regards,
> 
> -- 
>       ,''`.
>      : :'  :     Chris Lamb
>      `. `'`      lamby@debian.org / chris-lamb.co.uk
>        `-

Hi Chris,

I suspect your patch is wrong because the original code is wrong as well.

$$ in postgres SQL is (often?) used to delimit the definition of
triggers and functions.  Therefore, I think you rather want the $$ to be
literal $$ in the config file rather than a ("random") number.

Thanks,
~Niels

Message #21 received at 861443@bugs.debian.org (full text, mbox, reply):

From: Niels Thykier <niels@thykier.net>

To: 861443@bugs.debian.org, Chris Lamb <lamby@debian.org>

Cc: gustavo panizzo <gfa@zumbi.com.ar>

Subject: Re: ora2pg: please make the build reproducible

Date: Thu, 04 May 2017 18:51:00 +0000

Control: tags -1 fixed-upstream

On Thu, 04 May 2017 17:35:00 +0000 Niels Thykier <niels@thykier.net> wrote:
> Control: tags -1 moreinfo
> 
> [...]
> 
> Hi Chris,
> 
> I suspect your patch is wrong because the original code is wrong as well.
> 
> $$ in postgres SQL is (often?) used to delimit the definition of
> triggers and functions.  Therefore, I think you rather want the $$ to be
> literal $$ in the config file rather than a ("random") number.
> 
> Thanks,
> ~Niels
> 
> 

Checked and it is fixed upstream in 18.1:

"""
  - Fix shell replacement of $$ in function definition in Makefile.PL
    embedded configuration file. Thanks to kuzmaka for the report.
"""

Thanks,
~Niels

Message #30 received at 861443-close@bugs.debian.org (full text, mbox, reply):

From: Christoph Berg <myon@debian.org>

To: 861443-close@bugs.debian.org

Subject: Bug#861443: fixed in ora2pg 18.1-1

Date: Thu, 15 Jun 2017 21:33:42 +0000

Source: ora2pg
Source-Version: 18.1-1

We believe that the bug you reported is fixed in the latest version of
ora2pg, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 861443@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christoph Berg <myon@debian.org> (supplier of updated ora2pg package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 15 Jun 2017 23:16:26 +0200
Source: ora2pg
Binary: ora2pg
Architecture: source
Version: 18.1-1
Distribution: unstable
Urgency: medium
Maintainer: Debian PostgreSQL Maintainers <pkg-postgresql-public@lists.alioth.debian.org>
Changed-By: Christoph Berg <myon@debian.org>
Description:
 ora2pg     - Oracle/MySQL to PostgreSQL database schema converter
Closes: 826778 861443
Changes:
 ora2pg (18.1-1) unstable; urgency=medium
 .
   * Adopt package in the PostgreSQL team. (Closes: #826778)
   * New upstream release.
     + Fixes $$ handling. (Closes: #861443)
   * Update package description.
   * Switch to the primary download location on GitHub.
   * Add autopkgtest.
Checksums-Sha1:
 170acb153c6671ecda614d6e84091394e65cdb16 2019 ora2pg_18.1-1.dsc
 15cee4d2050bb24398c2882d1f4aa48efc1baa2f 358395 ora2pg_18.1.orig.tar.gz
 928ffc97ecbf3055b0192cf8c0a36248ede56842 6408 ora2pg_18.1-1.debian.tar.xz
 94353314bc888e979d45a8c65edfbb39cc79acd1 5174 ora2pg_18.1-1_source.buildinfo
Checksums-Sha256:
 802fbcc455018186e7f7ae33537afdb6cc0a763a78c366c6df40cbbe523822c6 2019 ora2pg_18.1-1.dsc
 b8d330b4b4f57d3bc32624880e37f25077656be6c4b5c9f8e9042a6ea83e20da 358395 ora2pg_18.1.orig.tar.gz
 774f90e5373049bb5b8b452daa43192f2df87787657939ea10c1266387872afc 6408 ora2pg_18.1-1.debian.tar.xz
 ae156db0ce6ab70465cf3942b8e2f2fca351f2acd3eea71f44e9436f7bfd6b3f 5174 ora2pg_18.1-1_source.buildinfo
Files:
 99928e1689b0ca9665f286b98a0330c9 2019 database extra ora2pg_18.1-1.dsc
 4d19f4ec9fe75d643ac470cd295b8342 358395 database extra ora2pg_18.1.orig.tar.gz
 ebceb285984039c659261cc647dd583a 6408 database extra ora2pg_18.1-1.debian.tar.xz
 03b91fc64a39c200489493c63e15f4c8 5174 database extra ora2pg_18.1-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEXEj+YVf0kXlZcIfGTFprqxLSp64FAllC+WMACgkQTFprqxLS
p658/xAApJ+YGaGW4fb3Z6Lb2+DUg5G4nv9ptKzfCeOEWPSgLq4wKP40UCJJBCJ5
qASL89Ukg68JaLKU2TCBhD3nxIjlqHgDFIUiGt56W9jvTxUsuo5MUzXvfvAamHCl
9I2gK6B6lZAiRZrPYcpZekO01uAu4ok0H/aCczbCqalXZfdMqoo6R0MDdw6sstUq
ExVtyZVKZkJOLSIyU4qmi+6Y+NAub9TVsP/BQoxnmShJdA1jNvGzHHT7b8qFOKWe
uGeVu1nI051uPEx07e9q/aOE4JjQGUiZR4qxg/QCTKciZUWKwo3AVHyrjtrDP+v6
SL+l5hjIka0RGGqby7pCXeYgMSvtk5/PbIRPLguwn31EElNxnjZekXxf3dTVzQ/F
giFoQSQYtYka/eP0Q9apYcxSwIA7Jsd46sVn3X5lnru914UCkvZH9EGou/Z5ePFC
LdIJZQBPZ9pgcHYOwO33Xac1ey6nxHnEAvigVpdwDkDiwDJJs1T998WnzJ1yp6k2
i2cmGbWOAnzgBLzKYzyGgvS6b/qMreUyJU9ANvhikDO6zHHK8PNYTAwvdiIorEmI
r6YSHa+ZZAOCtefXaA4fi8yTKqQ9P+uFd9qtQJQQOIo5ppcwrxFijWrpurZnLeiS
MlL1ik/667p0gOm/PUYGFsBHjSrIJ0V7LTrJ+2ZYs25mCsuaoXI=
=Nd2q
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.