Debian Bug report logs - #861125
ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing

version graph

Package: wnpp; Maintainer for wnpp is wnpp@debian.org;

Reported by: Antoine Beaupre <anarcat@debian.org>

Date: Mon, 24 Apr 2017 20:15:02 UTC

Owned by: Nicholas D Steeves <nsteeves@gmail.com>

Severity: wishlist

Fixed in version writegood-mode/2.0.2-1

Done: Nicholas D Steeves <nsteeves@gmail.com>

Bug is archived. No further changes may be made.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, debian-emacsen@lists.debian.org, wnpp@debian.org:
Bug#861125; Package wnpp. (Mon, 24 Apr 2017 20:15:05 GMT) (full text, mbox, link).


Acknowledgement sent to Antoine Beaupre <anarcat@debian.org>:
New Bug report received and forwarded. Copy sent to debian-emacsen@lists.debian.org, wnpp@debian.org. (Mon, 24 Apr 2017 20:15:05 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Antoine Beaupre <anarcat@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: RFP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
Date: Mon, 24 Apr 2017 16:13:23 -0400
Package: wnpp
Severity: wishlist

* Package name    : elpa-writegood-mode
  Version         : 2.0.2
  Upstream Author : Benjamin Beckwith
* URL             : http://bnbeckwith.com/code/writegood-mode.html
* License         : GPL-3+
  Programming Lang: Elisp
  Description     : Minor mode for Emacs to improve English writing

This is a minor mode to aid in finding common writing problems. Matt
Might’s weaselwords scripts inspired this mode.

It highlights text based on a set of weasel-words, passive-voice and
duplicate words.

----

I use this when writing journalistic articles, fairly useful. No
dependencies that I know of.

LWN made a review of similar tools for Emacs here and here:

https://lwn.net/Articles/692054/
https://lwn.net/Articles/692872/

... but I haven't found something better just yet.

I'd be happy to comaintain this with the elpa team if no one steps
up.

Information forwarded to debian-bugs-dist@lists.debian.org, wnpp@debian.org:
Bug#861125; Package wnpp. (Tue, 25 Apr 2017 00:48:03 GMT) (full text, mbox, link).


Acknowledgement sent to Nicholas D Steeves <nsteeves@gmail.com>:
Extra info received and forwarded to list. Copy sent to wnpp@debian.org. (Tue, 25 Apr 2017 00:48:03 GMT) (full text, mbox, link).


Message #10 received at submit@bugs.debian.org (full text, mbox, reply):

From: Nicholas D Steeves <nsteeves@gmail.com>
To: Antoine Beaupre <anarcat@debian.org>, 861125@bugs.debian.org
Cc: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: Re: Bug#861125: RFP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
Date: Mon, 24 Apr 2017 20:46:13 -0400
[Message part 1 (text/plain, inline)]
control: -1 owner
control: -1 retitle ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing

Hi Antoine,

I'll do this one too, because it's something I'm interested in and
wish I had had as an undergrad.  Y-a-t'il une version française?
C'est quelque dont j'apprécierais énormément!

Cordially,
Nicholas
[signature.asc (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, wnpp@debian.org:
Bug#861125; Package wnpp. (Tue, 25 Apr 2017 00:48:05 GMT) (full text, mbox, link).


Acknowledgement sent to Nicholas D Steeves <nsteeves@gmail.com>:
Extra info received and forwarded to list. Copy sent to wnpp@debian.org. (Tue, 25 Apr 2017 00:48:05 GMT) (full text, mbox, link).


Owner recorded as Nicholas D Steeves <nsteeves@gmail.com>. Request was from Nicholas D Steeves <nsteeves@gmail.com> to control@bugs.debian.org. (Tue, 25 Apr 2017 00:51:05 GMT) (full text, mbox, link).


Removed annotation that Bug was owned by Nicholas D Steeves <nsteeves@gmail.com>. Request was from Bart Martens <bartm@quantz.debian.org> to control@bugs.debian.org. (Tue, 25 Apr 2017 04:21:02 GMT) (full text, mbox, link).


Owner recorded as Nicholas D Steeves <nsteeves@gmail.com>. Request was from Nicholas D Steeves <nsteeves@gmail.com> to control@bugs.debian.org. (Tue, 25 Apr 2017 12:06:02 GMT) (full text, mbox, link).


Changed Bug title to 'ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing' from 'RFP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing'. Request was from Nicholas D Steeves <nsteeves@gmail.com> to control@bugs.debian.org. (Tue, 25 Apr 2017 12:06:03 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, wnpp@debian.org, Nicholas D Steeves <nsteeves@gmail.com>:
Bug#861125; Package wnpp. (Tue, 25 Apr 2017 12:09:04 GMT) (full text, mbox, link).


Acknowledgement sent to Antoine Beaupré <anarcat@debian.org>:
Extra info received and forwarded to list. Copy sent to wnpp@debian.org, Nicholas D Steeves <nsteeves@gmail.com>. (Tue, 25 Apr 2017 12:09:04 GMT) (full text, mbox, link).


Message #28 received at 861125@bugs.debian.org (full text, mbox, reply):

From: Antoine Beaupré <anarcat@debian.org>
To: Nicholas D Steeves <nsteeves@gmail.com>
Cc: 861125@bugs.debian.org
Subject: Re: Bug#861125: RFP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
Date: Tue, 25 Apr 2017 08:06:50 -0400
On 2017-04-24 20:46:13, Nicholas D Steeves wrote:
> control: -1 owner
> control: -1 retitle ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
>
> Hi Antoine,
>
> I'll do this one too, because it's something I'm interested in and
> wish I had had as an undergrad.

Great!

> Y-a-t'il une version française?
> C'est quelque dont j'apprécierais énormément!

This is for english, and is rather simple, as I mentioned. A french
version would require a completely different package, or a severe
reconfiguration of this one... I looked into Grammalecte here:

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=860579

.. but it's not quite ready to be packaged just yet...

A.

-- 
That's one of the remarkable things about life: it's never so bad that
it can't get worse.
                        - Calvin



Information forwarded to debian-bugs-dist@lists.debian.org, wnpp@debian.org:
Bug#861125; Package wnpp. (Tue, 25 Apr 2017 15:21:02 GMT) (full text, mbox, link).


Acknowledgement sent to Nicholas D Steeves <nsteeves@gmail.com>:
Extra info received and forwarded to list. Copy sent to wnpp@debian.org. (Tue, 25 Apr 2017 15:21:02 GMT) (full text, mbox, link).


Message #33 received at 861125@bugs.debian.org (full text, mbox, reply):

From: Nicholas D Steeves <nsteeves@gmail.com>
To: Antoine Beaupré <anarcat@debian.org>
Cc: 861125@bugs.debian.org
Subject: Re: Bug#861125: ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
Date: Tue, 25 Apr 2017 11:17:28 -0400
control: tags -1 pending

Hi Antoine,

On Tue, Apr 25, 2017 at 08:06:50AM -0400, Antoine Beaupré wrote:
> On 2017-04-24 20:46:13, Nicholas D Steeves wrote:
> 
> > Y-a-t'il une version française?
> > C'est quelque dont j'apprécierais énormément!
> 
> This is for english, and is rather simple, as I mentioned. A french
> version would require a completely different package, or a severe
> reconfiguration of this one... I looked into Grammalecte here:
> 
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=860579
> 
> .. but it's not quite ready to be packaged just yet...

It will take some time to learn how this one works, but another reason
I'm interested in maintaining writegood-mode is I'm certain I can
contribute to it.  Preliminary packaging is here:
ssh://git.debian.org/git/pkg-emacsen/pkg/writegood-mode.git

Oh, I failed to ask in the writeroom RFP thread: Do you like the idea
of teaming up for that mini project (or a similar project).

I can't wait until Grammalecte is ready! :-)  How does it compare to a
famous business wordprocessor's grammar check, or to bonpatron?

Cheers,
Nicholas



Added tag(s) pending. Request was from Nicholas D Steeves <nsteeves@gmail.com> to 861125-submit@bugs.debian.org. (Tue, 25 Apr 2017 15:21:02 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, wnpp@debian.org, Nicholas D Steeves <nsteeves@gmail.com>:
Bug#861125; Package wnpp. (Tue, 25 Apr 2017 17:39:05 GMT) (full text, mbox, link).


Acknowledgement sent to Antoine Beaupré <anarcat@debian.org>:
Extra info received and forwarded to list. Copy sent to wnpp@debian.org, Nicholas D Steeves <nsteeves@gmail.com>. (Tue, 25 Apr 2017 17:39:05 GMT) (full text, mbox, link).


Message #40 received at 861125@bugs.debian.org (full text, mbox, reply):

From: Antoine Beaupré <anarcat@debian.org>
To: Nicholas D Steeves <nsteeves@gmail.com>
Cc: 861125@bugs.debian.org
Subject: Re: Bug#861125: ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
Date: Tue, 25 Apr 2017 13:37:12 -0400
On 2017-04-25 11:17:28, Nicholas D Steeves wrote:
> control: tags -1 pending
>
> Hi Antoine,
>
> On Tue, Apr 25, 2017 at 08:06:50AM -0400, Antoine Beaupré wrote:
>> On 2017-04-24 20:46:13, Nicholas D Steeves wrote:
>> 
>> > Y-a-t'il une version française?
>> > C'est quelque dont j'apprécierais énormément!
>> 
>> This is for english, and is rather simple, as I mentioned. A french
>> version would require a completely different package, or a severe
>> reconfiguration of this one... I looked into Grammalecte here:
>> 
>> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=860579
>> 
>> .. but it's not quite ready to be packaged just yet...
>
> It will take some time to learn how this one works, but another reason
> I'm interested in maintaining writegood-mode is I'm certain I can
> contribute to it.  Preliminary packaging is here:
> ssh://git.debian.org/git/pkg-emacsen/pkg/writegood-mode.git

Excellent. Same remark than writeroom about uploading to
mentors.debian.net. :) But it's great you pushed into git!

(It's just that I'm lazy: mentors.debian.net shows lintian output for
me... ;))

> Oh, I failed to ask in the writeroom RFP thread: Do you like the idea
> of teaming up for that mini project (or a similar project).

Sure, I can try - but I don't have much time unfortunately. I would
rather see the other emacsen people join in here - I'm not even part of
that team yet!

> I can't wait until Grammalecte is ready! :-)  How does it compare to a
> famous business wordprocessor's grammar check, or to bonpatron?

I don't quite know yet.

A.

-- 
Code is law.
                         - Lawrence Lessig



Information forwarded to debian-bugs-dist@lists.debian.org, wnpp@debian.org:
Bug#861125; Package wnpp. (Tue, 25 Apr 2017 22:30:03 GMT) (full text, mbox, link).


Acknowledgement sent to Nicholas D Steeves <nsteeves@gmail.com>:
Extra info received and forwarded to list. Copy sent to wnpp@debian.org. (Tue, 25 Apr 2017 22:30:03 GMT) (full text, mbox, link).


Message #45 received at 861125@bugs.debian.org (full text, mbox, reply):

From: Nicholas D Steeves <nsteeves@gmail.com>
To: Antoine Beaupré <anarcat@debian.org>
Cc: 861125@bugs.debian.org
Subject: Re: Bug#861125: ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
Date: Tue, 25 Apr 2017 18:27:11 -0400
On Tue, Apr 25, 2017 at 01:37:12PM -0400, Antoine Beaupré wrote:
> On 2017-04-25 11:17:28, Nicholas D Steeves wrote:
> >
> > It will take some time to learn how this one works, but another reason
> > I'm interested in maintaining writegood-mode is I'm certain I can
> > contribute to it.  Preliminary packaging is here:
> > ssh://git.debian.org/git/pkg-emacsen/pkg/writegood-mode.git
> 
> Excellent. Same remark than writeroom about uploading to
> mentors.debian.net. :) But it's great you pushed into git!
> 
> (It's just that I'm lazy: mentors.debian.net shows lintian output for
> me... ;))

I've uploaded a package for review.  Since I'm still a DM, would you
please sponsor it if it looks good?  I'd be happy to add you to
uploaders, if you'd like.

https://mentors.debian.net/package/writegood-mode
dget -x https://mentors.debian.net/debian/pool/main/w/writegood-mode/writegood-mode_2.0.2-1.dsc

> > Oh, I failed to ask in the writeroom RFP thread: Do you like the idea
> > of teaming up for that mini project (or a similar project).
> 
> Sure, I can try - but I don't have much time unfortunately. I would
> rather see the other emacsen people join in here - I'm not even part of
> that team yet!

I'd even appreciate occasional mockups/screenshots, brainstorming, or
wish lists, because I find they're good for staying motivated and
avoiding the "questions have more than one answer" pitfall when
implementing solutions ;-)

Cheers,
Nicholas



Information forwarded to debian-bugs-dist@lists.debian.org, wnpp@debian.org, Nicholas D Steeves <nsteeves@gmail.com>:
Bug#861125; Package wnpp. (Tue, 25 Apr 2017 23:09:03 GMT) (full text, mbox, link).


Acknowledgement sent to Antoine Beaupré <anarcat@debian.org>:
Extra info received and forwarded to list. Copy sent to wnpp@debian.org, Nicholas D Steeves <nsteeves@gmail.com>. (Tue, 25 Apr 2017 23:09:03 GMT) (full text, mbox, link).


Message #50 received at 861125@bugs.debian.org (full text, mbox, reply):

From: Antoine Beaupré <anarcat@debian.org>
To: Nicholas D Steeves <nsteeves@gmail.com>
Cc: 861125@bugs.debian.org
Subject: Re: Bug#861125: ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
Date: Tue, 25 Apr 2017 19:07:09 -0400
On 2017-04-25 18:27:11, Nicholas D Steeves wrote:
> On Tue, Apr 25, 2017 at 01:37:12PM -0400, Antoine Beaupré wrote:
>> On 2017-04-25 11:17:28, Nicholas D Steeves wrote:
>> >
>> > It will take some time to learn how this one works, but another reason
>> > I'm interested in maintaining writegood-mode is I'm certain I can
>> > contribute to it.  Preliminary packaging is here:
>> > ssh://git.debian.org/git/pkg-emacsen/pkg/writegood-mode.git
>> 
>> Excellent. Same remark than writeroom about uploading to
>> mentors.debian.net. :) But it's great you pushed into git!
>> 
>> (It's just that I'm lazy: mentors.debian.net shows lintian output for
>> me... ;))
>
> I've uploaded a package for review.  Since I'm still a DM, would you
> please sponsor it if it looks good?  I'd be happy to add you to
> uploaders, if you'd like.
>
> https://mentors.debian.net/package/writegood-mode
> dget -x https://mentors.debian.net/debian/pool/main/w/writegood-mode/writegood-mode_2.0.2-1.dsc

thanks!

here's a short review.

 1. the package's description doesn't mention "emacs" or "english" - in
    the original RFP, i used this instead:

    Description     : Minor mode for Emacs to improve English writing
      This is a minor mode to aid in finding common writing
      problems. Matt Might’s weaselwords scripts inspired this mode.
      .
      It highlights text based on a set of weasel-words, passive-voice
      and duplicate words.

 2. that version patch - really necessary? if upstream screwed up their
    versioning, it's kind of their problem no? since it's just a
    cosmetic change, I would avoid it, personnally.

 3. if you still think it's necessary, explain *why* it is there in the
    changelog, not just "it's there". :) same in the patch: not "what"
    but "why" in commitlogs...

 4. picking a random elpa package (elpa-helm), i notice it depends on
    "emacs" while yours depend on "emacs-common" - why? and why the
    versioned dependencies?

    https://anonscm.debian.org/git/pkg-emacsen/pkg/helm.git/tree/debian/control

I'm not very familiar with "elpa" packages, so I don't know if it works
or not - did you actually test this? :)

Thanks!

A.

-- 
Never be deceived that the rich will allow you to vote away their wealth.
                        - Lucy Parsons



Information forwarded to debian-bugs-dist@lists.debian.org, wnpp@debian.org, Nicholas D Steeves <nsteeves@gmail.com>:
Bug#861125; Package wnpp. (Thu, 27 Apr 2017 01:24:06 GMT) (full text, mbox, link).


Acknowledgement sent to Nicholas Steeves <nsteeves@gmail.com>:
Extra info received and forwarded to list. Copy sent to wnpp@debian.org, Nicholas D Steeves <nsteeves@gmail.com>. (Thu, 27 Apr 2017 01:24:06 GMT) (full text, mbox, link).


Message #55 received at 861125@bugs.debian.org (full text, mbox, reply):

From: Nicholas Steeves <nsteeves@gmail.com>
To: Antoine Beaupré <anarcat@debian.org>
Cc: 861125@bugs.debian.org, Sean Whitton <spwhitton@spwhitton.name>
Subject: Re: Bug#861125: ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
Date: Wed, 26 Apr 2017 21:22:23 -0400
Hi Antoine and Sean,

If you don't know each other yet, I'll just say that you two of the
most friendly and patient people I've met through Debian.

Sean, I've CC'ed you because Antoine expressed interest in joining the
pkg-emacsen team, and he asked me a couple of questions about dh-elpa
and dh-make-elpa that I couldn't answer.  I'd be happy to work your
replies into a documentation patch, or a wiki page if you're busy.
The questions we need help with are at 2. and especially 4.

On 25 April 2017 at 19:07, Antoine Beaupré <anarcat@debian.org> wrote:
> On 2017-04-25 18:27:11, Nicholas D Steeves wrote:
>> On Tue, Apr 25, 2017 at 01:37:12PM -0400, Antoine Beaupré wrote:
>>> On 2017-04-25 11:17:28, Nicholas D Steeves wrote:
>>> >
>>> > It will take some time to learn how this one works, but another reason
>>> > I'm interested in maintaining writegood-mode is I'm certain I can
>>> > contribute to it.  Preliminary packaging is here:
>>> > ssh://git.debian.org/git/pkg-emacsen/pkg/writegood-mode.git
>>>
>>> Excellent. Same remark than writeroom about uploading to
>>> mentors.debian.net. :) But it's great you pushed into git!
>>>
>>> (It's just that I'm lazy: mentors.debian.net shows lintian output for
>>> me... ;))
>>
>> I've uploaded a package for review.  Since I'm still a DM, would you
>> please sponsor it if it looks good?  I'd be happy to add you to
>> uploaders, if you'd like.
>>
>> https://mentors.debian.net/package/writegood-mode
>> dget -x https://mentors.debian.net/debian/pool/main/w/writegood-mode/writegood-mode_2.0.2-1.dsc
>
> thanks!
>
> here's a short review.
>
>  1. the package's description doesn't mention "emacs" or "english" - in
>     the original RFP, i used this instead:
>
>     Description     : Minor mode for Emacs to improve English writing
>       This is a minor mode to aid in finding common writing
>       problems. Matt Might’s weaselwords scripts inspired this mode.
>       .
>       It highlights text based on a set of weasel-words, passive-voice
>       and duplicate words.

My apologies, I failed to scrutinise the differences between the
description you provided and the one dh-make-elpa generated.  I've
merged your copy and credited you in d/copyright.  D/* uses the same
license as upstream package, which you said was your preference in
another thread, so I assume this is ok.  By the way, dh-make-elpa and
gbp make it really easy to do these packages.  From the manpage (plus
addition of the gbp repo creation)

% git clone -o upstream https://foo.org/foo.git
% cd foo
% git reset --hard 1.0.0    # package latest stable release
% dh-make-elpa --pkg-emacsen
% git add debian && git commit -m "initial Debianisation"
% git deborig
% dpkg-buildpackage -us -uc
% gbp create-remote-repo --remote-url-pattern=ssh://git.debian.org/git/pkg-emacsen/pkg/foo.git

>  2. that version patch - really necessary? if upstream screwed up their
>     versioning, it's kind of their problem no? since it's just a
>     cosmetic change, I would avoid it, personnally.

Is it just a cosmetic change?  I chose to be cautious out of ignorance
of how elpa/MELPA works, because I wonder if it uses this versioning
to decide whether to download local-to-$USER updates.  We don't
recommend that users mix packaging systems like this, of course, and I
guess it could be argued that if the system provided version
(unpatched is 2.1) is higher than the upstream one (2.0.1), then MELPA
would refuse to download locale-to-$USER updates until upstream tagged
2.1.0.  I plan to drop a similar patch for writeroom-mode, because the
convention of most of these upstreams seems to be to only increment
major and minor versions but not patch-level versions.

>  3. if you still think it's necessary, explain *why* it is there in the
>     changelog, not just "it's there". :) same in the patch: not "what"
>     but "why" in commitlogs...

" * Add filename.patch for maximal correctness and just to be extra
safe" didn't seem like a strong enough case, and I prefer to do the
work when I have time and revert if unnecessary.  If it's truly just
cosmetic I'll drop it.  'good for some gbp pq practice and another
lesson in how *self describing file names are not sufficient for
debian changelogs* ;-)

>  4. picking a random elpa package (elpa-helm), i notice it depends on
>     "emacs" while yours depend on "emacs-common" - why? and why the
>     versioned dependencies?
>
>     https://anonscm.debian.org/git/pkg-emacsen/pkg/helm.git/tree/debian/control

My best guess is it's the difference between a package converted to
elpa vs a package created with dh-make-elpa, and I Sean has reasons
for generating versioned dependencies by default.  This is actually
one of the reasons I was paranoid about 2. ;-)

> I'm not very familiar with "elpa" packages, so I don't know if it works
> or not - did you actually test this? :)

Yes, and I was surprised to see teal squiggly lines appear...for
passive voice :-o Also, at the moment, the versioned dependencies for
sid can be satisfied on stretch. (I built in a sid cowbuilder but
installed on stretch).

Cheers,
Nicholas



Information forwarded to debian-bugs-dist@lists.debian.org, wnpp@debian.org, Nicholas D Steeves <nsteeves@gmail.com>:
Bug#861125; Package wnpp. (Thu, 27 Apr 2017 01:30:05 GMT) (full text, mbox, link).


Acknowledgement sent to Antoine Beaupré <anarcat@debian.org>:
Extra info received and forwarded to list. Copy sent to wnpp@debian.org, Nicholas D Steeves <nsteeves@gmail.com>. (Thu, 27 Apr 2017 01:30:05 GMT) (full text, mbox, link).


Message #60 received at 861125@bugs.debian.org (full text, mbox, reply):

From: Antoine Beaupré <anarcat@debian.org>
To: Nicholas Steeves <nsteeves@gmail.com>
Cc: 861125@bugs.debian.org, Sean Whitton <spwhitton@spwhitton.name>
Subject: Re: Bug#861125: ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
Date: Wed, 26 Apr 2017 21:26:49 -0400
Hi!

I unfortunately won't have time to review this further - but don't block
on anything from me, all is good if spwhitton goes it. ;)

And i'm fine with licensing the description as you see fit.

A.
-- 
Ce que les siècles des grands abatoirs nous aura appris
Devrait être inscrit au fond de toutes les écoles;
Voici l'homme: le destructeur des mondes est arrivé.
                        - [no one is innocent]



Information forwarded to debian-bugs-dist@lists.debian.org, wnpp@debian.org, Nicholas D Steeves <nsteeves@gmail.com>:
Bug#861125; Package wnpp. (Thu, 27 Apr 2017 20:39:03 GMT) (full text, mbox, link).


Acknowledgement sent to Sean Whitton <spwhitton@spwhitton.name>:
Extra info received and forwarded to list. Copy sent to wnpp@debian.org, Nicholas D Steeves <nsteeves@gmail.com>. (Thu, 27 Apr 2017 20:39:03 GMT) (full text, mbox, link).


Message #65 received at 861125@bugs.debian.org (full text, mbox, reply):

From: Sean Whitton <spwhitton@spwhitton.name>
To: Nicholas Steeves <nsteeves@gmail.com>
Cc: Antoine Beaupré <anarcat@debian.org>, 861125@bugs.debian.org
Subject: Re: Bug#861125: ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
Date: Thu, 27 Apr 2017 13:36:10 -0700
[Message part 1 (text/plain, inline)]
Hello Nicholas,

On Wed, Apr 26, 2017 at 09:22:23PM -0400, Nicholas Steeves wrote:
> The questions we need help with are at 2. and especially 4.

Okay -- I'll answer those.

> >  2. that version patch - really necessary? if upstream screwed up their
> >     versioning, it's kind of their problem no? since it's just a
> >     cosmetic change, I would avoid it, personnally.
> 
> Is it just a cosmetic change?

Nicholas is right.  It's not just a cosmetic change.  It's important
that ELPA package versions match Debian package versions.

In addition to enabling users to mix package.el packages and Debian
elpa-* packages, it ensures that Emacs has the right information to tell
whether versioned ELPA dependencies are satisfied.  Otherwise it can
refuse to load packages/try to download new versions from MELPA.

> >  4. picking a random elpa package (elpa-helm), i notice it depends on
> >     "emacs" while yours depend on "emacs-common" - why? and why the
> >     versioned dependencies?
> >
> >     https://anonscm.debian.org/git/pkg-emacsen/pkg/helm.git/tree/debian/control
> 
> My best guess is it's the difference between a package converted to
> elpa vs a package created with dh-make-elpa, and I Sean has reasons
> for generating versioned dependencies by default.  This is actually
> one of the reasons I was paranoid about 2. ;-)

That's a bug in elpa-helm.  It should be emacsen-common.  See the Debian
Emacs policy.

-- 
Sean Whitton
[signature.asc (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, wnpp@debian.org:
Bug#861125; Package wnpp. (Thu, 27 Apr 2017 21:27:03 GMT) (full text, mbox, link).


Acknowledgement sent to Nicholas D Steeves <nsteeves@gmail.com>:
Extra info received and forwarded to list. Copy sent to wnpp@debian.org. (Thu, 27 Apr 2017 21:27:03 GMT) (full text, mbox, link).


Message #70 received at 861125@bugs.debian.org (full text, mbox, reply):

From: Nicholas D Steeves <nsteeves@gmail.com>
To: Sean Whitton <spwhitton@spwhitton.name>, Antoine Beaupré <anarcat@debian.org>, 861125@bugs.debian.org
Subject: Re: Bug#861125: ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
Date: Thu, 27 Apr 2017 17:23:45 -0400
[Message part 1 (text/plain, inline)]
Hi Sean,

On Thu, Apr 27, 2017 at 01:36:10PM -0700, Sean Whitton wrote:
> Hello Nicholas,
> 
> On Wed, Apr 26, 2017 at 09:22:23PM -0400, Nicholas Steeves wrote:
> > The questions we need help with are at 2. and especially 4.
> 
> Okay -- I'll answer those.
> 
> > >  2. that version patch - really necessary? if upstream screwed up their
> > >     versioning, it's kind of their problem no? since it's just a
> > >     cosmetic change, I would avoid it, personnally.
> > 
> > Is it just a cosmetic change?
> 
> Nicholas is right.  It's not just a cosmetic change.  It's important
> that ELPA package versions match Debian package versions.

Thank you for mentoring me to err on the side of caution :-) As a
rule, for Debian, is it most correct that the embedded version in the
headers be patched to reflect x.y.z tag, even if upstream only updates
the header version for x.y?  Also, to make this stranger yet, the
MELPA uses date-based snapshot versioning. eg: 20160802.1405

https://melpa.org/#/writegood-mode

> In addition to enabling users to mix package.el packages and Debian
> elpa-* packages, it ensures that Emacs has the right information to tell
> whether versioned ELPA dependencies are satisfied.  Otherwise it can
> refuse to load packages/try to download new versions from MELPA.
> 
> > >  4. picking a random elpa package (elpa-helm), i notice it depends on
> > >     "emacs" while yours depend on "emacs-common" - why? and why the
> > >     versioned dependencies?
> > >
> > >     https://anonscm.debian.org/git/pkg-emacsen/pkg/helm.git/tree/debian/control
> > 
> > My best guess is it's the difference between a package converted to
> > elpa vs a package created with dh-make-elpa, and I Sean has reasons
> > for generating versioned dependencies by default.  This is actually
> > one of the reasons I was paranoid about 2. ;-)
> 
> That's a bug in elpa-helm.  It should be emacsen-common.  See the Debian
> Emacs policy.

I fixed this as a team upload, and pushed the changes.
The package is also available here:

https://mentors.debian.net/package/helm
dget -x https://mentors.debian.net/debian/pool/main/h/helm/helm_2.5.0-2.dsc

I only tested that it built and installed without error because I'm
not familiar with helm.

Cheers,
Nicholas
[signature.asc (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, wnpp@debian.org, Nicholas D Steeves <nsteeves@gmail.com>:
Bug#861125; Package wnpp. (Thu, 27 Apr 2017 23:06:03 GMT) (full text, mbox, link).


Acknowledgement sent to Sean Whitton <spwhitton@spwhitton.name>:
Extra info received and forwarded to list. Copy sent to wnpp@debian.org, Nicholas D Steeves <nsteeves@gmail.com>. (Thu, 27 Apr 2017 23:06:03 GMT) (full text, mbox, link).


Message #75 received at 861125@bugs.debian.org (full text, mbox, reply):

From: Sean Whitton <spwhitton@spwhitton.name>
To: Nicholas D Steeves <nsteeves@gmail.com>
Cc: Antoine Beaupré <anarcat@debian.org>, 861125@bugs.debian.org
Subject: Re: Bug#861125: ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
Date: Thu, 27 Apr 2017 16:04:17 -0700
[Message part 1 (text/plain, inline)]
On Thu, Apr 27, 2017 at 05:23:45PM -0400, Nicholas D Steeves wrote:
> Thank you for mentoring me to err on the side of caution :-) As a
> rule, for Debian, is it most correct that the embedded version in the
> headers be patched to reflect x.y.z tag, even if upstream only updates
> the header version for x.y?  Also, to make this stranger yet, the
> MELPA uses date-based snapshot versioning. eg: 20160802.1405
> 
> https://melpa.org/#/writegood-mode

It shouldn't be patched to add a minor version.  This is because other
ELPA package authors won't include this in their versioned
dependencies.

> I fixed this as a team upload, and pushed the changes.
> The package is also available here:
> 
> https://mentors.debian.net/package/helm
> dget -x https://mentors.debian.net/debian/pool/main/h/helm/helm_2.5.0-2.dsc
> 
> I only tested that it built and installed without error because I'm
> not familiar with helm.

Thanks for the fix -- though this would need to go to experimental due
to the freeze.

-- 
Sean Whitton
[signature.asc (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, wnpp@debian.org:
Bug#861125; Package wnpp. (Thu, 11 May 2017 14:42:04 GMT) (full text, mbox, link).


Acknowledgement sent to Nicholas D Steeves <nsteeves@gmail.com>:
Extra info received and forwarded to list. Copy sent to wnpp@debian.org. (Thu, 11 May 2017 14:42:04 GMT) (full text, mbox, link).


Message #80 received at 861125@bugs.debian.org (full text, mbox, reply):

From: Nicholas D Steeves <nsteeves@gmail.com>
To: Sean Whitton <spwhitton@spwhitton.name>, Antoine Beaupré <anarcat@debian.org>, 861125@bugs.debian.org
Subject: Re: Bug#861125: ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
Date: Thu, 11 May 2017 10:39:22 -0400
[Message part 1 (text/plain, inline)]
On Thu, Apr 27, 2017 at 04:04:17PM -0700, Sean Whitton wrote:
> On Thu, Apr 27, 2017 at 05:23:45PM -0400, Nicholas D Steeves wrote:
> > Thank you for mentoring me to err on the side of caution :-) As a
> > rule, for Debian, is it most correct that the embedded version in the
> > headers be patched to reflect x.y.z tag, even if upstream only updates
> > the header version for x.y?  Also, to make this stranger yet, the
> > MELPA uses date-based snapshot versioning. eg: 20160802.1405
> > 
> > https://melpa.org/#/writegood-mode
> 
> It shouldn't be patched to add a minor version.  This is because other
> ELPA package authors won't include this in their versioned
> dependencies.
> 
> > I fixed this as a team upload, and pushed the changes.
> > The package is also available here:
> > 
> > https://mentors.debian.net/package/helm
> > dget -x https://mentors.debian.net/debian/pool/main/h/helm/helm_2.5.0-2.dsc
> > 
> > I only tested that it built and installed without error because I'm
> > not familiar with helm.
> 
> Thanks for the fix -- though this would need to go to experimental due
> to the freeze.

Hi Sean,

You're welcome, and thank you for the assistance.  'Hope you're
enjoying settling into your new home :-)

I think src:writegood-mode is ready to upload.  Since Antoine is going
to be busy for a while would you please consider sponsoring this one?

It builds these binary packages:

    elpa-writegood-mode - Minor mode for Emacs to improve English writing

To access further information about this package, please visit the following URL:

    https://mentors.debian.net/package/writegood-mode

Alternatively, one can download the package with dget using this command:

    dget -x https://mentors.debian.net/debian/pool/main/w/writegood-mode/writegood-mode_2.0.2-1.dsc

Also available here:

    git clone ssh://git.debian.org/git/pkg-emacsen/pkg/writegood-mode.git

Sincerely,
Nicholas
[signature.asc (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, wnpp@debian.org:
Bug#861125; Package wnpp. (Thu, 11 May 2017 14:51:03 GMT) (full text, mbox, link).


Acknowledgement sent to Nicholas D Steeves <nsteeves@gmail.com>:
Extra info received and forwarded to list. Copy sent to wnpp@debian.org. (Thu, 11 May 2017 14:51:03 GMT) (full text, mbox, link).


Message #85 received at 861125@bugs.debian.org (full text, mbox, reply):

From: Nicholas D Steeves <nsteeves@gmail.com>
To: Sean Whitton <spwhitton@spwhitton.name>, Antoine Beaupré <anarcat@debian.org>, 861125@bugs.debian.org
Subject: P.S. Re: Bug#861125: ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
Date: Thu, 11 May 2017 10:46:47 -0400
P.S. I had already filed RFS Bug #861699.  For future reference, which
is correct?

1) I. someone files an RFP, II. one takes ownership and retitles it to an
ITP, III. if one then needs a sponsor one drops ownership and retitles to
an RFS ... [ITP]

2) I and II remain the same, but instead of III, file a new RFS.



Information forwarded to debian-bugs-dist@lists.debian.org, wnpp@debian.org, Nicholas D Steeves <nsteeves@gmail.com>:
Bug#861125; Package wnpp. (Thu, 11 May 2017 17:24:07 GMT) (full text, mbox, link).


Acknowledgement sent to Sean Whitton <spwhitton@spwhitton.name>:
Extra info received and forwarded to list. Copy sent to wnpp@debian.org, Nicholas D Steeves <nsteeves@gmail.com>. (Thu, 11 May 2017 17:24:07 GMT) (full text, mbox, link).


Message #90 received at 861125@bugs.debian.org (full text, mbox, reply):

From: Sean Whitton <spwhitton@spwhitton.name>
To: Nicholas D Steeves <nsteeves@gmail.com>
Cc: Antoine Beaupré <anarcat@debian.org>, 861125@bugs.debian.org
Subject: Re: Bug#861125: ITP: elpa-writegood-mode -- Minor mode for Emacs to improve English writing
Date: Thu, 11 May 2017 10:21:29 -0700
[Message part 1 (text/plain, inline)]
On Thu, May 11, 2017 at 10:39:22AM -0400, Nicholas D Steeves wrote:
> I think src:writegood-mode is ready to upload.  Since Antoine is going
> to be busy for a while would you please consider sponsoring this one?

I hope to take a look, but it will probably have to wait until the end
of next week -- I'm changing continents for the summer.

On Thu, May 11, 2017 at 10:46:47AM -0400, Nicholas D Steeves wrote:
> P.S. I had already filed RFS Bug #861699.  For future reference, which
> is correct?
> 
> 1) I. someone files an RFP, II. one takes ownership and retitles it to an
> ITP, III. if one then needs a sponsor one drops ownership and retitles to
> an RFS ... [ITP]
> 
> 2) I and II remain the same, but instead of III, file a new RFS.

(2).  The RFP/ITP and RFS are completely separate.  The RFS should block
the ITP.

-- 
Sean Whitton
[signature.asc (application/pgp-signature, inline)]

Added blocking bug(s) of 861125: 861699 Request was from Nicholas D Steeves <nsteeves@gmail.com> to control@bugs.debian.org. (Fri, 12 May 2017 01:51:03 GMT) (full text, mbox, link).


Reply sent to Nicholas D Steeves <nsteeves@gmail.com>:
You have taken responsibility. (Wed, 17 May 2017 14:03:08 GMT) (full text, mbox, link).


Notification sent to Antoine Beaupre <anarcat@debian.org>:
Bug acknowledged by developer. (Wed, 17 May 2017 14:03:08 GMT) (full text, mbox, link).


Message #97 received at 861125-close@bugs.debian.org (full text, mbox, reply):

From: Nicholas D Steeves <nsteeves@gmail.com>
To: 861125-close@bugs.debian.org
Subject: Bug#861125: fixed in writegood-mode 2.0.2-1
Date: Wed, 17 May 2017 14:00:18 +0000
Source: writegood-mode
Source-Version: 2.0.2-1

We believe that the bug you reported is fixed in the latest version of
writegood-mode, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 861125@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Nicholas D Steeves <nsteeves@gmail.com> (supplier of updated writegood-mode package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 14 May 2017 21:49:52 -0400
Source: writegood-mode
Binary: elpa-writegood-mode
Architecture: all source
Version: 2.0.2-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Emacs addons team <pkg-emacsen-addons@lists.alioth.debian.org>
Changed-By: Nicholas D Steeves <nsteeves@gmail.com>
Closes: 861125
Description: 
 elpa-writegood-mode - Minor mode for Emacs to improve English writing
Changes:
 writegood-mode (2.0.2-1) unstable; urgency=medium
 .
   * Initial release. (Closes: #861125)
   * Add 0001-Correct-Version-and-Last-Updated-date.patch
     - this insures that any potential ELPA dependencies are correctly
       satisfied from within Emacs. If a user downloads a MELPA package that
       needs a newer version of writegood-mode than this, Emacs should
       download that updated version from MELPA, and hopefully that user will
       file a bug requesting that we package that new upstream version.
Checksums-Sha1: 
 d06649cb8dc76b20105bc4315b51ccf73b1125c0 2149 writegood-mode_2.0.2-1.dsc
 4e8cae7c3d1e7c22c25a0e0df5419cfe522b3f73 4528 writegood-mode_2.0.2.orig.tar.xz
 34e3cad2c5a8d63235d849309af5df5726cdd8db 2308 writegood-mode_2.0.2-1.debian.tar.xz
 054424237861b030b6e304cf4ff0113853ee8c5c 7858 elpa-writegood-mode_2.0.2-1_all.deb
 7f9fb8046ab806605662d1184021c214a93dc61a 7337 writegood-mode_2.0.2-1_amd64.buildinfo
Checksums-Sha256: 
 f71e8fa315e4bf7b4438a0a4463ba23f93851be0030e6823fdffb49bf6669bca 2149 writegood-mode_2.0.2-1.dsc
 e5fd2ac28904b3359b8e82c1e69491aaf17bf7bb9d4d21010a85ae86bbef5248 4528 writegood-mode_2.0.2.orig.tar.xz
 6aeff5745d06fb5cd332c9af51e5b5ae62fdc6f74d186ece949f09da8b01fb47 2308 writegood-mode_2.0.2-1.debian.tar.xz
 dabe3ccd636eea7362224df0f0c3dd9a3f3e6383e28d7982a856d5fcae58f2d2 7858 elpa-writegood-mode_2.0.2-1_all.deb
 9854cd6489fffc112a3f1f45f259915d5acf4e25196d6553f3a7e30280f19fee 7337 writegood-mode_2.0.2-1_amd64.buildinfo
Files: 
 5b63eeb7219e5f3c2c67a855a67f2c0c 2149 lisp optional writegood-mode_2.0.2-1.dsc
 0d8e1c85cfdb11df1d0abfe8c977b662 4528 lisp optional writegood-mode_2.0.2.orig.tar.xz
 992bee325581d9b1e01427adf6f2cd3b 2308 lisp optional writegood-mode_2.0.2-1.debian.tar.xz
 ebe934821a24d03cca61af8d3e28089f 7858 lisp optional elpa-writegood-mode_2.0.2-1_all.deb
 2bfb18684c34c17b3ac1562bd411ea74 7337 lisp optional writegood-mode_2.0.2-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEm5FwB64DDjbk/CSLaVt65L8GYkAFAlkaMPMACgkQaVt65L8G
YkD0Sw//WSGQO6ywPbaSrygMOYoYUFfXNZS1s6EpgvgryqWjcNQ7r0Mfl3VrhG+w
SCKufkMDx/5Nxdszoj5bpU9ROgurFu/JuMMiOYvcJdFvmtSFnZ4SsJARgQEl12Ra
WWPXduaUMjPeVbHvZFOrkmnECzAhBLUw3vJDjfnSbQMKYePiBHx68V/D5oTOmVG3
7H3SoIe1e5XGL81B7L8op2p6LCWvI6jVcLbt5+vCb2Mf9j+LV8A2H6hseLGL/TC5
pmRXn1aEJXEJCI1JHKWVOQbOEyqYimh2jyLZ+fFcrZPFk/4XIkXkg9y90p+VMRY8
eNr1axocw4CUZ1TphfWJfJ29chp9YbP4jiXM1edE9AUEtOj1JBpKNl2EKtdYs6oZ
cyVb4whMOVX7u3mD9/wLB0kZSQlyXcUR/PENttd/5p1TzqbKEHWQQpTGA+64tEOO
VRcd9c8lvL6Q9Z2vI78rpduO5iNwejnvBzoG3BCBP4rutWP5F37RFzcUglmaWpcF
VXUFgpe36qUu9RDfw0zWA9ZVpwmjyJne4SocLbWV6yDY7XUeIgpFBRBKIYtJk4+2
4eu6vX8Rb15qsb56Nt88d4cTz4rHe6E0pkNxTek5aSV1ZUfB16FKkoYAY2V+OAom
BfVbR2QLWq5UbOXOHIR4an6ksPTbNAVek6itUMsHAzj840mIUbY=
=rDLu
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Thu, 15 Jun 2017 07:25:17 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Fri Nov 22 00:22:55 2024; Machine Name: bembo

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.