Debian Bug report logs - #857940
diffoscope: FTBFS: test errors

version graph

Package: src:diffoscope; Maintainer for src:diffoscope is Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>;

Reported by: Mattia Rizzolo <mattia@debian.org>

Date: Thu, 16 Mar 2017 14:03:01 UTC

Severity: serious

Found in version diffoscope/79

Fixed in version diffoscope/80

Done: Chris Lamb <lamby@debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#857940; Package src:diffoscope. (Thu, 16 Mar 2017 14:03:03 GMT) (full text, mbox, link).


Message #3 received at submit@bugs.debian.org (full text, mbox, reply):

From: Mattia Rizzolo <mattia@debian.org>
To: submit@bugs.debian.org
Subject: diffoscope: FTBFS: test errors
Date: Thu, 16 Mar 2017 15:01:42 +0100
[Message part 1 (text/plain, inline)]
Source: diffoscope
Version: 79
Severity: serious

=================================== FAILURES ===================================
________________________________ test_diff_meta ________________________________

differences_meta = [<Difference Image metadata -- Image metadata []>]

    @skip_unless_tools_exist('img2txt', 'identify')
    @skip_unless_tool_is_at_least('identify', identify_version, '6.9.6')
    def test_diff_meta(differences_meta):
        expected_diff = get_data('ico_image_meta_expected_diff')
>       assert differences_meta[-1].unified_diff == expected_diff
E       assert '@@ -1,9 +1,9... Channels: \n' == '@@ -1,17 +1,1...a: 0.454545\n'
E         - @@ -1,9 +1,9 @@
E         ?       ^    ^
E         + @@ -1,17 +1,17 @@
E         ?       ^^    ^^
E            Image format: ICO
E         - -File size: 6.8Ki
E         ?               ^ ^
E         + -File size: 6.93KB
E         ?               ^^ ^
E         - +File size: 3.2Ki
E         ?                 ^
E         + +File size: 3.27KB
E         ?                + ^
E         -  Height: 
E         +  Height: 100
E         ?          +++
E         -  Width: 
E         +  Width: 100
E         ?         +++
E         -  Orientation: 
E         +  Orientation: Undefined
E         ?               +++++++++
E         -  Compression type: 
E         +  Compression type: Undefined
E         ?                    +++++++++
E         -  Compression quality: 
E         +  Compression quality: 0
E         ?                       +
E         -  Colorspace: 
E         +  Colorspace: sRGB
E         ?              ++++
E         -  Channels: 
E         +  Channels: srgba
E         ?            +++++
E         + -Depth: 4
E         + +Depth: 1
E         +  Interlace mode: None
E         +  Rendering intent: Perceptual
E         +  X resolution: 0
E         +  Y resolution: 0
E         +  Resolution units: Undefined
E         +  Transparency channel enabled: True
E         +  Gamma: 0.454545

differences_meta = [<Difference Image metadata -- Image metadata []>]
expected_diff = '@@ -1,17 +1,17 @@\n Image format: ICO\n-File size: 6.93KB\n+File size: 3.27KB\n Height: 100\n Width: 100\n Orientatio...resolution: 0\n Y resolution: 0\n Resolution units: Undefined\n Transparency channel enabled: True\n Gamma: 0.454545\n'

tests/comparators/test_ico_image.py:58: AssertionError
________________________________ test_diff_meta ________________________________

differences_meta = [<Difference Image metadata -- Image metadata []>]

    @skip_unless_tools_exist('img2txt', 'identify')
    @skip_unless_tool_is_at_least('identify', identify_version, '6.9.6')
    def test_diff_meta(differences_meta):
        expected_diff = get_data('jpeg_image_meta_expected_diff')
>       assert differences_meta[-1].unified_diff == expected_diff
E       assert '@@ -1,9 +1,9...EXIF data: \n' == '@@ -1,20 +1,2...EXIF data: \n'
E         - @@ -1,9 +1,9 @@
E         ?       ^    ^
E         + @@ -1,20 +1,20 @@
E         ?       ^^    ^^
E            Image format: JPEG
E         - -File size: 662
E         + -File size: 662B
E         ?                +
E         - +File size: 627
E         + +File size: 627B
E         ?                +
E         -  Height: 
E         +  Height: 100
E         ?          +++
E         -  Width: 
E         +  Width: 100
E         ?         +++
E         -  Orientation: 
E         +  Orientation: Undefined
E         ?               +++++++++
E         -  Compression type: 
E         +  Compression type: JPEG
E         ?                    ++++
E         -  Compression quality: 
E         ? ^
E         + -Compression quality: 90
E         ? ^                     ++
E         + +Compression quality: 95
E         -  Colorspace: 
E         +  Colorspace: sRGB
E         ?              ++++
E         -  Channels: 
E         +  Channels: srgb
E         ?            ++++
E         - @@ -12,9 +12,9 @@
E         +  Depth: 8
E         +  Interlace mode: JPEG
E         -  Rendering intent: 
E         +  Rendering intent: Perceptual
E         ?                    ++++++++++
E         -  X resolution: 
E         ? ^
E         + -X resolution: 88
E         ? ^              ++
E         -  Y resolution: 
E         ? ^
E         + -Y resolution: 88
E         ? ^              ++
E         + +X resolution: 65
E         + +Y resolution: 65
E         -  Resolution units: 
E         +  Resolution units: PixelsPerInch
E         ?                    +++++++++++++
E         -  Transparency channel enabled: false
E         ?                                ^
E         +  Transparency channel enabled: False
E         ?                                ^
E         -  Gamma: 
E         +  Gamma: 0.454545
E         -  Number of unique colors: 
E         +  Number of unique colors: 1
E         ?                           +
E           -Comment: Comment #1
E           +Comment: Comment #2
E            EXIF data:

differences_meta = [<Difference Image metadata -- Image metadata []>]
expected_diff = '@@ -1,20 +1,20 @@\n Image format: JPEG\n-File size: 662B\n+File size: 627B\n Height: 100\n Width: 100\n Orientation: ...bled: False\n Gamma: 0.454545\n Number of unique colors: 1\n-Comment: Comment #1\n+Comment: Comment #2\n EXIF data: \n'

tests/comparators/test_jpeg_image.py:73: AssertionError
============== 2 failed, 282 passed, 15 skipped in 235.62 seconds ==============
E: pybuild pybuild:283: test: plugin distutils failed with: exit code=1: cd /«PKGBUILDDIR»/.pybuild/pythonX.Y_3.5/build; python3.5 -m pytest -vv -r sxX -l --cov=diffoscope --cov-report=term-missing --cov-report=html
dh_auto_test: pybuild --test --test-pytest -i python{version} -p 3.5 returned exit code 13
debian/rules:29: recipe for target 'build-indep' failed
make: *** [build-indep] Error 25
dpkg-buildpackage: error: debian/rules build-indep gave error exit status 2

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
[signature.asc (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#857940; Package src:diffoscope. (Thu, 16 Mar 2017 15:45:05 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Lamb <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Thu, 16 Mar 2017 15:45:05 GMT) (full text, mbox, link).


Message #8 received at 857940@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>
To: 857940@bugs.debian.org
Subject: Re: Bug#857940: diffoscope: FTBFS: test errors
Date: Thu, 16 Mar 2017 15:40:46 +0000
Hi Mattia,

> […]

Assuming this is from...

  https://buildd.debian.org/status/fetch.php?pkg=diffoscope&arch=all&ver=79&stamp=1489658432&raw=0

... it appears to be caused by "graphicsmagick-imagemagick-compat"
package being installed. With this package installed locally I can
reproduce the test failures.

I don't yet know why it is being installed at all; it isn't when
installing all the build-dependencies on my machine, even under
experimental.

Nor is it being installed on tests.reproducible.org or we would
naturally have all seen this prior to upload. Indeed, we should
have seen it whenever we first pushed to experimental weeks ago;
there have been no code changes to the ICO or JPEG handler.

(Perhaps the/this experimental:all buildd is installing packages
with Recommends, or a different APT pinning, or...?)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-



Information forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#857940; Package src:diffoscope. (Thu, 16 Mar 2017 16:03:13 GMT) (full text, mbox, link).


Message #11 received at 857940@bugs.debian.org (full text, mbox, reply):

From: Mattia Rizzolo <mattia@debian.org>
To: 857940@bugs.debian.org
Subject: Re: Bug#857940: diffoscope: FTBFS: test errors
Date: Thu, 16 Mar 2017 16:58:23 +0100
[Message part 1 (text/plain, inline)]
On Thu, Mar 16, 2017 at 03:40:46PM +0000, Chris Lamb wrote:
> Assuming this is from...
> 
>   https://buildd.debian.org/status/fetch.php?pkg=diffoscope&arch=all&ver=79&stamp=1489658432&raw=0

yes.

> ... it appears to be caused by "graphicsmagick-imagemagick-compat"
> package being installed. With this package installed locally I can
> reproduce the test failures.

umh

> (Perhaps the/this experimental:all buildd is installing packages
> with Recommends, or a different APT pinning, or...?)

The buildds are using the aspcud sbuild resolver for experimental, this
might have something to do with that.
Anyhow, if a package causes the build to fail it should either be in
Build-Conflicts{,-Indep,-Arch}, or the package be fixed, imho (besides,
this is the same argument we brought to add those Build-Conflicts with
package failing to build with a buggy locales-all two years ago…).

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
[signature.asc (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#857940; Package src:diffoscope. (Thu, 16 Mar 2017 16:06:03 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Lamb <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Thu, 16 Mar 2017 16:06:03 GMT) (full text, mbox, link).


Message #16 received at 857940@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>
To: 857940@bugs.debian.org
Subject: Re: diffoscope: FTBFS: test errors
Date: Thu, 16 Mar 2017 16:02:46 +0000
tags 857940 + pending
thanks

Fixed in Git:

  https://anonscm.debian.org/git/reproducible/diffoscope.git/commit/?id=d03037820c34ddd168d6ce5d000e5a5dbcbf4e7f


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-



Added tag(s) pending. Request was from Chris Lamb <lamby@debian.org> to control@bugs.debian.org. (Thu, 16 Mar 2017 16:06:05 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#857940; Package src:diffoscope. (Thu, 16 Mar 2017 16:15:09 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Lamb <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Thu, 16 Mar 2017 16:15:10 GMT) (full text, mbox, link).


Message #23 received at 857940@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>
To: 857940@bugs.debian.org
Subject: Re: Bug#857940: diffoscope: FTBFS: test errors
Date: Thu, 16 Mar 2017 16:13:23 +0000
Mattia Rizzolo wrote:

> The buildds are using the aspcud sbuild resolver for experimental

I'm using mk-build-deps w/--no-install-recommends. It does not get
installed with that (and therefore I did not see the build failures
prior to uploading).

> Anyhow, if a package causes the build to fail it should either be in
> Build-Conflicts{,-Indep,-Arch}, or the package be fixed, imho

I agree, hence d030378 etc.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-



Reply sent to Chris Lamb <lamby@debian.org>:
You have taken responsibility. (Thu, 16 Mar 2017 16:36:06 GMT) (full text, mbox, link).


Notification sent to Mattia Rizzolo <mattia@debian.org>:
Bug acknowledged by developer. (Thu, 16 Mar 2017 16:36:06 GMT) (full text, mbox, link).


Message #28 received at 857940-close@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>
To: 857940-close@bugs.debian.org
Subject: Bug#857940: fixed in diffoscope 80
Date: Thu, 16 Mar 2017 16:33:40 +0000
Source: diffoscope
Source-Version: 80

We believe that the bug you reported is fixed in the latest version of
diffoscope, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 857940@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated diffoscope package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 16 Mar 2017 17:06:45 +0100
Source: diffoscope
Binary: diffoscope
Architecture: source
Version: 80
Distribution: experimental
Urgency: medium
Maintainer: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 diffoscope - in-depth comparison of files, archives, and directories
Closes: 857940
Changes:
 diffoscope (80) experimental; urgency=medium
 .
   * Ensure that we really are using ImageMagick and not, for example, the
     GraphicsMagick compatibility layer installed by
     graphicsmagick-imagemagick-compat. (Closes: #857940)
   * Factor out the unicode decoding of the identify -version output.
   * travis.yml: Don't build tags.
Checksums-Sha1:
 a8a4a56f6667975f4b0a70f33b4b49e889e1a515 2997 diffoscope_80.dsc
 36581c3e2bd013633239339ecfb29655f1fd4f73 355288 diffoscope_80.tar.xz
 2f7d4838f6c895e678496234593ce3c661a96cea 17076 diffoscope_80_amd64.buildinfo
Checksums-Sha256:
 c09b6e35b2b0157f0052f254283dac9f5a3fbc2fe8b97827d94cbe0640521c2b 2997 diffoscope_80.dsc
 f0f00007ff19818f38066c967d61b265dde770fc1c2d2e192e4f2bd401fee999 355288 diffoscope_80.tar.xz
 8ea3a40a865109f284430b49de4f051ecc5f5c2ec15ef05809f02515dfc1d818 17076 diffoscope_80_amd64.buildinfo
Files:
 d861e4bda26f4cfe1d4c9154a136526e 2997 devel optional diffoscope_80.dsc
 dcac924507ab8c61790d85b26f46b9ce 355288 devel optional diffoscope_80.tar.xz
 0bfda91dd8c1b44acfe6da050c236cd7 17076 devel optional diffoscope_80_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAljKuZIACgkQHpU+J9Qx
HlihNRAArHqMecPG/q6B56zpaGlZL1cY/UgRml65hVP58UOdgm6xiP/0IlKWm6Yd
azfBdsyX53UaepsUeogpC9sD7zwflzlrdt9eDBCPJZt4UcLatU60Zv1Eo3RjFCxe
8grJInxuQ7TKsZp+ksWzYHQllUPlciKHCv/AmtYGpz/xDhiJsAcau7PfVM3uy2a8
cvHTEjNPhZ5WR6HrGWZLcJ9P0Axzvx28nfFoxiW0+jvoufDGbZ5bf+655g1Y6tID
3g75NfX0sfLa3pwdZX96njlmRhMtaS5tu2JyUj/Lt0SbKAZuJesXMcLV9aUBBl98
HfjZiIxrPt/+j+DLMZQuDZE0pExo4yfz0jgCRERoazg6P5T7B7PQka68RKve0mQQ
wgASz8GfomyyWGO/RBeaphH1b1I9L8WWRZTI6JBZXfJL4E23b6FQrOqycY3rk0Si
1YiXh8is91/PFTBN4xSjArx0cgfRv6YESEaJU0k3PCQJjmfY0OMzp9iuJ5shs5GQ
La4fEe0SPe3ZWptSmGbSmshUON/7N9WnIAHAx5a4SC6Q1II7xHCWeqaZ1zxl4sE0
LamBsissUaQuUHdP0vji3D9OIjnTnYvBN/cSmiFhs2CAdO5/pxBBUZbfGn183CNs
VU3gHf40+h2IzjPu79pCihUETLo0WRWdsabLh+HRkjtJs6vRkkw=
=gqGt
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Fri, 14 Apr 2017 07:27:08 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Wed May 17 13:45:15 2023; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.