Debian Bug report logs -
#857803
shadow: Make the sp_lstchg shadow field reproducible.
Toggle useless messages
Report forwarded
to debian-bugs-dist@lists.debian.org, reproducible-bugs@lists.alioth.debian.org, Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>:
Bug#857803; Package shadow.
(Wed, 15 Mar 2017 10:39:04 GMT) (full text, mbox, link).
Acknowledgement sent
to Chris Lamb <lamby@debian.org>:
New Bug report received and forwarded. Copy sent to reproducible-bugs@lists.alioth.debian.org, Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>.
(Wed, 15 Mar 2017 10:39:04 GMT) (full text, mbox, link).
Message #5 received at submit@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
Package: shadow
Severity: wishlist
Version: 1:4.4-4
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: toolchain
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org
Hi,
Attached is the following:
commit 2dd84b0ee31e44dc51cba7b7cdc8657bf9ff0a31
Author: Chris Lamb <lamby@debian.org>
Date: Wed Mar 15 11:35:35 2017 +0100
Make the sp_lstchg shadow field reproducible.
The third field in the /etc/shadow file (sp_lstchg) contains the date of
the last password change expressed as the number of days since Jan 1, 1970.
As this is a relative time, creating a user today will result in:
username:17238:0:99999:7:::
whilst creating the same user tomorrow will result in:
username:17239:0:99999:7:::
This has an impact for the Reproducible Builds[0] project where we aim to
be independent of as many elements the build environment as possible,
including the current date.
This patch changes the behaviour to use the SOURCE_DATE_EPOCH[1]
environment variable (instead of Jan 1, 1970) if available.
[0] https://reproducible-builds.org/
[1] https://reproducible-builds.org/specs/source-date-epoch/
Signed-off-by: Chris Lamb <lamby@debian.org>
lib/prototypes.h | 3 ++
libmisc/Makefile.am | 1 +
libmisc/gettime.c | 86 +++++++++++++++++++++++++++++++++++++++++++++++++++++
src/chpasswd.c | 2 +-
src/newusers.c | 4 +--
src/passwd.c | 2 +-
src/useradd.c | 2 +-
src/usermod.c | 4 +--
8 files changed, 97 insertions(+), 7 deletions(-)
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` lamby@debian.org / chris-lamb.co.uk
`-
[0001-Make-the-sp_lstchg-shadow-field-reproducible.patch (text/x-diff, attachment)]
Information forwarded
to debian-bugs-dist@lists.debian.org, Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>:
Bug#857803; Package shadow.
(Wed, 15 Mar 2017 11:21:02 GMT) (full text, mbox, link).
Acknowledgement sent
to Chris Lamb <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>.
(Wed, 15 Mar 2017 11:21:02 GMT) (full text, mbox, link).
Message #10 received at 857803@bugs.debian.org (full text, mbox, reply):
Hi,
> Patch attached […]
Just to clarify two points:
a) this doesn't disable the password expiry feature, it only changes
the relative date used to ensure that the same /etc/shadow file
is generated regardless of the current date.
b) The behaviour only changes if SOURCE_DATE_EPOCH is exported, for
example if running "env SOURCE_DATE_EPOCH=somevalue debootstrap […]".
Subsequent calls to (eg.) useradd would not be affected, nor would
a regular Debian system.
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` lamby@debian.org / chris-lamb.co.uk
`-
Information forwarded
to debian-bugs-dist@lists.debian.org, Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>:
Bug#857803; Package shadow.
(Fri, 07 Apr 2017 21:45:03 GMT) (full text, mbox, link).
Acknowledgement sent
to "Serge E. Hallyn" <serge@hallyn.com>:
Extra info received and forwarded to list. Copy sent to Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>.
(Fri, 07 Apr 2017 21:45:03 GMT) (full text, mbox, link).
Message #15 received at 857803@bugs.debian.org (full text, mbox, reply):
Quoting Chris Lamb (lamby@debian.org):
> Package: shadow
> Severity: wishlist
> Version: 1:4.4-4
> Tags: patch
> User: reproducible-builds@lists.alioth.debian.org
> Usertags: toolchain
> X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org
>
> Hi,
>
> Attached is the following:
>
> commit 2dd84b0ee31e44dc51cba7b7cdc8657bf9ff0a31
> Author: Chris Lamb <lamby@debian.org>
> Date: Wed Mar 15 11:35:35 2017 +0100
>
> Make the sp_lstchg shadow field reproducible.
>
> The third field in the /etc/shadow file (sp_lstchg) contains the date of
> the last password change expressed as the number of days since Jan 1, 1970.
> As this is a relative time, creating a user today will result in:
>
> username:17238:0:99999:7:::
>
> whilst creating the same user tomorrow will result in:
>
> username:17239:0:99999:7:::
>
> This has an impact for the Reproducible Builds[0] project where we aim to
> be independent of as many elements the build environment as possible,
> including the current date.
>
> This patch changes the behaviour to use the SOURCE_DATE_EPOCH[1]
> environment variable (instead of Jan 1, 1970) if available.
>
> [0] https://reproducible-builds.org/
> [1] https://reproducible-builds.org/specs/source-date-epoch/
>
> Signed-off-by: Chris Lamb <lamby@debian.org>
>
> lib/prototypes.h | 3 ++
> libmisc/Makefile.am | 1 +
> libmisc/gettime.c | 86 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> src/chpasswd.c | 2 +-
> src/newusers.c | 4 +--
> src/passwd.c | 2 +-
> src/useradd.c | 2 +-
> src/usermod.c | 4 +--
> 8 files changed, 97 insertions(+), 7 deletions(-)
>
>
> Regards,
Hi,
looks ok to me, although, would it be better to fall back to time(NULL)
if the env variable is invalid?
Do you want to submit this as a patch to upstream at
github.com/shadow-maint/shadow ?
-serge
>
> --
> ,''`.
> : :' : Chris Lamb
> `. `'` lamby@debian.org / chris-lamb.co.uk
> `-
> >From 2dd84b0ee31e44dc51cba7b7cdc8657bf9ff0a31 Mon Sep 17 00:00:00 2001
> From: Chris Lamb <lamby@debian.org>
> Date: Wed, 15 Mar 2017 11:35:35 +0100
> Subject: [PATCH] Make the sp_lstchg shadow field reproducible.
>
> The third field in the /etc/shadow file (sp_lstchg) contains the date of
> the last password change expressed as the number of days since Jan 1, 1970.
> As this is a relative time, creating a user today will result in:
>
> username:17238:0:99999:7:::
>
> whilst creating the same user tomorrow will result in:
>
> username:17239:0:99999:7:::
>
> This has an impact for the Reproducible Builds[0] project where we aim to
> be independent of as many elements the build environment as possible,
> including the current date.
>
> This patch changes the behaviour to use the SOURCE_DATE_EPOCH[1]
> environment variable (instead of Jan 1, 1970) if available.
>
> [0] https://reproducible-builds.org/
> [1] https://reproducible-builds.org/specs/source-date-epoch/
>
> Signed-off-by: Chris Lamb <lamby@debian.org>
> ---
> lib/prototypes.h | 3 ++
> libmisc/Makefile.am | 1 +
> libmisc/gettime.c | 86 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> src/chpasswd.c | 2 +-
> src/newusers.c | 4 +--
> src/passwd.c | 2 +-
> src/useradd.c | 2 +-
> src/usermod.c | 4 +--
> 8 files changed, 97 insertions(+), 7 deletions(-)
> create mode 100644 libmisc/gettime.c
>
> diff --git a/lib/prototypes.h b/lib/prototypes.h
> index 7aaf1a6..4808d5d 100644
> --- a/lib/prototypes.h
> +++ b/lib/prototypes.h
> @@ -179,6 +179,9 @@ extern int getrange (char *range,
> unsigned long *min, bool *has_min,
> unsigned long *max, bool *has_max);
>
> +/* gettime.c */
> +extern time_t gettime ();
> +
> /* get_uid.c */
> extern int get_uid (const char *uidstr, uid_t *uid);
>
> diff --git a/libmisc/Makefile.am b/libmisc/Makefile.am
> index 76f3c05..e691dac 100644
> --- a/libmisc/Makefile.am
> +++ b/libmisc/Makefile.am
> @@ -31,6 +31,7 @@ libmisc_a_SOURCES = \
> getdate.y \
> getgr_nam_gid.c \
> getrange.c \
> + gettime.c \
> hushed.c \
> idmapping.h \
> idmapping.c \
> diff --git a/libmisc/gettime.c b/libmisc/gettime.c
> new file mode 100644
> index 0000000..b0c539b
> --- /dev/null
> +++ b/libmisc/gettime.c
> @@ -0,0 +1,86 @@
> +/*
> + * Copyright (c) 2017, Chris Lamb
> + * All rights reserved.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + * 1. Redistributions of source code must retain the above copyright
> + * notice, this list of conditions and the following disclaimer.
> + * 2. Redistributions in binary form must reproduce the above copyright
> + * notice, this list of conditions and the following disclaimer in the
> + * documentation and/or other materials provided with the distribution.
> + * 3. The name of the copyright holders or contributors may not be used to
> + * endorse or promote products derived from this software without
> + * specific prior written permission.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> + * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
> + * PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> + * HOLDERS OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> + */
> +
> +#include <config.h>
> +
> +#ident "$Id$"
> +
> +#include <errno.h>
> +#include <limits.h>
> +#include <stdio.h>
> +#include "defines.h"
> +#include "prototypes.h"
> +
> +/*
> + * gettime() returns the time as the number of seconds since the Epoch
> + *
> + * Like time(), gettime() returns the time as the number of seconds since the
> + * Epoch, 1970-01-01 00:00:00 +0000 (UTC), except that if the SOURCE_DATE_EPOCH
> + * environment variable is exported it will use that instead.
> + */
> +/*@observer@*/time_t gettime ()
> +{
> + char *endptr;
> + char *source_date_epoch;
> + unsigned long long epoch;
> +
> + source_date_epoch = getenv ("SOURCE_DATE_EPOCH");
> + if (!source_date_epoch)
> + return time (NULL);
> +
> + errno = 0;
> + epoch = strtoull (source_date_epoch, &endptr, 10);
> + if ((errno == ERANGE && (epoch == ULLONG_MAX || epoch == 0))
> + || (errno != 0 && epoch == 0)) {
> + fprintf (stderr,
> + _("Environment variable $SOURCE_DATE_EPOCH: strtoull: %s\n"),
> + strerror(errno));
> + exit(EXIT_FAILURE);
> + }
> + if (endptr == source_date_epoch) {
> + fprintf (stderr,
> + _("Environment variable $SOURCE_DATE_EPOCH: No digits were found: %s\n"),
> + endptr);
> + exit(EXIT_FAILURE);
> + }
> + if (*endptr != '\0') {
> + fprintf (stderr,
> + _("Environment variable $SOURCE_DATE_EPOCH: Trailing garbage: %s\n"),
> + endptr);
> + exit(EXIT_FAILURE);
> + }
> + if (epoch > ULONG_MAX) {
> + fprintf (stderr,
> + _("Environment variable $SOURCE_DATE_EPOCH: value must be smaller than or equal to %lu but was found to be: %llu \n"),
> + ULONG_MAX, epoch);
> + exit(EXIT_FAILURE);
> + }
> +
> + return (time_t)epoch;
> +}
> diff --git a/src/chpasswd.c b/src/chpasswd.c
> index 21008f5..f985672 100644
> --- a/src/chpasswd.c
> +++ b/src/chpasswd.c
> @@ -552,7 +552,7 @@ int main (int argc, char **argv)
> if (NULL != sp) {
> newsp = *sp;
> newsp.sp_pwdp = cp;
> - newsp.sp_lstchg = (long) time ((time_t *)NULL) / SCALE;
> + newsp.sp_lstchg = (long) gettime () / SCALE;
> if (0 == newsp.sp_lstchg) {
> /* Better disable aging than requiring a
> * password change */
> diff --git a/src/newusers.c b/src/newusers.c
> index 724cbb4..2b0c693 100644
> --- a/src/newusers.c
> +++ b/src/newusers.c
> @@ -496,7 +496,7 @@ static int add_passwd (struct passwd *pwd, const char *password)
> }
> spent.sp_pwdp = cp;
> }
> - spent.sp_lstchg = (long) time ((time_t *) 0) / SCALE;
> + spent.sp_lstchg = (long) gettime () / SCALE;
> if (0 == spent.sp_lstchg) {
> /* Better disable aging than requiring a password
> * change */
> @@ -553,7 +553,7 @@ static int add_passwd (struct passwd *pwd, const char *password)
> */
> spent.sp_pwdp = "!";
> #endif
> - spent.sp_lstchg = (long) time ((time_t *) 0) / SCALE;
> + spent.sp_lstchg = (long) gettime () / SCALE;
> if (0 == spent.sp_lstchg) {
> /* Better disable aging than requiring a password change */
> spent.sp_lstchg = -1;
> diff --git a/src/passwd.c b/src/passwd.c
> index 1191111..3af3e65 100644
> --- a/src/passwd.c
> +++ b/src/passwd.c
> @@ -668,7 +668,7 @@ static void update_shadow (void)
> }
> #ifndef USE_PAM
> if (do_update_age) {
> - nsp->sp_lstchg = (long) time ((time_t *) 0) / SCALE;
> + nsp->sp_lstchg = (long) gettime () / SCALE;
> if (0 == nsp->sp_lstchg) {
> /* Better disable aging than requiring a password
> * change */
> diff --git a/src/useradd.c b/src/useradd.c
> index fefa234..d7bde8f 100644
> --- a/src/useradd.c
> +++ b/src/useradd.c
> @@ -825,7 +825,7 @@ static void new_spent (struct spwd *spent)
> memzero (spent, sizeof *spent);
> spent->sp_namp = (char *) user_name;
> spent->sp_pwdp = (char *) user_pass;
> - spent->sp_lstchg = (long) time ((time_t *) 0) / SCALE;
> + spent->sp_lstchg = (long) gettime () / SCALE;
> if (0 == spent->sp_lstchg) {
> /* Better disable aging than requiring a password change */
> spent->sp_lstchg = -1;
> diff --git a/src/usermod.c b/src/usermod.c
> index 687487d..db8c0a8 100644
> --- a/src/usermod.c
> +++ b/src/usermod.c
> @@ -641,7 +641,7 @@ static void new_spent (struct spwd *spent)
> spent->sp_pwdp = new_pw_passwd (spent->sp_pwdp);
>
> if (pflg) {
> - spent->sp_lstchg = (long) time ((time_t *) 0) / SCALE;
> + spent->sp_lstchg = (long) gettime () / SCALE;
> if (0 == spent->sp_lstchg) {
> /* Better disable aging than requiring a password
> * change. */
> @@ -1673,7 +1673,7 @@ static void usr_update (void)
> spent.sp_pwdp = xstrdup (pwent.pw_passwd);
> pwent.pw_passwd = xstrdup (SHADOW_PASSWD_STRING);
>
> - spent.sp_lstchg = (long) time ((time_t *) 0) / SCALE;
> + spent.sp_lstchg = (long) gettime () / SCALE;
> if (0 == spent.sp_lstchg) {
> /* Better disable aging than
> * requiring a password change */
> --
> 2.11.0
>
> _______________________________________________
> Pkg-shadow-devel mailing list
> Pkg-shadow-devel@lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-shadow-devel
Information forwarded
to debian-bugs-dist@lists.debian.org, Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>:
Bug#857803; Package shadow.
(Sun, 09 Apr 2017 09:09:03 GMT) (full text, mbox, link).
Acknowledgement sent
to Chris Lamb <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>.
(Sun, 09 Apr 2017 09:09:03 GMT) (full text, mbox, link).
Message #20 received at 857803@bugs.debian.org (full text, mbox, reply):
Serge E. Hallyn wrote:
> looks ok to me, although, would it be better to fall back to time(NULL)
> if the env variable is invalid?
In my experience it is far superior to explicitly error out in this
situation.
It's much better end-user debugging experience than the build "silently"
not being reproducible if (for whatever reason) S_D_E is invalid, especially
in terms of preventing regressions early.
> Do you want to submit this as a patch to upstream at
> github.com/shadow-maint/shadow ?
Very happy to once I get an ACK on the above.
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` lamby@debian.org / chris-lamb.co.uk
`-
Information forwarded
to debian-bugs-dist@lists.debian.org, Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>:
Bug#857803; Package shadow.
(Sun, 09 Apr 2017 13:30:05 GMT) (full text, mbox, link).
Acknowledgement sent
to "Serge E. Hallyn" <serge@hallyn.com>:
Extra info received and forwarded to list. Copy sent to Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>.
(Sun, 09 Apr 2017 13:30:05 GMT) (full text, mbox, link).
Message #25 received at 857803@bugs.debian.org (full text, mbox, reply):
On Sun, Apr 09, 2017 at 10:07:38AM +0100, Chris Lamb wrote:
> Serge E. Hallyn wrote:
>
> > looks ok to me, although, would it be better to fall back to time(NULL)
> > if the env variable is invalid?
>
> In my experience it is far superior to explicitly error out in this
> situation.
My concern is unprivileged users causing unexpected failure in a more
privileged script or program by setting an invalid environment variable.
Information forwarded
to debian-bugs-dist@lists.debian.org, Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>:
Bug#857803; Package shadow.
(Sun, 09 Apr 2017 13:54:03 GMT) (full text, mbox, link).
Acknowledgement sent
to Chris Lamb <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>.
(Sun, 09 Apr 2017 13:54:03 GMT) (full text, mbox, link).
Message #30 received at 857803@bugs.debian.org (full text, mbox, reply):
Hi Serge,
> > > looks ok to me, although, would it be better to fall back to time(NULL)
> > > if the env variable is invalid?
> >
> > In my experience it is far superior to explicitly error out in this
> > situation.
>
> My concern is unprivileged users causing unexpected failure in a more
> privileged script or program by setting an invalid environment variable.
I hadn't considered that until now. However, I think you have bigger
problems if you can do that (eg. manipulate PATH!) and tools generally
do the right thing these days with respect to cleaning the environment
(eg. sudo).
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` lamby@debian.org / chris-lamb.co.uk
`-
Information forwarded
to debian-bugs-dist@lists.debian.org, Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>:
Bug#857803; Package shadow.
(Sun, 09 Apr 2017 15:51:03 GMT) (full text, mbox, link).
Acknowledgement sent
to "Serge E. Hallyn" <serge@hallyn.com>:
Extra info received and forwarded to list. Copy sent to Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>.
(Sun, 09 Apr 2017 15:51:03 GMT) (full text, mbox, link).
Message #35 received at 857803@bugs.debian.org (full text, mbox, reply):
Quoting Chris Lamb (lamby@debian.org):
> Hi Serge,
>
> > > > looks ok to me, although, would it be better to fall back to time(NULL)
> > > > if the env variable is invalid?
> > >
> > > In my experience it is far superior to explicitly error out in this
> > > situation.
> >
> > My concern is unprivileged users causing unexpected failure in a more
> > privileged script or program by setting an invalid environment variable.
>
> I hadn't considered that until now. However, I think you have bigger
> problems if you can do that (eg. manipulate PATH!) and tools generally
> do the right thing these days with respect to cleaning the environment
> (eg. sudo).
Right, sudo does but just setuid-root does not. This env variable
is for reproducible builds, so can we check ruid==0 and ignore the
env variable if not? Or do the build scripts also run as non-root?
Information forwarded
to debian-bugs-dist@lists.debian.org, Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>:
Bug#857803; Package shadow.
(Mon, 10 Apr 2017 08:39:08 GMT) (full text, mbox, link).
Acknowledgement sent
to Chris Lamb <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>.
(Mon, 10 Apr 2017 08:39:09 GMT) (full text, mbox, link).
Message #40 received at 857803@bugs.debian.org (full text, mbox, reply):
forwarded 857803 https://github.com/shadow-maint/shadow/pull/71
thanks
Hi Serge,
> Right, sudo does but just setuid-root does not. This env variable
> is for reproducible builds, so can we check ruid==0 and ignore the
> env variable if not? Or do the build scripts also run as non-root?
Great points. So: as there is no one "build script" (eg. Tails might
do it one way, someone else might do it another way...) and this is
shadow(5) after all, let's play it safe and fallback as you suggested.
PR submitted here:
https://github.com/shadow-maint/shadow/pull/71
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` lamby@debian.org / chris-lamb.co.uk
`-
Information forwarded
to debian-bugs-dist@lists.debian.org, Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>:
Bug#857803; Package shadow.
(Thu, 20 Apr 2017 13:39:06 GMT) (full text, mbox, link).
Acknowledgement sent
to Chris Lamb <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>.
(Thu, 20 Apr 2017 13:39:06 GMT) (full text, mbox, link).
Message #47 received at 857803@bugs.debian.org (full text, mbox, reply):
tags 857803 + fixed-upstream
thanks
Hi,
> shadow: Make the sp_lstchg shadow field reproducible.
This has been merged/fixed upstream:
https://github.com/shadow-maint/shadow/pull/71#issuecomment-295467618
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` lamby@debian.org / chris-lamb.co.uk
`-
Added tag(s) fixed-upstream.
Request was from Chris Lamb <lamby@debian.org>
to control@bugs.debian.org.
(Thu, 20 Apr 2017 13:39:07 GMT) (full text, mbox, link).
Reply sent
to Balint Reczey <rbalint@ubuntu.com>:
You have taken responsibility.
(Wed, 27 Sep 2017 17:21:06 GMT) (full text, mbox, link).
Notification sent
to Chris Lamb <lamby@debian.org>:
Bug acknowledged by developer.
(Wed, 27 Sep 2017 17:21:06 GMT) (full text, mbox, link).
Message #54 received at 857803-close@bugs.debian.org (full text, mbox, reply):
Source: shadow
Source-Version: 1:4.5-1
We believe that the bug you reported is fixed in the latest version of
shadow, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 857803@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Balint Reczey <rbalint@ubuntu.com> (supplier of updated shadow package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 27 Sep 2017 12:45:23 -0400
Source: shadow
Binary: passwd login uidmap
Architecture: source
Version: 1:4.5-1
Distribution: unstable
Urgency: medium
Maintainer: Shadow package maintainers <pkg-shadow-devel@lists.alioth.debian.org>
Changed-By: Balint Reczey <rbalint@ubuntu.com>
Description:
login - system login tools
passwd - change and administer password and group data
uidmap - programs to help use subuids
Closes: 756630 857803 865762
Changes:
shadow (1:4.5-1) unstable; urgency=medium
.
* New upstream version 4.5
- Fix buffer overflow if NULL line is present in db (CVE-2017-12424)
(Closes: #756630)
- Make the sp_lstchg shadow field reproducible (Closes: #857803)
- Fix regression in useradd not loading defaults properly.
(Closes: #865762)
* Refresh patches
* Drop patches manipulating su argument concatenation:
* Cut redundant information from Debian-specific README files
* Revert adding pts/0 and pts/1 to securetty.
Adding pts/* defeats the purpose of securetty. Let containers add it if
needed as described in #830255.
* Use my @ubuntu.com email address in Maintainer field
Checksums-Sha1:
f13fd80b70b35fabdbeeffb86971c2f1fe06f89b 2282 shadow_4.5-1.dsc
16f366e1b2bb7dbc53af91dbdd2d03e1702cf919 1344524 shadow_4.5.orig.tar.xz
f694c1310522e5f36f1a5c110152ed04865187c3 462752 shadow_4.5-1.debian.tar.xz
Checksums-Sha256:
1e93b2e4cb3f0f14a52dd9603bf8153f31a3117c580c0b46fd94822437516ff6 2282 shadow_4.5-1.dsc
22b0952dc944b163e2370bb911b11ca275fc80ad024267cf21e496b28c23d500 1344524 shadow_4.5.orig.tar.xz
0aa8980eddef9159ee6532d40bda92237ad2163dcc2bb6601aecc415ab9662ee 462752 shadow_4.5-1.debian.tar.xz
Files:
85e9f6101d566e975a4dd09bb11f5b3d 2282 admin required shadow_4.5-1.dsc
dc6263258eab3dbeb66c8687841ae4a9 1344524 admin required shadow_4.5.orig.tar.xz
34ff6d315dcccec4b2ec5e96f79f48af 462752 admin required shadow_4.5-1.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIwBAEBCAAaBQJZy9hUExxyYmFsaW50QHVidW50dS5jb20ACgkQ9mTSVrRpGn3B
2A/7BZz3Jc4aV1O0O0EfLSreUqxOeEAH0s6OtlMgzamLfbKMeqoB37PYHt1YEYRO
GV79XLUB1tU0heEvymDunpLSf+DiO3Ae1BcxjejTI3wjPIZHdHDaI4QR1kVV/INz
WvBTutzzUQZ07IDBrkzdlYOCgoet+TCFOPVy5YPxoQxnKm/3dPqVTwHVUO7ZT1px
2cvfJUXUhthlHzvqru7Rb0FXAotgqh75AL6wyvtJghfm/wVQAjLoc5dvbYezwFwV
2C9k/6N2slrg+3D+sUcH520K9WgQLF1K8ftNbTyFn9Np2tWXLcot6UtjM/7GnTYo
ymfYv+1dElUezrHVjlXgf51msbPX/p4tfCg/NRGJRj5XSXAGU2UP1dS2uLs0kqre
1AQA/VhOPGTFyHUSvtS8DzGO0jDCXCecnE7JE7jtozcNihpMXkzRXFAmgowFnxfP
lhyn418vdgRmJaRsm8oo0XTESDEKQjxYs3w5hUfHBby9x3q5Cr7qWw/7ufRiAc7p
jFNVqOpg/af/kD3Pcg96hBCBBCSThV23ql6bMMdCaBEWQZYedpO+zz/QO/6ULnWL
cCgs05RlxLKr849D8mDqJwiKWc7vrmlXI0tJIz6uouMBivocFmLfIE1m5OPrKEkT
ZGfWwVxJf6DPiSAPxhenJi8jBsYM6i1IjC6TPiLhbQOSklQ=
=oGpF
-----END PGP SIGNATURE-----
Bug archived.
Request was from Debbugs Internal Request <owner@bugs.debian.org>
to internal_control@bugs.debian.org.
(Tue, 31 Oct 2017 07:25:15 GMT) (full text, mbox, link).
Send a report that this bug log contains spam.
Debian bug tracking system administrator <owner@bugs.debian.org>.
Last modified:
Wed May 17 09:28:10 2023;
Machine Name:
buxtehude
Debian Bug tracking system
Debbugs is free software and licensed under the terms of the GNU
Public License version 2. The current version can be obtained
from https://bugs.debian.org/debbugs-source/.
Copyright © 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson,
2005-2017 Don Armstrong, and many other contributors.