Debian Bug report logs - #857753
python-websockets: non-determinstic testsuite

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: submit@bugs.debian.org

Subject: python-websockets: Non-determistically FTBFS due to unreliable timing in tests

Date: Mon, 06 Feb 2017 20:31:44 +1300

[Message part 1 (text/plain, inline)]

Source: python-websockets
Version: 3.2-1
Severity: serious
Justification: fails to build from source
User: reproducible-builds@lists.alioth.debian.org
Usertags: ftbfs
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Dear Maintainer,

python-websockets's testsuite appears to use method timing/benchmarking in such a way that it will non-deterministically FTBFS:

  […]
  
  ======================================================================
  FAIL: test_eof_received_timeout (websockets.test_protocol.ClientTests)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/build/1st/python-websockets-3.2/.pybuild/pythonX.Y_3.5/build/websockets/test_protocol.py", line 792, in test_eof_received_timeout
      self.loop.run_until_complete(self.protocol.close(reason='close'))
    File "/usr/lib/python3.5/contextlib.py", line 66, in __exit__
      next(self.gen)
    File "/build/1st/python-websockets-3.2/.pybuild/pythonX.Y_3.5/build/websockets/test_protocol.py", line 249, in assertCompletesWithin
      dt, max_time, "Too slow: {} >= {}".format(dt, max_time))
  AssertionError: 0.022619478404521942 not less than 0.019 : Too slow: 0.022619478404521942 >= 0.019
  
  ======================================================================
  FAIL: test_remote_close_race_with_failing_connection (websockets.test_protocol.ClientTests)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/build/1st/python-websockets-3.2/.pybuild/pythonX.Y_3.5/build/websockets/test_protocol.py", line 716, in test_remote_close_race_with_failing_connection
      self.assertConnectionClosed(1011, '')
    File "/build/1st/python-websockets-3.2/.pybuild/pythonX.Y_3.5/build/websockets/test_protocol.py", line 237, in assertConnectionClosed
      self.assertEqual(self.protocol.close_code, code)
  AssertionError: 1000 != 1011
  
  ======================================================================
  FAIL: test_close_handshake_timeout (websockets.test_protocol.ServerTests)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/build/1st/python-websockets-3.2/.pybuild/pythonX.Y_3.5/build/websockets/test_protocol.py", line 761, in test_close_handshake_timeout
      self.loop.run_until_complete(self.protocol.close(reason='close'))
    File "/usr/lib/python3.5/contextlib.py", line 66, in __exit__
      next(self.gen)
    File "/build/1st/python-websockets-3.2/.pybuild/pythonX.Y_3.5/build/websockets/test_protocol.py", line 249, in assertCompletesWithin
      dt, max_time, "Too slow: {} >= {}".format(dt, max_time))
  AssertionError: 0.0209119264036417 not less than 0.019 : Too slow: 0.0209119264036417 >= 0.019
  
  ----------------------------------------------------------------------
  Ran 235 tests in 2.067s
  
  FAILED (failures=3, skipped=29)
  E: pybuild pybuild:283: test: plugin distutils failed with: exit code=1: cd «BUILDDIR»/.pybuild/pythonX.Y_3.5/build; python3.5 -m unittest discover -v 
  dh_auto_test: pybuild --test -i python{version} -p 3.5 returned exit code 13
  debian/rules:5: recipe for target 'build' failed
  make: *** [build] Error 25
  dpkg-buildpackage: error: debian/rules build gave error exit status 2

  […]

The full build log is attached.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[python-websockets.3.2-1.unstable.amd64.log.txt.gz (application/octet-stream, attachment)]

Message #12 received at 854335@bugs.debian.org (full text, mbox, reply):

From: Aymeric Augustin <aymeric.augustin@polytechnique.org>

To: 854335@bugs.debian.org

Date: Tue, 21 Feb 2017 10:38:50 +0100

[Message part 1 (text/plain, inline)]

I answered the upstream bug report: https://github.com/aaugustin/websockets/issues/163#issuecomment-281292067 <https://github.com/aaugustin/websockets/issues/163#issuecomment-281292067>

-- 
Aymeric.

[Message part 2 (text/html, inline)]

Message #19 received at 854335-submitter@bugs.debian.org (full text, mbox, reply):

From: Piotr Ożarowski <piotr@debian.org>

To: 854335-submitter@bugs.debian.org

Subject: Bug#854335 marked as pending

Date: Tue, 14 Mar 2017 12:32:55 +0000

tag 854335 pending
thanks

Hello,

Bug #854335 reported by you has been fixed in the Git repository. You can
see the changelog below, and you can check the diff of the fix at:

    http://git.debian.org/?p=python-modules/packages/python-websockets.git;a=commitdiff;h=0ea3518

---
commit 0ea3518832621c81f5365e163f9b60a5a5b2580c
Author: Piotr Ożarowski <piotr@debian.org>
Date:   Tue Mar 14 13:23:30 2017 +0100

    set WEBSOCKETS_TESTS_TIMEOUT_FACTOR to 100 to avoid FTBFS on slower buildds

diff --git a/debian/changelog b/debian/changelog
index e8a4ee5..645b1d6 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+python-websockets (3.2-2) unstable; urgency=medium
+
+  * set WEBSOCKETS_TESTS_TIMEOUT_FACTOR to 100 to avoid FTBFS on slower
+    buildd (closes: 854335)
+
+ -- Piotr Ożarowski <piotr@debian.org>  Tue, 14 Mar 2017 13:21:33 +0100
+
 python-websockets (3.2-1) unstable; urgency=medium
 
   [ Ondřej Nový ]

Message #24 received at 854335-close@bugs.debian.org (full text, mbox, reply):

From: Piotr Ożarowski <piotr@debian.org>

To: 854335-close@bugs.debian.org

Subject: Bug#854335: fixed in python-websockets 3.2-2

Date: Tue, 14 Mar 2017 12:50:45 +0000

Source: python-websockets
Source-Version: 3.2-2

We believe that the bug you reported is fixed in the latest version of
python-websockets, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 854335@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Piotr Ożarowski <piotr@debian.org> (supplier of updated python-websockets package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 14 Mar 2017 13:21:33 +0100
Source: python-websockets
Binary: python3-websockets
Architecture: source all
Version: 3.2-2
Distribution: unstable
Urgency: medium
Maintainer: Piotr Ożarowski <piotr@debian.org>
Changed-By: Piotr Ożarowski <piotr@debian.org>
Description:
 python3-websockets - implementation of the WebSocket Protocol (RFC 6455)
Closes: 854335
Changes:
 python-websockets (3.2-2) unstable; urgency=medium
 .
   * set WEBSOCKETS_TESTS_TIMEOUT_FACTOR to 100 to avoid FTBFS on slower
     buildd (closes: 854335)
Checksums-Sha1:
 8200e8f06d4d15894020cb0e58127944fc74814f 2086 python-websockets_3.2-2.dsc
 a6bbc2d88f341e6c0950d8d3cdfe398c0316e178 3260 python-websockets_3.2-2.debian.tar.xz
 468b006dcba2b0b3b84476ebf099e192fce4040a 6133 python-websockets_3.2-2_amd64.buildinfo
 da131261e914384e5ce9cd0e0de51d1d1b421adf 28322 python3-websockets_3.2-2_all.deb
Checksums-Sha256:
 f95979307be992540c868a01f72fce41c9373a315f8164426c7b61a198176af0 2086 python-websockets_3.2-2.dsc
 948dda4a61c455d3122b0e8db69ffcf18675f22b5c6a5ddc45fd6d7665a2a3a5 3260 python-websockets_3.2-2.debian.tar.xz
 a6c70f4a80d1677e38d963b6335b80def9ced430fccb2885c0d790795b36fc2d 6133 python-websockets_3.2-2_amd64.buildinfo
 35e2f71efd8ce008c06e75f3276fd37edd237b8bf168bd22c7c9e5733e0d2b73 28322 python3-websockets_3.2-2_all.deb
Files:
 ccf4f97d62c8e7da74ab107f533967c7 2086 python optional python-websockets_3.2-2.dsc
 d1eb6f343e7bfa1cee7cf0e37f97b801 3260 python optional python-websockets_3.2-2.debian.tar.xz
 205e01db1b9de827ab74a24d6f795bc3 6133 python optional python-websockets_3.2-2_amd64.buildinfo
 9192ab046e0f3496b3b02121ff976a5e 28322 python optional python3-websockets_3.2-2_all.deb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEHS+omFjar2IXhi33rvbxoqdFdkUFAljH4uQACgkQrvbxoqdF
dkWzmQ/+K/yVD1nb7GtzoDEuLrMst7jOVGqPP75VGAxRugG1ow77lBqzCmW+gE40
yVVzkLKlW/Va0NtgskfqHeNC5RHlfekLCzERz6FtrTDpoD8wMB8tVI5MFIP+wQr6
Gw0IVvqz1NhFNnr4I2DSVHHeQ8K/wPmRVAivjXtK3KoDitZPBLRlsU6PlgmYxNfE
HBPKcl4knAawG43Jwyn7rHygQFKhjaHWqwXz+Q0IJnpmCpo4TyPUOM36NXRAKlm3
fi+VR0LE0RpcuX65KWhX+iFf5WW4bKvGJaLhUU54dCki8RipN4XAyB8po52Byd6l
4LGy0nfaCx+T+I3xOtNzZ/YtRkjg8Hrl21e4IYOgtUIyEBm4aJXTOqmzSZboSCgD
aE9mo/AF7u+7KyXsFSye1cQnW+hpz/+Y67WMMGZHE9aOmqH7ea9ZkarAZf1Vouiu
WiMz7A5O2b5h3jtQlAXKB8d8i00969tVJ4ov2mRNrKEw3KWwHP8k/9Lx7kflU075
aZCQghPx95Ekw0lZHvz64h3f8N+6esaTwt0dUp7ak8calqqus97bvrqTwGdIR5dd
kCIlaibuVw+gBz087H76ssZRLZOSBOoQvvXERvEP8+qKksBMmD6urHrSl3mAwVSd
O13c7uINyHd1ElYyhhOnvEMMkV/uvUUetfBh8djm2kqWsIAZoxw=
=8tOn
-----END PGP SIGNATURE-----

Message #29 received at 854335@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: Piotr Ożarowski <piotr@debian.org>, 854335@bugs.debian.org, 854335-submitter@bugs.debian.org

Subject: Re: Bug#854335: marked as pending

Date: Tue, 14 Mar 2017 12:52:26 +0000

Piotr Ożarowski wrote:
 
>     set WEBSOCKETS_TESTS_TIMEOUT_FACTOR to 100 to avoid
>        FTBFS on slower buildds

Hm. Whilst this might "work" it is still non-determinstic, alas...


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #35 received at 854335-submitter@bugs.debian.org (full text, mbox, reply):

From: Piotr Ożarowski <piotr@debian.org>

To: 854335-submitter@bugs.debian.org

Subject: Re: Bug#854335: marked as pending

Date: Tue, 14 Mar 2017 15:40:35 +0100

> >     set WEBSOCKETS_TESTS_TIMEOUT_FACTOR to 100 to avoid
> >        FTBFS on slower buildds
> 
> Hm. Whilst this might "work" it is still non-determinstic, alas...

feel free to clone this bug with non-RC severity. All I care about right
now is to make it usable for Stretch

Message #40 received at 854335@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: Piotr Ożarowski <piotr@debian.org>, 854335@bugs.debian.org

Subject: Re: Bug#854335: marked as pending

Date: Tue, 14 Mar 2017 17:01:16 +0000

clone 854335 -1
retitle -1 python-websockets: non-determinstic testsuite
severity -1 important
found -1 3.2-2
thanks

Piotr Ożarowski wrote:

> > >     set WEBSOCKETS_TESTS_TIMEOUT_FACTOR to 100 to avoid
> > >        FTBFS on slower buildds
> > 
> > Hm. Whilst this might "work" it is still non-determinstic, alas...
> 
> feel free to clone this bug with non-RC severity. All I care about right
> now is to make it usable for Stretch


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Send a report that this bug log contains spam.