Debian Bug report logs - #857745
vbindiff: segmentation fault at end of file

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Michael Gold <mgold@qnx.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: vbindiff: segmentation fault at end of file

Date: Tue, 14 Mar 2017 12:09:46 -0400

[Message part 1 (text/plain, inline)]

Package: vbindiff
Version: 3.0-beta4-1+b3
Severity: important

I'm seeing segfaults in vbindiff, apparently when it reaches the end of
the file(s).  These steps trigger it immediately:
  echo test > a
  echo test > b
  vbindiff a b

gdb shows a crash in strlen().

For larger files, it works until I scroll to the end.

- Michael


-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-2-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages vbindiff depends on:
ii  libc6        2.24-9
ii  libgcc1      1:6.3.0-6
ii  libncurses5  6.0+20161126-1
ii  libstdc++6   6.3.0-6
ii  libtinfo5    6.0+20161126-1

vbindiff recommends no packages.

vbindiff suggests no packages.

-- no debconf information

[signature.asc (application/pgp-signature, inline)]

[Message part 3 (text/plain, inline)]

---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

Message #10 received at 857745@bugs.debian.org (full text, mbox, reply):

From: Raphaël Rigo <M8R-a3dcsm@mailinator.com>

To: 857745@bugs.debian.org

Subject: Some fixes are available

Date: Mon, 20 Mar 2017 23:40:18 +0100

Hello,
it appears the original developer is not responding as pending pull requests
have not been replied to in years.

Another forked repo on github includes important fixes which could be added to
thee debian package:
https://github.com/mrdudz/vbindiff

Thanks for maintaining the package !

Raphaël

Message #15 received at 857745@bugs.debian.org (full text, mbox, reply):

From: Reiner Herrmann <reiner@reiner-h.de>

To: 857745@bugs.debian.org

Subject: Re: vbindiff: segmentation fault at end of file

Date: Tue, 21 Mar 2017 12:11:24 +0100

[Message part 1 (text/plain, inline)]

Hi,

I'm getting the same segmentation fault.
It also happens when you are searching, but there are no further
search results (so it also reaches the end of file), which makes
the search functionality not really usable.

Here is a backtrace:

#0  strlen () at ../sysdeps/x86_64/strlen.S:106
No locals.
#1  0x00007f076944cb88 in waddnstr (win=0x5633b16a9030, astr=0x20007ffec81f3730 <error: Cannot access memory at address 0x20007ffec81f3730>, n=<optimized out>) at ../../ncurses/base/lib_addstr.c:62
        str = 0x20007ffec81f3730 <error: Cannot access memory at address 0x20007ffec81f3730>
        code = 0
#2  0x00005633b07170a0 in ConWindow::put (s=0x20007ffec81f3730 <error: Cannot access memory at address 0x20007ffec81f3730>, y=22, x=61, this=0x5633b091e828 <file1+296>) at ./curses/ConWin.hpp:64
No locals.
#3  FileDisplay::display (this=0x5633b091e700 <file1>) at vbindiff.cpp:494
        str = 0x7ffec81f375a ' ' <repeats 70 times>
        lineOffset = 130736
        i = <optimized out>
        j = <optimized out>
        index = <optimized out>
        lineLength = 0
        buf = ' ' <repeats 18 times>
        buf2 = "0001 FEB0:", ' ' <repeats 70 times>
#4  0x00005633b071a1e4 in FileDisplay::display (this=0x5633b091e700 <file1>) at vbindiff.cpp:1721
No locals.
#5  handleCmd (cmd=<optimized out>) at vbindiff.cpp:1719
No locals.
#6  0x00005633b0716678 in main (argc=<optimized out>, argv=<optimized out>) at vbindiff.cpp:1869
        cmd = <optimized out>

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 857745@bugs.debian.org (full text, mbox, reply):

From: Reiner Herrmann <reiner@reiner-h.de>

To: 857745@bugs.debian.org

Subject: Re: vbindiff: segmentation fault at end of file

Date: Tue, 21 Mar 2017 13:21:22 +0100

[Message part 1 (text/plain, inline)]

Control: tags -1 + patch upstream
Control: forwarded -1 https://github.com/madsen/vbindiff/pull/3

I just tested this oneline patch in the upstream pull request,
and it fixes the crash for me.

Please consider applying it for stretch.

[signature.asc (application/pgp-signature, inline)]

Message #41 received at 857745-done@bugs.debian.org (full text, mbox, reply):

From: Reiner Herrmann <reiner@reiner-h.de>

To: 857745-done@bugs.debian.org

Subject: Re: vbindiff: segmentation fault at end of file

Date: Wed, 25 Oct 2017 18:18:04 +0200

[Message part 1 (text/plain, inline)]

Version: 3.0-beta5-1

Closing this bug as it was fixed in the 3.0-beta5-1 upload.
Thanks!

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.