Debian Bug report logs - #857355
orthanc-webviewer: Libraries manually set in wrong order

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Tiago Stürmer Daitx <tiago.daitx@canonical.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: orthanc-webviewer: Libraries manually set in wrong order

Date: Fri, 10 Mar 2017 09:34:02 -0300

[Message part 1 (text/plain, inline)]

Package: orthanc-webviewer
Version: 2.2-1
Severity: normal
Tags: patch

Dear Maintainer,

Currently the file debian/patches/cmake is removing cmake's automatic
library linking resolution and adding "missing" libraries manually.

The uuid library ends up being added twice while linking
libOrthancWebViewer.so. I verified that this is no longer required.

The libraries are being added through LINK_FLAGS, which is not a good
practice. On make this would be the similar to adding libraries to
LD_FLAGS instead of LD_LIBS, which causes 'undefined reference' errors
when stric order is enabled (like in Ubuntu, where the package FTBFS).

I verified that cmake is able to successfully determine the required
gdcm libraries and that the library arguments in LINK_FLAGS can be
safely removed.

Please see the attached patch for the fix.

Regards,
Tiago Daitx

-  

-- System Information:
Debian Release: stretch/sid
  APT prefers xenial-updates
  APT policy: (500, 'xenial-updates'), (500, 'xenial-security'), (500, 'xenial'), (400, 'xenial-proposed'), (100, 'xenial-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.8.0-34-generic (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

[fix-library.patch (text/x-diff, attachment)]

Message #10 received at 857355-close@bugs.debian.org (full text, mbox, reply):

From: Sebastien Jodogne <s.jodogne@gmail.com>

To: 857355-close@bugs.debian.org

Subject: Bug#857355: fixed in orthanc-webviewer 2.2-2

Date: Sat, 18 Mar 2017 06:52:25 +0000

Source: orthanc-webviewer
Source-Version: 2.2-2

We believe that the bug you reported is fixed in the latest version of
orthanc-webviewer, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 857355@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Sebastien Jodogne <s.jodogne@gmail.com> (supplier of updated orthanc-webviewer package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 17 Mar 2017 16:47:23 +0100
Source: orthanc-webviewer
Binary: orthanc-webviewer
Architecture: source
Version: 2.2-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Med Packaging Team <debian-med-packaging@lists.alioth.debian.org>
Changed-By: Sebastien Jodogne <s.jodogne@gmail.com>
Description:
 orthanc-webviewer - Web viewer of medical images for Orthanc
Closes: 857355
Changes:
 orthanc-webviewer (2.2-2) unstable; urgency=medium
 .
   [ Tiago Sturmer Daitx <tiago.daitx@canonical.com> ]
   * Fix linking of libraries. Closes: #857355
Checksums-Sha1:
 2f0f5ae70f9c0e1beb27a90da2ac9bb07d1c8603 2380 orthanc-webviewer_2.2-2.dsc
 52327065e3ba4fe92728d85cac706b77860f3991 108128 orthanc-webviewer_2.2-2.debian.tar.xz
 4a0adf40f2d93a69b5f09edbcd896f9d718c6af9 18871 orthanc-webviewer_2.2-2_source.buildinfo
Checksums-Sha256:
 a7da4361e0a63700ac7763f76210358b412ce4b29c5d745cf817c9c81a1ecd36 2380 orthanc-webviewer_2.2-2.dsc
 492ff5007d3afc48294eee225ab4af009204ffe8e2c243cf496f54cddc47f489 108128 orthanc-webviewer_2.2-2.debian.tar.xz
 42046b4f3bded743c6d9d51f8fdf6bdefc12a4ba4bf30d454353df5c65913f98 18871 orthanc-webviewer_2.2-2_source.buildinfo
Files:
 16f8b011b54d5f35d3aa0969df744c06 2380 science optional orthanc-webviewer_2.2-2.dsc
 01a8b6ff5c3c6ca59c2638ed080a5b34 108128 science optional orthanc-webviewer_2.2-2.debian.tar.xz
 27458864e439e925bd306af4301fb250 18871 science optional orthanc-webviewer_2.2-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCAAvFiEE8fAHMgoDVUHwpmPKV4oElNHGRtEFAljM1PsRHHRpbGxlQGRl
Ymlhbi5vcmcACgkQV4oElNHGRtH+oxAAm/uxxBKUiIrj+yI1nsyfVmfZHtdGPp0D
+YgUevwYeYPUqYclyIRqy4Lb8cqQv+q7/AguDYdIFV953B9cmjp/1KPhwxEfdSbs
WpcvcZj8W6T+K8IzzO6vPTmPEzbwTemSgFMyT3xu+H9RLgWn5PhmV5YfpqXhgI9/
eLlFxK4sT6fVZq7dbB9TcfrgXavTWvyjCFydQZ4KBLuS8t2JhykTiSwRcOCo5FSe
WRRfokdVa9ubl1j0hnU6ecvF/yzE3xE3SbVTVwcCHaabsUhGXDhbCmzV+5n6HNb4
aBvj0EcHF8n2cRCXXQi0FDDIh19onBX8Tu/lJze9q4uOV2MBzrocIsKVpIOue7un
+oEpq8vQxkMA/fZxw8mdbR8yoLEM8BrWi6yrUbTiPMtc7mwgV3zfL1e925vGwNCZ
nhuFiQuJeJtqpAHT0wIF3HEfxye6LyA1j9rtxgrPi8lInBW8qIeG3lhBXoo5QAuZ
AoGt4ANnVilPTtjRBVDc25vsTleErjfGdMHo5ZTZ0Ra+daxMyaVek2CRDUBuu5Bz
QFTJPFXVFpn0dAw7zSZi9df/aqF7ViwRAlr048NfAJjj1kpIv53L0eKRSI8bQVh2
BuFVRlaFMhSpbENRoLcMyeE4i7Ke5Xv/Lddctkfrdrip6FlDSUIWpC2JOQOOycG/
Sd1r6iSOrz4=
=g6Bx
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.