Debian Bug report logs - #856728
opentyrian: When run via menu the game silently exits if data is missing

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Andrej Mernik <andrejm@ubuntu.si>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: opentyrian: When run via menu the game silently exits if data is missing

Date: Sat, 04 Mar 2017 13:35:14 +0100

Package: opentyrian
Version: 2.1.20130907+dfsg-1
Severity: important

Dear Maintainer,

when you run the game via the menu and the data package was not installed yet, it just exits with no warning.
The proper way to handle missing data would be to display a popup with the error message which points user to readme.
Alternatively, the installer script could ask the user if he wants to download and install the data files too. 

Best Regards,
Andrej Mernik


-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=sl_SI.UTF-8, LC_CTYPE=sl_SI.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages opentyrian depends on:
ii  game-data-packager  48
ii  libc6               2.24-9
ii  libsdl-net1.2       1.2.8-4
ii  libsdl1.2debian     1.2.15+dfsg1-4

opentyrian recommends no packages.

opentyrian suggests no packages.

-- no debconf information

Message #10 received at 856728@bugs.debian.org (full text, mbox, reply):

From: Alexandre Detiste <alexandre.detiste@gmail.com>

To: Andrej Mernik <andrejm@ubuntu.si>, 856728@bugs.debian.org

Subject: Re: Bug#856728: opentyrian: When run via menu the game silently exits if data is missing

Date: Sat, 04 Mar 2017 20:29:05 +0100

Le samedi 4 mars 2017, 13 h 35 min 14 s CET Andrej Mernik a écrit :
> Package: opentyrian
> Version: 2.1.20130907+dfsg-1
> Severity: important

Hi,

I had a patch for this that was proposed upstream,
then I completely forgot about it:

https://bitbucket.org/opentyrian/opentyrian/pull-requests/6/display-dialog-box-if-files-are-missing/diff

This could be reworked & simplified for Debian only.


> Alternatively, the installer script could ask the user if he wants to download and install the data files too. 

No, doing this in postinst script is dangerous (run as root,
files doesn't get registered as owned by opentyrian in dpkg database...)
we have a generic anwser to this generic problem and it's called game-data-packager.

Greets,

Alexandre Detiste

Message #15 received at 856728@bugs.debian.org (full text, mbox, reply):

From: Andrej Mernik <andrejm@ubuntu.si>

To: 856728@bugs.debian.org

Cc: Alexandre Detiste <alexandre.detiste@gmail.com>

Subject: Re: Bug#856728: opentyrian: When run via menu the game silently exits if data is missing

Date: Sat, 04 Mar 2017 22:00:09 +0100

Hello,

> I had a patch for this that was proposed upstream,
> then I completely forgot about it:
> 
> https://bitbucket.org/opentyrian/opentyrian/pull-requests/6/display-dialog-b
> ox-if-files-are-missing/diff
> 
> This could be reworked & simplified for Debian only.

That would be great. Currently people might think the game keeps crashing and 
remove it without playing.

> No, doing this in postinst script is dangerous (run as root,
> files doesn't get registered as owned by opentyrian in dpkg database...)
> we have a generic anwser to this generic problem and it's called
> game-data-packager.
> 

I was actually thinking more  that the post installer would run game-data-
packager if the user clicks yes.

Best Regards,
Andrej Mernik

Message #20 received at 856728@bugs.debian.org (full text, mbox, reply):

From: Simon McVittie <smcv@debian.org>

To: Alexandre Detiste <alexandre.detiste@gmail.com>, 856728@bugs.debian.org, Andrej Mernik <andrejm@ubuntu.si>

Subject: Re: Bug#856728: opentyrian: When run via menu the game silently exits if data is missing

Date: Sat, 4 Mar 2017 23:39:48 +0000

On Sat, 04 Mar 2017 at 20:29:05 +0100, Alexandre Detiste wrote:
> I had a patch for this that was proposed upstream,
> then I completely forgot about it:
> 
> https://bitbucket.org/opentyrian/opentyrian/pull-requests/6/display-dialog-box-if-files-are-missing/diff
> 
> This could be reworked & simplified for Debian only.

Freeze exception requested,
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=856810

On Sat, 04 Mar 2017 at 22:00:09 +0100, Andrej Mernik wrote:
> I was actually thinking more  that the post installer would run game-data-
> packager if the user clicks yes.

Sorry, that isn't possible for several reasons. game-data-packager is
currently a CLI rather than interactive, and needs to be told where to
find data as command-line arguments. If it was interactive (we want
it to be a GUI eventually), then it would still be unsuitable to run
from packages' maintainer scripts because GUIs should never run as root,
because package installation while offline should work, and because
maintainer scripts run with the dpkg lock held (so additional package
installations are impossible).

The long-term solution is likely to be putting a "launcher" wrapper
in opentyrian's menu entry, which would run the real engine if everything
is available, or launch the hypothetical future game-data-packager GUI
if data files are missing. Several games (e.g. quake) already have a
wrapper like this, although so far it just shows an error message,
because turning game-data-packager into an interactive GUI is going to be
a lot of work.

    S

Message #25 received at 856728-close@bugs.debian.org (full text, mbox, reply):

From: Simon McVittie <smcv@debian.org>

To: 856728-close@bugs.debian.org

Subject: Bug#856728: fixed in opentyrian 2.1.20130907+dfsg-2

Date: Sun, 05 Mar 2017 12:20:19 +0000

Source: opentyrian
Source-Version: 2.1.20130907+dfsg-2

We believe that the bug you reported is fixed in the latest version of
opentyrian, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 856728@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Simon McVittie <smcv@debian.org> (supplier of updated opentyrian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 04 Mar 2017 22:36:42 +0000
Source: opentyrian
Binary: opentyrian
Architecture: source
Version: 2.1.20130907+dfsg-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <pkg-games-devel@lists.alioth.debian.org>
Changed-By: Simon McVittie <smcv@debian.org>
Closes: 856728
Description: 
 opentyrian - open-source port of the DOS shoot-em-up Tyrian
Changes:
 opentyrian (2.1.20130907+dfsg-2) unstable; urgency=medium
 .
   * Team upload.
 .
   [ Alexandre Detiste ]
   * Display an error message when data is missing (Closes: #856728)
   * Exit gracefully after displaying that error, in particular resetting
     the screen resolution if running fullscreen in X11
   * Use HTTPS for Vcs-* URLs
   * Update years in Etienne Millon's packaging copyright
 .
   [ Simon McVittie ]
   * Add Suggests on the programs used to display the message
   * Add DEP-3 metadata to Alexandre's patch
Checksums-Sha1: 
 bb8a73fff444612675714eceec981c080ab29470 2101 opentyrian_2.1.20130907+dfsg-2.dsc
 5be2f7bd904cf0b5184849356d684e864e975af4 6176 opentyrian_2.1.20130907+dfsg-2.debian.tar.xz
Checksums-Sha256: 
 d990df01f7ec8557b925acc10786dc01a2b4757ce16a6e6c4a4a504306f1c04b 2101 opentyrian_2.1.20130907+dfsg-2.dsc
 87cb2df59ec45fcba2b5ee7e7ca58dcd9918c4dcc5bbe5daac7681d32f5464d8 6176 opentyrian_2.1.20130907+dfsg-2.debian.tar.xz
Files: 
 37c5aada0bad9fb4069ed8d62d6c748e 2101 contrib/games optional opentyrian_2.1.20130907+dfsg-2.dsc
 e0a21f41f8db5efadf026d8bb916c5fd 6176 contrib/games optional opentyrian_2.1.20130907+dfsg-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE2pjyXAhxxJpZ6v8sTej/KmPHzJAFAli7/bsACgkQTej/KmPH
zJAGEhAAiwHdM2TKLBDyQj+yrsL4lV47vgeoJGRQfi1p+6YYHGa8zo0mJd2mWUgr
LQ4EkDHSfqJqctTXGrladGLNzamWXKj2VXhtCeDq0DPp8gKTEGzWyJSIt6/jYxqU
a1tO2ielfTchntoaSFvVyoy3JgH7rvyi3UoaQvMlA/05JAzBie2RppvWtmja+PWF
IX8ZjWDikDK7On2bDTlnndNnpfnGbSgQNcwcniQjfK4JRJB/Vv6GzXyktmr9reqg
aDP/CSavJg9yyL6In7M71iUhh53qKG9xomtjxQ5GtGZU0I7Krcl85m7SYBJVaU/M
k4sPIbvMppMEOFe8TGFRxWnfutuj9F3sbMk6xjWC3zb9qcwhKJvTd7hXzQCDmk9e
lCasY/D05NDqW8ij25vk1mfzKNpUGYnCIiHS2UZcrIznzNTGWjE18ILGmVRzfjwv
8wMAiMJM53XIeppqzycH6GEei1r5N2oIwxd+knLKxTQpvRRi9VbkC7008qXLEXi8
Ryqg2/2dqNIPJDEifLH+W+wKqN8NElSAT8jWHJhokuHT1/EwolYCwG52uoZ2Bs8Y
5QdzJrPicmujCXQTYpb4pSix6C60voeULhB18ZMliKIwyGdTaj7UVZZ01PfBZhNL
iAffgHhRIoTOKUqmQ/15GoaIlSsx+UdyNVPVME0mOZAuMXvLkcA=
=VM8r
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.