Debian Bug report logs - #856447
diffoscope: test_icc::test_diff fails due to locale difference in output

version graph

Package: diffoscope; Maintainer for diffoscope is Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>; Source for diffoscope is src:diffoscope (PTS, buildd, popcon).

Reported by: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>

Date: Tue, 8 Mar 2016 21:57:06 UTC

Severity: normal

Found in versions diffoscope/77, diffoscope/48

Fixed in versions diffoscope/79, diffoscope/83

Done: Chris Lamb <lamby@debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#817193; Package diffoscope. (Tue, 08 Mar 2016 21:57:09 GMT) (full text, mbox, link).


Acknowledgement sent to Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>:
New Bug report received and forwarded. Copy sent to Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Tue, 08 Mar 2016 21:57:09 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
To: submit@bugs.debian.org
Subject: failing tests: test_gzip.py::test_metadata, test_ipk.py::test_metadata, test_java.py::test_diff
Date: Tue, 8 Mar 2016 21:34:04 +0000
Package: diffoscope
Version: 48

Hi,

I'm trying to package diffoscope for Fedora and the tests listed
in $subject are failing. Seems to be some timezone issue:

============================================= FAILURES ==============================================
_________________________________________ test_differences __________________________________________

differences = [<Difference test1.ext4.tar -- test2.ext4.tar [<Difference file list -- file list []>, <Difference ./date.txt -- ./date.txt [<Difference encoding -- encoding []>]>]>]

    @pytest.mark.skipif(not guestfs_working(), reason='guestfs not working on the system')
    @pytest.mark.skipif(tool_missing('qemu-img'), reason='missing qemu-img')
    @pytest.mark.skipif(miss_guestfs, reason='guestfs is missing')
    def test_differences(differences):
        assert differences[0].source1 == 'test1.ext4.tar'
        tarinfo = differences[0].details[0]
        tardiff = differences[0].details[1]
        encodingdiff = tardiff.details[0]
        assert tarinfo.source1 == 'file list'
        assert tarinfo.source2 == 'file list'
        assert tardiff.source1 == './date.txt'
        assert tardiff.source2 == './date.txt'
        assert encodingdiff.source1 == 'encoding'
        assert encodingdiff.source2 == 'encoding'
        expected_diff = open(os.path.join(os.path.dirname(__file__), '../data/ext4_expected_diffs'), encoding='utf-8').read()
        found_diff = tarinfo.unified_diff + tardiff.unified_diff + encodingdiff.unified_diff
>       assert expected_diff == found_diff
E       assert '@@ -1,3 +1,3...cii\n+utf-8\n' == '@@ -1,3 +1,3 ...cii\n+utf-8\n'
E           @@ -1,3 +1,3 @@
E         - -drwxr-xr-x   0        0        0        0 2015-12-02 16:01:40.000000 ./
E         - +drwxr-xr-x   0        0        0        0 2015-12-02 16:03:11.000000 ./
E         -  drwx------   0        0        0        0 2015-12-02 16:00:55.000000 ./lost+found/
E         + -drwxr-xr-x   0 root         (0) root         (0)        0 2015-12-02 16:01:40.000000 ./
E         + +drwxr-xr-x   0 root         (0) root         (0)        0 2015-12-02 16:03:11.000000 ./
E         +  drwx------   0 root         (0) root         (0)        0 2015-12-02 16:00:55.000000 ./lost+found/
E           --rw-rw-rw-   0     1234     1234       28 2015-12-02 16:01:40.000000 ./date.txt
E           +-r--r--r--   0     4321     4321       44 2015-12-02 16:03:11.000000 ./date.txt
E           @@ -1 +1 @@
E           -Wed Dec 2 17:01:40 CET 2015
E           +jeudi 3 décembre 2015, 06:03:11 (UTC+1400)
E           @@ -1 +1 @@
E           -us-ascii
E           +utf-8

tests/comparators/test_fsimage.py:85: AssertionError
___________________________________________ test_metadata ___________________________________________

differences = [<Difference metadata -- metadata []>, <Difference test1 -- test2 []>]

    def test_metadata(differences):
        assert differences[0].source1 == 'metadata'
        assert differences[0].source2 == 'metadata'
        expected_diff = open(os.path.join(os.path.dirname(__file__), '../data/gzip_metadata_expected_diff')).read()
>       assert differences[0].unified_diff == expected_diff
E       assert '@@ -1 +1 @@\..., from Unix\n' == '@@ -1 +1 @@\n..., from Unix\n'
E           @@ -1 +1 @@
E         - -gzip compressed data, last modified: Tue Jun 23 06:12:28 2015, max compression, from Unix
E         ?                                                   -
E         + -gzip compressed data, last modified: Tue Jun 23 10:12:28 2015, max compression, from Unix
E         ?                                                  +
E         - +gzip compressed data, last modified: Tue Jun 23 06:12:28 2015, from Unix
E         ?                                                   -
E         + +gzip compressed data, last modified: Tue Jun 23 10:12:28 2015, from Unix
E         ?                                                  +

tests/comparators/test_gzip.py:54: AssertionError
___________________________________________ test_metadata ___________________________________________

differences = [<Difference metadata -- metadata []>, <Difference base-files_157-r45695_ar71xx.ipk-content -- base-files_157-r45918_a...rence control.tar -- control.tar [<Difference file list -- file list []>, <Difference ./control -- ./control []>]>]>]>]

    def test_metadata(differences):
        assert differences[0].source1 == 'metadata'
        expected_diff = open(os.path.join(os.path.dirname(__file__), '../data/ipk_metadata_expected_diff')).read()
>       assert differences[0].unified_diff == expected_diff
E       assert '@@ -1 +1 @@\..., from Unix\n' == '@@ -1 +1 @@\n..., from Unix\n'
E           @@ -1 +1 @@
E         - -gzip compressed data, last modified: Mon May 18 19:26:52 2015, from Unix
E         ?                                                  ^^
E         + -gzip compressed data, last modified: Mon May 18 23:26:52 2015, from Unix
E         ?                                                  ^^
E         - +gzip compressed data, last modified: Mon Jun  8 13:31:21 2015, from Unix
E         ?                                                   ^
E         + +gzip compressed data, last modified: Mon Jun  8 17:31:21 2015, from Unix
E         ?                                                   ^

tests/comparators/test_ipk.py:52: AssertionError
_____________________________________________ test_diff _____________________________________________

differences = [<Difference javap -verbose -constants -s -l -private {} -- javap -verbose -constants -s -l -private {} []>]

    @pytest.mark.skipif(tool_missing('javap'), reason='missing javap')
    def test_diff(differences):
        expected_diff = open(os.path.join(os.path.dirname(__file__), '../data/class_expected_diff')).read()
>       assert differences[0].unified_diff == expected_diff
E       assert '@@ -31,13 +3..."Test.java"\n' == '@@ -36,12 +36...ne 3: 0\n }\n'
E         - @@ -31,13 +31,13 @@
E         ?      ^  ^   ^  ^
E         + @@ -36,12 +36,12 @@
E         ?      ^  ^   ^  ^
E         -          line 1: 0
E         -  
E              public static int main(java.lang.String[]);
E         -      descriptor: ([Ljava/lang/String;)I
E         ?      ^ --------
E         +      Signature: ([Ljava/lang/String;)I
E         ?      ^^^^^^^^
E                flags: ACC_PUBLIC, ACC_STATIC
E         +      LineNumberTable:
E         +        line 3: 0
E                Code:
E                  stack=1, locals=1, args_size=1
E           -         0: bipush        42
E         - -         2: ireturn
E         + -         2: ireturn       
E         ?                     +++++++
E         - +         0: iconst_m1
E         + +         0: iconst_m1     
E         ?                       +++++
E         - +         1: ireturn
E         + +         1: ireturn       
E         ?                     +++++++
E                  LineNumberTable:
E                    line 3: 0
E            }
E         -  SourceFile: "Test.java"

tests/comparators/test_java.py:53: AssertionError
========================= 4 failed, 170 passed, 39 skipped in 61.10 seconds =========================

See http://koji.fedoraproject.org/koji/taskinfo?taskID=13279412
for the whole thing.

Zbyszek



Reply sent to Holger Levsen <holger@layer-acht.org>:
You have taken responsibility. (Wed, 09 Mar 2016 07:55:38 GMT) (full text, mbox, link).


Notification sent to Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>:
Bug acknowledged by developer. (Wed, 09 Mar 2016 07:55:38 GMT) (full text, mbox, link).


Message #10 received at 817193-done@bugs.debian.org (full text, mbox, reply):

From: Holger Levsen <holger@layer-acht.org>
To: "Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>, 817193-done@bugs.debian.org
Subject: Re: [Reproducible-builds] Bug#817193: failing tests: test_gzip.py::test_metadata, test_ipk.py::test_metadata, test_java.py::test_diff
Date: Wed, 9 Mar 2016 08:43:36 +0100
[Message part 1 (text/plain, inline)]
Hi Zbigniew,

thanks for your bug report and for packaging diffoscope for Fedora! Much 
appreciated!

On Dienstag, 8. März 2016, Zbigniew Jędrzejewski-Szmek wrote:
> Package: diffoscope
> Version: 48
[...]
> I'm trying to package diffoscope for Fedora and the tests listed
> in $subject are failing. Seems to be some timezone issue:

This is a known bug in diffoscope <50, please try the latest version (51) 
where this bug has been fixed.


cheers,
	Holger
[signature.asc (application/pgp-signature, inline)]

Message #11 received at 817193-done@bugs.debian.org (full text, mbox, reply):

From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
To: Holger Levsen <holger@layer-acht.org>
Cc: 817193-done@bugs.debian.org
Subject: Re: [Reproducible-builds] Bug#817193: failing tests: test_gzip.py::test_metadata, test_ipk.py::test_metadata, test_java.py::test_diff
Date: Wed, 9 Mar 2016 11:56:34 +0000
On Wed, Mar 09, 2016 at 11:51:26AM +0000, Zbigniew Jędrzejewski-Szmek wrote:
> On Wed, Mar 09, 2016 at 08:43:36AM +0100, Holger Levsen wrote:
> > Hi Zbigniew,
> > 
> > thanks for your bug report and for packaging diffoscope for Fedora! Much 
> > appreciated!
> > 
> > On Dienstag, 8. März 2016, Zbigniew Jędrzejewski-Szmek wrote:
> > > Package: diffoscope
> > > Version: 48
> > [...]
> > > I'm trying to package diffoscope for Fedora and the tests listed
> > > in $subject are failing. Seems to be some timezone issue:
> > 
> > This is a known bug in diffoscope <50, please try the latest version (51) 
> > where this bug has been fixed.
> 
> I'll update, thanks for the fast reply!
> 
> FYI: I checked why I missed diffscope 49, 50, and 51.
> It seems to be a problem with pypi:
> https://pypi.python.org/pypi?%3Aaction=search&term=diffoscope&submit=search
> only lists diffoscope 48 as the lastest version. So either somebody forgot
> to upload the latest versions there, or it's not displaying them for some
> reason.
V. 49 is also on pypi, just doesn't show up in the search.

Is there a canonical place do download a tarball of the project apart from pypi?

Zbyszek




Message #12 received at 817193-done@bugs.debian.org (full text, mbox, reply):

From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
To: Holger Levsen <holger@layer-acht.org>
Cc: 817193-done@bugs.debian.org
Subject: Re: [Reproducible-builds] Bug#817193: failing tests: test_gzip.py::test_metadata, test_ipk.py::test_metadata, test_java.py::test_diff
Date: Wed, 9 Mar 2016 11:51:26 +0000
On Wed, Mar 09, 2016 at 08:43:36AM +0100, Holger Levsen wrote:
> Hi Zbigniew,
> 
> thanks for your bug report and for packaging diffoscope for Fedora! Much 
> appreciated!
> 
> On Dienstag, 8. März 2016, Zbigniew Jędrzejewski-Szmek wrote:
> > Package: diffoscope
> > Version: 48
> [...]
> > I'm trying to package diffoscope for Fedora and the tests listed
> > in $subject are failing. Seems to be some timezone issue:
> 
> This is a known bug in diffoscope <50, please try the latest version (51) 
> where this bug has been fixed.

I'll update, thanks for the fast reply!

FYI: I checked why I missed diffscope 49, 50, and 51.
It seems to be a problem with pypi:
https://pypi.python.org/pypi?%3Aaction=search&term=diffoscope&submit=search
only lists diffoscope 48 as the lastest version. So either somebody forgot
to upload the latest versions there, or it's not displaying them for some
reason.

Zbyszek



Message #13 received at 817193-done@bugs.debian.org (full text, mbox, reply):

From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
To: Holger Levsen <holger@layer-acht.org>
Cc: 817193-done@bugs.debian.org
Subject: Re: [Reproducible-builds] Bug#817193: failing tests: test_gzip.py::test_metadata, test_ipk.py::test_metadata, test_java.py::test_diff
Date: Wed, 9 Mar 2016 12:40:12 +0000
On Wed, Mar 09, 2016 at 08:43:36AM +0100, Holger Levsen wrote:
> Hi Zbigniew,
> 
> thanks for your bug report and for packaging diffoscope for Fedora! Much 
> appreciated!
> 
> On Dienstag, 8. März 2016, Zbigniew Jędrzejewski-Szmek wrote:
> > Package: diffoscope
> > Version: 48
> [...]
> > I'm trying to package diffoscope for Fedora and the tests listed
> > in $subject are failing. Seems to be some timezone issue:
> 
> This is a known bug in diffoscope <50, please try the latest version (51) 
> where this bug has been fixed.

The tests still fail with v. 51:

$ PYTHONPATH=. py.test-3 -vv
========================================= FAILURES ==================================
_____________________________________ test_differences ______________________________

differences = [<Difference test1.ext4.tar -- test2.ext4.tar [<Difference file list -- file list []>, <Difference ./date.txt -- ./date.txt [<Difference encoding -- encoding []>]>]>]

    @pytest.mark.skipif(not guestfs_working(), reason='guestfs not working on the system')
    @pytest.mark.skipif(tool_missing('qemu-img'), reason='missing qemu-img')
    @pytest.mark.skipif(miss_guestfs, reason='guestfs is missing')
    def test_differences(differences):
        assert differences[0].source1 == 'test1.ext4.tar'
        tarinfo = differences[0].details[0]
        tardiff = differences[0].details[1]
        encodingdiff = tardiff.details[0]
        assert tarinfo.source1 == 'file list'
        assert tarinfo.source2 == 'file list'
        assert tardiff.source1 == './date.txt'
        assert tardiff.source2 == './date.txt'
        assert encodingdiff.source1 == 'encoding'
        assert encodingdiff.source2 == 'encoding'
        expected_diff = open(os.path.join(os.path.dirname(__file__), '../data/ext4_expected_diffs'), encoding='utf-8').read()
        found_diff = tarinfo.unified_diff + tardiff.unified_diff + encodingdiff.unified_diff
>       assert expected_diff == found_diff
E       assert '@@ -1,3 +1,3...cii\n+utf-8\n' == '@@ -1,3 +1,3 ...cii\n+utf-8\n'
E           @@ -1,3 +1,3 @@
E         - -drwxr-xr-x   0        0        0        0 2015-12-02 16:01:40.000000 ./
E         - +drwxr-xr-x   0        0        0        0 2015-12-02 16:03:11.000000 ./
E         -  drwx------   0        0        0        0 2015-12-02 16:00:55.000000 ./lost+found/
E         + -drwxr-xr-x   0 root         (0) root         (0)        0 2015-12-02 16:01:40.000000 ./
E         + +drwxr-xr-x   0 root         (0) root         (0)        0 2015-12-02 16:03:11.000000 ./
E         +  drwx------   0 root         (0) root         (0)        0 2015-12-02 16:00:55.000000 ./lost+found/
E           --rw-rw-rw-   0     1234     1234       28 2015-12-02 16:01:40.000000 ./date.txt
E           +-r--r--r--   0     4321     4321       44 2015-12-02 16:03:11.000000 ./date.txt
E           @@ -1 +1 @@
E           -Wed Dec 2 17:01:40 CET 2015
E           +jeudi 3 décembre 2015, 06:03:11 (UTC+1400)
E           @@ -1 +1 @@
E           -us-ascii
E           +utf-8

tests/comparators/test_fsimage.py:85: AssertionError
________________________________ test_metadata _____________________________________________

differences = [<Difference metadata -- metadata []>, <Difference test1 -- test2 []>]

    def test_metadata(differences):
        assert differences[0].source1 == 'metadata'
        assert differences[0].source2 == 'metadata'
        expected_diff = open(os.path.join(os.path.dirname(__file__), '../data/gzip_metadata_expected_diff')).read()
>       assert differences[0].unified_diff == expected_diff
E       assert '@@ -1 +1 @@\..., from Unix\n' == '@@ -1 +1 @@\n..., from Unix\n'
E           @@ -1 +1 @@
E         - -gzip compressed data, last modified: Tue Jun 23 06:12:28 2015, max compression, from Unix
E         ?                                                   -
E         + -gzip compressed data, last modified: Tue Jun 23 10:12:28 2015, max compression, from Unix
E         ?                                                  +
E         - +gzip compressed data, last modified: Tue Jun 23 06:12:28 2015, from Unix
E         ?                                                   -
E         + +gzip compressed data, last modified: Tue Jun 23 10:12:28 2015, from Unix
E         ?                                                  +

tests/comparators/test_gzip.py:54: AssertionError
_________________ test_metadata ________________________________________________________

differences = [<Difference metadata -- metadata []>, <Difference base-files_157-r45695_ar71xx.ipk-content -- base-files_157-r45918_a...rence control.tar -- control.tar [<Difference file list -- file list []>, <Difference ./control -- ./control []>]>]>]>]

    def test_metadata(differences):
        assert differences[0].source1 == 'metadata'
        expected_diff = open(os.path.join(os.path.dirname(__file__), '../data/ipk_metadata_expected_diff')).read()
>       assert differences[0].unified_diff == expected_diff
E       assert '@@ -1 +1 @@\..., from Unix\n' == '@@ -1 +1 @@\n..., from Unix\n'
E           @@ -1 +1 @@
E         - -gzip compressed data, last modified: Mon May 18 19:26:52 2015, from Unix
E         ?                                                  ^^
E         + -gzip compressed data, last modified: Mon May 18 23:26:52 2015, from Unix
E         ?                                                  ^^
E         - +gzip compressed data, last modified: Mon Jun  8 13:31:21 2015, from Unix
E         ?                                                   ^
E         + +gzip compressed data, last modified: Mon Jun  8 17:31:21 2015, from Unix
E         ?                                                   ^

tests/comparators/test_ipk.py:52: AssertionError
======================= 3 failed, 180 passed, 39 skipped in 57.58 seconds =============

If I set TZ=UTC, I only get the first failure.

Zbyszek



Information forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#817193; Package diffoscope. (Wed, 09 Mar 2016 14:09:03 GMT) (full text, mbox, link).


Acknowledgement sent to Holger Levsen <holger@layer-acht.org>:
Extra info received and forwarded to list. Copy sent to Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Wed, 09 Mar 2016 14:09:03 GMT) (full text, mbox, link).


Message #18 received at 817193@bugs.debian.org (full text, mbox, reply):

From: Holger Levsen <holger@layer-acht.org>
To: "Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>, 817193@bugs.debian.org
Subject: Re: [Reproducible-builds] Bug#817193: failing tests: test_gzip.py::test_metadata, test_ipk.py::test_metadata, test_java.py::test_diff
Date: Wed, 9 Mar 2016 15:03:53 +0100
[Message part 1 (text/plain, inline)]
control: reopen -1

Hi,

On Mittwoch, 9. März 2016, Zbigniew Jędrzejewski-Szmek wrote:
> The tests still fail with v. 51:

ok, reopening, thanks for confirming!
 
> If I set TZ=UTC, I only get the first failure.

interesting…


cheers,
	Holger


[signature.asc (application/pgp-signature, inline)]

Bug reopened Request was from Holger Levsen <holger@layer-acht.org> to 817193-submit@bugs.debian.org. (Wed, 09 Mar 2016 14:09:03 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#817193; Package diffoscope. (Wed, 09 Mar 2016 14:27:08 GMT) (full text, mbox, link).


Acknowledgement sent to Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>:
Extra info received and forwarded to list. Copy sent to Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Wed, 09 Mar 2016 14:27:08 GMT) (full text, mbox, link).


Message #25 received at 817193@bugs.debian.org (full text, mbox, reply):

From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
To: Holger Levsen <holger@layer-acht.org>
Cc: 817193@bugs.debian.org
Subject: Re: [Reproducible-builds] Bug#817193: failing tests: test_gzip.py::test_metadata, test_ipk.py::test_metadata, test_java.py::test_diff
Date: Wed, 9 Mar 2016 14:08:03 +0000
On Wed, Mar 09, 2016 at 03:03:53PM +0100, Holger Levsen wrote:
> control: reopen -1
> 
> Hi,
> 
> On Mittwoch, 9. März 2016, Zbigniew Jędrzejewski-Szmek wrote:
> > The tests still fail with v. 51:
> 
> ok, reopening, thanks for confirming!
>  
> > If I set TZ=UTC, I only get the first failure.
> 
> interesting…

I'll be able link to build logs in koji (the Fedora build system) once
python-libarchive-c passes review and I can build against it.

Zbyszek



Information forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#817193; Package diffoscope. (Fri, 11 Mar 2016 15:06:11 GMT) (full text, mbox, link).


Acknowledgement sent to Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>:
Extra info received and forwarded to list. Copy sent to Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Fri, 11 Mar 2016 15:06:11 GMT) (full text, mbox, link).


Message #30 received at 817193@bugs.debian.org (full text, mbox, reply):

From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
To: Holger Levsen <holger@layer-acht.org>
Cc: 817193@bugs.debian.org
Subject: Re: [Reproducible-builds] Bug#817193: failing tests: test_gzip.py::test_metadata, test_ipk.py::test_metadata, test_java.py::test_diff
Date: Fri, 11 Mar 2016 15:03:28 +0000
> On Mittwoch, 9. März 2016, Zbigniew Jędrzejewski-Szmek wrote:
> > I'll be able link to build logs in koji (the Fedora build system) once
> > python-libarchive-c passes review and I can build against it.

Example of full test suite failing:
https://kojipkgs.fedoraproject.org//work/tasks/890/13300890/build.log

(I also run with this test commented out, and had a bunch of different
failures, not sure what is going on there:
https://kojipkgs.fedoraproject.org//work/tasks/834/13300834/build.log)

Zbyszek



Information forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#817193; Package diffoscope. (Fri, 11 Mar 2016 21:33:03 GMT) (full text, mbox, link).


Acknowledgement sent to Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>:
Extra info received and forwarded to list. Copy sent to Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Fri, 11 Mar 2016 21:33:03 GMT) (full text, mbox, link).


Message #35 received at 817193@bugs.debian.org (full text, mbox, reply):

From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
To: Holger Levsen <holger@layer-acht.org>
Cc: 817193@bugs.debian.org
Subject: Re: [Reproducible-builds] Bug#817193: failing tests: test_gzip.py::test_metadata, test_ipk.py::test_metadata, test_java.py::test_diff
Date: Fri, 11 Mar 2016 21:28:08 +0000
On Fri, Mar 11, 2016 at 03:03:28PM +0000, Zbigniew Jędrzejewski-Szmek wrote:
> > On Mittwoch, 9. März 2016, Zbigniew Jędrzejewski-Szmek wrote:
> > > I'll be able link to build logs in koji (the Fedora build system) once
> > > python-libarchive-c passes review and I can build against it.

One more status update, sorry for the noise.

> Example of full test suite failing:
> https://kojipkgs.fedoraproject.org//work/tasks/890/13300890/build.log

Another, different, failure:
https://kojipkgs.fedoraproject.org//work/tasks/2994/13312994/build.log
(this one appears to be non-deterministic)

> (I also run with this test commented out, and had a bunch of different
> failures, not sure what is going on there:
> https://kojipkgs.fedoraproject.org//work/tasks/834/13300834/build.log)
This was caused by locale issues (?). With LC_CTYPE=en_US.utf8
I don't see this any more.

Zbyszek



Information forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#817193; Package diffoscope. (Mon, 15 Aug 2016 10:27:04 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Lamb <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Mon, 15 Aug 2016 10:27:04 GMT) (full text, mbox, link).


Message #40 received at 817193@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>
To: 817193@bugs.debian.org
Cc: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>, Holger Levsen <holger@layer-acht.org>
Subject: Re: failing tests: test_gzip.py::test_metadata, test_ipk.py::test_metadata, test_java.py::test_diff
Date: Mon, 15 Aug 2016 11:24:05 +0100
Hi Zbigniew,

> > https://kojipkgs.fedoraproject.org//work/tasks/890/13300890/build.log
[..]
> https://kojipkgs.fedoraproject.org//work/tasks/2994/13312994/build.log
[..]
> https://kojipkgs.fedoraproject.org//work/tasks/834/13300834/build.log)

Alas these links now 404. Could you let me know:

a) Whether you still see these errors (and link to fresher URLs?)

b) How, exactly, you are invoking the tests. This matters because
   diffoscope does some "environment reset" (see ``set_locale``) but
   its not always called and probably isn't during tests. This might
   be deliberate, I haven't looked into it.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-



Changed Bug title to 'diffoscope: failing tests: test_gzip.py::test_metadata, test_ipk.py::test_metadata, test_java.py::test_diff' from 'failing tests: test_gzip.py::test_metadata, test_ipk.py::test_metadata, test_java.py::test_diff'. Request was from Holger Levsen <holger@layer-acht.org> to control@bugs.debian.org. (Mon, 15 Aug 2016 13:15:06 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#817193; Package diffoscope. (Mon, 15 Aug 2016 18:06:08 GMT) (full text, mbox, link).


Acknowledgement sent to Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>:
Extra info received and forwarded to list. Copy sent to Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Mon, 15 Aug 2016 18:06:08 GMT) (full text, mbox, link).


Message #47 received at 817193@bugs.debian.org (full text, mbox, reply):

From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
To: Chris Lamb <lamby@debian.org>
Cc: 817193@bugs.debian.org, Holger Levsen <holger@layer-acht.org>
Subject: Re: failing tests: test_gzip.py::test_metadata, test_ipk.py::test_metadata, test_java.py::test_diff
Date: Mon, 15 Aug 2016 18:01:48 +0000
I "enabled" the cbfs tests by installing the appropriate dependency (coreboot-utils),
and one more test starting failing:

=================================== FAILURES ===================================
_________________________________ test_listing _________________________________

differences = [<Difference cbfstool {} print -- cbfstool {} print []>, <Difference text -- text []>]

    @pytest.mark.skipif(tool_missing('cbfstool'), reason='missing cbfstool')
    def test_listing(differences):
        expected_diff = open(os.path.join(os.path.dirname(__file__), '../data/cbfs_listing_expected_diff')).read()
>       assert differences[0].unified_diff == expected_diff
E       assert '@@ -1,3 +1,3...      31896\n' == '@@ -1,6 +1,3 ...      31896\n'
E         - @@ -1,3 +1,3 @@
E         ?       ^
E         + @@ -1,6 +1,3 @@
E         ?       ^
E         + -32 kB, bootblocksize 0, romsize 32768, offset 0x0
E         + -alignment: 64 bytes, architecture: x86
E         + -
E            Name                           Offset     Type         Size
E           -text                           0x0        raw          446
E           -(empty)                        0x200      null         32152
E           +text                           0x0        raw          671
E           +(empty)                        0x300      null         31896

tests/comparators/test_cbfs.py:79: AssertionError
---------------------------- Captured stdout setup -----------------------------
--- /tmp/pytest-of-zbyszek/pytest-15/test_listing0/coreboot1
+++ /tmp/pytest-of-zbyszek/pytest-15/test_listing0/coreboot2.rom
├── cbfstool {} print
│ @@ -1,3 +1,3 @@
│  Name                           Offset     Type         Size
│ -text                           0x0        raw          446
│ -(empty)                        0x200      null         32152
│ +text                           0x0        raw          671
│ +(empty)                        0x300      null         31896
├── text
│ @@ -1,6 +1,12 @@
│ +A common form of lorem ipsum reads:
│ +
│  Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor
│  incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis
│  nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.
│  Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu
│  fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in
│  culpa qui officia deserunt mollit anim id est laborum.
│ +
│ +"Lorem ipsum" text is derived from sections 1.10.32--3 of Cicero's De finibus
│ +bonorum et malorum (On the Ends of Goods and Evils, or alternatively [About]
│ +The Purposes of Good and Evil).
╵
---------------------------- Captured stderr setup -----------------------------
Created CBFS (capacity = 32664 bytes)
Created CBFS (capacity = 32664 bytes)
============== 1 failed, 202 passed, 29 skipped in 54.96 seconds ===============

Unfortunately Fedora is missing a bunch of the tools required to
support all tests. In particular pdftk has been retired because of licensing
reasons [https://lists.fedoraproject.org/pipermail/devel/2014-March/196394.html],
so some tests will continue to have to be skipped.

Zbyszek



Information forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#817193; Package diffoscope. (Mon, 15 Aug 2016 18:24:03 GMT) (full text, mbox, link).


Acknowledgement sent to Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>:
Extra info received and forwarded to list. Copy sent to Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Mon, 15 Aug 2016 18:24:03 GMT) (full text, mbox, link).


Message #52 received at 817193@bugs.debian.org (full text, mbox, reply):

From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
To: Chris Lamb <lamby@debian.org>
Cc: 817193@bugs.debian.org, Holger Levsen <holger@layer-acht.org>
Subject: Re: failing tests: test_gzip.py::test_metadata, test_ipk.py::test_metadata, test_java.py::test_diff
Date: Mon, 15 Aug 2016 17:42:23 +0000
On Mon, Aug 15, 2016 at 11:24:05AM +0100, Chris Lamb wrote:
> Hi Zbigniew,
> 
> > > https://kojipkgs.fedoraproject.org//work/tasks/890/13300890/build.log
> [..]
> > https://kojipkgs.fedoraproject.org//work/tasks/2994/13312994/build.log
> [..]
> > https://kojipkgs.fedoraproject.org//work/tasks/834/13300834/build.log)
> 
> Alas these links now 404. Could you let me know:
Hi,

unfortunately failed builds are purged from koji after some time. I periodically
forget about that.

> a) Whether you still see these errors (and link to fresher URLs?)
I see only a single error. It was also on that list. Others have been fixed:

======================================================= FAILURES ========================================================
___________________________________________________ test_differences ____________________________________________________

differences = [<Difference test1.ext4.tar -- test2.ext4.tar [<Difference file list -- file list []>, <Difference ./date.txt -- ./date.txt [<Difference encoding -- encoding []>]>]>]

    @pytest.mark.skipif(not guestfs_working(), reason='guestfs not working on the system')
    @pytest.mark.skipif(tool_missing('qemu-img'), reason='missing qemu-img')
    @pytest.mark.skipif(miss_guestfs, reason='guestfs is missing')
    def test_differences(differences):
        assert differences[0].source1 == 'test1.ext4.tar'
        tarinfo = differences[0].details[0]
        tardiff = differences[0].details[1]
        encodingdiff = tardiff.details[0]
        assert tarinfo.source1 == 'file list'
        assert tarinfo.source2 == 'file list'
        assert tardiff.source1 == './date.txt'
        assert tardiff.source2 == './date.txt'
        assert encodingdiff.source1 == 'encoding'
        assert encodingdiff.source2 == 'encoding'
        expected_diff = open(os.path.join(os.path.dirname(__file__), '../data/ext4_expected_diffs'), encoding='utf-8').read()
        found_diff = tarinfo.unified_diff + tardiff.unified_diff + encodingdiff.unified_diff
>       assert expected_diff == found_diff
E       assert '@@ -1,3 +1,3...cii\n+utf-8\n' == '@@ -1,3 +1,3 ...cii\n+utf-8\n'
E           @@ -1,3 +1,3 @@
E         - -drwxr-xr-x   0        0        0        0 2015-12-02 16:01:40.000000 ./
E         - +drwxr-xr-x   0        0        0        0 2015-12-02 16:03:11.000000 ./
E         -  drwx------   0        0        0        0 2015-12-02 16:00:55.000000 ./lost+found/
E         + -drwxr-xr-x   0 root         (0) root         (0)        0 2015-12-02 16:01:40.000000 ./
E         + +drwxr-xr-x   0 root         (0) root         (0)        0 2015-12-02 16:03:11.000000 ./
E         +  drwx------   0 root         (0) root         (0)        0 2015-12-02 16:00:55.000000 ./lost+found/
E           --rw-rw-rw-   0     1234     1234       28 2015-12-02 16:01:40.000000 ./date.txt
E           +-r--r--r--   0     4321     4321       44 2015-12-02 16:03:11.000000 ./date.txt
E           @@ -1 +1 @@
E           -Wed Dec 2 17:01:40 CET 2015
E           +jeudi 3 décembre 2015, 06:03:11 (UTC+1400)
E           @@ -1 +1 @@
E           -us-ascii
E           +utf-8

tests/comparators/test_fsimage.py:85: AssertionError
=================================== 1 failed, 197 passed, 35 skipped in 61.54 seconds ===================================

> b) How, exactly, you are invoking the tests. This matters because
>    diffoscope does some "environment reset" (see ``set_locale``) but
>    its not always called and probably isn't during tests. This might
>    be deliberate, I haven't looked into it.

I invoke the tests as "PYTHONPATH=. py.test-3 . -vv" locally. Above output
is from that.

Let me know if I should provide additional information.

Zbyszek



Information forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#817193; Package diffoscope. (Mon, 15 Aug 2016 20:09:04 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Lamb <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Mon, 15 Aug 2016 20:09:04 GMT) (full text, mbox, link).


Message #57 received at 817193@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>
To: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Cc: 817193@bugs.debian.org, Holger Levsen <holger@layer-acht.org>
Subject: Re: failing tests: test_gzip.py::test_metadata, test_ipk.py::test_metadata, test_java.py::test_diff
Date: Mon, 15 Aug 2016 21:07:03 +0100
Zbigniew Jędrzejewski-Szmek wrote:

> I invoke the tests as "PYTHONPATH=. py.test-3 . -vv" locally. Above output
> is from that.

Hm, cannot seem to reproduce.

Are you building inside a container, out of interest? I see some strange
things building in some containers as they prevent writes to /etc/timezone

Oh, can you confirm that set_locale() is being called? Putting "1/0" in that
method will suffice.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-



Information forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#817193; Package diffoscope. (Mon, 15 Aug 2016 23:42:08 GMT) (full text, mbox, link).


Acknowledgement sent to Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>:
Extra info received and forwarded to list. Copy sent to Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Mon, 15 Aug 2016 23:42:08 GMT) (full text, mbox, link).


Message #62 received at 817193@bugs.debian.org (full text, mbox, reply):

From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
To: Chris Lamb <lamby@debian.org>
Cc: 817193@bugs.debian.org, Holger Levsen <holger@layer-acht.org>
Subject: Re: failing tests: test_gzip.py::test_metadata, test_ipk.py::test_metadata, test_java.py::test_diff
Date: Mon, 15 Aug 2016 23:39:41 +0000
On Mon, Aug 15, 2016 at 09:07:03PM +0100, Chris Lamb wrote:
> Zbigniew Jędrzejewski-Szmek wrote:
> 
> > I invoke the tests as "PYTHONPATH=. py.test-3 . -vv" locally. Above output
> > is from that.
> 
> Hm, cannot seem to reproduce.
> 
> Are you building inside a container, out of interest? I see some strange
> things building in some containers as they prevent writes to /etc/timezone
I see no difference between running on bare metal and the mock chroot.

PYTHONPATH=. py.test-3 . -vv -k test_differences
================================ test session starts =================================
platform linux -- Python 3.5.1, pytest-2.9.2, py-1.4.31, pluggy-0.3.1 -- /usr/bin/python3
cachedir: .cache
rootdir: /home/zbyszek/python/diffoscope, inifile: 
plugins: cov-2.2.1
collected 233 items 

tests/comparators/test_dex.py::test_differences SKIPPED
tests/comparators/test_elf.py::test_differences_with_dbgsym SKIPPED
tests/comparators/test_epub.py::test_differences ERROR
tests/comparators/test_fsimage.py::test_differences ERROR

===================================== ERRORS ========================================
_________________________ ERROR at setup of test_differences ________________________

    @pytest.fixture(autouse=True)
    def set_locale():
>       diffoscope.set_locale()

tests/comparators/conftest.py:28: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

    def set_locale():
        """Normalize locale so external tool gives us stable and properly
        encoded output"""
    
>       1/0
E       ZeroDivisionError: division by zero

diffoscope/__init__.py:265: ZeroDivisionError
_______________________ ERROR at setup of test_differences _________________________

    @pytest.fixture(autouse=True)
    def set_locale():
>       diffoscope.set_locale()

tests/comparators/conftest.py:28: 
 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

    def set_locale():
        """Normalize locale so external tool gives us stable and properly
        encoded output"""
    
>       1/0
E       ZeroDivisionError: division by zero

diffoscope/__init__.py:265: ZeroDivisionError
============== 229 tests deselected by '-ktest_differences' =========================
============== 2 skipped, 229 deselected, 2 error in 14.69 seconds ==================


Zbyszek



Information forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#817193; Package diffoscope. (Tue, 16 Aug 2016 00:12:04 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Lamb <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Tue, 16 Aug 2016 00:12:04 GMT) (full text, mbox, link).


Message #67 received at 817193@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>
To: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Cc: 817193@bugs.debian.org, Holger Levsen <holger@layer-acht.org>
Subject: Re: failing tests: test_gzip.py::test_metadata, test_ipk.py::test_metadata, test_java.py::test_diff
Date: Tue, 16 Aug 2016 01:09:54 +0100
> I see no difference between running on bare metal and the mock chroot.

(Thanks for checking!)

>     def set_locale():
>         """Normalize locale so external tool gives us stable and properly
>         encoded output"""
>     
> >       1/0

Hm, then I'm stumped for now. :)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-



Information forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#817193; Package diffoscope. (Tue, 15 Nov 2016 16:48:03 GMT) (full text, mbox, link).


Acknowledgement sent to Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>:
Extra info received and forwarded to list. Copy sent to Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Tue, 15 Nov 2016 16:48:03 GMT) (full text, mbox, link).


Message #72 received at 817193@bugs.debian.org (full text, mbox, reply):

From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
To: 817193@bugs.debian.org
Subject: Bug#817193: failing tests with v62: test_listing, test_diff test_gzip.py::test_metadata, test_ipk.py::test_metadata, test_java.py::test_diff
Date: Tue, 15 Nov 2016 16:14:20 +0000
=================================== FAILURES ===================================
_________________________________ test_listing _________________________________

differences = [<Difference cbfstool {} print -- cbfstool {} print []>, <Difference text -- text []>]

    @skip_unless_tools_exist('cbfstool')
    def test_listing(differences):
        expected_diff = open(data('cbfs_listing_expected_diff')).read()
>       assert differences[0].unified_diff == expected_diff
E       assert '@@ -1,3 +1,3...      31896\n' == '@@ -1,6 +1,3 ...      31896\n'
E         - @@ -1,3 +1,3 @@
E         ?       ^
E         + @@ -1,6 +1,3 @@
E         ?       ^
E         + -32 kB, bootblocksize 0, romsize 32768, offset 0x0
E         + -alignment: 64 bytes, architecture: x86
E         + -
E            Name                           Offset     Type         Size
E           -text                           0x0        raw          446
E           -(empty)                        0x200      null         32152
E           +text                           0x0        raw          671
E           +(empty)                        0x300      null         31896

tests/comparators/test_cbfs.py:79: AssertionError
---------------------------- Captured stdout setup -----------------------------
--- /tmp/pytest-of-zbyszek/pytest-1/test_listing0/coreboot1
+++ /tmp/pytest-of-zbyszek/pytest-1/test_listing0/coreboot2.rom
├── cbfstool {} print
│ @@ -1,3 +1,3 @@
│  Name                           Offset     Type         Size
│ -text                           0x0        raw          446
│ -(empty)                        0x200      null         32152
│ +text                           0x0        raw          671
│ +(empty)                        0x300      null         31896
├── text
│ @@ -1,6 +1,12 @@
│ +A common form of lorem ipsum reads:
│ +
│  Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor
│  incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis
│  nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.
│  Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu
│  fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in
│  culpa qui officia deserunt mollit anim id est laborum.
│ +
│ +"Lorem ipsum" text is derived from sections 1.10.32--3 of Cicero's De finibus
│ +bonorum et malorum (On the Ends of Goods and Evils, or alternatively [About]
│ +The Purposes of Good and Evil).
╵
---------------------------- Captured stderr setup -----------------------------
Created CBFS (capacity = 32664 bytes)
Created CBFS (capacity = 32664 bytes)
__________________________________ test_diff ___________________________________

differences = [<Difference cd-iccdump {} -- cd-iccdump {} []>]

    @skip_unless_tools_exist('cd-iccdump')
    def test_diff(differences):
        expected_diff = open(data('icc_expected_diff')).read()
>       assert differences[0].unified_diff == expected_diff
E       assert '@@ -1,20 +1,... [24 bytes]\n' == '@@ -1,20 +1,2... [24 bytes]\n'
E           @@ -1,20 +1,20 @@
E            icc:
E            Header:
E              Size             = 14684 bytes
E              Version  = 4.3
E              Profile Kind     = display-device
E              Colorspace       = rgb
E              Conn. Space      = xyz
E           -  Date, Time       = 2016-02-15, 21:02:09
E           +  Date, Time       = 2016-02-15, 21:03:22
E              Flags            = Not embedded profile, Use anywhere
E              Dev. Attrbts     = reflective, glossy
E              Rndrng Intnt     = perceptual
E              Creator  = lcms
E           -  Profile ID       = 0x0477fa4b
E           +  Profile ID       = 0x06017f17
E            
E            tag 00:
E              sig      'desc' [0x64657363]
E              size     38
E              type     'mluc' [0x6d6c7563]
E            Text:
E         -    ne_SU:   sRGB [24 bytes]
E         ?     -  -
E         +    en_US:   sRGB [24 bytes]
E         ?    +  +

tests/comparators/test_icc.py:45: AssertionError
============== 2 failed, 208 passed, 38 skipped in 41.30 seconds ===============

test_differences, which was failing before, now passes.

Zbyszek



Information forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#817193; Package diffoscope. (Tue, 15 Nov 2016 17:03:03 GMT) (full text, mbox, link).


Acknowledgement sent to Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>:
Extra info received and forwarded to list. Copy sent to Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Tue, 15 Nov 2016 17:03:03 GMT) (full text, mbox, link).


Message #77 received at 817193@bugs.debian.org (full text, mbox, reply):

From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
To: 817193@bugs.debian.org
Subject: Re: Bug#817193: failing tests with v62: test_listing, test_diff test_gzip.py::test_metadata, test_ipk.py::test_metadata, test_java.py::test_diff
Date: Tue, 15 Nov 2016 16:59:30 +0000
I noticed that I was missing ppudmp from my installation, so tests
were skipped.  Once it is installed, the ppu tests also fail. Looks
like a programming error, PpuFile is File, not FilesystemFile from a
quick look.

=================================== FAILURES ===================================
_____________________________ test_identification ______________________________

file1 = <<class 'diffoscope.comparators.binary.FilesystemFile'> /builddir/build/BUILD/diffoscope/tests/data/test1.ppu>

    @skip_unless_tools_exist('ppudump')
    def test_identification(file1):
>       assert isinstance(file1, PpuFile)
E       assert isinstance(<<class 'diffoscope.comparators.binary.FilesystemFile'> /builddir/build/BUILD/diffoscope/tests/data/test1.ppu>, PpuFile)

tests/comparators/test_ppu.py:46: AssertionError
__________________________________ test_diff ___________________________________

differences = []

    @skip_unless_tool_is_older_than('ppudump', ppudump_version, '3.0.0')
    def test_diff(differences):
>       print(differences[0].unified_diff)
E       IndexError: list index out of range

tests/comparators/test_ppu.py:58: IndexError
__________________________ test_compare_non_existing ___________________________

monkeypatch = <_pytest.monkeypatch.monkeypatch object at 0xf3f7c52c>
file1 = <<class 'diffoscope.comparators.binary.FilesystemFile'> /builddir/build/BUILD/diffoscope/tests/data/test1.ppu>

    @skip_unless_tool_is_older_than('ppudump', ppudump_version, '3.0.0')
    def test_compare_non_existing(monkeypatch, file1):
>       assert_non_existing(monkeypatch, file1, has_null_source=False)

tests/comparators/test_ppu.py:64: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

monkeypatch = <_pytest.monkeypatch.monkeypatch object at 0xf3f7c52c>
fixture = <<class 'diffoscope.comparators.binary.FilesystemFile'> /builddir/build/BUILD/diffoscope/tests/data/test1.ppu>
has_null_source = False, has_details = True

    def assert_non_existing(monkeypatch, fixture, has_null_source=True, has_details=True):
        monkeypatch.setattr(Config(), 'new_file', True)
        assert Config().new_file, "didnt get patched"
    
        difference = fixture.compare(NonExistingFile('/nonexisting', fixture))
    
        output_html(difference, print_func=print)
        output_text(difference, print_func=print)
    
        assert difference.source2 == '/nonexisting'
>       assert not has_details or len(difference.details) > 0
E       assert (not True or 0 > 0)
E        +  where 0 = len([])
E        +    where [] = <Difference /builddir/build/BUILD/diffoscope/tests/data/test1.ppu -- /nonexisting []>.details

tests/comparators/utils.py:79: AssertionError



Information forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#817193; Package diffoscope. (Tue, 07 Feb 2017 01:15:02 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Lamb <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Tue, 07 Feb 2017 01:15:02 GMT) (full text, mbox, link).


Message #82 received at 817193@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>
To: 817193@bugs.debian.org
Cc: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Subject: Re: diffoscope: failing tests: test_gzip.py::test_metadata, test_ipk.py::test_metadata, test_java.py::test_diff
Date: Tue, 07 Feb 2017 14:11:51 +1300
Hi Zbigniew,

> diffoscope: failing tests: test_gzip.py::test_metadata, test_ipk.py::test_metadata, test_java.py::test_diff

Are you still any of these test failures with a recent diffoscope
version? We have made a few locale changes recently so its likely
that at least some of these are fixed.

Please reply with exactly which you are seeing, preferably with an
updated traceback, etc.


Many thanks,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-



Information forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#817193; Package diffoscope. (Thu, 23 Feb 2017 09:51:04 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Lamb <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Thu, 23 Feb 2017 09:51:04 GMT) (full text, mbox, link).


Message #87 received at 817193@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>
To: 817193@bugs.debian.org
Cc: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Subject: Re: diffoscope: failing tests: test_gzip.py::test_metadata, test_ipk.py::test_metadata, test_java.py::test_diff
Date: Thu, 23 Feb 2017 17:48:14 +0800
tags 817193 + unreproducible
thanks

Chris Lamb wrote:

> Are you still any of these test failures with a recent diffoscope
> version? We have made a few locale changes recently so its likely
> that at least some of these are fixed.

As I can't reproduce this and there has been no reply I'm going to
go ahead and close it. Re-open if you can still demonstrate the issue
of course. :)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-



Reply sent to Chris Lamb <lamby@debian.org>:
You have taken responsibility. (Thu, 23 Feb 2017 09:51:09 GMT) (full text, mbox, link).


Notification sent to Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>:
Bug acknowledged by developer. (Thu, 23 Feb 2017 09:51:09 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#817193; Package diffoscope. (Sun, 26 Feb 2017 18:12:02 GMT) (full text, mbox, link).


Acknowledgement sent to Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>:
Extra info received and forwarded to list. Copy sent to Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Sun, 26 Feb 2017 18:12:02 GMT) (full text, mbox, link).


Message #97 received at 817193@bugs.debian.org (full text, mbox, reply):

From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
To: Chris Lamb <lamby@debian.org>
Cc: 817193@bugs.debian.org
Subject: Re: diffoscope: failing tests: test_gzip.py::test_metadata, test_ipk.py::test_metadata, test_java.py::test_diff
Date: Sun, 26 Feb 2017 17:37:51 +0000
On Thu, Feb 23, 2017 at 05:48:14PM +0800, Chris Lamb wrote:
> tags 817193 + unreproducible
> thanks
> 
> Chris Lamb wrote:
> 
> > Are you still any of these test failures with a recent diffoscope
> > version? We have made a few locale changes recently so its likely
> > that at least some of these are fixed.
> 
> As I can't reproduce this and there has been no reply I'm going to
> go ahead and close it. Re-open if you can still demonstrate the issue
> of course. :)

Hi,
sorry for the late reply. Too many packages ;)

With diffoscope-77, I get the following failures:
(Fedora rawhide amd64 mock, export LC_CTYPE=en_US.utf8 TZ=UTC)

=================================== FAILURES ===================================
_________________________________ test_listing _________________________________

differences = [<Difference cbfstool {} print -- cbfstool {} print []>, <Difference text -- text []>]

    @skip_unless_tools_exist('cbfstool')
    def test_listing(differences):
        expected_diff = get_data('cbfs_listing_expected_diff')
>       assert differences[0].unified_diff == expected_diff
E       assert '@@ -1,3 +1,3...      31896\n' == '@@ -1,6 +1,3 ...      31896\n'
E         - @@ -1,3 +1,3 @@
E         ?       ^
E         + @@ -1,6 +1,3 @@
E         ?       ^
E         + -32 kB, bootblocksize 0, romsize 32768, offset 0x0
E         + -alignment: 64 bytes, architecture: x86
E         + -
E            Name                           Offset     Type         Size
E           -text                           0x0        raw          446
E           -(empty)                        0x200      null         32152
E           +text                           0x0        raw          671
E           +(empty)                        0x300      null         31896

tests/comparators/test_cbfs.py:80: AssertionError
---------------------------- Captured stderr setup -----------------------------
Created CBFS (capacity = 32664 bytes)
Created CBFS (capacity = 32664 bytes)
__________________________________ test_diff ___________________________________

differences = [<Difference cd-iccdump {} -- cd-iccdump {} []>]

    @skip_unless_tools_exist('cd-iccdump')
    def test_diff(differences):
        expected_diff = get_data('icc_expected_diff')
>       assert differences[0].unified_diff == expected_diff
E       assert '@@ -1,20 +1,... [24 bytes]\n' == '@@ -1,20 +1,2... [24 bytes]\n'
E           @@ -1,20 +1,20 @@
E            icc:
E            Header:
E              Size		= 14684 bytes
E              Version		= 4.3
E              Profile Kind	= display-device
E              Colorspace	= rgb
E              Conn. Space	= xyz
E           -  Date, Time	= 2016-02-15, 21:02:09
E           +  Date, Time	= 2016-02-15, 21:03:22
E              Flags 		= Not embedded profile, Use anywhere
E              Dev. Attrbts	= reflective, glossy
E              Rndrng Intnt	= perceptual
E              Creator		= lcms
E           -  Profile ID	= 0x0477fa4b
E           +  Profile ID	= 0x06017f17
E            
E            tag 00:
E              sig	'desc' [0x64657363]
E              size	38
E              type	'mluc' [0x6d6c7563]
E            Text:
E         -    ne_SU:	sRGB [24 bytes]
E         ?     -  -
E         +    en_US:	sRGB [24 bytes]
E         ?    +  +

tests/comparators/test_icc.py:47: AssertionError
============== 2 failed, 249 passed, 42 skipped in 44.78 seconds ===============

The second issue looks like a real difference.

The first issue I think is just a slightly different diff context between
the texts. I have seen something similar when generating patches using different
versions of git.

Zbyszek



Information forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#817193; Package diffoscope. (Sun, 26 Feb 2017 18:24:05 GMT) (full text, mbox, link).


Acknowledgement sent to Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>:
Extra info received and forwarded to list. Copy sent to Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Sun, 26 Feb 2017 18:24:06 GMT) (full text, mbox, link).


Message #102 received at 817193@bugs.debian.org (full text, mbox, reply):

From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
To: Chris Lamb <lamby@debian.org>
Cc: 817193@bugs.debian.org
Subject: Re: diffoscope: failing tests: test_gzip.py::test_metadata, test_ipk.py::test_metadata, test_java.py::test_diff
Date: Sun, 26 Feb 2017 18:20:21 +0000
On Sun, Feb 26, 2017 at 05:37:51PM +0000, Zbigniew Jędrzejewski-Szmek wrote:
> On Thu, Feb 23, 2017 at 05:48:14PM +0800, Chris Lamb wrote:
> > tags 817193 + unreproducible
> > thanks
> > 
> > Chris Lamb wrote:
> > 
> > > Are you still any of these test failures with a recent diffoscope
> > > version? We have made a few locale changes recently so its likely
> > > that at least some of these are fixed.
> > 
> > As I can't reproduce this and there has been no reply I'm going to
> > go ahead and close it. Re-open if you can still demonstrate the issue
> > of course. :)
> 
> Hi,
> sorry for the late reply. Too many packages ;)
> 
> With diffoscope-77, I get the following failures:
> (Fedora rawhide amd64 mock, export LC_CTYPE=en_US.utf8 TZ=UTC)
> 
> =================================== FAILURES ===================================
> _________________________________ test_listing _________________________________
> 
> differences = [<Difference cbfstool {} print -- cbfstool {} print []>, <Difference text -- text []>]
> 
>     @skip_unless_tools_exist('cbfstool')
>     def test_listing(differences):
>         expected_diff = get_data('cbfs_listing_expected_diff')
> >       assert differences[0].unified_diff == expected_diff
> E       assert '@@ -1,3 +1,3...      31896\n' == '@@ -1,6 +1,3 ...      31896\n'
> E         - @@ -1,3 +1,3 @@
> E         ?       ^
> E         + @@ -1,6 +1,3 @@
> E         ?       ^
> E         + -32 kB, bootblocksize 0, romsize 32768, offset 0x0
> E         + -alignment: 64 bytes, architecture: x86
> E         + -
> E            Name                           Offset     Type         Size
> E           -text                           0x0        raw          446
> E           -(empty)                        0x200      null         32152
> E           +text                           0x0        raw          671
> E           +(empty)                        0x300      null         31896
> 
> tests/comparators/test_cbfs.py:80: AssertionError
> ---------------------------- Captured stderr setup -----------------------------
> Created CBFS (capacity = 32664 bytes)
> Created CBFS (capacity = 32664 bytes)
> __________________________________ test_diff ___________________________________
> 
> differences = [<Difference cd-iccdump {} -- cd-iccdump {} []>]
> 
>     @skip_unless_tools_exist('cd-iccdump')
>     def test_diff(differences):
>         expected_diff = get_data('icc_expected_diff')
> >       assert differences[0].unified_diff == expected_diff
> E       assert '@@ -1,20 +1,... [24 bytes]\n' == '@@ -1,20 +1,2... [24 bytes]\n'
> E           @@ -1,20 +1,20 @@
> E            icc:
> E            Header:
> E              Size		= 14684 bytes
> E              Version		= 4.3
> E              Profile Kind	= display-device
> E              Colorspace	= rgb
> E              Conn. Space	= xyz
> E           -  Date, Time	= 2016-02-15, 21:02:09
> E           +  Date, Time	= 2016-02-15, 21:03:22
> E              Flags 		= Not embedded profile, Use anywhere
> E              Dev. Attrbts	= reflective, glossy
> E              Rndrng Intnt	= perceptual
> E              Creator		= lcms
> E           -  Profile ID	= 0x0477fa4b
> E           +  Profile ID	= 0x06017f17
> E            
> E            tag 00:
> E              sig	'desc' [0x64657363]
> E              size	38
> E              type	'mluc' [0x6d6c7563]
> E            Text:
> E         -    ne_SU:	sRGB [24 bytes]
> E         ?     -  -
> E         +    en_US:	sRGB [24 bytes]
> E         ?    +  +
> 
> tests/comparators/test_icc.py:47: AssertionError
> ============== 2 failed, 249 passed, 42 skipped in 44.78 seconds ===============
> 
> The second issue looks like a real difference.
> 
> The first issue I think is just a slightly different diff context between
> the texts. I have seen something similar when generating patches using different
> versions of git.

Actually no, the first also looks like a real difference. For some reason
the expected header is not printed:

$ "cbfstool" "/tmp/pytest-of-zbyszek/pytest-11/test_listing0/coreboot1" "print"
Name                           Offset     Type         Size
text                           0x0        raw          446
(empty)                        0x200      null         32152

$ "cbfstool" "/tmp/pytest-of-zbyszek/pytest-11/test_listing0/coreboot2.rom" "print"
Name                           Offset     Type         Size
text                           0x0        raw          671
(empty)                        0x300      null         31896

$ rpm -qf /bin/cbfstool
coreboot-utils-4.2-2.fc24.x86_64
coreboot-utils-4.5-2.fc26.x86_64 (the same)



Information forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#817193; Package diffoscope. (Wed, 01 Mar 2017 06:06:05 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Lamb <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Wed, 01 Mar 2017 06:06:05 GMT) (full text, mbox, link).


Message #107 received at 817193@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>
To: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Cc: 817193@bugs.debian.org
Subject: Re: diffoscope: failing tests: test_gzip.py::test_metadata, test_ipk.py::test_metadata, test_java.py::test_diff
Date: Wed, 01 Mar 2017 14:03:52 +0800
clone 817193 -1 -2
found -1 77
retitle -1 diffoscope: test_cbfs::test_listing fails due to unexpected header in output
found -2 77
retitle -2 diffoscope: test_icc::test_diff fails due to locale difference in output
thanks

Zbigniew Jędrzejewski-Szmek wrote:


> With diffoscope-77, I get the following failures:
> (Fedora rawhide amd64 mock, export LC_CTYPE=en_US.utf8 TZ=UTC)

[…]

Thanks; have split this bug accordingly :)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-



Bug 817193 cloned as bugs 856446, 856447 Request was from Chris Lamb <lamby@debian.org> to control@bugs.debian.org. (Wed, 01 Mar 2017 06:06:06 GMT) (full text, mbox, link).


Marked as found in versions diffoscope/77 and reopened. Request was from Chris Lamb <lamby@debian.org> to control@bugs.debian.org. (Wed, 01 Mar 2017 06:06:08 GMT) (full text, mbox, link).


Changed Bug title to 'diffoscope: test_icc::test_diff fails due to locale difference in output' from 'diffoscope: failing tests: test_gzip.py::test_metadata, test_ipk.py::test_metadata, test_java.py::test_diff'. Request was from Chris Lamb <lamby@debian.org> to control@bugs.debian.org. (Wed, 01 Mar 2017 06:06:09 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#856447; Package diffoscope. (Fri, 03 Mar 2017 08:15:09 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Lamb <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Fri, 03 Mar 2017 08:15:09 GMT) (full text, mbox, link).


Message #118 received at 856447@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>
To: 856447@bugs.debian.org
Cc: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Subject: Re: diffoscope: test_icc::test_diff fails due to locale difference in output
Date: Fri, 03 Mar 2017 16:11:57 +0800
tags 856447 + pending
thanks

You are seeing this in Fedora because you don't have the Debian-specific
patch from:

  https://bugs.debian.org/847595

We now skip this test if we detect the patch is not applied:

  https://anonscm.debian.org/git/reproducible/diffoscope.git/commit/?id=fcbcafa1b1cefb08a7ffbd8936f22c5bc6849991

Thanks for reporting!


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-



Added tag(s) pending. Request was from Chris Lamb <lamby@debian.org> to control@bugs.debian.org. (Fri, 03 Mar 2017 08:15:12 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>:
Bug#856447; Package diffoscope. (Fri, 03 Mar 2017 15:45:03 GMT) (full text, mbox, link).


Acknowledgement sent to Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>:
Extra info received and forwarded to list. Copy sent to Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>. (Fri, 03 Mar 2017 15:45:03 GMT) (full text, mbox, link).


Message #125 received at 856447@bugs.debian.org (full text, mbox, reply):

From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
To: Chris Lamb <lamby@debian.org>
Cc: 856447@bugs.debian.org
Subject: Re: diffoscope: test_icc::test_diff fails due to locale difference in output
Date: Fri, 3 Mar 2017 15:15:36 +0000
On Fri, Mar 03, 2017 at 04:11:57PM +0800, Chris Lamb wrote:
>   https://bugs.debian.org/847595
>   https://anonscm.debian.org/git/reproducible/diffoscope.git/commit/?id=fcbcafa1b1cefb08a7ffbd8936f22c5bc6849991

Cool, thanks!

I added a note to our spec file, and we'll just wait for the fixes to
percolate through upstream releases.

Zbyszek



Reply sent to Chris Lamb <lamby@debian.org>:
You have taken responsibility. (Thu, 16 Mar 2017 09:27:26 GMT) (full text, mbox, link).


Notification sent to Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>:
Bug acknowledged by developer. (Thu, 16 Mar 2017 09:27:26 GMT) (full text, mbox, link).


Message #130 received at 856447-close@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>
To: 856447-close@bugs.debian.org
Subject: Bug#856447: fixed in diffoscope 79
Date: Thu, 16 Mar 2017 09:18:59 +0000
Source: diffoscope
Source-Version: 79

We believe that the bug you reported is fixed in the latest version of
diffoscope, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 856447@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated diffoscope package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 16 Mar 2017 09:38:16 +0100
Source: diffoscope
Binary: diffoscope
Architecture: source
Version: 79
Distribution: experimental
Urgency: medium
Maintainer: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 diffoscope - in-depth comparison of files, archives, and directories
Closes: 850758 856446 856447 857610
Changes:
 diffoscope (79) experimental; urgency=medium
 .
   [ Chris Lamb ]
   * Extract SquashFS images in one go rather than per-file, speeding up (eg.)
     Tails ISO comparison by ~10x.
   * Support newer versions of cbfstool to avoid test failures.
     (Closes: #856446)
   * Skip icc test that varies on endian if the Debian-specific patch is not
     present. (Closes: #856447)
   * Compare GIF images using gifbuild. (Closes: #857610)
   * Also interpret "DOS/MBR boot sector" files as ISO images as they may have
     been processed by isohybrid.
   * Progress bar:
     - Hide bar if we are running with --debug mode.
     - Update prior to working on an item so the displayed filename is correct.
 .
   [ Maria Glukhova ]
   * Improve AndroidManifest.xml comparison for APK files.
     - Indicate the AndroidManifest.xml type. (Closes: #850758)
Checksums-Sha1:
 496feb215d728030e2fa59f2fac3b208a9a16db8 2997 diffoscope_79.dsc
 d8d840bf0aeda8568a0edf27ac4e3653eb58e7db 355184 diffoscope_79.tar.xz
 fcbd3d8359b293f85c3cd51a23113b5e4444210a 17076 diffoscope_79_amd64.buildinfo
Checksums-Sha256:
 6d45b881a6769f389a8035cad5f3a7f0b35520661cd9c4b11fc0d7a60d8157cb 2997 diffoscope_79.dsc
 66f22b45b2186e83532a3271b07b783dcf68d69e4140420935c6925c4a92a11d 355184 diffoscope_79.tar.xz
 4979216727fd8d538a2b877cbfa6fd5f8df7e3860739a6902492bd3fbbdf6f86 17076 diffoscope_79_amd64.buildinfo
Files:
 82c74d4cccb1caa650f1666a8c04c3aa 2997 devel optional diffoscope_79.dsc
 88fb8d44784783ea46b115b89a93f162 355184 devel optional diffoscope_79.tar.xz
 0d100c2a8c845473f387ed458795634c 17076 devel optional diffoscope_79_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAljKU3YACgkQHpU+J9Qx
HlgtLRAAkiAY0JtDHAe2YATK7gUfZYGf8TF+iYDAx3rp5TW+pIEZCQRTuNbPoH0k
WyBpd3KA7wpnX3jpl0lp+XgzY7ZVhXhEjE5kDwII1ZZd7bacS1n3E85Rf36pPfD+
5ZVTFx0oVkWN3/GG2lq2kZaiDthnfhh3hEvKWKtn2miWxPoIkWPkbt2mko9eSOUn
/92Ps8rQnBvuhY+0idFQzY1RCz59Q+rQBqySZqA36/0cWruY/Dt2fVR+5HeH157/
YVVxAmpSKwM1mJPEWTR0sCbb79dNSFLW/acK03MqQNTKHrpLPfzD9q9dwfS1HImL
grf3Zm2OPjMRy02nAZgccn7sLTsPba7bt6nbP6T1Og0P7aQdrDrwZgsR2Z1zM9dS
JxSGgkYh6Iadry4zVX3hUdnS8EMdR9dskm4NxQr42IvKJ2ntgZD/nTaEgkNCkj7D
vTJJk/JVTWkYIzVYtvW0AARuGOePZ8Bb3Qadwuj47J7O4L6Zi52sIjZotzkelFSq
q63I8dn6iS3v8zU20XDnJ0lst2jGG8zUi8Iz/2KgQUlgS8+nmCLO+QyNUe4dK/UB
wT/Fm843IksTZvBIms+esXOQ5aIH9dBbXLZH3ea1imKC2Uke2q6hNAMre1oj0iSn
pu0WaXmzlTgKTwc6+1xHAxG+EXFUUcpmJ9if2yKBfifjd1cwYgg=
=Y7Hn
-----END PGP SIGNATURE-----




Reply sent to Chris Lamb <lamby@debian.org>:
You have taken responsibility. (Sun, 18 Jun 2017 09:09:11 GMT) (full text, mbox, link).


Notification sent to Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>:
Bug acknowledged by developer. (Sun, 18 Jun 2017 09:09:11 GMT) (full text, mbox, link).


Message #135 received at 856447-close@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>
To: 856447-close@bugs.debian.org
Subject: Bug#856447: fixed in diffoscope 83
Date: Sun, 18 Jun 2017 09:05:15 +0000
Source: diffoscope
Source-Version: 83

We believe that the bug you reported is fixed in the latest version of
diffoscope, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 856447@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated diffoscope package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 18 Jun 2017 15:34:59 +0800
Source: diffoscope
Binary: diffoscope
Built-For-Profiles: nocheck
Architecture: source
Version: 83
Distribution: unstable
Urgency: medium
Maintainer: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 diffoscope - in-depth comparison of files, archives, and directories
Closes: 780761 833697 850758 856446 856447 857610 857940 858223 858867 859034 859056 859117 861109 861286
Changes:
 diffoscope (83) unstable; urgency=medium
 .
   [ Chris Lamb ]
   * New features:
     * Add comparator for Fontconfig cache files.
   * Bug fixes:
     - Don't fail when run under perversely recursive input files. See
       <https://research.swtch.com/zip> for more information. (Closes: #780761)
     - Prevent a traceback when using --new-file with containers by passing
       progress_name of the Member and not the member itself. (Closes: #861286)
     - Drop passing has_differences around, fixing an issue with generating
       files called '-'.
   * Cleanups & refactoring:
     - Reorder and rename FIFOFeeder arguments to prevent tools incorrectly
       parsing as a SyntaxError.
     - Refactor HTML and text presenters so they fit the same interface.
     - Refactor Presenter to a singleton manager.
     - Split output and configuration of presenters.
     - Prevent abstraction-level violation by defining visual diff support on
       the Presenter classes.
     - Split diffoscope.difference into a feeders module.
     - Document various variables.
     - PEP8-ify and tidy a lot of files.
 .
   [ Ximin Luo ]
   * New features:
     - Add --max-container-depth CLI option.
     - Add various traverse_* methods to Difference.
     - Weigh elements in progress bar by their size.
     - Add a reader for the JSON format.
     - Add a --exclude-command CLI for filtering out long-running commands like
       "readelf --debug-dump=info".
     - Don't show +/- controls for differences with no children.
     - Use unicode chars for the +/- controls instead of punctuation.
   * Bug fixes:
     - Fix --exclude control.tar.gz.
     - Make the progress bar play nicely with --debug.
     - When enforcing max-container-depth, show which internal files differ,
       without showing details.
     - Fix JSON presenter to handle recursion properly.
     - Avoid a ZeroDivisionError in the progress bar
     - Fix create_limited_print_func.
   * Tests:
     - Fix failing tests due to logging global state.
     - Add tips about running with TMPDIR=/run/shm.
   * Cleanups & refactoring:
     - Remove unnecessary "dest" args to argparse.
     - Refactor DirectoryContainer to be more similar to Container.
     - Refactor Container abstract method names.
     - Remove unused imports and tidy up Container.comparisons().
     - rename get_{filtered => adjusted}_members_sizes for consistency.
     - Move tests/comparators/utils up one directory.
     - html-dir: show/hide diff comments which can be very large.
     - Refactor html-dir presenter to a class instance avoiding global state.
     - Move side-by-side and linediff algorithms to difference.py.
     - difference: has_children -> has_visible_children, and take into account
       comments.
     - Move ydiff/linediff from diffoscope.{difference => diff} to group
       unified_diff-related things together
 .
   [ Maria Glukhova ]
   * New features:
     - Add visual comparisons for JPEG, ICO, PNG and static GIF images.
   * Test improvements:
     - Test that external tools providers are being returned when tool is not
       found.
     - Add tests for OutputParserError and ContainerExtractionError.
   * Cleanups & refactoring:
     * Ignore text difference if we have a visual one.
     * Fix link formatting and typo in README.
     * Rename html_output to compute_visual_diffs and explain its purpose.
     * Removed duplicated functions from diff.py.
 .
   [ Mattia Rizzolo ]
   * Export junit-xml style test report when building on Jenkins.
 .
   [ anthraxx ]
   * Extend external Arch Linux tools list.
 .
 diffoscope (82) experimental; urgency=medium
 .
   [ Chris Lamb ]
   * New features:
     - Add support for comparing Pcap files. (Closes: #858867)
     - Add support for .docx and .odt files via docx2txt & odt2txt.
       (Closes: #859056)
     - Add support for PGP files via pgpdump. (Closes: #859034)
     - Add support for comparing Ogg Vorbis files.
   * Bug fixes:
     - Don't crash on invalid archives; print a useful error instead.
       (Closes: #833697)
     - Ensure tests and the runtime environment can locate binaries in
       /usr/sbin (eg. tcpdump)
   * Tests:
     - Ensure that PATH is modified.
     - Ensure @tool_required raises RequiredToolNotFound.
     - Don't assume that /sbin/init exists; locate any /sbin binary manually and
       then test for that. This should prevent FTBFS on travis-ci.org.
     - Show packages installed in report output.
   * Misc:
     - comparators.bzip2: Don't print error output from bzip2 call.
     - comparators.pcap: Show the delta, not the absolute time.
     - Use /usr/share/dpkg/pkg-info.mk over manual calls to dpkg-parsechangelog
       in debian/rules.
     - Document PYTHONPATH usage when running tests in README.Source.
     - Add internal documentation for @tool_required decorator.
 .
   [ beuc@beuc.net ]
   * Display differences in zip platform-specific timestamps. (Closes: #859117)
 .
   [ Ximin Luo ]
   * Add support for R .rds and .rdb object files.
 .
   [ Vagrant Cascadian ]
   * Add support for .dtb (device tree blob) files (Closes: #861109).
 .
 diffoscope (81) experimental; urgency=medium
 .
   [ Chris Lamb ]
   * Correct meaningless "1234-content" metadata when introspecting files
     within archives. This was a regression since #854723 due to the use of
     auto-incrementing on-disk filenames. (Closes: #858223)
   * Refactor get_compressed_content_name.
 .
   [ Ximin Luo ]
   * Improve ISO9660/DOS/MBR check.
 .
 diffoscope (80) experimental; urgency=medium
 .
   * Ensure that we really are using ImageMagick and not, for example, the
     GraphicsMagick compatibility layer installed by
     graphicsmagick-imagemagick-compat. (Closes: #857940)
   * Factor out the unicode decoding of the identify -version output.
   * travis.yml: Don't build tags.
 .
 diffoscope (79) experimental; urgency=medium
 .
   [ Chris Lamb ]
   * Extract SquashFS images in one go rather than per-file, speeding up (eg.)
     Tails ISO comparison by ~10x.
   * Support newer versions of cbfstool to avoid test failures.
     (Closes: #856446)
   * Skip icc test that varies on endian if the Debian-specific patch is not
     present. (Closes: #856447)
   * Compare GIF images using gifbuild. (Closes: #857610)
   * Also interpret "DOS/MBR boot sector" files as ISO images as they may have
     been processed by isohybrid.
   * Progress bar:
     - Hide bar if we are running with --debug mode.
     - Update prior to working on an item so the displayed filename is correct.
 .
   [ Maria Glukhova ]
   * Improve AndroidManifest.xml comparison for APK files.
     - Indicate the AndroidManifest.xml type. (Closes: #850758)
Checksums-Sha1:
 8ee2f30785e4c2eb1509acb9d682eb5ed00fb216 3217 diffoscope_83.dsc
 35b07d8349c804bd8d5028eefc9ccfd17bfe0d0e 641012 diffoscope_83.tar.xz
 8b811f4c2dbb8f9c4be03436326b503ad993d021 6370 diffoscope_83_amd64.buildinfo
Checksums-Sha256:
 487d50c63ee1c67fb304b7244038b935ae756c231f649156a23dc730e8fd1673 3217 diffoscope_83.dsc
 09fc25285eb9ad9ebe6dec80b11c2b3f8c5b7250b3e047be6fefbf0f9149308f 641012 diffoscope_83.tar.xz
 58e3e6df90a0b306f0bb0a419133dd8527ffd7119817a27702bbf87ebaa8c456 6370 diffoscope_83_amd64.buildinfo
Files:
 2f3c4b9bc0f16ea6ac6257ec0283b382 3217 devel optional diffoscope_83.dsc
 dffd5533f8b0bfaf5a5ef59c6ff90f21 641012 devel optional diffoscope_83.tar.xz
 e5852580906da10eb8028c6f4af2c19c 6370 devel optional diffoscope_83_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAllGNGIACgkQHpU+J9Qx
HliPlA//bthdQrAQR8qfpuJCGj4wNS4j8V4b+ZgyCVLzHtBYmgiPjE69W6CTZZNf
pkZlLTtEkbnlbTL39bgKcNp3PAu8+4pWLj7blG2p/XxCnDrNPQvS0GN5zSI+hy+X
7I51641tjTzJQvYXFk7ZfSBAkwbNrsRm87WZySCOhU+TBSBYASBKpqHRqTpB3Csi
bVIW7z0Yli43h5+Ge9lpazp42ZXffBwt4rDhJHt/tKfoXhh2AXRL5Rer93Pih/Ah
akX/yL9LY691nfxNsv04kBNl4bBGBSKQDzsYuF71GO824R61XmsancMGlUT6QByP
czjILbdzbecFC6N3kikVXciwxPhXdAC3uRzGPIAAG+7Acqee7I270KR2nOxVZIoy
uVPPasXs4nK2pR50E9eHXh8P+TZxHHjTpVaYLh8aJwTBdpoGF/DUB1fmMkpZBvBD
5y7WxQlV2a/ZvwF4Hxt2nu5lJjvfb4zZH/2O07pVGnhPi/gmtAxGw8wLWKMaV6NJ
Ov1CtUMYp6nICWFMqumrDLHcZkp5rGlF2DVQy8l+o8A37gkioGQiwseIH5c/rt35
FVNXLkLwj2HfGC8PdVj8R9ZknVv20Tbhmd58pXshcPnSLetEM8pQbXDeiQHz7iEs
jU02FT9ac/EUHGAeKKoolo82/M4SYSV4H5xRaLHj6QMjuLfvXpU=
=2QRm
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Mon, 17 Jul 2017 07:30:12 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Wed May 17 14:02:05 2023; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.