Debian Bug report logs - #856133
shiboken FTBFS on i386/armel/armhf: other_collector_external_operator test failed

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Adrian Bunk <bunk@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: shiboken FTBFS on i386/armel/armhf: other_collector_external_operator test failed

Date: Sat, 25 Feb 2017 16:07:03 +0200

Source: shiboken
Version: 1.2.2-3
Severity: serious

https://buildd.debian.org/status/package.php?p=shiboken&suite=sid

...
 41/169 Test  #41: other_collector_external_operator ..................................***Failed    0.10 sec
.F
======================================================================
FAIL: testOtherReversal (__main__.CollectorOtherObjectType)
Collector << OtherObjectType # libother << operator
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/«PKGBUILDDIR»/tests/otherbinding/collector_external_operator_test.py", line 49, in testOtherReversal
    self.assertEqual(collector.items()[0], obj.identifier() * 2)
AssertionError: 4036055648L != 8331022944L

----------------------------------------------------------------------
Ran 2 tests in 0.001s

FAILED (failures=1)
[43124 refs]
...
99% tests passed, 1 tests failed out of 169

Total Test time (real) =   2.81 sec

The following tests FAILED:
	 41 - other_collector_external_operator (Failed)
Errors while running CTest
Makefile:130: recipe for target 'test' failed
make[2]: *** [test] Error 8

Message #10 received at 856133@bugs.debian.org (full text, mbox, reply):

From: gregor herrmann <gregoa@debian.org>

To: 856133@bugs.debian.org

Subject: Re: Bug#856133: shiboken FTBFS on i386/armel/armhf: other_collector_external_operator test failed

Date: Sat, 4 Mar 2017 20:06:36 +0100

[Message part 1 (text/plain, inline)]

On Sat, 25 Feb 2017 16:07:03 +0200, Adrian Bunk wrote:

> Source: shiboken
> Version: 1.2.2-3
> Severity: serious
> 
> https://buildd.debian.org/status/package.php?p=shiboken&suite=sid
> 

FWIW, the package currently builds fine for me in an i386 sid
cowbuilder chroot (and an amd64 machine).


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at/ - Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Zueriwest: So wie denn i daem Summer

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 856133@bugs.debian.org (full text, mbox, reply):

From: Gilles Filippini <pini@debian.org>

To: 856133@bugs.debian.org

Subject: Re: Bug#856133: shiboken FTBFS on i386/armel/armhf: other_collector_external_operator test failed

Date: Sat, 25 Mar 2017 17:20:18 +0100

[Message part 1 (text/plain, inline)]

On Sat, 4 Mar 2017 20:06:36 +0100 gregor herrmann <gregoa@debian.org> wrote:
> On Sat, 25 Feb 2017 16:07:03 +0200, Adrian Bunk wrote:
> 
> > Source: shiboken
> > Version: 1.2.2-3
> > Severity: serious
> > 
> > https://buildd.debian.org/status/package.php?p=shiboken&suite=sid
> > 
> 
> FWIW, the package currently builds fine for me in an i386 sid
> cowbuilder chroot (and an amd64 machine).

Strangely it builds fine in an i386 sbuild chroot, but it fails
reproducibly on porter box barriere.debian.org.

Thanks,

_g.

[signature.asc (application/pgp-signature, attachment)]

Message #20 received at 856133@bugs.debian.org (full text, mbox, reply):

From: Gilles Filippini <pini@debian.org>

To: 856133@bugs.debian.org

Cc: odyx@debian.org

Subject: Re: Bug#856133: shiboken FTBFS on i386/armel/armhf: other_collector_external_operator test failed

Date: Sun, 26 Mar 2017 16:48:13 +0200

[Message part 1 (text/plain, inline)]

Control: tags -1 + patch

Gilles Filippini a écrit le 25/03/2017 à 17:20 :
> On Sat, 4 Mar 2017 20:06:36 +0100 gregor herrmann <gregoa@debian.org> wrote:
>> On Sat, 25 Feb 2017 16:07:03 +0200, Adrian Bunk wrote:
>>
>>> Source: shiboken
>>> Version: 1.2.2-3
>>> Severity: serious
>>>
>>> https://buildd.debian.org/status/package.php?p=shiboken&suite=sid
>>>
>>
>> FWIW, the package currently builds fine for me in an i386 sid
>> cowbuilder chroot (and an amd64 machine).
> 
> Strangely it builds fine in an i386 sbuild chroot, but it fails
> reproducibly on porter box barriere.debian.org.

The failing testcase seems flawed:
> class CollectorOtherObjectType(unittest.TestCase):
>     '''Test cases for Collector << OtherObjectType'''
>     ...
>     def testOtherReversal(self):
>         '''Collector << OtherObjectType # libother << operator'''
>         collector = Collector()
>         obj = OtherObjectType()
>         collector << obj
>         self.assertEqual(collector.items()[0], obj.identifier() * 2)

Collector stores unsigned long ids:
> class LIBSAMPLE_API Collector
> {
> public:
>     Collector() {}
>     virtual ~Collector() {}
> 
>     void clear();
> 
>     Collector& operator<<(unsigned long item);
> 
>     Collector& operator<<(const ObjectType *);
> 
>     std::list<unsigned long> items();
>     int size();
> ...

OtherObjectType inherits identifier() from ObjectType:
>     inline unsigned long identifier() const { return reinterpret_cast<unsigned long>(this); }

And << operator for OtherObjectType strores the objects's id * 2 into the collector:
> Collector&
> operator<<(Collector& collector, const OtherObjectType& obj)
> {
>     std::cout << sizeof(&obj) << std::endl;
>     collector << obj.identifier()*2;
>     return collector;
> }

The problem is that the *2 operation may causes an overflow when the results is > ULONG_MAX.
To fix the test, either drop the *2, or store unsigned long long into Collector.items(). The easiest being the former, IMHO.
Patch attached.

Thanks,

_g.

[shiboken-1.2.2-3.1.debdiff (text/plain, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #27 received at 856133@bugs.debian.org (full text, mbox, reply):

From: Ivo De Decker <ivodd@debian.org>

To: Gilles Filippini <pini@debian.org>

Cc: 856133@bugs.debian.org, odyx@debian.org

Subject: Re: Bug#856133: shiboken FTBFS on i386/armel/armhf: other_collector_external_operator test failed

Date: Thu, 13 Apr 2017 17:55:54 +0200

[Message part 1 (text/plain, inline)]

Hi,

On Sun, Mar 26, 2017 at 04:48:13PM +0200, Gilles Filippini wrote:
> The problem is that the *2 operation may causes an overflow when the results is > ULONG_MAX.
> To fix the test, either drop the *2, or store unsigned long long into Collector.items(). The easiest being the former, IMHO.
> Patch attached.

Thanks for the patch!

I prepared an NMU. Debdiff attached.

Cheers,

Ivo

[shiboken_856133.debdiff (text/plain, attachment)]

Message #32 received at 856133-close@bugs.debian.org (full text, mbox, reply):

From: Ivo De Decker <ivodd@debian.org>

To: 856133-close@bugs.debian.org

Subject: Bug#856133: fixed in shiboken 1.2.2-3.1

Date: Thu, 13 Apr 2017 16:05:58 +0000

Source: shiboken
Source-Version: 1.2.2-3.1

We believe that the bug you reported is fixed in the latest version of
shiboken, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 856133@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ivo De Decker <ivodd@debian.org> (supplier of updated shiboken package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 13 Apr 2017 17:22:45 +0200
Source: shiboken
Binary: shiboken shiboken-doc libshiboken1.2v5 libshiboken-py3-1.2v5 libshiboken-dev shiboken-dbg
Architecture: source
Version: 1.2.2-3.1
Distribution: unstable
Urgency: medium
Maintainer: Debian Python Modules Team <python-modules-team@lists.alioth.debian.org>
Changed-By: Ivo De Decker <ivodd@debian.org>
Description:
 libshiboken-dev - development files for the shiboken bindings generator library
 libshiboken-py3-1.2v5 - CPython3 bindings generator for C++ libraries - shared library
 libshiboken1.2v5 - CPython bindings generator for C++ libraries - shared library
 shiboken   - CPython bindings generator for C++ libraries
 shiboken-dbg - debugging symbols for shiboken and its library
 shiboken-doc - CPython bindings generator for C++ libraries documentation
Closes: 856133
Changes:
 shiboken (1.2.2-3.1) unstable; urgency=medium
 .
   [ Ivo De Decker ]
   * Non-maintainer upload.
 .
   [ Gilles Filippini ]
   * New patch fix-collector_external_operator_test.patch to fix an
     unsigned long overflow in testcase collector_external_operator_test.py
     Fixes FTBFS (Closes: #856133)
Checksums-Sha1:
 ecf007702c68804aca16d6d80ca3bc6c6777c6d9 2603 shiboken_1.2.2-3.1.dsc
 eca1385f1358c9b6f08b579c8421289b48114086 16548 shiboken_1.2.2-3.1.debian.tar.xz
Checksums-Sha256:
 835b5a504b46a9379a0497f82e371ff76e6a76e9e47d29880a3dd790ce5fe6c8 2603 shiboken_1.2.2-3.1.dsc
 bff048543c54d4c73b9873d2ddac9fdc7e0d0dd17c880bcbb31a2072c971a9d6 16548 shiboken_1.2.2-3.1.debian.tar.xz
Files:
 19868523f9928bd067f16989ac2b011f 2603 devel optional shiboken_1.2.2-3.1.dsc
 0bef25db944eb1047a8922f7ee472f08 16548 devel optional shiboken_1.2.2-3.1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJY757nAAoJEKxAu1iXBOr8KoAP/iktqQR8BDAwFGKeqb6gr0hL
WOwnmB+nDTQ0lkJCrClP5GcqMNiOpQIRfnzfUVz78zFnMkCSQgM18Phyj6FJ1Dna
RIWbu+8ca9056yfaGlTGA+weX103WVNYkThiFMI0yt4t2HBHe7a3h/1uLnzlKhsG
eYMxhpelakzB4ArhzbC8I4phxGSwqBEeA9dsufSZruDhGY8vVxWqPB1rVBB3kPth
nkzR5C7ZwfrwvnP/yU6Rri6s0j2tBWAu4LpxmPVctV7Gq9x4JhravPaWblWuxJzQ
23n1c1F28id/GQ21E94SJTOeoMxlAVsblG4czZ4QHSs59TznA3as2naC6++Vdg9n
0Iqf6Ja9FAOYA1746zUBQHNt1kH1cd/RMOo/uLmF0jSblkIYnx3MpQjpeLG8GPKZ
ahRh+amciIVD7sMkcyWljYfGBKMQBaqHfNbe+AF90Zt3dnTpKT/19h6P2SutyuP8
Yeub769S3ROHn9XvxuCsLBIST+ZOfykfIcUCyYrfycut+C1qZT5scJ4yzWK2Zc2k
iFdh0fMX/4NNpE5NmfuMjjh5Ou0ofPgjcUQI1JYn97k+OxjyPFjqCFLO69nPZRdC
Ww8PkREVBsxCxPX2/zLQ67LkR83Sb3Ux4b86bgNyp7xQYB8EpO1FH+KCq4l5I/oX
wwC7FMWRNYkeIIk3kH5f
=xNiE
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.