Debian Bug report logs - #855233
diffoscope: Crashes when comparing bad JSON on Python pre-3.5

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Brett Smith <debbug@brettcsmith.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: diffoscope: Crashes when comparing bad JSON on Python pre-3.5

Date: Wed, 15 Feb 2017 14:47:01 -0500

[Message part 1 (text/plain, inline)]

Package: diffoscope
Severity: normal
Tags: upstream patch

Dear Maintainer,

Commit 50be22f checks for JSON decoding errors by catching
json.JSONDecodeError.  This class was introduced in Python 3.5.  Earlier
version of the json module simply raised ValueError in the same situation.

When running tests on earlier versions of Python, test_json.test_invalid
crashes when it fails to find json.JSONDecodeError.

ValueError is the base class of json.JSONDecodeError, so catching that works
as expected on Python 3.5 and older versions.  The attached patch makes that
change and sees the test pass on older versions of Python.

Thanks,

-- System Information:
Debian Release: 8.7
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-0.bpo.1-amd64 (SMP w/4 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=UTF-8) (ignored: LC_ALL set to en_US.utf8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

[0001-comparators.json-Catch-bad-JSON-errors-on-Python-pre.patch (text/x-diff, attachment)]

Message #8 received at 855233@bugs.debian.org (full text, mbox, reply):

From: Mattia Rizzolo <mattia@debian.org>

To: Brett Smith <debbug@brettcsmith.org>, 855233@bugs.debian.org

Subject: Re: Bug#855233: diffoscope: Crashes when comparing bad JSON on Python pre-3.5

Date: Wed, 15 Feb 2017 21:13:28 +0100

[Message part 1 (text/plain, inline)]

Control: tag -1 pending

On Wed, Feb 15, 2017 at 02:47:01PM -0500, Brett Smith wrote:
> Package: diffoscope
> Severity: normal
> Tags: upstream patch

Thank you for your bug and patch, which I merged via IRC before even
noticing this bug report :)

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 855233-close@bugs.debian.org (full text, mbox, reply):

From: Mattia Rizzolo <mattia@debian.org>

To: 855233-close@bugs.debian.org

Subject: Bug#855233: fixed in diffoscope 78

Date: Sun, 26 Feb 2017 21:04:30 +0000

Source: diffoscope
Source-Version: 78

We believe that the bug you reported is fixed in the latest version of
diffoscope, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 855233@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mattia Rizzolo <mattia@debian.org> (supplier of updated diffoscope package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 26 Feb 2017 17:26:48 +0100
Source: diffoscope
Binary: diffoscope
Architecture: source
Version: 78
Distribution: unstable
Urgency: medium
Maintainer: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>
Changed-By: Mattia Rizzolo <mattia@debian.org>
Description:
 diffoscope - in-depth comparison of files, archives, and directories
Closes: 855169 855233 855239
Changes:
 diffoscope (78) unstable; urgency=medium
 .
   [ Brett Smith ]
   * comparators.json:
     + Catch bad JSON errors on Python pre-3.5.  Closes: #855233
 .
   [ Chris Lamb ]
   * tests:
     + Move normalize_zeros to more generic `utils.data` module.
     + Fix tests that call xxd fail on jessie due to output change.
       Closes: #855239
 .
   [ Ed Maste ]
   * comparators.directory:
     + Assume BSD-style stat(1) on FreeBSD.  Closes: #855169
Checksums-Sha1:
 dbca0cf40169c42e079c2c1c1e4199d15b423b5e 2972 diffoscope_78.dsc
 6502474142f19b2394d70b8d8937152f897d85bb 349612 diffoscope_78.tar.xz
 3da2126418e31dae8bd7a7e46ed78f5879ee8cc7 16205 diffoscope_78_amd64.buildinfo
Checksums-Sha256:
 b45d7e2c6fccf9ccd52dc3c5cb7cef263b3eba378d790e9357b41ac0407b7d3f 2972 diffoscope_78.dsc
 6ae6a46123d5ce97062a24e94cd3e9aab15d8297019fa5a0830c46934ab54d52 349612 diffoscope_78.tar.xz
 4f8756aababb01106afaa322516769f33d791f6e9821e62eb479440e0adc9b7c 16205 diffoscope_78_amd64.buildinfo
Files:
 ab383677f26b502dd0483c282aa31f9d 2972 devel optional diffoscope_78.dsc
 222ea64cc6c31a32372fce5eef028128 349612 devel optional diffoscope_78.tar.xz
 9639240d6f28ed0772efc8baf04b9748 16205 devel optional diffoscope_78_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEi3hoeGwz5cZMTQpICBa54Yx2K60FAlizODUACgkQCBa54Yx2
K63CYg//UJjqls2B6UsRJ4VkYvNkzMtptLfJdxNICpe6sjJZvxXA7I1ZbivVCnTi
ziTxG/KQYmLPyzzP17/TX8pYRHpOp0kXeZBQSZwOHAoWZk06rht8J0jJI6f6rWC8
brtLJTRoELCU1KtL/FuWhFpypXnQCnoyhuRtXWxPJbhwVwIP6LAB729Wlj76vlRq
yOcydhT19jf+0dNHHX5I3w5HgCAzW6CnJ10TI1fgDHOi41q97ev+XhJiqvlQ8QlA
e+SY4MXF12gSPHgybNGO86w92i+b7P9W0Blqq3wuuOgUPDJNSs0+5Q90ptcPOQDV
MiJBV8CiusPmtyuXZPHd6YpVTIz68t+3oOjk8/7idO1fVsSfX++sMOm2y/tCbssL
QvIvLG6WluqFXRgqpf75Z7rDUKHl1p6J/084K7hH78Sx5QtaZB1hPKE79V9SufST
onHloqVxxp78/3ZPzXB7Ze93oCklANf4CDnSn3H+fg6mLwFXNZEMT927TgxwFrdG
82XVcVx6+Ft3byYPee1GxhkTHVkTJU88UtkSxaedpaLNKlCAtibXwoJHpmeM6pPF
kRUiZ2dlYJRZhYn4PCk1bJfoEuTB3rvmYckxqrebZllWTwDuvDfXXZnUVytj+Aj+
1YMysy6XTLWVkBO5c03yKrrhDtcWkmEe/3sF3Mdp/tCNHvUeXao=
=kWZp
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.