Debian Bug report logs - #855169
diffoscope: use BSD-style stat on FreeBSD

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Ed Maste <emaste@freebsd.org>

To: submit@bugs.debian.org

Subject: diffoscope: use BSD-style stat on FreeBSD

Date: Tue, 14 Feb 2017 16:56:13 -0500

[Message part 1 (text/plain, inline)]

Package: diffoscope
Version: 77

From GNU stat output diffoscope filters those parts that are allowed
to change. The BSD stat(1) command does not match the output format
and reports undesired differences:

% python3 setup.py test --pytest-args="-rsx -l -vv
tests/test_main.py::test_no_differences_directories"
...
>       assert ret == 0
E       assert 1 == 0

capsys     = <_pytest.capture.CaptureFixture object at 0x806b08c18>
create_dir = <function
test_no_differences_directories.<locals>.create_dir at 0x808576b70>
err        = ''
out        = '---
/tmp/pytest-of-emaste/pytest-13/test_no_differences_directorie0/a\n+++
/tmp/pytest-of-emaste/pytest-13/test_no_di...14 21:49:59 2017" "Jan  1
00:00:00 1970" 32768 8 0
/tmp/pytest-of-emaste/pytest-13/test_no_differences_directorie0/b\n'
ret        = 1
...

BSD stat accepts a -f argument to specify the output format so the
filtering can be avoided altogether.

Attached patch (also available as
https://github.com/emaste/diffoscope/commit/e709c11212a18105f3b6862d5ed20de61038b71a)
is my approach at addressing this.

[diffoscope-bsd-stat.diff (text/plain, attachment)]

Message #10 received at 855169@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 855169@bugs.debian.org

Cc: Ed Maste <emaste@freebsd.org>

Subject: Re: diffoscope: use BSD-style stat on FreeBSD

Date: Sat, 18 Feb 2017 13:05:02 +1300

tags 855169 + pending
thanks

Applied; many thanks. :)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #17 received at 855169-close@bugs.debian.org (full text, mbox, reply):

From: Mattia Rizzolo <mattia@debian.org>

To: 855169-close@bugs.debian.org

Subject: Bug#855169: fixed in diffoscope 78

Date: Sun, 26 Feb 2017 21:04:30 +0000

Source: diffoscope
Source-Version: 78

We believe that the bug you reported is fixed in the latest version of
diffoscope, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 855169@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mattia Rizzolo <mattia@debian.org> (supplier of updated diffoscope package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 26 Feb 2017 17:26:48 +0100
Source: diffoscope
Binary: diffoscope
Architecture: source
Version: 78
Distribution: unstable
Urgency: medium
Maintainer: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>
Changed-By: Mattia Rizzolo <mattia@debian.org>
Description:
 diffoscope - in-depth comparison of files, archives, and directories
Closes: 855169 855233 855239
Changes:
 diffoscope (78) unstable; urgency=medium
 .
   [ Brett Smith ]
   * comparators.json:
     + Catch bad JSON errors on Python pre-3.5.  Closes: #855233
 .
   [ Chris Lamb ]
   * tests:
     + Move normalize_zeros to more generic `utils.data` module.
     + Fix tests that call xxd fail on jessie due to output change.
       Closes: #855239
 .
   [ Ed Maste ]
   * comparators.directory:
     + Assume BSD-style stat(1) on FreeBSD.  Closes: #855169
Checksums-Sha1:
 dbca0cf40169c42e079c2c1c1e4199d15b423b5e 2972 diffoscope_78.dsc
 6502474142f19b2394d70b8d8937152f897d85bb 349612 diffoscope_78.tar.xz
 3da2126418e31dae8bd7a7e46ed78f5879ee8cc7 16205 diffoscope_78_amd64.buildinfo
Checksums-Sha256:
 b45d7e2c6fccf9ccd52dc3c5cb7cef263b3eba378d790e9357b41ac0407b7d3f 2972 diffoscope_78.dsc
 6ae6a46123d5ce97062a24e94cd3e9aab15d8297019fa5a0830c46934ab54d52 349612 diffoscope_78.tar.xz
 4f8756aababb01106afaa322516769f33d791f6e9821e62eb479440e0adc9b7c 16205 diffoscope_78_amd64.buildinfo
Files:
 ab383677f26b502dd0483c282aa31f9d 2972 devel optional diffoscope_78.dsc
 222ea64cc6c31a32372fce5eef028128 349612 devel optional diffoscope_78.tar.xz
 9639240d6f28ed0772efc8baf04b9748 16205 devel optional diffoscope_78_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEi3hoeGwz5cZMTQpICBa54Yx2K60FAlizODUACgkQCBa54Yx2
K63CYg//UJjqls2B6UsRJ4VkYvNkzMtptLfJdxNICpe6sjJZvxXA7I1ZbivVCnTi
ziTxG/KQYmLPyzzP17/TX8pYRHpOp0kXeZBQSZwOHAoWZk06rht8J0jJI6f6rWC8
brtLJTRoELCU1KtL/FuWhFpypXnQCnoyhuRtXWxPJbhwVwIP6LAB729Wlj76vlRq
yOcydhT19jf+0dNHHX5I3w5HgCAzW6CnJ10TI1fgDHOi41q97ev+XhJiqvlQ8QlA
e+SY4MXF12gSPHgybNGO86w92i+b7P9W0Blqq3wuuOgUPDJNSs0+5Q90ptcPOQDV
MiJBV8CiusPmtyuXZPHd6YpVTIz68t+3oOjk8/7idO1fVsSfX++sMOm2y/tCbssL
QvIvLG6WluqFXRgqpf75Z7rDUKHl1p6J/084K7hH78Sx5QtaZB1hPKE79V9SufST
onHloqVxxp78/3ZPzXB7Ze93oCklANf4CDnSn3H+fg6mLwFXNZEMT927TgxwFrdG
82XVcVx6+Ft3byYPee1GxhkTHVkTJU88UtkSxaedpaLNKlCAtibXwoJHpmeM6pPF
kRUiZ2dlYJRZhYn4PCk1bJfoEuTB3rvmYckxqrebZllWTwDuvDfXXZnUVytj+Aj+
1YMysy6XTLWVkBO5c03yKrrhDtcWkmEe/3sF3Mdp/tCNHvUeXao=
=kWZp
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.