Report forwarded
to Android Tools Maintainers <android-tools-devel@lists.alioth.debian.org>: Bug#853310; Package src:android-platform-build.
(Tue, 31 Jan 2017 09:33:44 GMT) (full text, mbox, link).
Acknowledgement sent
to Matthias Klose <doko@debian.org>:
New Bug report received and forwarded. Copy sent to Android Tools Maintainers <android-tools-devel@lists.alioth.debian.org>.
(Tue, 31 Jan 2017 09:33:44 GMT) (full text, mbox, link).
Package: src:android-platform-build
Version: 1:7.0.0+r1-2
Severity: normal
Tags: sid buster
User: debian-gcc@lists.debian.org
Usertags: ftbfs-gcc-7
Please keep this issue open in the bug tracker for the package it
was filed for. If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.
The package fails to build in a test rebuild on at least amd64 with
gcc-7/g++-7, but succeeds to build with gcc-6/g++-6. The
severity of this report may be raised before the buster release.
There is no need to fix this issue in time for the stretch release.
The full build log can be found at:
http://people.debian.org/~doko/logs/gcc7-20170126/android-platform-build_7.0.0+r1-2_unstable_gcc7.log
The last lines of the build log are at the end of this report.
To build with GCC 7, either set CC=gcc-7 CXX=g++-7 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.
apt-get -t=experimental install g++
Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-7/porting_to.html
[...]
dpkg-source: info: building android-platform-build using existing ./android-platform-build_7.0.0+r1.orig.tar.xz
dpkg-source: info: building android-platform-build in android-platform-build_7.0.0+r1-2.debian.tar.xz
dpkg-source: info: building android-platform-build in android-platform-build_7.0.0+r1-2.dsc
debian/rules build
dh build --with javahelper
dh_testdir
dh_update_autotools_config
dh_autoreconf
dh_auto_configure
jh_linkjars
debian/rules override_dh_auto_build-arch
make[1]: Entering directory '/<<BUILDDIR>>/android-platform-build-7.0.0+r1'
make -f debian/zipalign.mk
make[2]: Entering directory '/<<BUILDDIR>>/android-platform-build-7.0.0+r1'
g++ tools/zipalign/ZipAlign.cpp tools/zipalign/ZipEntry.cpp tools/zipalign/ZipFile.cpp -o zipalign -g -O2 -fdebug-prefix-map=/<<BUILDDIR>>/android-platform-build-7.0.0+r1=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -DNDEBUG -I/usr/include/android -Wl,-z,relro -fPIC -Wl,-rpath=/usr/lib/x86_64-linux-gnu/android -lpthread -lzopfli -lz -L/usr/lib/x86_64-linux-gnu/android -lutils -llog -landroidfw
In file included from tools/zipalign/ZipFile.h:24:0,
from tools/zipalign/ZipAlign.cpp:20:
/usr/include/android/utils/Vector.h: In member function 'const android::Vector<T>& android::Vector<TYPE>::operator=(const android::Vector<TYPE>&) const':
/usr/include/android/utils/Vector.h:251:64: error: no matching function for call to 'android::Vector<TYPE>::operator=(const android::VectorImpl&) const'
VectorImpl::operator = (static_cast<const VectorImpl&>(rhs));
^
In file included from /usr/include/android/utils/Vector.h:26:0,
from tools/zipalign/ZipFile.h:24,
from tools/zipalign/ZipAlign.cpp:20:
/usr/include/android/utils/VectorImpl.h:56:29: note: candidate: android::VectorImpl& android::VectorImpl::operator=(const android::VectorImpl&) <near match>
VectorImpl& operator = (const VectorImpl& rhs);
^~~~~~~~
/usr/include/android/utils/VectorImpl.h:56:29: note: passing 'const android::Vector<TYPE>*' as 'this' argument discards qualifiers
In file included from tools/zipalign/ZipFile.h:24:0,
from tools/zipalign/ZipFile.cpp:26:
/usr/include/android/utils/Vector.h: In member function 'const android::Vector<T>& android::Vector<TYPE>::operator=(const android::Vector<TYPE>&) const':
/usr/include/android/utils/Vector.h:251:64: error: no matching function for call to 'android::Vector<TYPE>::operator=(const android::VectorImpl&) const'
VectorImpl::operator = (static_cast<const VectorImpl&>(rhs));
^
In file included from /usr/include/android/utils/Vector.h:26:0,
from tools/zipalign/ZipFile.h:24,
from tools/zipalign/ZipFile.cpp:26:
/usr/include/android/utils/VectorImpl.h:56:29: note: candidate: android::VectorImpl& android::VectorImpl::operator=(const android::VectorImpl&) <near match>
VectorImpl& operator = (const VectorImpl& rhs);
^~~~~~~~
/usr/include/android/utils/VectorImpl.h:56:29: note: passing 'const android::Vector<TYPE>*' as 'this' argument discards qualifiers
debian/zipalign.mk:10: recipe for target 'build' failed
make[2]: *** [build] Error 1
make[2]: Leaving directory '/<<BUILDDIR>>/android-platform-build-7.0.0+r1'
debian/rules:20: recipe for target 'zipalign' failed
make[1]: *** [zipalign] Error 2
make[1]: Leaving directory '/<<BUILDDIR>>/android-platform-build-7.0.0+r1'
debian/rules:32: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
Severity set to 'important' from 'normal'
Request was from Matthias Klose <doko@debian.org>
to control@bugs.debian.org.
(Tue, 20 Jun 2017 14:30:23 GMT) (full text, mbox, link).
Severity set to 'serious' from 'important'
Request was from Matthias Klose <doko@debian.org>
to control@bugs.debian.org.
(Fri, 04 Aug 2017 20:03:15 GMT) (full text, mbox, link).
No longer marked as found in versions android-platform-build/1:7.0.0+r1-2.
Request was from Adrian Bunk <bunk@debian.org>
to control@bugs.debian.org.
(Fri, 18 Aug 2017 22:06:03 GMT) (full text, mbox, link).
Marked as found in versions android-platform-system-core/1:7.0.0+r1-2.
Request was from Adrian Bunk <bunk@debian.org>
to control@bugs.debian.org.
(Fri, 18 Aug 2017 22:06:04 GMT) (full text, mbox, link).
Merged 853310853311853312
Request was from Adrian Bunk <bunk@debian.org>
to control@bugs.debian.org.
(Fri, 18 Aug 2017 22:06:06 GMT) (full text, mbox, link).
Added indication that 853310 affects src:android-platform-build and src:android-platform-frameworks-base
Request was from Adrian Bunk <bunk@debian.org>
to control@bugs.debian.org.
(Fri, 18 Aug 2017 22:06:07 GMT) (full text, mbox, link).
Removed indication that 853310 affects src:android-platform-build and src:android-platform-frameworks-base
Added indication that 853310 affects src:android-platform-build,src:android-platform-frameworks-base
Request was from Adrian Bunk <bunk@debian.org>
to control@bugs.debian.org.
(Thu, 04 Jan 2018 17:03:10 GMT) (full text, mbox, link).
Added tag(s) patch.
Request was from Paul Wise <pabs@debian.org>
to control@bugs.debian.org.
(Sun, 20 May 2018 08:06:04 GMT) (full text, mbox, link).
Added tag(s) ftbfs.
Request was from Adrian Bunk <bunk@debian.org>
to control@bugs.debian.org.
(Fri, 22 Jun 2018 16:39:45 GMT) (full text, mbox, link).
Acknowledgement sent
to Raphael Hertzog <hertzog@debian.org>:
Extra info received and forwarded to list. Copy sent to Android Tools Maintainers <android-tools-devel@lists.alioth.debian.org>.
(Tue, 04 Sep 2018 08:51:03 GMT) (full text, mbox, link).
Subject: Re: Bug#853310: android-platform-system-core: ftbfs with GCC-7
Date: Tue, 4 Sep 2018 10:49:43 +0200
Hello,
this bug on android-platform-system-core is the reason why
apktool got dropped from Debian Testing. I would like it to go back
to Debian Testing.
I saw that the package has many updates in the git repository.
I guess the FTBFS issue is fixed in the new upstream version that you
packaged in git. Can you thus release the update and get back to a better
state ?
Let me know if I can help (for example if you need sponsorship).
Cheers,
--
Raphaël Hertzog ◈ Debian Developer
Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/
Acknowledgement sent
to 殷啟聰 | Kai-Chung Yan <seamlikok@gmail.com>:
Extra info received and forwarded to list. Copy sent to Android Tools Maintainers <android-tools-devel@lists.alioth.debian.org>.
(Mon, 10 Sep 2018 17:00:04 GMT) (full text, mbox, link).
Hello Raphael,
Sorry for being dormant on the matter. We had been in the process of updating the whole SDK suite to Oreo but it is blocked by an upload of this package. The latest update produces several new packages so I don't have the permission to upload it, and the DDs in the team were too busy as well.
It would be wonderful if you could sponsor the upload. We have prepared everything on Salsa, all you need to do is to change "UNRELEASED" to "experimental" in the changelog. The RFS [1] has more details.
Cheers,
Kai-Chung Yan
[1]: https://alioth-lists.debian.net/pipermail/android-tools-devel/2018q3/003388.html
Acknowledgement sent
to Raphael Hertzog <hertzog@debian.org>:
Extra info received and forwarded to list. Copy sent to Android Tools Maintainers <android-tools-devel@lists.alioth.debian.org>.
(Tue, 11 Sep 2018 09:51:03 GMT) (full text, mbox, link).
Hello,
On Tue, 11 Sep 2018, 殷啟聰 | Kai-Chung Yan wrote:
> Sorry for being dormant on the matter. We had been in the process of
> updating the whole SDK suite to Oreo but it is blocked by an upload of
> this package. The latest update produces several new packages so I don't
> have the permission to upload it, and the DDs in the team were too busy
> as well.
Who are the DD in the team? Are there other contributors currently
following the process to become a DD?
> It would be wonderful if you could sponsor the upload. We have prepared
> everything on Salsa, all you need to do is to change "UNRELEASED" to
> "experimental" in the changelog. The RFS [1] has more details.
It would have helped if you had given me the URL of the repository.
Anyway, I'm willing to sponsor the update (even though I don't know much
about Android Tools) but I have a few comments:
1/ your RFS mentions the need to do a "stage1" upload but you actually
manually dropped the package and the build dependencies that were tagged
stage1, why did you do that?
2/ I don't understand why you replace "android-tools-mkbootimg" with
"mkbootimg". The latter package has a very generic name while the former
was rather explicit. It looks like a step backwards. Yes, now it matches
the name of the executable inside the package, but I'm not sure it
justifies introducing a new package and dealing with a transitional
package. What was your rationale? And you should have documented your
rationale in the commit messages and in the changelog entry.
Cheers,
--
Raphaël Hertzog ◈ Debian Developer
Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/
Acknowledgement sent
to 殷啟聰 | Kai-Chung Yan <seamlikok@gmail.com>:
Extra info received and forwarded to list. Copy sent to Android Tools Maintainers <android-tools-devel@lists.alioth.debian.org>.
(Thu, 13 Sep 2018 13:51:03 GMT) (full text, mbox, link).
> Who are the DD in the team? Are there other contributors currently
> following the process to become a DD?
Mostly Hans (eighthave) is the DD involved a lot, and Markus (apo) occasionally helps. I am currently going through the process of becoming a DD but it is going very slowly.
> It would have helped if you had given me the URL of the repository.
> Anyway, I'm willing to sponsor the update (even though I don't know much
> about Android Tools) but I have a few comments:
Thank you for the sponsor, it will help us a lot!
The repository is at <https://salsa.debian.org/android-tools-team/android-platform-system-core>. Sorry about that, I thought it was too trivial.
> 1/ your RFS mentions the need to do a "stage1" upload but you actually
> manually dropped the package and the build dependencies that were tagged
> stage1, why did you do that?
"stage1" is everything but "fastboot". "fastboot" depends on some libraries in "android-platform-system-extras" which also depend on libraries in this source package, making a circular dependency. We are going to upload the full version after "android-platform-system-extras" gets uploaded.
"buildd" does not support staged uploads, so we have to manually remove "fastboot", hence the "~stage1" part of the version.
> 2/ I don't understand why you replace "android-tools-mkbootimg" with
> "mkbootimg". The latter package has a very generic name while the former
> was rather explicit. It looks like a step backwards. Yes, now it matches
> the name of the executable inside the package, but I'm not sure it
> justifies introducing a new package and dealing with a transitional
> package. What was your rationale? And you should have documented your
> rationale in the commit messages and in the changelog entry.
We have renamed "adb" and "fastboot" as well, and we are doing the same for "mkbootimg" this time. For the moment, the names of these programs have been well-known and exclusive in the society, so I don't think the "android-tools-" prefix is necessary. For a name, they seem not that generic to me as I've seen something more so (e.g. "docker" and "node", which did caused name conflicts in Debian).
Another reason has been mentioned by you: They match the executables.
There are other executables built by this package with names more generic, like "img2simg" and "append2simg". We put them together in a single package (as you can see in the changelog") because they belong to the same subproject "libsparse". Unfortunately "mkbootimg" lives on its own so I just make it its own package.
Acknowledgement sent
to Raphael Hertzog <hertzog@debian.org>:
Extra info received and forwarded to list. Copy sent to Android Tools Maintainers <android-tools-devel@lists.alioth.debian.org>.
(Fri, 14 Sep 2018 14:21:03 GMT) (full text, mbox, link).
Hi,
On Thu, 13 Sep 2018, 殷啟聰 | Kai-Chung Yan wrote:
> > It would have helped if you had given me the URL of the repository.
> > Anyway, I'm willing to sponsor the update (even though I don't know much
> > about Android Tools) but I have a few comments:
>
> Thank you for the sponsor, it will help us a lot!
>
> The repository is at
> <https://salsa.debian.org/android-tools-team/android-platform-system-core>.
> Sorry about that, I thought it was too trivial.
It's not hard but I did not know the name of the team on salsa and there
are many packages in the team and the Vcs-Git in the current source
package was obviously outdated. :)
Anyway, I sponsored this upload targetting experimental.
Cheers,
--
Raphaël Hertzog ◈ Debian Developer
Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/
Acknowledgement sent
to 殷啟聰 | Kai-Chung Yan <seamlikok@gmail.com>:
Extra info received and forwarded to list. Copy sent to Android Tools Maintainers <android-tools-devel@lists.alioth.debian.org>.
(Sat, 15 Sep 2018 17:30:02 GMT) (full text, mbox, link).
> Anyway, I sponsored this upload targetting experimental.
Thank you for the sponsor. I am surprised it got cleared in the queue so quickly.
There's a FTFBS on MIPS, I think I can handle it.
Debbugs is free software and licensed under the terms of the GNU
Public License version 2. The current version can be obtained
from https://bugs.debian.org/debbugs-source/.