Debian Bug report logs - #852475
autopkgtest: apt-get install needs automatic conffile handling

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Barry Warsaw <barry@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: autopkgtest: apt-get install needs automatic conffile handling

Date: Tue, 24 Jan 2017 14:49:15 -0500

Package: autopkgtest
Version: 4.3
Severity: normal

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Dear Maintainer,

Let's say one of your autopkgtest dependencies (perhaps recursively)
needs to update a configuration file, i.e. via a conffile.  E.g. when
running the autopkgtests for aptdaemon in an Ubuntu Zesty chroot, the
netbase package wants to be installed, and this has conffiles for
/etc/{protocols,rpc,services}.

This can break the tests when dpkg needs to query about updating these
conffiles because the default is to --force-confdef, which prompts the
user and waits for a response.  This fails in the following way:

Setting up netbase (5.4) ...

Configuration file '/etc/protocols'
 ==> File on system created by you or by a script.
 ==> File also in package provided by package maintainer.
   What would you like to do about it ?  Your options are:
    Y or I  : install the package maintainer's version
    N or O  : keep your currently-installed version
    D       : show the differences between the versions
    Z       : start a shell to examine the situation
 The default action is to keep your current version.
*** protocols (Y/I/N/O/D/Z) [default=N] ? dpkg: error processing package netbase (--configure):
 end of file on stdin at conffile prompt
 
Thus the test dependencies can't be installed and the entire
autopkgtest fails.

It would be better I think when setting up the testbed, to pass to the 
`apt-get install` command an additional option: 
- -o Dpkg::Options::="--force-confnew" so that the prompt is bypassed
and the dependency can be installed.

I can't think of a reason why you'd want to retain the old conffile,
since the testbed is (usually? always?) ephemeral.  If you can think
of a use case for that, then an autopkgtest option would probably be
required.  I'd opt for YAGNI and just include that dpkg option
unconditionally.  

Seems like it should be a relatively easy fix in adt_testbed.py; I'll
try to put together a branch and test it.

- -- System Information:
Debian Release: 9.0
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages autopkgtest depends on:
ii  apt-utils       1.4~beta4
ii  libdpkg-perl    1.18.18
ii  procps          2:3.3.12-3
ii  python3         3.5.3-1
ii  python3-debian  0.1.29

Versions of packages autopkgtest recommends:
ii  autodep8  0.8

Versions of packages autopkgtest suggests:
pn  lxc          <none>
pn  lxd-client   <none>
pn  qemu-system  <none>
pn  qemu-utils   <none>
ii  schroot      1.6.10-3

- -- no debconf information

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEhBcVftvnPZ6sHlObEm61Y6dLBr8FAliHr7kACgkQEm61Y6dL
Br9yew/+NRKoZ1e5B3z2I0MRdo2qiNOF76zaP6WDAAoFeLyQaplFshvIMmKTzvKt
cERFGnijEKWfeCPOP3wyLbotqVXHYqqJmiqDDmx7jFUJEUFYO9UIPqymUz6LGU4S
//Ya1GSYucOCw/VQQfHt1hAlsnyAxWfv2e87xfgFIDhxQihoQu7VZqA8dvGIkvRt
nbXiAPf4a2s9/MRjLctEAfwwyw3HbGSzytaDyCgiZH+r562tqccClfe7VhMfGn3j
QQvzumjELwcXPQbijZAiNeMHN4JEWQzzXwbRwndlq51F+tsCzrjPrm5bcUnILiVL
jA7mrZGMAHanOPl6F4ZC5Idfby7h6gXRqZ5Nc2o/+rUU+TX6iBb/TEtT64ejiy9O
G5PxrQGuL2WxEk8ObcVi6E5PW/L9hmx/T/kLm3oVdOEFEmxhPS95uNlu7aKnOg9N
6X4BeDej7UNwRVjG45lgKw1xW0xfZ5rLBvdQtQqsXkECZDgquW298eBM1D4JuPbc
I5bZyj4w7pNkWIrBglkeX6rxy3YzH+k/21Fx/pYAtG4PRfk09p7k+YOePATRrclf
FBOnf9+KzgfDiCTqgXB1HN/nxbpcTBirg0d4CCrdpW4wcru5VEpnEe9GRxJbY/X3
pZPKAoKkE4jTYgXICqaheEHjAtsh3k0rFNuYmLL9dUHnVi9zGI8=
=rNub
-----END PGP SIGNATURE-----

Message #10 received at 852475@bugs.debian.org (full text, mbox, reply):

From: Barry Warsaw <barry@debian.org>

To: 852475@bugs.debian.org

Subject: Re: Bug#852475: autopkgtest: apt-get install needs automatic conffile handling

Date: Tue, 24 Jan 2017 15:01:12 -0500

[Message part 1 (text/plain, inline)]

https://code.launchpad.net/~barry/autopkgtest/+git/autopkgtest/+ref/852475

[Message part 2 (application/pgp-signature, inline)]

Message #15 received at 852475@bugs.debian.org (full text, mbox, reply):

From: Martin Pitt <mpitt@debian.org>

To: Barry Warsaw <barry@debian.org>, 852475@bugs.debian.org

Subject: Re: Bug#852475: autopkgtest: apt-get install needs automatic conffile handling

Date: Tue, 24 Jan 2017 21:19:12 +0100

Hey Barry,

Barry Warsaw [2017-01-24 14:49 -0500]:
> Let's say one of your autopkgtest dependencies (perhaps recursively)
> needs to update a configuration file, i.e. via a conffile.  E.g. when
> running the autopkgtests for aptdaemon in an Ubuntu Zesty chroot, the
> netbase package wants to be installed, and this has conffiles for
> /etc/{protocols,rpc,services}.

Ah, sbuild usually copies that from the host system
(/etc/schroot/default/nssdatabases), so indeed this tends to cause conffile
conflicts.

> It would be better I think when setting up the testbed, to pass to the 
> `apt-get install` command an additional option: 
> - -o Dpkg::Options::="--force-confnew" so that the prompt is bypassed
> and the dependency can be installed.

Agreed. As a matter of fact, --apt-update is already doing that, but
lib/adt_testbed.py's install_apt() is missing it.

Thanks!

Martin

Message #20 received at 852475@bugs.debian.org (full text, mbox, reply):

From: Martin Pitt <mpitt@debian.org>

To: Barry Warsaw <barry@debian.org>, 852475@bugs.debian.org

Subject: Re: Bug#852475: autopkgtest: apt-get install needs automatic conffile handling

Date: Tue, 24 Jan 2017 21:20:20 +0100

[Message part 1 (text/plain, inline)]

Control: tag -1 pending

Hey Barry,

Barry Warsaw [2017-01-24 15:01 -0500]:
> https://code.launchpad.net/~barry/autopkgtest/+git/autopkgtest/+ref/852475

Applied, thanks!

Martin

[signature.asc (application/pgp-signature, inline)]

Message #27 received at 852475@bugs.debian.org (full text, mbox, reply):

From: Barry Warsaw <barry@debian.org>

To: autopkgtest-devel@lists.alioth.debian.org

Cc: Martin Pitt <mpitt@debian.org>, 852475@bugs.debian.org

Subject: Re: Bug#852475: autopkgtest: apt-get install needs automatic conffile handling

Date: Tue, 24 Jan 2017 15:56:00 -0500

[Message part 1 (text/plain, inline)]

Hi Martin,

On Jan 24, 2017, at 09:19 PM, Martin Pitt wrote:

>Ah, sbuild usually copies that from the host system
>(/etc/schroot/default/nssdatabases), so indeed this tends to cause conffile
>conflicts.

Ah ha!  That was the piece I was missing.

Thanks for applying the patch.

-Barry

[Message part 2 (application/pgp-signature, inline)]

Message #32 received at 852475-close@bugs.debian.org (full text, mbox, reply):

From: Martin Pitt <mpitt@debian.org>

To: 852475-close@bugs.debian.org

Subject: Bug#852475: fixed in autopkgtest 4.4

Date: Sun, 30 Apr 2017 17:33:56 +0000

Source: autopkgtest
Source-Version: 4.4

We believe that the bug you reported is fixed in the latest version of
autopkgtest, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 852475@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Martin Pitt <mpitt@debian.org> (supplier of updated autopkgtest package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 30 Apr 2017 19:09:57 +0200
Source: autopkgtest
Binary: autopkgtest
Architecture: source all
Version: 4.4
Distribution: unstable
Urgency: medium
Maintainer: Autopkgtest team <autopkgtest-devel@lists.alioth.debian.org>
Changed-By: Martin Pitt <mpitt@debian.org>
Description:
 autopkgtest - automatic as-installed testing for Debian packages
Closes: 851556 851899 852475 855954
Changes:
 autopkgtest (4.4) unstable; urgency=medium
 .
   [ Martin Pitt ]
   * doc/README.package-tests.rst: Document network access (Closes: #851556)
   * qemu: Robustify ssh port locks.
     Stop assuming that /run/lock is user-writable (it is not in non-Debian
     systems). Instead create the lock file in /tmp and use 'x' to avoid
     /tmp file races.
   * tests/autopkgtest: Fix crashes when running on non-apt system
   * Fix candidate version detection for packages containing regexp operators
     '+' and '.' are valid characters in a Debian package name. Escape them
     in the call to apt-cache policy so that we get what we want to know.
     (Closes: #855954)
 .
   [ Iain Lane ]
   * Fix build_source to work if "Package-List" is the last line in the apt
     output (Closes: #851899)
   * autopkgtest-virt-lxd: Check uptime for reboot waiting. (LP: #1654025)
   * Add a debug-fail hook and implement it for autopkgtest-virt-ssh.
     At the minute, this is mainly so that the nova script can have its
     failure information (`nova console-log') propagated up to the output, so
     that in the case of kernel panics or other random failures we get useful
     output that the driver of autopkgtest (e.g. autopkgtest-cloud) can look
     at. (LP: #1630578)
   * autopkgtest-build-lxd: Allow overriding the target release by setting
     RELEASE=. This will cause the container to be dist-upgraded to the new
     release. Useful for the very early stages of a release when the LXD
     images on images.linuxcontainers.org don't exist yet.
 .
   [ Barry Warsaw ]
   * Pass Dpkg::Options::=--force-confnew to apt-get install.
     This avoids dpkg from prompting for conffile installation when you always
     want the new conffile in the testbed anyway. (Closes: #852475)
Checksums-Sha1:
 4557a588fefa33c4e8d191dc39460476d3c6fc65 1895 autopkgtest_4.4.dsc
 44aa9a4ad5e1623eec338a196ab503d7b40119f8 172936 autopkgtest_4.4.tar.xz
 b69f4c5275d06fb654858bff996a809249457eb1 186432 autopkgtest_4.4_all.deb
 76653f52975aae961550bb78afc29af178fe0423 6197 autopkgtest_4.4_amd64.buildinfo
Checksums-Sha256:
 ff7eedfbeebfc0b83ac5b0d7d23dd8058cdda3fc781639f88ce3a774bfc67317 1895 autopkgtest_4.4.dsc
 7db144b39bd5a08e91261c4b4d91a450445e4a57a8c848091bb2a272ef80acc6 172936 autopkgtest_4.4.tar.xz
 325cf656760f8f7e4f496e087c85671dcca7c355154df6c40502ed75878a6c9b 186432 autopkgtest_4.4_all.deb
 564eca2150ad1412f4ccd7617823bf4640d92d4575f34080f63ef9b293d0a528 6197 autopkgtest_4.4_amd64.buildinfo
Files:
 d06d8b3dc1fd5fd9af99c7700363f1d5 1895 devel optional autopkgtest_4.4.dsc
 9b1d367f019e8091ec90b4479f1bff8d 172936 devel optional autopkgtest_4.4.tar.xz
 6069c392bfa690a54a1ff41736b0b6de 186432 devel optional autopkgtest_4.4_all.deb
 0b6ad590bb1e6f10acd705c92ea27fae 6197 devel optional autopkgtest_4.4_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEPbRrVe+lnUDmIyFI0U7xXa/hE0cFAlkGHRIACgkQ0U7xXa/h
E0ejqg//cvBSy5gixnN9rplIyHKAYkI3aeg2lHv9/NW7q/3iSsILsiztA3QQ3lGi
N9BYMfiKUY8YhptJkiE5KAYz+gVyTKn+bLuEjqMQua1bx6AMB04lfaDUXN2S+Oqt
bxFeAyzLj8IKsK30hGJB36OwHP46qoCazlzPCzFFRUdT8jXmDJKbOQKg7lBZ1dlQ
V6L1LwwflLvasMcVnCmlzLklpNHfcsMigrMRR5gnistP/TlfQNmALr0J1QxgtBDr
bWeGXu+vv0x1LkxRDIZwUNsCP1Ij6y5ECh3NMRPsZgeqHaYnxsiLZNNYqxlbfwCe
YFXz+FI1d+tJKr7XxoMnwqP+t1EXaBPUbPwp68vEKRWEZ9WGUfe2zb/0OEL1K/p7
8vT1dZUrBy0REfD+8mu4VyFFi4vjrxhOUn/bk+8QZGlhJCrvt4lSsJXm3yCdETG6
66+yxsq9jMnM0XE0lluUeWcclcwtUDsrca8FKk70c9K85ZqQrQBgBphCRsPeeAHA
i/UvuJICy/e+IIV1MrMDtLARoew4vScjS9a9YO9CgXU4ldX1MYZpGY5Z5z5+CTbg
7mMMQBfoAKotf+E7q/jprtCCHeagSjLoGMMaI9wP4VDP3eSKabwD62S4Dm4FY23Q
ijxaHUDLbdoCMU3dqS09D/wAlkn1hAecSo2E33Yf40uLwMxEl68=
=i1QW
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.