Debian Bug report logs - #850055
diffoscope: Comparing a device with a regular file fails

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: submit@bugs.debian.org

Subject: diffoscope: Comparing a device with a regular file fails

Date: Tue, 03 Jan 2017 15:58:08 +0000

Package: diffoscope
Version: 66
Severity: normal

$ diffoscope --no-progress --debug /dev/null /etc/fstab
1483458952.621770    DEBUG Starting comparison
1483458952.622251    DEBUG Using Device for /dev/null
1483458952.628209    DEBUG Using TextFile for /etc/fstab
1483458952.628395    DEBUG Comparing files <<class 'abc.Device'> /dev/null> and <<class 'abc.TextFile'> /etc/fstab>
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/diffoscope/main.py", line 297, in main
    sys.exit(run_diffoscope(parsed_args))
  File "/usr/lib/python3/dist-packages/diffoscope/main.py", line 251, in run_diffoscope
    parsed_args.path1, parsed_args.path2)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/__init__.py", line 133, in compare_root_paths
    return compare_files(file1, file2)
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/__init__.py", line 138, in compare_files
    if file1.has_same_content_as(file2):
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/device.py", line 39, in has_same_content_as
    return self.get_device() == other.get_device()
AttributeError: 'TextFile' object has no attribute 'get_device'

The other way around works:

$ diffoscope --no-progress --debug  /etc/fstab /dev/null
1483459010.885976    DEBUG Starting comparison
1483459010.892007    DEBUG Using TextFile for /etc/fstab
1483459010.892327    DEBUG Using Device for /dev/null
1483459010.892452    DEBUG Comparing files <<class 'abc.TextFile'> /etc/fstab> and <<class 'abc.Device'> /dev/null>
1483459010.892538    DEBUG Binary.has_same_content: <<class 'abc.TextFile'> /etc/fstab> <<class 'abc.Device'> /dev/null>
1483459010.900649    DEBUG running ['xxd', '/etc/fstab']
1483459010.902732    DEBUG running ['xxd', '/tmp/tmp9i74wicn_diffoscope']
1483459010.904995    DEBUG done with xxd. exit code 0
1483459010.905473    DEBUG done with xxd. exit code 0
1483459010.905671    DEBUG running ['diff', '-aU7', '/tmp/tmp9pz5hgjt/f1', '/tmp/tmp9pz5hgjt/f2']
1483459010.907623    DEBUG done with diff, returncode 1, parsed True
[..]



Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #12 received at 850055-close@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 850055-close@bugs.debian.org

Subject: Bug#850055: fixed in diffoscope 68

Date: Mon, 16 Jan 2017 00:48:26 +0000

Source: diffoscope
Source-Version: 68

We believe that the bug you reported is fixed in the latest version of
diffoscope, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 850055@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated diffoscope package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 16 Jan 2017 11:24:22 +1100
Source: diffoscope
Binary: diffoscope
Architecture: source
Version: 68
Distribution: unstable
Urgency: medium
Maintainer: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 diffoscope - in-depth comparison of files, archives, and directories
Closes: 849395 850055 850485 850501 850502 850730 850807 850850
Changes:
 diffoscope (68) unstable; urgency=medium
 .
   [ Chris Lamb ]
 .
   * Don't blow up if directory containing ELF debug symbols already exists.
     (Closes: #850807)
   * Fix .APK extration when provided with absolute filenames.
     (Closes: #850485)
   * Support comparing .ico files using img2txt. (Closes: #850730)
   * comparators.utils.file: If we don't have an archive-extraction tool (eg.
     apktool), don't blow up when attempting to unpack it.
   * Include magic file type when we know the file format but can't find
     file-specific details. (Closes: #850850)
   * Ensure fake "APK metadata" file appears first, fixing non-deterministic
     tests/output.
   * Correctly escape value of href="" elements (re. #849411)
 .
   * Optimisations:
     - Disable profiling entirely (unless enabled) for a 2%+ optimisation
     - Compile APK filename regex instead of generating it each loop.
 .
   * Logging:
     - Log tempfile cleanup process
     - Log when we add a progress observer.
     - Drop milliseconds from log output
 .
   * Misc:
     - Many unused import removals, indentation changes, etc.
     - Fix duplicated word and long line errors in debian/changelog.
     - Suggest some promotion in post-release documentation.
 .
   [ Maria Glukhova ]
   * comparators/device: don't crash when comparing a non-device against a
     device (Closes: #850055)
   * Remove archive name from apktool.yml and rename it. (Closes: #850501)
   * Zipinfo included in APK files comparison. (Closes: #850502)
     - Add some tests for APK comparator.
   * Add image metadata comparison. (Closes: #849395)
   * Ensure imagemagick version is new enough for image metadata tests.
 .
   [ Mattia Rizzolo ]
   * Skip the openssh_pub_key test if the version of ssh is < 6.9.
   * comparators/icc: rename RE_FILE_EXTENSION to RE_FILE_TYPE, as that's what
     the regular expression is looking for.
   * Make use of a new mechanism to remove a bunch of recognizes() methods
     dealing with simple RE_FILE_TYPE matching.
Checksums-Sha1:
 30784a46bd47bd40ea061544dbd8efa80c2f70b9 2940 diffoscope_68.dsc
 c2bb3ade5270b5eb1a74f04601a48daa04f6d979 324376 diffoscope_68.tar.xz
Checksums-Sha256:
 825057d67e926532df3fd06ea63e2c57a0075f5e0709dccd6bd393f77ac556e1 2940 diffoscope_68.dsc
 42db84379df4a6932c09b5674b64828880ab9a64c5426628220c8c127d66f18b 324376 diffoscope_68.tar.xz
Files:
 4237325fb0e88b2d2c5571f5fc9f0cac 2940 devel optional diffoscope_68.dsc
 aeb6a542b7db5b8d478b55d5a06abfec 324376 devel optional diffoscope_68.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAlh8FEkACgkQHpU+J9Qx
Hlj3WBAAtsuSuNT0D0vgccnZq5y+S9byiuwotBQA5V/iDgpnuhmCRJnN4paFJfXn
wHCoFoTyqZZuX548DLC3UooidTJmSf1Bw5uCIBv++EyE4cSNwLaR2kV+7XE+WGnV
JA/WuwdH3QprhVzvGfCmLSDcsW7XHwS96jJlv/f4Qf42GSiRcZn30t9iaZlZAtPm
O9+oSZdWL8HKCgpdluB+YKe5nq7lH/qTtGecAzJvytlR9TqRlaId05jfc4f0dc8w
/znweuf0nWg4mbGRWhOll765XLp27puw4/bSee879990Q+8EBJKmmKpogWN+UiZR
NPMmDKV+caxOWeGT/uHWrr7A4ViMWlPw6jl1Z7jrNUZijYD1zQzYhSZMNOX5O7oT
wih2ynSYLpOSqRBjjx8U8lRhoKXsB9Yz9FHLYDLhtKAEymGld7hcsL7OdM/m9FNk
kQqHCUCpSkrO3RZQLmf+9dDKgwyuzR9z/AtmluYmJMJ7TntENn5+4Fk0sOCUxTah
QMnipPeBpku+lYFRAwwI9aa8CHRzsPb28PfSbRJKRrrvrCxXoyRxB0mZkiQpVm0H
HlIaddchgElL61zWcCXS9oZ9EMb8lQ4Pl7ArxMpyJxGJCap4MnmtrFTxzSQOe7v2
NYI9QHDDJj9eyBQMgvDqtTrEwCO0EhNwc8jmUC8EorvqhZPVhVE=
=1s7L
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.