Debian Bug report logs - #849969
root zpool broken on Debian stretch

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Lukas Wunner <lukas@wunner.de>

To: submit@bugs.debian.org

Subject: root zpool broken on Debian stretch

Date: Mon, 2 Jan 2017 20:00:02 +0100

[Message part 1 (text/plain, inline)]

Package: zfs-dracut
Version: 0.6.5.8-2
Severity: important
Tags: patch

After upgrading to systemd 230 as included with Debian stretch, systems
that build their initramfs with dracut and have their root partition on
a zpool fail to boot:

On boot, /usr/lib/dracut/modules.d/98dracut-systemd/rootfs-generator.sh
generates a systemd unit to mount the "root=" kernel parameter, which
for ZFS may look like "zfs:pool/dataset" or "zfs:AUTO", a format not
understood by mount(8).  As a result systemd switches to emergency mode.

A fix was committed upstream in April 2016 with a5a370227eb0 ("fix
booting via dracut generated initramfs"), but never made it into the
0.6.5.* point releases, presumably because they do not pick up fixes
in the contrib/ directory.  Note that upstream has a lot more dracut
fixes but this single patch is already sufficient to make my machine
boot again.

Add a patch containing that commit.  The patch makes use of the
--with-systemdunitdir configure parameter which we do not set and
which incorrectly defaults to /usr/lib/systemd/system/.  (Debian uses
/lib/systemd/system/.)  Amend debian/rules to set that parameter.
This obviates the need to specify the /lib/systemd/system/ path in
debian/zfs-zed.install and debian/zfsutils-linux.install, so fix those
up while at it.

[0001-zfs-dracut-Fix-root-zpool-on-Debian-stretch.patch (text/plain, attachment)]

Message #10 received at 849969@bugs.debian.org (full text, mbox, reply):

From: Aron Xu <aron@debian.org>

To: Lukas Wunner <lukas@wunner.de>, 849969@bugs.debian.org

Subject: Re: [Pkg-zfsonlinux-devel] Bug#849969: root zpool broken on Debian stretch

Date: Sat, 28 Jan 2017 02:53:01 +0800

Hi Lukas,

I've committed some more cherry-picks from upstream about dracut, as in
https://anonscm.debian.org/git/pkg-zfsonlinux/zfs.git/commit/?id=146eee208ab3a35cecdb65a3edafd82e3130ff44

and your fixes about systemd unit files, as in
https://anonscm.debian.org/git/pkg-zfsonlinux/zfs.git/commit/?id=58907cc6bf85f30ebcf577a97e1e6877f264f65b

Can you test whether these fixes work for you? I'd like to make an
upload for dracut issue and the Linux 4.9 compatibility stuff.


Regards,
Aron

Message #15 received at 849969@bugs.debian.org (full text, mbox, reply):

From: Lukas Wunner <lukas@wunner.de>

To: Aron Xu <aron@debian.org>

Cc: 849969@bugs.debian.org, Eric Desrochers <eric.desrochers@canonical.com>

Subject: Re: [Pkg-zfsonlinux-devel] Bug#849969: root zpool broken on Debian stretch

Date: Sat, 28 Jan 2017 21:59:36 +0100

[Message part 1 (text/plain, inline)]

On Sat, Jan 28, 2017 at 02:53:01AM +0800, Aron Xu wrote:
> I've committed some more cherry-picks from upstream about dracut, as in
> https://anonscm.debian.org/git/pkg-zfsonlinux/zfs.git/commit/?id=146eee208ab3a35cecdb65a3edafd82e3130ff44
> 
> and your fixes about systemd unit files, as in
> https://anonscm.debian.org/git/pkg-zfsonlinux/zfs.git/commit/?id=58907cc6bf85f30ebcf577a97e1e6877f264f65b
> 
> Can you test whether these fixes work for you? I'd like to make an
> upload for dracut issue and the Linux 4.9 compatibility stuff.

Thanks a lot Aron, I'm happy to confirm that the tip of the master branch
(94b699fe4012) boots and shuts down correctly on a ZFS root with dracut
and kernel 4.9.


There are two unrelated glitches though:

(1) systemd complains on boot:

    "systemd[2234]: zfs-share.service: Failed at step EXEC spawning
     /usr/sbin/rm: No such file or directory"

    This was introduced by b83d293b8d8d ("Change utilities path (bindir)
    to /usr/sbin (Closes: #832938)").  Adding Eric Desrochers to cc.
    I think fumbling bindir to point to /usr/sbin isn't a good idea,
    instead the three Python scripts should be moved to /usr/sbin in a
    debhelper override.

(2) If the umask is set to 077 the build fails.  Attached is a patch to
    fix this.  I didn't notice this earlier as I changed my default
    umask only recently.

Thanks,

Lukas

[0001-Fix-build-breakage-caused-by-nonstandard-umask.patch (text/plain, attachment)]

Message #20 received at 849969@bugs.debian.org (full text, mbox, reply):

From: Fabian Grünbichler <f.gruenbichler@proxmox.com>

To: 849969@bugs.debian.org, Lukas Wunner <lukas@wunner.de>, Aron Xu <aron@debian.org>

Cc: Eric Desrochers <eric.desrochers@canonical.com>

Subject: Re: Bug#849969: [Pkg-zfsonlinux-devel] Bug#849969: root zpool broken on Debian stretch

Date: Sun, 29 Jan 2017 15:07:45 +0100 (CET)

> Lukas Wunner <lukas@wunner.de> hat am 28. Januar 2017 um 21:59 geschrieben:
> 
> There are two unrelated glitches though:
> 
> (1) systemd complains on boot:
> 
>     "systemd[2234]: zfs-share.service: Failed at step EXEC spawning
>      /usr/sbin/rm: No such file or directory"
> 
>     This was introduced by b83d293b8d8d ("Change utilities path (bindir)
>     to /usr/sbin (Closes: #832938)").  Adding Eric Desrochers to cc.
>     I think fumbling bindir to point to /usr/sbin isn't a good idea,
>     instead the three Python scripts should be moved to /usr/sbin in a
>     debhelper override.

That's https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=842237 - which might be nice to tackle with the next upload as well? Simply hardcoding the (correct ;)) path of 'rm' is the easiest, most straight-forward way IMHO.

Message #25 received at 849969-close@bugs.debian.org (full text, mbox, reply):

From: Aron Xu <aron@debian.org>

To: 849969-close@bugs.debian.org

Subject: Bug#849969: fixed in zfs-linux 0.6.5.9-1

Date: Tue, 07 Feb 2017 06:33:43 +0000

Source: zfs-linux
Source-Version: 0.6.5.9-1

We believe that the bug you reported is fixed in the latest version of
zfs-linux, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 849969@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Aron Xu <aron@debian.org> (supplier of updated zfs-linux package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 06 Feb 2017 15:57:50 +0800
Source: zfs-linux
Binary: libnvpair1linux libuutil1linux libzfslinux-dev libzfs2linux libzpool2linux zfs-dkms zfs-initramfs zfs-dracut zfsutils-linux zfs-zed zfs-dbg
Architecture: source amd64 all
Version: 0.6.5.9-1
Distribution: unstable
Urgency: medium
Maintainer: Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>
Changed-By: Aron Xu <aron@debian.org>
Description:
 libnvpair1linux - Solaris name-value library for Linux
 libuutil1linux - Solaris userland utility library for Linux
 libzfs2linux - OpenZFS filesystem library for Linux
 libzfslinux-dev - OpenZFS filesystem development files for Linux
 libzpool2linux - OpenZFS pool library for Linux
 zfs-dbg    - Debugging symbols for OpenZFS userland libraries and tools
 zfs-dkms   - OpenZFS filesystem kernel modules for Linux
 zfs-dracut - OpenZFS root filesystem capabilities for Linux - dracut
 zfs-initramfs - OpenZFS root filesystem capabilities for Linux - initramfs
 zfs-zed    - OpenZFS Event Daemon
 zfsutils-linux - command-line tools to manage OpenZFS filesystems
Closes: 842237 849969 851513
Changes:
 zfs-linux (0.6.5.9-1) unstable; urgency=medium
 .
   [ Aron Xu ]
   * Imported Upstream version 0.6.5.9 (Closes: #851513)
 .
   [ Lukas Wunner ]
   * Cherry picks for root zpool with dracut (Closes: #849969)
   * Fix installation path of systemd files
   * Fix build breakage caused by nonstandard umask
 .
   [ Fabian Grünbichler ]
   * fix python script install path (Closes: #842237)
Checksums-Sha1:
 d34e86e53aeb3c6872f19d2703e9c50e8174cf21 2593 zfs-linux_0.6.5.9-1.dsc
 6c580575691e346bd97c31959148921ea9df8c26 2610650 zfs-linux_0.6.5.9.orig.tar.gz
 76e6bc928a1b902f910254b3baddabe6a0ae4703 51380 zfs-linux_0.6.5.9-1.debian.tar.xz
 af8e56e3fefa522bc0b96f2bd5b89d16b1dec8c5 44182 libnvpair1linux_0.6.5.9-1_amd64.deb
 b0b5886aa4c3f95ddf83cbaa9755b35b9b2974be 47178 libuutil1linux_0.6.5.9-1_amd64.deb
 e0ae55e156e063654b01174ee459967f916eee1b 125776 libzfs2linux_0.6.5.9-1_amd64.deb
 0427979b007a2422e9b9a96efe37c0764fc4e20d 813844 libzfslinux-dev_0.6.5.9-1_amd64.deb
 eb96537aa5dc86a2882e8f7ac9299ff8b9964750 401064 libzpool2linux_0.6.5.9-1_amd64.deb
 e46585f7110fdd50f5e1a8faea2454534716c347 2646752 zfs-dbg_0.6.5.9-1_amd64.deb
 59ba7542c3c804290393c98a6a50f156691b58a8 1079392 zfs-dkms_0.6.5.9-1_all.deb
 a5008c9f21f7a64dd52045d510936ab1a59e6493 19900 zfs-dracut_0.6.5.9-1_all.deb
 a906c3582f442557b3a566efae5fc4ea755fb0a7 23010 zfs-initramfs_0.6.5.9-1_all.deb
 253142a517fc3e56f1c47aaac2bd46f0ed496335 8138 zfs-linux_0.6.5.9-1_amd64.buildinfo
 4e2900841f7359452e1cc0af50cee906e939c9cf 42870 zfs-zed_0.6.5.9-1_amd64.deb
 4dae69d4d38efcb723f6a870c12c4f936fd4cb4c 335112 zfsutils-linux_0.6.5.9-1_amd64.deb
Checksums-Sha256:
 399a936eec1134186edd27851647b2d7ae3ddcd9b8bbbd06385df2e8762112b9 2593 zfs-linux_0.6.5.9-1.dsc
 b724b57dbddae59246fdc15f88f1224061c712945bb36412a2087e0c7760d77f 2610650 zfs-linux_0.6.5.9.orig.tar.gz
 73c7681830aafd5e6a64fbeccbd2928f38e9917ed54503e6ccc0f8b969efa131 51380 zfs-linux_0.6.5.9-1.debian.tar.xz
 2bfba6d2fd80799609d98a0c2f3f884ca5ed4442a0d3184555593b3cf76fc3a2 44182 libnvpair1linux_0.6.5.9-1_amd64.deb
 7e1fc815e4eaa8e62f8778c13a09050fceb74f4c7ed3fe66746d56fd7fb4ca12 47178 libuutil1linux_0.6.5.9-1_amd64.deb
 bf1a96af9975fcdf7a5b4fa6754a9f13bdc601cf5f4186f102b5175832fc2330 125776 libzfs2linux_0.6.5.9-1_amd64.deb
 08bf42729e0546374cb17d8e52b2301f39a32c59a03c02dff0198ab4a6123669 813844 libzfslinux-dev_0.6.5.9-1_amd64.deb
 963980518913e9ce5b21437348ef028a5fcf041b38a9c9fb064a92358ae9b0bc 401064 libzpool2linux_0.6.5.9-1_amd64.deb
 3fa4a0dd7e262ce6e5b8ca9e7e55b7d9cc870f179e58de4ac19aa939fca9b091 2646752 zfs-dbg_0.6.5.9-1_amd64.deb
 8cc731849ff7f7924f4a7962b01579ceb8a1d73cb107e0f0a31f4d6ac230985f 1079392 zfs-dkms_0.6.5.9-1_all.deb
 041d862a5b31cfca271e6e30fd71ed68331084b265f8ec42dfdc9b7839f02ce3 19900 zfs-dracut_0.6.5.9-1_all.deb
 62dd622e18d6c9fdd11f5c360a209250779ce02c56aa25dc61bf750434176029 23010 zfs-initramfs_0.6.5.9-1_all.deb
 5820c139d8c8fd100e087138dff4d25ea0dd2a6f0fd849da60e4f5683f51e88f 8138 zfs-linux_0.6.5.9-1_amd64.buildinfo
 f81e4d3a302f68b350e0ac4184f892d5ff4ae9158b01cd231c50c6562a5b306c 42870 zfs-zed_0.6.5.9-1_amd64.deb
 37412dd74f045cd8f412e64a988da2d4017ae1b60f9ab64e44a713452620fb93 335112 zfsutils-linux_0.6.5.9-1_amd64.deb
Files:
 9de9e4d1b52b8850c00db7ace373bb2a 2593 contrib/kernel optional zfs-linux_0.6.5.9-1.dsc
 9dceb3930be4e1a8cf35bcc40e48e527 2610650 contrib/kernel optional zfs-linux_0.6.5.9.orig.tar.gz
 8c16e9ac1d3b1882a8c08fe6fd5c027f 51380 contrib/kernel optional zfs-linux_0.6.5.9-1.debian.tar.xz
 10ea1b7b210ace6505140c34c81fe183 44182 contrib/libs optional libnvpair1linux_0.6.5.9-1_amd64.deb
 9456629567bd0485e82b91026dab1715 47178 contrib/libs optional libuutil1linux_0.6.5.9-1_amd64.deb
 a708b41748de1662cebc7bb4fd4c60a9 125776 contrib/libs optional libzfs2linux_0.6.5.9-1_amd64.deb
 f661a48a790b8b6442ae5f885e649e98 813844 contrib/libdevel optional libzfslinux-dev_0.6.5.9-1_amd64.deb
 2c6bde4311897a9c898da423548a95bc 401064 contrib/libs optional libzpool2linux_0.6.5.9-1_amd64.deb
 4f3020a5c7e8817135a873d26a1c969b 2646752 contrib/debug extra zfs-dbg_0.6.5.9-1_amd64.deb
 5f8492d14eebbe4814fc0c0c82dce4c3 1079392 contrib/kernel optional zfs-dkms_0.6.5.9-1_all.deb
 03f0523cb69188a44c3ee0ffaf175d0e 19900 contrib/kernel optional zfs-dracut_0.6.5.9-1_all.deb
 65b4f5e0cfdaf08e99ce0fc3883c29a1 23010 contrib/kernel optional zfs-initramfs_0.6.5.9-1_all.deb
 ebe62071f1008d5e5468ec89f7423752 8138 contrib/kernel optional zfs-linux_0.6.5.9-1_amd64.buildinfo
 53a41171d1f6bc76d8841640d8366677 42870 contrib/admin optional zfs-zed_0.6.5.9-1_amd64.deb
 fa945c8e4f67e561725c65a082b3e11f 335112 contrib/admin optional zfsutils-linux_0.6.5.9-1_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEET3MbhxKET+7/a6zdW0gHVdEZ6o4FAliZZccACgkQW0gHVdEZ
6o7BbAf6A/g+L/0157mpXm/2SD4COLjdqm4KBvG4s1j6YDO/37jVCHVLiSCt1wD5
oE7C7TQ1UzaQRzAKsU0k6pC50/9bgVTF9rBbayYRZb8557uVtwjz2J9orNvWelh8
8TGZSSor4+Xf51yy+vm4StUtf0wcdN4nN/RQrGpq2QajsCFBx6E5S0eG18KzvxNA
FOB4P8mRvXX5oE2npSrr+m39CTba0Wr2nRm/nYXsduRLt2RPo+NIcziRGcHAncZu
2lqrrHsgLJYCQg3dvqfqWw3BeJPVT7dApFaLpUslhF/IYHziMtnIb3LD8YnMjFc1
i2G7RsEYhzMdvIwiiC3yUOBh9CUdGw==
=JMyR
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.