Debian Bug report logs - #847768
hoichess: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: submit@bugs.debian.org

Subject: hoichess: please make the build reproducible

Date: Sun, 11 Dec 2016 15:00:43 +0100

[Message part 1 (text/plain, inline)]

Source: hoichess
Version: 0.19.0-5
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that hoichess could not be built reproducibly.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[hoichess.diff.txt (text/plain, attachment)]

Message #10 received at 847768@bugs.debian.org (full text, mbox, reply):

From: Daniel Shahaf <danielsh@apache.org>

To: Chris Lamb <lamby@debian.org>

Cc: 847768@bugs.debian.org

Subject: Re: hoichess: please make the build reproducible

Date: Sun, 11 Dec 2016 14:55:40 +0000

Chris Lamb wrote on Sun, Dec 11, 2016 at 15:00:43 +0100:
> Patch attached.

You beat me to it :-)  The patch I've come up with is slightly different
to yours, so I'll post it here and let the maintainer choose.

Cheers,

Daniel


diff --git a/debian/patches/dirname-agnostic-1.patch b/debian/patches/dirname-agnostic-1.patch
index e69de29..6793c5d 100644
--- a/debian/patches/dirname-agnostic-1.patch
+++ b/debian/patches/dirname-agnostic-1.patch
@@ -0,0 +1,29 @@
+Description: Extract version number from within the build directory
+ Makes the build reproducible when the absolute path to the source root
+ directory differs.
+Author: Daniel Shahaf <danielsh@apache.org>
+Bug: https://bugs.debian.org/-1
+Forwarded: no
+Last-Update: 2016-12-11
+
+--- a/src/build/print_version_str
++++ b/src/build/print_version_str
+@@ -19,17 +19,7 @@
+ 
+ 	version_str="$branch-$rev (svn)"
+ else
+-	dirname=`cd "$basedir" && pwd | xargs basename`
+-	case "$dirname" in
+-		"$progname"-*)
+-			version=`echo "$dirname" | sed -e "s/^$progname-//"`
+-			;;
+-		*)
+-			version="unknown"
+-			;;
+-	esac
+-
+-	version_str="$version"
++	version_str="`< "${basedir}"/ChangeLog head -n1 | awk '{print $2}'`"
+ fi
+ 
+ echo "$version_str"
diff --git a/debian/patches/dirname-agnostic-2.patch b/debian/patches/dirname-agnostic-2.patch
index e69de29..825a6a9 100644
--- a/debian/patches/dirname-agnostic-2.patch
+++ b/debian/patches/dirname-agnostic-2.patch
@@ -0,0 +1,18 @@
+Description: Use the debian package version instead of the upstream version
+ Follow-up to dirname-agnostic-1.patch.
+Author: Daniel Shahaf <danielsh@apache.org>
+Bug: https://bugs.debian.org/-1
+Forwarded: not-needed
+Last-Update: 2016-12-11
+
+--- a/src/build/print_version_str
++++ b/src/build/print_version_str
+@@ -19,7 +19,7 @@
+ 
+ 	version_str="$branch-$rev (svn)"
+ else
+-	version_str="`< "${basedir}"/ChangeLog head -n1 | awk '{print $2}'`"
++	version_str="`cd "${basedir}" && dpkg-parsechangelog -SVersion`"
+ fi
+ 
+ echo "$version_str"
diff --git a/debian/patches/series b/debian/patches/series
index 94c3b93..036d7c2 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -2,3 +2,5 @@ flags.patch
 docs.patch
 reproducible-build.patch
 sparc32.patch
+dirname-agnostic-1.patch
+dirname-agnostic-2.patch

Message #15 received at 847768@bugs.debian.org (full text, mbox, reply):

From: Samuel Henrique <samueloph@gmail.com>

To: Daniel Shahaf <danielsh@apache.org>, 847768@bugs.debian.org, Holger Ruckdeschel <holger@hoicher.de>, Chris Lamb <lamby@debian.org>

Subject: Re: Bug#847768: hoichess: please make the build reproducible

Date: Tue, 13 Dec 2016 22:09:08 -0200

[Message part 1 (text/plain, inline)]

Hi Holger,

I bet you'll like these patches[1], it's your pick, let me now and i can
patch on my [debian] side so we have reproducible hoichess builds before
you make a new release.

[1]https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=847768

Samuel Henrique <samueloph>

[Message part 2 (text/html, inline)]

Message #20 received at 847768@bugs.debian.org (full text, mbox, reply):

From: Samuel Henrique <samueloph@gmail.com>

To: Daniel Shahaf <danielsh@apache.org>, 847768@bugs.debian.org, Holger Ruckdeschel <holger@hoicher.de>, Chris Lamb <lamby@debian.org>

Subject: Re: Bug#847768: hoichess: please make the build reproducible

Date: Mon, 19 Jun 2017 21:59:00 -0300

[Message part 1 (text/plain, inline)]

Hi again Holger,

I see on the changelog of 0.20.0:

> * Included reproducible-build patch from Debian package
>    hoichess_0.19.0-3.
>

​Although, 0.21.0 still has other reproducibility problems[1], could you
help us with that?

This bugreport contains two patches that would fix the problem[2].

*Also, please note that the patch you applied on 0.19.0 solved one problem,
as seen on [3].

[1]
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/hoichess.html
​
​[2]​https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=847768
​[3]https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=826982​


Samuel Henrique <samueloph>

[Message part 2 (text/html, inline)]

Message #25 received at 847768@bugs.debian.org (full text, mbox, reply):

From: Holger Ruckdeschel <holger@hoicher.de>

To: Samuel Henrique <samueloph@gmail.com>

Cc: Daniel Shahaf <danielsh@apache.org>, 847768@bugs.debian.org, Chris Lamb <lamby@debian.org>

Subject: Re: Bug#847768: hoichess: please make the build reproducible

Date: Tue, 20 Jun 2017 21:29:07 +0200

[Message part 1 (text/plain, inline)]

On Mon, 19 Jun 2017 21:59:00 -0300, Samuel Henrique wrote:

> I see on the changelog of 0.20.0:
> 
> > * Included reproducible-build patch from Debian package
> >    hoichess_0.19.0-3.
> >  
> 
> ​Although, 0.21.0 still has other reproducibility problems[1], could you
> help us with that?

Hello Samuel,

I have applied the attached change to my source, it will be included in the
next releases. You could still replace this by the Debian package version
as suggested by Daniel Shahaf. In this case, I kindly ask you to add e.g.
"-debian" to the version string to avoid confusion.

Best regards,
Holger

[hoichess-2537.diff (text/x-patch, attachment)]

Message #30 received at 847768-submitter@bugs.debian.org (full text, mbox, reply):

From: Samuel Henrique <samueloph@gmail.com>

To: 847768-submitter@bugs.debian.org

Subject: Bug#847768 marked as pending

Date: Sun, 25 Jun 2017 23:54:29 +0000

tag 847768 pending
thanks

Hello,

Bug #847768 reported by you has been fixed in the Git repository. You can
see the changelog below, and you can check the diff of the fix at:

    https://anonscm.debian.org/cgit/collab-maint/hoichess.git/commit/?id=787192f

---
commit 787192f1874a9b71aceb18a12dedac95982eeb1e
Author: Samuel Henrique <samueloph@gmail.com>
Date:   Sun Jun 25 20:47:39 2017 -0300

    Prepare changelog

diff --git a/debian/changelog b/debian/changelog
index 3290449..b536f5d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,13 @@
+hoichess (0.21.0-2) unstable; urgency=medium
+
+  * d/p/agnostic*.patch: new patch to introduce reproducible builds, thanks to
+    Daniel Shahaf <danielsh@apache.org> for creating the patch, Chris Lamb
+    <lamby@debian.org> for reporting and helping with another patch and
+    hoichess's upstream Holger Ruckdeschel <holger@hoicher.de> for the help
+    (closes: #847768).
+
+ -- Samuel Henrique <samueloph@gmail.com>  Sun, 25 Jun 2017 20:45:17 -0300
+
 hoichess (0.21.0-1) unstable; urgency=medium
 
   * New upstream version 0.21.0.

Message #35 received at 847768-close@bugs.debian.org (full text, mbox, reply):

From: Samuel Henrique <samueloph@gmail.com>

To: 847768-close@bugs.debian.org

Subject: Bug#847768: fixed in hoichess 0.21.0-2

Date: Mon, 26 Jun 2017 00:19:33 +0000

Source: hoichess
Source-Version: 0.21.0-2

We believe that the bug you reported is fixed in the latest version of
hoichess, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 847768@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Samuel Henrique <samueloph@gmail.com> (supplier of updated hoichess package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 25 Jun 2017 20:45:17 -0300
Source: hoichess
Binary: hoichess
Architecture: source
Version: 0.21.0-2
Distribution: unstable
Urgency: medium
Maintainer: Samuel Henrique <samueloph@gmail.com>
Changed-By: Samuel Henrique <samueloph@gmail.com>
Description:
 hoichess   - xboard compatible chess engine to play chess with
Closes: 847768
Changes:
 hoichess (0.21.0-2) unstable; urgency=medium
 .
   * d/p/agnostic*.patch: new patch to introduce reproducible builds, thanks to
     Daniel Shahaf <danielsh@apache.org> for creating the patch, Chris Lamb
     <lamby@debian.org> for reporting and helping with another patch and
     hoichess's upstream Holger Ruckdeschel <holger@hoicher.de> for the help
     (closes: #847768).
Checksums-Sha1:
 744e32b638dcfffdd298bbc8d29faa11be55a816 1921 hoichess_0.21.0-2.dsc
 82222820225a451e86275857c33766a31f3ebb67 6736 hoichess_0.21.0-2.debian.tar.xz
 86caf3b229eb79fd1f21c59c815040e511dd923e 5454 hoichess_0.21.0-2_source.buildinfo
Checksums-Sha256:
 0543ea8f5b5a7461f64b5257a5896a20d48e00843a994c037fe3a2dd1154d90f 1921 hoichess_0.21.0-2.dsc
 028509674d16c40bbf225b40f5f1875f5c99d306f136ce152bb34b2fa085b587 6736 hoichess_0.21.0-2.debian.tar.xz
 62c1542f292f41acee156f0edac634967a45440cde8db36f2008a0979afb2fec 5454 hoichess_0.21.0-2_source.buildinfo
Files:
 cfee0b42ae14bd3871943a4b8c5c85fa 1921 games optional hoichess_0.21.0-2.dsc
 20bd57659cf1b45603308b6dd22864a4 6736 games optional hoichess_0.21.0-2.debian.tar.xz
 44b8f7281a744f04270d62ed6e64dcf1 5454 games optional hoichess_0.21.0-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJIBAEBCAAyFiEExICiG1qOAnbrbFtuWYleRLFpYm0FAllQTUsUHHNhbXVlbG9w
aEBnbWFpbC5jb20ACgkQWYleRLFpYm07mBAAgJxirjvyBtAaGAdh/r7eCugDlXPT
skCRjrmGbEHfSQjhsyx5qUf0Ix9LnFImiR7vHF+o7vyWAIApiaYIeTmaciJ9jU9O
qeSsctBJM3IWcU1b956o3etA5flhmejDCtLD/GEPljKjogFqI65EbZDfMKQUXJew
M6qkkIRrZBAJkpwrTbCqbeB1atlpdBGRgkYOeL4hpTNkeQywakGCf94rg5ZWJKiz
2aPonBGOyeFyiE4zKaT5ymUFPzISa2R7JkIx+yYCduBCUNdHPXh8/XzkFRtYxrPr
yrUKKLQg3Ffoh1Q4ziZj/Ah1u8FcgB//N/NjUZYXStBgQhWkzANnq61CqhIH6Kwu
FpuBzf5mhzsMgraBskXeWPB7pWF8B526VdMnd42qiE682UsB/lH+noTEB4Hw+ux2
cL+f6UQct4hLYxgLpH9Ke+tX7f2ZjBbXDiQXxOnihPJ06H1fw/Z43Fk2/Lto1wId
a6qpxX0bY2zw8qUUzyVqfXjyVRG3BUMkSHx8XzOvlUxXmY7vdwj1QhbfZ4ebU15d
n70yt7OrvrXuFaeSh0KpNyMoMsjArPdthYxV0J9s/Tp82WHWi7Or3NFma0FVJsaB
82hx/QH4ljH6F/Ynefs/YNurXxjUbOopcIELuRGEQhcFYvcvSwJc9jAtXtrhiX5B
COq9Gf7QZB0A6TI=
=VZt+
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.