Debian Bug report logs - #845782
hannah: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Reiner Herrmann <reiner@reiner-h.de>

To: submit@bugs.debian.org

Subject: hannah: please make the build reproducible

Date: Sat, 26 Nov 2016 18:09:46 +0100

[Message part 1 (text/plain, inline)]

Source: hannah
Version: 1.0-3
Severity: wishlist
Tags: patch upstream
User: reproducible-builds@lists.alioth.debian.org
Usertags: fileordering
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that hannah could not be built reproducibly.
During build objects are linked in non-deterministic order.

The attached patch fixes this by sorting the list of source files.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds

[hannah.patch (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 845782@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: 845782@bugs.debian.org, 901260@bugs.debian.org

Subject: NMU for reproducible builds and cross building

Date: Thu, 06 Oct 2022 17:25:13 -0700

[Message part 1 (text/plain, inline)]

I've submitted NMUs to DELAYED/10 fixing reproducible builds and cross
building issues:

diff -Nru hannah-1.0/debian/changelog hannah-1.0/debian/changelog
--- hannah-1.0/debian/changelog	2021-01-03 03:25:33.000000000 -0800
+++ hannah-1.0/debian/changelog	2022-10-06 17:14:03.000000000 -0700
@@ -1,3 +1,23 @@
+hannah (1.0-3.3) unstable; urgency=medium
+
+  * Non-maintainer upload.
+
+  [ Helmut Grohne ]
+  * Fix FTCBFS: Let dh_auto_build pass cross tools to make.
+    (Closes: #901260)
+
+ -- Vagrant Cascadian <vagrant@reproducible-builds.org>  Thu, 06 Oct 2022 17:14:03 -0700
+
+hannah (1.0-3.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+
+  [ Reiner Herrmann ]
+  * Sort source files so that objects are linked in deterministic order
+    (Closes: #845782)
+
+ -- Vagrant Cascadian <vagrant@reproducible-builds.org>  Thu, 06 Oct 2022 16:48:01 -0700
+
 hannah (1.0-3.1) unstable; urgency=medium
 
   * Non maintainer upload by the Reproducible Builds team.
diff -Nru hannah-1.0/debian/patches/series hannah-1.0/debian/patches/series
--- hannah-1.0/debian/patches/series	2015-06-07 10:03:18.000000000 -0700
+++ hannah-1.0/debian/patches/series	2022-10-06 17:14:03.000000000 -0700
@@ -1,2 +1,3 @@
 fix_score_dir.diff
 fix-compiler-errors
+sort-source-files-so-that-objects-are-li.patch
diff -Nru hannah-1.0/debian/patches/sort-source-files-so-that-objects-are-li.patch hannah-1.0/debian/patches/sort-source-files-so-that-objects-are-li.patch
--- hannah-1.0/debian/patches/sort-source-files-so-that-objects-are-li.patch	1969-12-31 16:00:00.000000000 -0800
+++ hannah-1.0/debian/patches/sort-source-files-so-that-objects-are-li.patch	2022-10-06 17:14:03.000000000 -0700
@@ -0,0 +1,22 @@
+From: Reiner Herrmann <reiner@reiner-h.de>
+Date: Sat, 26 Nov 2016 18:09:46 +0100
+X-Dgit-Generated: 1.0-3.2 643a1240bd171728e30fc90e2af81db2b5a9c9a9
+Subject: Sort source files so that objects are linked in deterministic order
+
+(Closes: #845782)
+
+---
+
+diff --git a/Makefile b/Makefile
+index 643a8e8..4a55a77 100644
+--- a/Makefile
++++ b/Makefile
+@@ -24,7 +24,7 @@ LIBS     = $(shell sdl-config --libs) -lSDL_image -lSDL_ttf -lSDL_mixer
+ # target binary and directory name
+ OUT = hhh
+ # source and object files
+-SRCS = $(wildcard *.cc)
++SRCS = $(sort $(wildcard *.cc))
+ OBJS = $(patsubst %.cc, %.o, $(SRCS))
+ 
+ # what to build
diff -Nru hannah-1.0/debian/rules hannah-1.0/debian/rules
--- hannah-1.0/debian/rules	2015-06-07 10:03:18.000000000 -0700
+++ hannah-1.0/debian/rules	2022-10-06 17:14:03.000000000 -0700
@@ -9,7 +9,7 @@
 	dh $@
 
 override_dh_auto_build-arch:
-	$(MAKE) DATA_INSTALL_DIR=/usr/share/games/hannah/ \
+	dh_auto_build -- DATA_INSTALL_DIR=/usr/share/games/hannah/ \
 	    SCOREDIR=/var/games/hannah/ CXXFLAGS="$(CXXFLAGS)" CFLAGS="$(CFLAGS)" \
 	    LDFLAGS="$(LDFLAGS)"
 
live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 845782@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: 845782@bugs.debian.org, 901260@bugs.debian.org

Subject: Re: NMU for reproducible builds and cross building

Date: Thu, 06 Oct 2022 17:26:46 -0700

[Message part 1 (text/plain, inline)]

Control: tags 845782 pending
Control: tags 901260 pending

On 2022-10-06, Vagrant Cascadian wrote:
> I've submitted NMUs to DELAYED/10 fixing reproducible builds and cross
> building issues:

Marking as pending.

live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 845782-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 845782-close@bugs.debian.org

Subject: Bug#845782: fixed in hannah 1.0-3.2

Date: Mon, 17 Oct 2022 00:34:22 +0000

Source: hannah
Source-Version: 1.0-3.2
Done: Vagrant Cascadian <vagrant@reproducible-builds.org>

We believe that the bug you reported is fixed in the latest version of
hannah, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 845782@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@reproducible-builds.org> (supplier of updated hannah package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 06 Oct 2022 16:48:01 -0700
Source: hannah
Architecture: source
Version: 1.0-3.2
Distribution: unstable
Urgency: medium
Maintainer: Margarita Manterola <marga@debian.org>
Changed-By: Vagrant Cascadian <vagrant@reproducible-builds.org>
Closes: 845782
Changes:
 hannah (1.0-3.2) unstable; urgency=medium
 .
   * Non-maintainer upload.
 .
   [ Reiner Herrmann ]
   * Sort source files so that objects are linked in deterministic order
     (Closes: #845782)
Checksums-Sha1:
 37e1a498ab32062aa2e68c3ae1f9a5d18c69152b 1406 hannah_1.0-3.2.dsc
 30fe6617f69d4559842646a0daaee73f4b1cb384 7608 hannah_1.0-3.2.debian.tar.xz
Checksums-Sha256:
 1b692a87e44370ad835e351639868c5603fdbb8911a535c5a3b03c2eb26cb541 1406 hannah_1.0-3.2.dsc
 f6b393a0ac38318fdfb24fa20a280bfa0c45a90aaa38ca33231c6442e353d493 7608 hannah_1.0-3.2.debian.tar.xz
Files:
 f4f80bd7b43238901a6bcecbb6c89e9c 1406 games extra hannah_1.0-3.2.dsc
 7fa7cf9226b74e00e663ba04e33fbbf3 7608 games extra hannah_1.0-3.2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iJYEARYKAD4WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYz9qNyAcdmFncmFudEBy
ZXByb2R1Y2libGUtYnVpbGRzLm9yZwAKCRDcUY/If5cWqlB3AQD4pX+emBgOTtlY
drkEkhrGyWWJyHv+UVDmY6WfMscolQD/UvM0ozdqhOI3ZPjl0Bgq69gkvX7IRA6p
Ht6Wcrh8XwY=
=Sho0
-----END PGP SIGNATURE-----

Message #27 received at 845782-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 845782-close@bugs.debian.org

Subject: Bug#845782: fixed in hannah 1.0-3.3

Date: Mon, 17 Oct 2022 00:49:22 +0000

Source: hannah
Source-Version: 1.0-3.3
Done: Vagrant Cascadian <vagrant@reproducible-builds.org>

We believe that the bug you reported is fixed in the latest version of
hannah, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 845782@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@reproducible-builds.org> (supplier of updated hannah package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 06 Oct 2022 17:14:03 -0700
Source: hannah
Architecture: source
Version: 1.0-3.3
Distribution: unstable
Urgency: medium
Maintainer: Margarita Manterola <marga@debian.org>
Changed-By: Vagrant Cascadian <vagrant@reproducible-builds.org>
Closes: 845782 901260
Changes:
 hannah (1.0-3.3) unstable; urgency=medium
 .
   * Non-maintainer upload.
 .
   [ Helmut Grohne ]
   * Fix FTCBFS: Let dh_auto_build pass cross tools to make.
     (Closes: #901260)
 .
 hannah (1.0-3.2) unstable; urgency=medium
 .
   * Non-maintainer upload.
 .
   [ Reiner Herrmann ]
   * Sort source files so that objects are linked in deterministic order
     (Closes: #845782)
Checksums-Sha1:
 436d5f19f1e10a525daff21d859b482d3ca20a6b 1406 hannah_1.0-3.3.dsc
 c3861769ba4d90412f7a05d7fde769ed41bb2e69 7664 hannah_1.0-3.3.debian.tar.xz
Checksums-Sha256:
 e80a870b93b099b804153ad44315824ed5b1580d2e389551f41fcbf09899a5df 1406 hannah_1.0-3.3.dsc
 d64509ff32a9dc7cac5a75e96c7aeaaf7e330242065ee43de4398bde0b4e9540 7664 hannah_1.0-3.3.debian.tar.xz
Files:
 79d916c24f4bf74bddc92299b575c845 1406 games extra hannah_1.0-3.3.dsc
 341389cd8dc65c227ec8b3dccc4be470 7664 games extra hannah_1.0-3.3.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iJYEARYKAD4WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYz9v3yAcdmFncmFudEBy
ZXByb2R1Y2libGUtYnVpbGRzLm9yZwAKCRDcUY/If5cWql1LAQCDuD7Uuu9avtAY
G40kgbpJhYYxBtSLhleZrF6fQTOuBQEAqKMo/0mDrPt585uYWZsPDpcyTQRlLagT
trWprmVl9ww=
=ABsR
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.