Debian Bug report logs - #845779
flash-kernel: flashkernel uses mkimage -A arm on arm64

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Heinrich Schuchardt <xypron.glpk@gmx.de>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: flash-kernel: flashkernel uses mkimage -A arm on arm64

Date: Sat, 26 Nov 2016 16:54:47 +0000

Package: flash-kernel
Version: 3.71
Severity: normal

Dear Maintainer,

I want to get the Hardkernel Odroid C2 supported by flash-kernel.

It is a 64bit system.

Unfortunately in file /usr/share/flash-kernel/functions the functions
mkimage_kernel() and mkimage_initrd() both call mkimage with argument

 -A arm .

This is incorrect. On 64bit arm systems you have to use

 -A arm64 .

Otherwise neither u-boot nor the kernel can read the images.

I suggest to use `uname -m` to determine the architectue.
If it is aarch64 use mkimage -A arm64.

Best regards

Heinrich Schuchardt

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: arm64 (aarch64)

Kernel: Linux 4.9.0-rc6-next-20161124 (SMP w/4 CPU cores; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages flash-kernel depends on:
ii  debconf [debconf-2.0]  1.5.59
ii  devio                  1.2-1.2
ii  initramfs-tools        0.125
ii  linux-base             4.5
ii  mtd-utils              1:1.5.2-1
ii  ucf                    3.0036

Versions of packages flash-kernel recommends:
ii  u-boot-tools  2016.11+dfsg1-1

flash-kernel suggests no packages.

-- debconf information:
  flash-kernel/linux_cmdline: quiet

Message #10 received at 845779@bugs.debian.org (full text, mbox, reply):

From: Heinrich Schuchardt <xypron.glpk@gmx.de>

To: 845779@bugs.debian.org

Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>

Subject: [PATCH 1/1] functions: call mkimage with correct architecture

Date: Sat, 26 Nov 2016 17:32:06 +0000

64bit u-boot and kernel cannot load 32bit u-boot images.

Hence on 32bit arm systems use 'mkimage -A arm',
on 64bit arm systems use 'mkimage -A arm64'.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 functions | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/functions b/functions
index 368cbf2..a62ea4c 100644
--- a/functions
+++ b/functions
@@ -33,6 +33,15 @@ read_machine_db() {
 }
 MACHINE_DB="$(read_machine_db)"
 
+get_mkimage_architecture() {
+	local arch="$(uname -m)"
+	case "$arch" in
+		"aarch64") echo "arm64" ;;
+		*)	   echo "arm"   ;;
+	esac
+	}
+MKARCH="$(get_mkimage_architecture)"
+
 error() {
 	echo "$@" >&2
 	exit 1
@@ -423,7 +432,7 @@ mkimage_kernel() {
 	local uimage="$5"
 
 	printf "Generating kernel u-boot image... " >&2
-	mkimage -A arm -O linux -T kernel -C none -a "$kaddr" -e "$epoint" \
+	mkimage -A "$MKARCH" -O linux -T kernel -C none -a "$kaddr" -e "$epoint" \
 		-n "$kdesc" -d "$kdata" "$uimage" >&2 1>/dev/null
 	echo "done." >&2
 }
@@ -435,7 +444,7 @@ mkimage_initrd() {
 	local uinitrd="$4"
 
 	printf "Generating initramfs u-boot image... " >&2
-	mkimage -A arm -O linux -T ramdisk -C none -a "$iaddr" -e "$iaddr" \
+	mkimage -A "$MKARCH" -O linux -T ramdisk -C none -a "$iaddr" -e "$iaddr" \
 		-n "$idesc" -d "$idata" "$uinitrd" >&2 1>/dev/null
 	echo "done." >&2
 }
@@ -459,7 +468,7 @@ mkimage_script() {
                   s/@@UBOOT_ENV_EXTRA@@//g
                   r $ubootenv
                 }" < $sdata > $tdata
-	mkimage -A arm -O linux -T script -C none -a "$saddr" -e "$saddr" \
+	mkimage -A "$MKARCH" -O linux -T script -C none -a "$saddr" -e "$saddr" \
 		-n "$sdesc" -d "$tdata" "$script" >&2 1>/dev/null
 	echo "done." >&2
 }
@@ -472,7 +481,7 @@ mkimage_multi() {
 	local umulti="$5"
 
 	printf "Generating u-boot image..." >&2
-	mkimage -A arm -O linux -T multi -C none -a "$maddr" -e "$maddr" \
+	mkimage -A "$MKARCH" -O linux -T multi -C none -a "$maddr" -e "$maddr" \
 		-n "$mdesc" -d "$kdata:$idata" "$umulti" >&2 1>/dev/null
 	echo "done." >&2
 }
-- 
2.10.2

Message #15 received at 845779@bugs.debian.org (full text, mbox, reply):

From: Ben Hutchings <ben@decadent.org.uk>

To: Heinrich Schuchardt <xypron.glpk@gmx.de>, 845779@bugs.debian.org

Subject: Re: Bug#845779: flash-kernel: flashkernel uses mkimage -A arm on arm64

Date: Sat, 26 Nov 2016 19:45:32 +0000

[Message part 1 (text/plain, inline)]

On Sat, 2016-11-26 at 16:54 +0000, Heinrich Schuchardt wrote:
> Package: flash-kernel
> Version: 3.71
> Severity: normal
> 
> Dear Maintainer,
> 
> I want to get the Hardkernel Odroid C2 supported by flash-kernel.
> 
> It is a 64bit system.
> 
> Unfortunately in file /usr/share/flash-kernel/functions the functions
> mkimage_kernel() and mkimage_initrd() both call mkimage with argument
> 
>  -A arm .
> 
> This is incorrect. On 64bit arm systems you have to use
> 
>  -A arm64 .
> 
> Otherwise neither u-boot nor the kernel can read the images.
> 
> I suggest to use `uname -m` to determine the architectue.
> If it is aarch64 use mkimage -A arm64.

I think it's currently possible to use flash-kernel:armhf on an arm64
system to build an armhf image, and this would break that.  Given that
flash-kernel is an arch-dependent package, I think it should use the
package architecture here instead of `uname -m`.

(But since flash-kernel doesn't contain any native code, I think it
wwould be even better to make it arch-independent and to specify the
machine architecture in each entry in db/all.db.)

Ben.

-- 
Ben Hutchings
Beware of programmers who carry screwdrivers. - Leonard Brandwein

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 845779@bugs.debian.org (full text, mbox, reply):

From: Heinrich Schuchardt <xypron.glpk@gmx.de>

To: Ben Hutchings <ben@decadent.org.uk>, 845779@bugs.debian.org

Subject: Re: Bug#845779: flash-kernel: flashkernel uses mkimage -A arm on arm64

Date: Sun, 27 Nov 2016 09:31:33 +0100

> 
> I think it's currently possible to use flash-kernel:armhf on an
> arm64 system to build an armhf image, and this would break that.
> Given that flash-kernel is an arch-dependent package, I think it
> should use the package architecture here instead of `uname -m`.
> 
> (But since flash-kernel doesn't contain any native code, I think
> it wwould be even better to make it arch-independent and to specify
> the machine architecture in each entry in db/all.db.)
> 
> Ben.
> 

Specifying the machine architecture in db/all.db will not solve the
problem.

The key field for all.db is the "Machine" property read from
/proc/device-tree/model. (It would be safer to read the property from
the new dtb to be installed because the model property may change over
time as has happened for the "Wandboard i.MX6 Quad Board rev B1".)

If a system is supported both by armhf and arm64 kernels we cannot
safely assume that the model property is different. Both armhf and
arm64 kernels might (or even should) be using the same device tree.

If we want to provide the package architecture we would have to pass
it to the kernel hooks.
linux-image-3.16.0-4-amd64.postinst has variable $arch.
Unfortunately it is missing in linux-image-4.7.0-1-amd64.postinst.
We could copy the architecture to an environment variable here, e.g.

$ENV{'DEB_ARCH'}="$arch";

Best regards

Heinrich Schuchardt

Message #25 received at 845779@bugs.debian.org (full text, mbox, reply):

From: Heinrich Schuchardt <xypron.glpk@gmx.de>

To: 845779@bugs.debian.org

Cc: Ben Hutchings <ben@decadent.org.uk>, Heinrich Schuchardt <xypron.glpk@gmx.de>

Subject: [PATCH 1/1 v2] functions: call mkimage with correct architecture

Date: Sun, 11 Dec 2016 19:26:44 +0100

64bit u-boot and kernel cannot load 32bit u-boot images.

Hence on 32bit arm systems use 'mkimage -A arm',
on 64bit arm systems use 'mkimage -A arm64'.

We can determine the bitness of the newly installed kernel
by using function get_kfile_suffix() which returns the last
part of the kernel version.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
v2:
        Do not rely on uname -m for determining the architecture
        of the newly installed kernel as it may differ from the 
        old architecture.

 functions      | 17 +++++++++++++----
 test_functions |  3 +++
 2 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/functions b/functions
index 368cbf2..893897d 100644
--- a/functions
+++ b/functions
@@ -212,6 +212,14 @@ get_machine_field() {
 	}
 }
 
+get_mkimage_architecture() {
+	kfile_suffix=$(get_kfile_suffix "$1")
+	case "$kfile_suffix" in
+		"arm64") echo "arm64";;
+		*) echo "arm";;
+	esac
+}
+
 get_dtb_name() {
 	local field="$(get_machine_field "$machine" "DTB-Id")" || :
 	case "$field" in
@@ -423,7 +431,7 @@ mkimage_kernel() {
 	local uimage="$5"
 
 	printf "Generating kernel u-boot image... " >&2
-	mkimage -A arm -O linux -T kernel -C none -a "$kaddr" -e "$epoint" \
+	mkimage -A "$mkarch" -O linux -T kernel -C none -a "$kaddr" -e "$epoint" \
 		-n "$kdesc" -d "$kdata" "$uimage" >&2 1>/dev/null
 	echo "done." >&2
 }
@@ -435,7 +443,7 @@ mkimage_initrd() {
 	local uinitrd="$4"
 
 	printf "Generating initramfs u-boot image... " >&2
-	mkimage -A arm -O linux -T ramdisk -C none -a "$iaddr" -e "$iaddr" \
+	mkimage -A "$mkarch" -O linux -T ramdisk -C none -a "$iaddr" -e "$iaddr" \
 		-n "$idesc" -d "$idata" "$uinitrd" >&2 1>/dev/null
 	echo "done." >&2
 }
@@ -459,7 +467,7 @@ mkimage_script() {
                   s/@@UBOOT_ENV_EXTRA@@//g
                   r $ubootenv
                 }" < $sdata > $tdata
-	mkimage -A arm -O linux -T script -C none -a "$saddr" -e "$saddr" \
+	mkimage -A "$mkarch" -O linux -T script -C none -a "$saddr" -e "$saddr" \
 		-n "$sdesc" -d "$tdata" "$script" >&2 1>/dev/null
 	echo "done." >&2
 }
@@ -472,7 +480,7 @@ mkimage_multi() {
 	local umulti="$5"
 
 	printf "Generating u-boot image..." >&2
-	mkimage -A arm -O linux -T multi -C none -a "$maddr" -e "$maddr" \
+	mkimage -A "$mkarch" -O linux -T multi -C none -a "$maddr" -e "$maddr" \
 		-n "$mdesc" -d "$kdata:$idata" "$umulti" >&2 1>/dev/null
 	echo "done." >&2
 }
@@ -765,6 +773,7 @@ fi
 
 echo "flash-kernel: installing version $kvers" >&2
 
+mkarch="$(get_mkimage_architecture $kvers)"
 machine_id="$(get_machine_field "$machine" "Machine-Id")" || :
 method="$(get_machine_field "$machine" "Method")" || method="generic"
 mtd_kernel="$(get_machine_field "$machine" "Mtd-Kernel")" || :
diff --git a/test_functions b/test_functions
index c28904e..e75b089 100755
--- a/test_functions
+++ b/test_functions
@@ -576,6 +576,7 @@ test_mkimage_kernel() {
         }
         . "$functions"
         saved_args=""
+        mkarch="arm"
         mkimage_kernel "0xdeadbeef" "0xbaddcafe" "desc" "input" "output" 2>/dev/null
         expected="-A arm -O linux -T kernel -C none -a 0xdeadbeef -e 0xbaddcafe -n desc -d input output"
         if [ "$expected" != "$saved_args" ]; then
@@ -593,6 +594,7 @@ test_mkimage_initrd() {
         }
         . "$functions"
         saved_args=""
+        mkarch="arm"
         mkimage_initrd "0xdeadbeef" "desc" "input" "output" 2>/dev/null
         expected="-A arm -O linux -T ramdisk -C none -a 0xdeadbeef -e 0xdeadbeef -n desc -d input output"
         if [ "$expected" != "$saved_args" ]; then
@@ -610,6 +612,7 @@ test_mkimage_multi() {
         }
         . "$functions"
         saved_args=""
+        mkarch="arm"
         mkimage_multi "0xdeadbeef" "desc" "kinput" "iinput" "output" 2>/dev/null
         expected="-A arm -O linux -T multi -C none -a 0xdeadbeef -e 0xdeadbeef -n desc -d kinput:iinput output"
         if [ "$expected" != "$saved_args" ]; then
-- 
2.10.2

Message #30 received at 845779@bugs.debian.org (full text, mbox, reply):

From: Martin Michlmayr <tbm@cyrius.com>

To: Heinrich Schuchardt <xypron.glpk@gmx.de>, 845779@bugs.debian.org

Subject: Re: Bug#845779: flash-kernel: flashkernel uses mkimage -A arm on arm64

Date: Sat, 17 Dec 2016 14:22:39 -0800

* Heinrich Schuchardt <xypron.glpk@gmx.de> [2016-11-26 16:54]:
> I want to get the Hardkernel Odroid C2 supported by flash-kernel.
> 
> It is a 64bit system.
> 
> Unfortunately in file /usr/share/flash-kernel/functions the functions
> mkimage_kernel() and mkimage_initrd() both call mkimage with argument
> 
>  -A arm .
> 
> This is incorrect. On 64bit arm systems you have to use
> 
>  -A arm64 .
> 
> Otherwise neither u-boot nor the kernel can read the images.

Your latest patch looks fine to me but I'm wondering why this is
needed in the first place.

On modern devices, we no longer wrap the kernel and initrd into an
u-boot image, but we boot it directly using bootz (arm) or booti
(arm64).

I see there's also one "mkimage -A arm" call to generate the boot
script.  Is that's what causing you the problem?

-- 
Martin Michlmayr
http://www.cyrius.com/

Message #35 received at 845779@bugs.debian.org (full text, mbox, reply):

From: Heinrich Schuchardt <xypron.glpk@gmx.de>

To: Martin Michlmayr <tbm@cyrius.com>, 845779@bugs.debian.org

Subject: Re: Bug#845779: flash-kernel: flashkernel uses mkimage -A arm on arm64

Date: Sun, 18 Dec 2016 10:02:42 +0100

On 12/17/2016 11:22 PM, Martin Michlmayr wrote:
> * Heinrich Schuchardt <xypron.glpk@gmx.de> [2016-11-26 16:54]:
>> I want to get the Hardkernel Odroid C2 supported by flash-kernel.
>>
>> It is a 64bit system.
>>
>> Unfortunately in file /usr/share/flash-kernel/functions the functions
>> mkimage_kernel() and mkimage_initrd() both call mkimage with argument
>>
>>  -A arm .
>>
>> This is incorrect. On 64bit arm systems you have to use
>>
>>  -A arm64 .
>>
>> Otherwise neither u-boot nor the kernel can read the images.
> 
> Your latest patch looks fine to me but I'm wondering why this is
> needed in the first place.
> 
> On modern devices, we no longer wrap the kernel and initrd into an
> u-boot image, but we boot it directly using bootz (arm) or booti
> (arm64).
> 
> I see there's also one "mkimage -A arm" call to generate the boot
> script.  Is that's what causing you the problem?
> 
Hello Martin,

for my Hardkernel Odroid C2 mailine U-Boot support is still incomplete.
It can only boot from tftp.

The legacy U-Boot provided by Hardkernel has a booti command but it
crashes with a mainline kernel.

The legacy kernel image does not start with 4D 5A (MZ) as normal images do.

So unfortunately currently I am stuck with bootm.

With my patch package flash-kernel is usable after updating the database
(cf. #845818).

Looking at the flash-kernel package you will find
/etc/flash-kernel/bootscript/bootscr.xgene-mustang uses bootm too.

Best regards

Heinrich Schuchardt

Message #40 received at 845779@bugs.debian.org (full text, mbox, reply):

From: Martin Michlmayr <tbm@cyrius.com>

To: Heinrich Schuchardt <xypron.glpk@gmx.de>

Cc: 845779@bugs.debian.org

Subject: Re: Bug#845779: flash-kernel: flashkernel uses mkimage -A arm on arm64

Date: Mon, 2 Jan 2017 15:17:32 -0800

Thanks, I applied this patch.

U-boot on the ARM64 system I tested (a Jetson TX1) accepts boot
scripts with both -A arm and -A arm64, but as you point out this may
not be the case on all systems.

-- 
Martin Michlmayr
http://www.cyrius.com/

Message #45 received at 845779@bugs.debian.org (full text, mbox, reply):

From: Geert Stappers <stappers@stappers.nl>

To: 845779@bugs.debian.org

Subject: Re: Bug#845779: flash-kernel: flashkernel uses mkimage -A arm on arm64

Date: Wed, 4 Jan 2017 21:41:55 +0100

On Mon, Jan 02, 2017 at 03:17:32PM -0800, Martin Michlmayr wrote:
> Thanks, I applied this patch.

Cross-reference to related bugreport
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=845818

Message #50 received at 845779-close@bugs.debian.org (full text, mbox, reply):

From: Christian Perrier <bubulle@debian.org>

To: 845779-close@bugs.debian.org

Subject: Bug#845779: fixed in flash-kernel 3.74

Date: Wed, 11 Jan 2017 06:03:29 +0000

Source: flash-kernel
Source-Version: 3.74

We believe that the bug you reported is fixed in the latest version of
flash-kernel, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 845779@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christian Perrier <bubulle@debian.org> (supplier of updated flash-kernel package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 11 Jan 2017 05:48:07 +0100
Source: flash-kernel
Binary: flash-kernel flash-kernel-installer
Architecture: source armel
Version: 3.74
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Christian Perrier <bubulle@debian.org>
Description:
 flash-kernel - utility to make certain embedded devices bootable
 flash-kernel-installer - Make the system bootable (udeb)
Closes: 789886 836679 845779
Changes:
 flash-kernel (3.74) unstable; urgency=medium
 .
   [ Martin Michlmayr ]
   * Add machine db entry for Marvell ESPRESSOBin.
   * Only create DTB boot file on kernels that require DTB (Closes:
     #789886)
   * Improve error message when DTB is missing by showing the search
     path for DTB (Closes: #836679)
 .
   [ Heinrich Schuchardt ]
   * Call mkimage with correct architecture (Closes: #845779)
Checksums-Sha1:
 255dfcc8f9fbd2a1ede08952a42aba7f928bc21f 1859 flash-kernel_3.74.dsc
 869988e9997275f2e2f880c317acbfa0680dbd42 68628 flash-kernel_3.74.tar.xz
 f4146efedaeba1fe6a8ea429eaa6e715a4831577 25674 flash-kernel-installer_3.74_armel.udeb
 8a9d73437dda912554fa9fe7fe45315d01f4fe51 4929 flash-kernel_3.74_armel.buildinfo
 44a5032f36d53d60ea32bac55ae17e52d6c2b935 45276 flash-kernel_3.74_armel.deb
Checksums-Sha256:
 a1383a29b47b7dfd0f67f185ebaf6b2684fb7fe37dd57ca1d02809e3cabcbd52 1859 flash-kernel_3.74.dsc
 79dea0248999d4e384121c6dbe0abbbd9b05c2059e523d586525ebbacce6c9f0 68628 flash-kernel_3.74.tar.xz
 bf3c19a642394c25672b97aacb6d3ee3d195cd30bbb7098cae9850ad8e5775f7 25674 flash-kernel-installer_3.74_armel.udeb
 7d32537fb8f05b78c4514531537dc0366b8a8adad590611d469b2be7a05e3205 4929 flash-kernel_3.74_armel.buildinfo
 cd82bae71a78187976f2c1bede78b0854054b3309b86a439d1a83fdada3a921c 45276 flash-kernel_3.74_armel.deb
Files:
 cb847bccf5f829a6a44838dd507d7830 1859 utils optional flash-kernel_3.74.dsc
 eea9a3f7e5248bc1b9db8007f2eb07a5 68628 utils optional flash-kernel_3.74.tar.xz
 d97ecba735e92b8caf1456ac74cf8161 25674 debian-installer standard flash-kernel-installer_3.74_armel.udeb
 6df94026ab9a103565ee7c70a80d0de2 4929 utils optional flash-kernel_3.74_armel.buildinfo
 35fcb60f9f60c710baadeef7e7bcb339 45276 utils optional flash-kernel_3.74_armel.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJYdcd/AAoJEIcvcCxNbiWomscQAKhlnJiZe71HZdrXgdz8BXTb
9lWJ0W2eWtq7FCXL6C0omdd707WQOas87Un/LR8FZAXu57WUEGPCLfCQZBjKnttn
baTeL8w7/vHwF08EK2GCa1y0iBh6augDt2uCUsjv7xILuNhC4B0SZVPUnYlcX57H
PdwDR8F7q0Lbv1EFBD1FQHWFw0YsVhn+3NQV3pXc9aXJTPS6tO8hq00VWqsvmPAv
I1PP1GDDJM29/AtLCQEICdTxpvdGOypF02tv0Ve64YW++MsJxuu6PQdwBS0b8U9H
x4KHjwqMw4IVwQ2SFD+do3TtsLRz8ePa+06Zuk/dmRt2130Eke6CWahlxW9fLAAb
btuFd4WGI/oApPNMUnlM7c952Bii0CeQGpJo62Wh+5/P7FGCaM6ZfU6RTcQWE3SG
jJb64Qgo1ZKwd8ebC9OwMFQKCBgNWN0ZZHIcytR9vfhzQ1NYP6V7NAiGkpdZ8ndE
jmtGAgcoMhGnu3jhmDistllvaA48zjy8A4YkQmjSlYzyYixcPJ4UGk3BHF9nOavm
Snyf1CUsWWPdGC8zd9Ea2PqvYTLWXCKngKh4o1wFRd0y9eGnKmeiXdsWPmG1IkJn
kgdffPuIjUVhwh8un/JSPvGKVdrq9Dnht1fmlq7X9WsdgYunRCkGCp8HYiOWcHbf
66SKvKA1qzLQfmnWXnkE
=nnGr
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.