Debian Bug report logs - #845282
pcsc-tools: please make the build reproducible (buildpath)

version graph

Package: src:pcsc-tools; Maintainer for src:pcsc-tools is Ludovic Rousseau <rousseau@debian.org>;

Reported by: Daniel Shahaf <danielsh@apache.org>

Date: Tue, 22 Nov 2016 06:30:01 UTC

Severity: wishlist

Tags: patch, upstream

Found in version pcsc-tools/1.4.27-1

Fixed in version pcsc-tools/1.5.1-1

Done: Ludovic Rousseau <ludovic.rousseau@free.fr>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, danielsh@apache.org, reproducible-bugs@lists.alioth.debian.org, danielsh@apache.org, Ludovic Rousseau <rousseau@debian.org>:
Bug#845282; Package src:pcsc-tools. (Tue, 22 Nov 2016 06:30:03 GMT) (full text, mbox, link).


Acknowledgement sent to Daniel Shahaf <danielsh@apache.org>:
New Bug report received and forwarded. Copy sent to danielsh@apache.org, reproducible-bugs@lists.alioth.debian.org, danielsh@apache.org, Ludovic Rousseau <rousseau@debian.org>. (Tue, 22 Nov 2016 06:30:03 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Daniel Shahaf <danielsh@apache.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: pcsc-tools: please make the build reproducible (buildpath)
Date: Tue, 22 Nov 2016 06:23:55 +0000
Source: pcsc-tools
Version: 1.4.27-1
Severity: wishlist
Tags: upstream patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath

Hi!

While working on the “reproducible builds” effort [1], we have noticed
that pcsc-tools could not be built reproducibly.

Specifically, the build process embeds a (munged version of) the
absolute source directory in the package:

    https://tests.reproducible-builds.org/debian/dbdtxt/unstable/amd64/pcsc-tools_1.4.27-1.diffoscope.txt
    # Build directory: /build/pcsc-tools-1.4.27/2nd
       0x000019d0                00 5620312e 342e3237        .V 1.4.27
    +  0x000019e0 2f326e64 20286329 20323030 312d3230 /2nd (c) 2001-20
    +  0x000019f0 31312c20 4c75646f 76696320 526f7573 11, Ludovic Rous
    +  0x00001a00 73656175 203c6c75 646f7669 632e726f seau <ludovic.ro
    +  0x00001a10 75737365 61754066 7265652e 66723e00 usseau@free.fr>.

Patch attached.

[[[
--- a/Makefile
+++ b/Makefile
@@ -5,7 +5,7 @@
 # by default install in /usr/local
 DESTDIR ?= /usr/local
 
-VERSION := $(shell pwd | sed s/.*tools-//)
+VERSION := $(shell <Changelog head -n1 | grep -o 'pcsc-tools-[^,]\+')
 CFLAGS := $(CFLAGS) -DVERSION=\"$(VERSION)\" $(PCSC_CFLAGS)
 LDLIBS := $(PCSC_LDLIBS)
 # On xBSD systems use
]]]

Cheers,

Daniel

 [1]: https://wiki.debian.org/ReproducibleBuilds



Marked as fixed in versions pcsc-tools/1.5.0-1. Request was from Ludovic Rousseau <ludovic.rousseau@free.fr> to control@bugs.debian.org. (Sun, 24 Dec 2017 17:30:03 GMT) (full text, mbox, link).


Reply sent to Ludovic Rousseau <ludovic.rousseau@free.fr>:
You have taken responsibility. (Sun, 24 Dec 2017 17:30:06 GMT) (full text, mbox, link).


Notification sent to Daniel Shahaf <danielsh@apache.org>:
Bug acknowledged by developer. (Sun, 24 Dec 2017 17:30:06 GMT) (full text, mbox, link).


Message #12 received at 845282-done@bugs.debian.org (full text, mbox, reply):

From: Ludovic Rousseau <ludovic.rousseau@free.fr>
To: 845282-done@bugs.debian.org
Cc: control@bugs.debian.org
Subject: Re: pcsc-tools: please make the build reproducible (buildpath)
Date: Sun, 24 Dec 2017 18:18:56 +0100
fixed 845282 1.5.0-1
thank

Hello,

pcsc-tools uses automake since version 1.5.0.
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/pcsc-tools.html indicates that the package is now build reproducible.

Closing the bug.

On Tue, 22 Nov 2016 06:23:55 +0000 Daniel Shahaf <danielsh@apache.org> wrote:
> Source: pcsc-tools
> Version: 1.4.27-1
> Severity: wishlist
> Tags: upstream patch
> User: reproducible-builds@lists.alioth.debian.org
> Usertags: buildpath
> 
> Hi!
> 
> While working on the “reproducible builds” effort [1], we have noticed
> that pcsc-tools could not be built reproducibly.
> 
> Specifically, the build process embeds a (munged version of) the
> absolute source directory in the package:
> 
>     https://tests.reproducible-builds.org/debian/dbdtxt/unstable/amd64/pcsc-tools_1.4.27-1.diffoscope.txt
>     # Build directory: /build/pcsc-tools-1.4.27/2nd
>        0x000019d0                00 5620312e 342e3237        .V 1.4.27
>     +  0x000019e0 2f326e64 20286329 20323030 312d3230 /2nd (c) 2001-20
>     +  0x000019f0 31312c20 4c75646f 76696320 526f7573 11, Ludovic Rous
>     +  0x00001a00 73656175 203c6c75 646f7669 632e726f seau <ludovic.ro
>     +  0x00001a10 75737365 61754066 7265652e 66723e00 usseau@free.fr>.
> 
> Patch attached.
> 
> [[[
> --- a/Makefile
> +++ b/Makefile
> @@ -5,7 +5,7 @@
>  # by default install in /usr/local
>  DESTDIR ?= /usr/local
>  
> -VERSION := $(shell pwd | sed s/.*tools-//)
> +VERSION := $(shell <Changelog head -n1 | grep -o 'pcsc-tools-[^,]\+')
>  CFLAGS := $(CFLAGS) -DVERSION=\"$(VERSION)\" $(PCSC_CFLAGS)
>  LDLIBS := $(PCSC_LDLIBS)
>  # On xBSD systems use
> ]]]
> 
> Cheers,
> 
> Daniel
> 
>  [1]: https://wiki.debian.org/ReproducibleBuilds
> 
> 

-- 
 Dr. Ludovic Rousseau



No longer marked as fixed in versions pcsc-tools/1.5.0-1. Request was from Andreas Beckmann <anbe@debian.org> to control@bugs.debian.org. (Sun, 08 Jul 2018 22:30:44 GMT) (full text, mbox, link).


Marked as fixed in versions pcsc-tools/1.5.1-1. Request was from Andreas Beckmann <anbe@debian.org> to control@bugs.debian.org. (Sun, 08 Jul 2018 22:30:45 GMT) (full text, mbox, link).


Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Mon, 06 Aug 2018 07:36:40 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Wed May 17 14:06:14 2023; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.