Debian Bug report logs - #845203
strip-nondeterminism: Please support normalising NTFS timestamps in zip files

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: submit@bugs.debian.org

Subject: strip-nondeterminism: Please support normalising NTFS timestamps in zip files

Date: Mon, 21 Nov 2016 13:39:20 +0100

Package: strip-nondeterminism
Version: 0.028-1
Severity: wishlist

Hi,

(Forwarding message)

"""
If you do this twice:

  7z u -tzip $some_zip $some_path/$some_file
  strip-nondeterminism --timestamp $some_zip

and then diffoscope the two results I *expect* them to be
indentical, but I get this for each folder of $some_path:

│ @@ -68,15 +68,15 @@
│    disk number on which file begins:               disk 1
│    apparent file type:                             binary
│    Unix file attributes (040755 octal):            drwxr-xr-x
│    MS-DOS file attributes (10 hex):                dir 
│  
│    The central-directory extra field contains:
│    - A subfield with ID 0x000a (PKWARE Win32) and 32 data bytes.  The first
│ -    20 are:   00 00 00 00 01 00 18 00 80 58 28 6d e8 43 d2 01 80 58 28 6d.
│ +    20 are:   00 00 00 00 01 00 18 00 00 8a 4d b2 ea 43 d2 01 00 8a 4d b2.
│  
│    There is no file comment.

and this for $some_file:

│    There are an extra -36 bytes preceding this file.
│ @@ -51129,15 +51129,15 @@
│    disk number on which file begins:               disk 1
│    apparent file type:                             binary
│    Unix file attributes (100644 octal):            -rw-r--r--
│    MS-DOS file attributes (00 hex):                none
│  
│    The central-directory extra field contains:
│    - A subfield with ID 0x000a (PKWARE Win32) and 32 data bytes.  The first
│ -    20 are:   00 00 00 00 01 00 18 00 80 58 28 6d e8 43 d2 01 80 58 28 6d.
│ +    20 are:   00 00 00 00 01 00 18 00 00 8a 4d b2 ea 43 d2 01 00 8a 4d b2.
│  
│    There is no file comment.

However, if I pass `-mtc=off` to 7z, all is fine. That
disables "NTFS timestamps for files: Modification time, Creation
time, Last access time". So it seems strip-nondeterminism is not
aware of this timestamp at the moment.
"""


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #10 received at 845203@bugs.debian.org (full text, mbox, reply):

From: u <u@451f.org>

To: 845203@bugs.debian.org

Subject: Example output

Date: Mon, 21 Nov 2016 13:50:00 +0000

FWIW, one can see the contents of those header fields as follows (only
visible on directories as it looks like):

@unzip -ZTv $some_zip@

Example output:

entral directory entry #1:
---------------------------

  chrome/

  offset of local header from start of archive:   0
                                                  (0000000000000000h) bytes
  file system or operating system of origin:      Unix
  version of encoding software:                   6.3
  minimum file system compatibility required:     Unix
  minimum software version required to extract:   2.0
  compression method:                             none (stored)
  file security status:                           not encrypted
  extended local header:                          no
  file last modified on (DOS date/time):          2016 Nov 21 12:48:18
  32-bit CRC value (hex):                         00000000
  compressed size:                                0 bytes
  uncompressed size:                              0 bytes
  length of filename:                             7 characters
  length of extra field:                          0 bytes
  length of file comment:                         0 characters
  disk number on which file begins:               disk 1
  apparent file type:                             binary
  Unix file attributes (040700 octal):            drwx------
  MS-DOS file attributes (10 hex):                dir

  There is a local extra field with ID 0x5855 (old Info-ZIP Unix/OS2/NT) and
  8 data bytes (GMT modification/access times only).

  There is no file comment.

Message #17 received at 845203@bugs.debian.org (full text, mbox, reply):

From: u <u@451f.org>

To: 845203@bugs.debian.org

Subject: Test script & case

Date: Mon, 21 Nov 2016 17:38:00 +0000

[Message part 1 (text/plain, inline)]

Hi!

while trying to provide a test case for this bug, we've noticed that the
problem only occurs when using @7z@ from testing or sid (provided by the
@p7zip-full@ package version >16).

It does not happen when using the Jessie version (currently
9.20.1~dfsg.1-4.1+deb8u2). So it might actually be that this bug will
need to be reassigned to p7zip-full, but I'm in not position to judge this.

The headers are created nonetheless, and thus this might still represent
a problem when using @dh-stripnondeterminism@.

Cheers!
u.

(The script is a fast dirty hack, I did not write it myself.)

[zip-ntfs-header-test.sh (application/x-shellscript, attachment)]

Message #22 received at 845203@bugs.debian.org (full text, mbox, reply):

From: Reiner Herrmann <reiner@reiner-h.de>

To: u <u@451f.org>, 845203@bugs.debian.org

Subject: Re: Bug#845203: Test script & case

Date: Mon, 21 Nov 2016 18:48:48 +0100

[Message part 1 (text/plain, inline)]

On Mon, Nov 21, 2016 at 05:38:00PM +0000, u wrote:
> while trying to provide a test case for this bug, we've noticed that the
> problem only occurs when using @7z@ from testing or sid (provided by the
> @p7zip-full@ package version >16).
> 
> It does not happen when using the Jessie version (currently
> 9.20.1~dfsg.1-4.1+deb8u2). So it might actually be that this bug will
> need to be reassigned to p7zip-full, but I'm in not position to judge this.
> 
> The headers are created nonetheless, and thus this might still represent
> a problem when using @dh-stripnondeterminism@.

Thanks for further information about this bug.
I don't know why the jessie version of 7zip behaves differently, but
strip-nondeterminism was indeed lacking support for NTFS timestamps (id
0x000a), so it is a valid bug.
A fix is already available in git, if you want to test it.

Regards,
  Reiner

[signature.asc (application/pgp-signature, inline)]

Message #27 received at 845203@bugs.debian.org (full text, mbox, reply):

From: u <u@451f.org>

To: Reiner Herrmann <reiner@reiner-h.de>, 845203@bugs.debian.org

Subject: Re: Bug#845203: Test script & case

Date: Mon, 21 Nov 2016 17:55:00 +0000

Hi Reiner,

> Thanks for further information about this bug.
> I don't know why the jessie version of 7zip behaves differently, but
> strip-nondeterminism was indeed lacking support for NTFS timestamps (id
> 0x000a), so it is a valid bug.

Ack.

I've nonetheless e-mailed the maintainer of the p7zip-full just to
confirm if this behaviour is actually expected.

> A fix is already available in git, if you want to test it.

Wohoo! Is it the fix at this commit
https://anonscm.debian.org/git/reproducible/strip-nondeterminism.git/commit/?id=7124c6b?

Cheers!
ulrike

Message #32 received at 845203@bugs.debian.org (full text, mbox, reply):

From: Reiner Herrmann <reiner@reiner-h.de>

To: u <u@451f.org>

Cc: 845203@bugs.debian.org

Subject: Re: Bug#845203: Test script & case

Date: Mon, 21 Nov 2016 18:58:31 +0100

[Message part 1 (text/plain, inline)]

On Mon, Nov 21, 2016 at 05:55:00PM +0000, u wrote:
> Wohoo! Is it the fix at this commit
> https://anonscm.debian.org/git/reproducible/strip-nondeterminism.git/commit/?id=7124c6b?

Without the question mark in the URL, yes. :-)

[signature.asc (application/pgp-signature, inline)]

Message #37 received at 845203-close@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 845203-close@bugs.debian.org

Subject: Bug#845203: fixed in strip-nondeterminism 0.029-1

Date: Thu, 22 Dec 2016 11:20:05 +0000

Source: strip-nondeterminism
Source-Version: 0.029-1

We believe that the bug you reported is fixed in the latest version of
strip-nondeterminism, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 845203@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated strip-nondeterminism package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 22 Dec 2016 10:55:20 +0000
Source: strip-nondeterminism
Binary: libfile-stripnondeterminism-perl strip-nondeterminism dh-strip-nondeterminism
Architecture: source
Version: 0.029-1
Distribution: unstable
Urgency: medium
Maintainer: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 dh-strip-nondeterminism - file non-deterministic information stripper — Debhelper add-on
 libfile-stripnondeterminism-perl - file non-deterministic information stripper — Perl module
 strip-nondeterminism - file non-deterministic information stripper — stand-alone tool
Closes: 845203 846895
Changes:
 strip-nondeterminism (0.029-1) unstable; urgency=medium
 .
   [ Chris Lamb ]
   * t/binaries.t:
     - Don't make tests rely on Debian::Debhelper::Dh_Lib for non-Debian
       distributions.
     - Smoke test strip-nondeterminism(1) and dh_strip_nondeterminism(1) to
       prevent regressions like a3c16cd08.
   * Makefile.PL: Change "NAME" argument to a Perl package name.
   * .pertidyrc: Inherit/copy from lintian's version but using tabs over spaces.
   * Run perltidy across codebase.
 .
   [ Reiner Herrmann ]
   * zip: normalize NTFS FIleTimes. (Closes: #845203)
 .
   [ Anders Kaseorg ]
   * libfile-stripnondeterminism-perl: Treat .par files as Zip archives.
     (Closes: #846895)
Checksums-Sha1:
 4995c72b256a595012235eb8a82b66e16df2c772 2425 strip-nondeterminism_0.029-1.dsc
 e4e17d2075b8815df71ca93fa3cb3a3485321227 169883 strip-nondeterminism_0.029.orig.tar.gz
 e779d77c526c80d73f24c59bd40258176753b26d 6348 strip-nondeterminism_0.029-1.debian.tar.xz
Checksums-Sha256:
 778470c12409f7f5179652e0360d7b52657570aa5ad2eb5a116b7e13fcc1d32b 2425 strip-nondeterminism_0.029-1.dsc
 1e6df1d0495c19859182c7746e6f5c189ca1494e7b6e6f143fb1bfecfd11de5c 169883 strip-nondeterminism_0.029.orig.tar.gz
 45e6012f6898ae70afc2e7800f524441ab80020a78b1a58cb61b52ea59e442c0 6348 strip-nondeterminism_0.029-1.debian.tar.xz
Files:
 67608335ff46c99d3af9d3fd64e603bd 2425 devel optional strip-nondeterminism_0.029-1.dsc
 de8270f0530d21dcd13e95e6967c4acf 169883 devel optional strip-nondeterminism_0.029.orig.tar.gz
 3264d9a2fb829876d8b3b6a2dda29174 6348 devel optional strip-nondeterminism_0.029-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAlhbseUACgkQHpU+J9Qx
HlgY6xAApFGde7FM0sSRvvy9lPoPMoGcEa2CSoLlepVqCRMbLOs7JTF6i+O9/ZBA
Yue2fQdEVwfVaCbrvJF0XmDcnFC8Doif59A59J4dpwV9rL07qecjGIDwCQHBlyTx
zurOSVfKIJ8S11BsVYYW1a+94SsqfJ5E4ffRg2APWVDiOnr8P8M6qBSdsqQx3atw
Nkmc/5OXzDTNiC8PQZxAltAJRQ+9iu6EdqzydPfvaqeoj4sRK0aUDGgtEm0egrFJ
FANt4CQUBo8kL4FS2tY8wx7f/LeKtmtcMi+7wOsF/i7PBjrzR/Z5/tyuRA9vhNVG
F6j9QSLLD2MdrqYHjiIWRMBluHDomWqX3/nEiHtCKjKCD3S5E9BHh+Cln+8WmGme
oyOB/sJqEWsEz3Cqx56wln2onv6NYZdGHpGyZdxATAN3FHjkJorg33JpSy8FBxSs
/Il2dorUstTIrffKs4VpKvzwkOh96SofDpGTJCvyqbMBdybLECzSHD+4ksbmf+FX
C6oBjmIYXFDKVj4Zp1go3kS60IPqqd9w/bB3T6YCrvZPLRYNJmpTbLxXszuZMZcx
kbv9toVDygl/pmf8gBXM5sbtGILTw0vaOCSaDeI+BjbRM91TVMXEFkBkBl+w3d06
u4n0Is50PuVsW/qecTF1ws6QaQ0RfyNP3wgM+yHmm1Ov0OsUwDA=
=f9ro
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.