Debian Bug report logs - #844549
network-console broken: no screen to be resumed matching sh

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Martin Michlmayr <tbm@cyrius.com>

To: submit@bugs.debian.org

Subject: network-console broken: no screen to be resumed matching sh

Date: Wed, 16 Nov 2016 12:07:07 -0800

Package: rootskel
Version: 1.119
Severity: serious
Tags: patch

Several users have reported to me that the network-console images are
broken.

Commit ec6d3c3d79 (Move screen support) moved the screen support
around and also changed the logic of when screen is used.
Unfortunately, that change broke all network-console images which now
lead to:

installer@192.168.0.102's password:
There is no screen to be resumed matching sh.
Connection to 192.168.0.102 closed.

This is because d-i is already running in screen on the serial console but
it's active and can't be resumed.

I believe below is the right fix, i.e. start screen when screen exists and
when we're on serial or when we're NOT on network.

Samuel, Roger, does that look correct?

diff --git a/src/lib/debian-installer.d/S70menu b/src/lib/debian-installer.d/S70menu
index 7b35fac..14cad7f 100644
--- a/src/lib/debian-installer.d/S70menu
+++ b/src/lib/debian-installer.d/S70menu
@@ -11,7 +11,7 @@ if [ -x "$bterm" ] && [ -e "$font" ] && [ -n "$TERM_UTF8" ] && [ -n "$TERM_FRAME
 	set -e
 else
 	rm -f $font
-	if [ -x "$screen_bin" -a \( "$TERM_TYPE" = network -o "$TERM_TYPE" = serial \) -a "$TERM" != dumb ]; then
+	if [ -x "$screen_bin" -a \( "$TERM_TYPE" != network -o "$TERM_TYPE" = serial \) -a "$TERM" != dumb ]; then
 		# there's GNU/screen binary, run menu in it.
 		# call this script again with in GNU/screen, possibly in UTF-8 mode
 		SCREEN_OPT=""

-- 
Martin Michlmayr
http://www.cyrius.com/

Message #10 received at submit@bugs.debian.org (full text, mbox, reply):

From: Ben Hutchings <ben@decadent.org.uk>

To: Martin Michlmayr <tbm@cyrius.com>, 844549@bugs.debian.org, submit@bugs.debian.org

Subject: Re: Bug#844549: network-console broken: no screen to be resumed matching sh

Date: Wed, 16 Nov 2016 21:15:18 +0000

[Message part 1 (text/plain, inline)]

On Wed, 2016-11-16 at 12:07 -0800, Martin Michlmayr wrote:
> Package: rootskel
> Version: 1.119
> Severity: serious
> Tags: patch
> 
> Several users have reported to me that the network-console images are
> broken.
> 
> Commit ec6d3c3d79 (Move screen support) moved the screen support
> around and also changed the logic of when screen is used.
> Unfortunately, that change broke all network-console images which now
> lead to:
> 
> installer@192.168.0.102's password:
> There is no screen to be resumed matching sh.
> Connection to 192.168.0.102 closed.
> 
> This is because d-i is already running in screen on the serial console but
> it's active and can't be resumed.
> 
> I believe below is the right fix, i.e. start screen when screen exists and
> when we're on serial or when we're NOT on network.
> 
> Samuel, Roger, does that look correct?
> 
> diff --git a/src/lib/debian-installer.d/S70menu b/src/lib/debian-installer.d/S70menu
> index 7b35fac..14cad7f 100644
> --- a/src/lib/debian-installer.d/S70menu
> +++ b/src/lib/debian-installer.d/S70menu
> @@ -11,7 +11,7 @@ if [ -x "$bterm" ] && [ -e "$font" ] && [ -n "$TERM_UTF8" ] && [ -n "$TERM_FRAME
>  	set -e
>  else
>  	rm -f $font
> -	if [ -x "$screen_bin" -a \( "$TERM_TYPE" = network -o "$TERM_TYPE" = serial \) -a "$TERM" != dumb ]; then
> +	if [ -x "$screen_bin" -a \( "$TERM_TYPE" != network -o "$TERM_TYPE" = serial \) -a "$TERM" != dumb ]; then

This makes the comparison with 'serial' redundant; the condition will
be equivalent to:

    [ -x "$screen_bin" -a "$TERM_TYPE" != network -a "$TERM" != dumb ]

Is that really what we want?

Ben.

>  		# there's GNU/screen binary, run menu in it.
> >  		# call this script again with in GNU/screen, possibly in UTF-8 mode
> >  		SCREEN_OPT=""
> 
-- 
Ben Hutchings
Time is nature's way of making sure that everything doesn't happen at
once.

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 844549@bugs.debian.org (full text, mbox, reply):

From: Martin Michlmayr <tbm@cyrius.com>

To: Ben Hutchings <ben@decadent.org.uk>

Cc: 844549@bugs.debian.org, Samuel Thibault <samuel.thibault@ens-lyon.org>, Roger Shimizu <rogershimizu@gmail.com>

Subject: Re: Bug#844549: network-console broken: no screen to be resumed matching sh

Date: Wed, 16 Nov 2016 13:39:21 -0800

* Ben Hutchings <ben@decadent.org.uk> [2016-11-16 21:15]:
> >  	rm -f $font
> > -	if [ -x "$screen_bin" -a \( "$TERM_TYPE" = network -o "$TERM_TYPE" = serial \) -a "$TERM" != dumb ]; then
> > +	if [ -x "$screen_bin" -a \( "$TERM_TYPE" != network -o "$TERM_TYPE" = serial \) -a "$TERM" != dumb ]; then
> 
> This makes the comparison with 'serial' redundant; the condition will
> be equivalent to:
> 
>     [ -x "$screen_bin" -a "$TERM_TYPE" != network -a "$TERM" != dumb ]
> 
> Is that really what we want?

Oh, good point.

I think that's what we want but I'm not sure.  Maybe Roger can
comment.  In his old code, there was also a $NETBOOT_SCREEN variable
which afaict wasn't set set anywhere.

-- 
Martin Michlmayr
http://www.cyrius.com/

Message #25 received at submit@bugs.debian.org (full text, mbox, reply):

From: Samuel Thibault <sthibault@debian.org>

To: Martin Michlmayr <tbm@cyrius.com>, 844549@bugs.debian.org

Cc: submit@bugs.debian.org

Subject: Re: Bug#844549: network-console broken: no screen to be resumed matching sh

Date: Wed, 16 Nov 2016 23:03:42 +0100

[Message part 1 (text/plain, inline)]

Hello,

Martin Michlmayr, on Wed 16 Nov 2016 12:07:07 -0800, wrote:
> I believe below is the right fix, i.e. start screen when screen exists and
> when we're on serial or when we're NOT on network.

But AIUI the intent was to have screen in ssh connections too.

We could have the case where d-i is first started with the serial
console, running through screen, and enable the network console, which
we'd also want to run through screen.

I'd thus say that we rather want the attached changes, to have one
screen session per terminal type.

I'm also thinking that we perhaps want to add -x when resuming a
session, so that somebody can connect trough ssh several times ?

Samuel

[patch (text/plain, attachment)]

Message #35 received at submit@bugs.debian.org (full text, mbox, reply):

From: Martin Michlmayr <tbm@cyrius.com>

To: Samuel Thibault <sthibault@debian.org>

Cc: 844549@bugs.debian.org, submit@bugs.debian.org

Subject: Re: Bug#844549: network-console broken: no screen to be resumed matching sh

Date: Wed, 16 Nov 2016 15:27:54 -0800

* Samuel Thibault <sthibault@debian.org> [2016-11-16 23:03]:
> But AIUI the intent was to have screen in ssh connections too.

I'm not sure what the intent was.  I assume you're right because Roger
didn't exclude screen from the network-console images.  Personally,
I'm not sure I see the point of screen in that case because you can
always open a second SSH connection and open a terminal, but I don't
have strong feelings either way if there's an advantage of having
screen in such cases.

> I'm also thinking that we perhaps want to add -x when resuming a
> session, so that somebody can connect trough ssh several times ?

Yes because right now I get this when I open a 2nd connection:

debug1: Sending env LC_COLLATE = C
There is a screen on:
        1356.network    (11/16/16 23:24:12)     (Attached)

Apart from this, the patch works for me.

-- 
Martin Michlmayr
http://www.cyrius.com/

Message #47 received at 844549@bugs.debian.org (full text, mbox, reply):

From: Cyril Brulebois <kibi@debian.org>

To: Martin Michlmayr <tbm@cyrius.com>, 844549@bugs.debian.org

Cc: Samuel Thibault <sthibault@debian.org>

Subject: Re: Bug#844549: network-console broken: no screen to be resumed matching sh

Date: Sun, 20 Nov 2016 07:47:35 +0100

[Message part 1 (text/plain, inline)]

Hi,

Martin Michlmayr <tbm@cyrius.com> (2016-11-16):
> * Samuel Thibault <sthibault@debian.org> [2016-11-16 23:03]:
> > But AIUI the intent was to have screen in ssh connections too.
> 
> I'm not sure what the intent was.  I assume you're right because Roger
> didn't exclude screen from the network-console images.  Personally,
> I'm not sure I see the point of screen in that case because you can
> always open a second SSH connection and open a terminal, but I don't
> have strong feelings either way if there's an advantage of having
> screen in such cases.
> 
> > I'm also thinking that we perhaps want to add -x when resuming a
> > session, so that somebody can connect trough ssh several times ?
> 
> Yes because right now I get this when I open a 2nd connection:
> 
> debug1: Sending env LC_COLLATE = C
> There is a screen on:
>         1356.network    (11/16/16 23:24:12)     (Attached)
> 
> Apart from this, the patch works for me.

Then I suggest we get that into git and into unstable sooner rather than
later, so that Stretch Alpha 9 gets a fix. I didn't add an errata entry
for that, but might do so later.


KiBi.

[signature.asc (application/pgp-signature, inline)]

Message #52 received at 844549@bugs.debian.org (full text, mbox, reply):

From: Philip Hands <phil@hands.com>

To: Martin Michlmayr <tbm@cyrius.com>, 844549@bugs.debian.org, Samuel Thibault <sthibault@debian.org>

Subject: Re: Bug#844549: network-console broken: no screen to be resumed matching sh

Date: Sun, 20 Nov 2016 12:20:38 +0100

[Message part 1 (text/plain, inline)]

Martin Michlmayr <tbm@cyrius.com> writes:

> * Samuel Thibault <sthibault@debian.org> [2016-11-16 23:03]:
>> But AIUI the intent was to have screen in ssh connections too.
>
> I'm not sure what the intent was.  I assume you're right because Roger
> didn't exclude screen from the network-console images.  Personally,
> I'm not sure I see the point of screen in that case because you can
> always open a second SSH connection and open a terminal, but I don't
> have strong feelings either way if there's an advantage of having
> screen in such cases.

I'd think that the advantage is that one could start a serial install up
to the point that the network comes up, and then hijack it onto the ssh
session so that one gets to see the same install (as well as any other
shells you might have started).

That way, if you think you've preseeded all the pre-network stuff, there
would be a session to look at via serial if it never gets to the
network.

Perhaps this is not a real scenario though (I've not played with SSH
connections to d-i, so I don't know what happens when you log in and
debconf is already active on the console)

Cheers, Phil.
-- 
|)|  Philip Hands  [+44 (0)20 8530 9560]  HANDS.COM Ltd.
|-|  http://www.hands.com/    http://ftp.uk.debian.org/
|(|  Hugo-Klemm-Strasse 34,   21075 Hamburg,    GERMANY

[signature.asc (application/pgp-signature, inline)]

Message #57 received at 844549@bugs.debian.org (full text, mbox, reply):

From: Samuel Thibault <sthibault@debian.org>

To: Philip Hands <phil@hands.com>

Cc: Martin Michlmayr <tbm@cyrius.com>, 844549@bugs.debian.org

Subject: Re: Bug#844549: network-console broken: no screen to be resumed matching sh

Date: Sun, 20 Nov 2016 17:22:16 +0100

Hello,

Philip Hands, on Sun 20 Nov 2016 12:20:38 +0100, wrote:
> Martin Michlmayr <tbm@cyrius.com> writes:
> 
> > * Samuel Thibault <sthibault@debian.org> [2016-11-16 23:03]:
> >> But AIUI the intent was to have screen in ssh connections too.
> >
> > I'm not sure what the intent was.  I assume you're right because Roger
> > didn't exclude screen from the network-console images.  Personally,
> > I'm not sure I see the point of screen in that case because you can
> > always open a second SSH connection and open a terminal, but I don't
> > have strong feelings either way if there's an advantage of having
> > screen in such cases.
> 
> I'd think that the advantage is that one could start a serial install up
> to the point that the network comes up, and then hijack it onto the ssh
> session so that one gets to see the same install (as well as any other
> shells you might have started).

Mmm, that's a nice idea indeed.  I've eventually uploaded the -x fix,
which gives us that behavior, and also allowing several people to follow
the installation, interact, etc.

Samuel

Message #62 received at 844549-close@bugs.debian.org (full text, mbox, reply):

From: Samuel Thibault <sthibault@debian.org>

To: 844549-close@bugs.debian.org

Subject: Bug#844549: fixed in rootskel 1.121

Date: Sun, 20 Nov 2016 16:35:04 +0000

Source: rootskel
Source-Version: 1.121

We believe that the bug you reported is fixed in the latest version of
rootskel, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 844549@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Samuel Thibault <sthibault@debian.org> (supplier of updated rootskel package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 20 Nov 2016 17:13:43 +0100
Source: rootskel
Binary: rootskel
Architecture: source amd64
Version: 1.121
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Samuel Thibault <sthibault@debian.org>
Description:
 rootskel   - Skeleton root filesystem used by debian-installer (udeb)
Closes: 844549
Changes:
 rootskel (1.121) unstable; urgency=medium
 .
   * Team upload
   * Fix starting screen in ssh when d-i is already running inside screen on
     serial port (Closes: #844549).
Checksums-Sha1:
 37726766e8a1de285b60afe7dd911bea4035e073 1704 rootskel_1.121.dsc
 172eff5712041a23d6d497c695394972aba29a1e 32232 rootskel_1.121.tar.xz
 0607f6804cc0fe80d0eeee04b1dfe7b86f3fae36 4348 rootskel_1.121_amd64.buildinfo
 2902ff48b84151f62867a7f3a6c6fec9fd68d2ea 9042 rootskel_1.121_amd64.udeb
Checksums-Sha256:
 2f4bbc05f3297c47cd4e3a940f0791a0398881a9a7a4a5bdbc178cbc5d71fc3c 1704 rootskel_1.121.dsc
 ef59c4962c5a2c00b8509112625b750177170a168cf2cd9569668e39253863b1 32232 rootskel_1.121.tar.xz
 be4a318732d024ee227363d65b83d73a3e2da19dde5a8e696cebc4482123347d 4348 rootskel_1.121_amd64.buildinfo
 b125e1c78b941926636b27422d43b6b7a3893202f4dc943c420e7a01e834edef 9042 rootskel_1.121_amd64.udeb
Files:
 9625add1d95cb875a7ce3a1546fb8f2a 1704 debian-installer standard rootskel_1.121.dsc
 1348fb24b94b7b67a4ca41e14304c7b0 32232 debian-installer standard rootskel_1.121.tar.xz
 4fe7c033ecac9de03c609eafdb036d6a 4348 debian-installer standard rootskel_1.121_amd64.buildinfo
 a96bbe373439d8799388151ffdd1c7bc 9042 debian-installer standard rootskel_1.121_amd64.udeb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE9jJ0zcYwCHPLPSnZ4+Uc6PtrLx0FAlgxzV0ACgkQ4+Uc6Ptr
Lx31fA/+Lxsj4KJC0OSBBxU05mzBXXVubJ/4abvZYMFR/a9kYIoeFHETTujXopy3
V8H0nhtM1NQQvvqJWsYu3RXmbjtJjo9p7pu9X2D0SSETmDFZwOgQhmUN82P4UIoM
fHrx7oj9cFQ5NDn6Jh6c1/miTrkLDKy1MLwOgEA2OtxpM6dFGI5VP4FoA4hvVkzm
skYjEDAOBy6zYaSMkW926nhNpGmPh6SsRELmTEzIC+fqcrm39uY9SzQZQdUsF0CT
GJoA9Yzv9F2unWN/1KfTd1S3u7Whg2aylF1t1dd8U8TrgG5MCXdCXPSU1FbhYcTR
ykbOhMDFTp0Gz6Zk5MGld+fMhegWO84ShYeX+jJkW9tBk+/fuw39hRUagJtzThSm
qqE/QAlbPVZ55BPHC1oBGUAYw3WMqpLijaZwO/U8kDCY7V85iugJc5uVeHzJGfmq
qY8Ibuy7skwpI4xQETqR95MQh3JE+m1SU+hAKXmKmQmstXTUOLLqRRPJHWTdZCI2
lZyz5Vad9UYGrf3tvo8w1LOkkBaUSJndttBeOWEfYwBIF3JSgvd7FM9vOrCPfukV
CvohbZSXDNk7wegeTbvXand7kNYnFq1n73GfVOiwF+LdYW2gS6uXl9rauhEIl55q
LOHsayT3hpLlgEUXLu0xRQ1RZylVCPLYz4tnvKKSMK1VMsGl7mY=
=THOf
-----END PGP SIGNATURE-----

Message #67 received at 844549@bugs.debian.org (full text, mbox, reply):

From: Roger Shimizu <rogershimizu@gmail.com>

To: Samuel Thibault <sthibault@debian.org>, Martin Michlmayr <tbm@cyrius.com>, Philip Hands <phil@hands.com>

Cc: 844549@bugs.debian.org

Subject: Re: Bug#844549: network-console broken: no screen to be resumed matching sh

Date: Tue, 22 Nov 2016 03:05:25 +0900

Seems I'm late for the d-i/screen party, but ..

On Thu, Nov 17, 2016 at 6:39 AM, Martin Michlmayr <tbm@cyrius.com> wrote:
>
> Oh, good point.
>
> I think that's what we want but I'm not sure.  Maybe Roger can
> comment.  In his old code, there was also a $NETBOOT_SCREEN variable
> which afaict wasn't set set anywhere.

Originally I add screen support to D-I for my orion5x-based
Linkstation NAS, which supports both serial / network console to start
D-I.

I want to support screen in both way (serial / network console), because
 - for serial console, no other option to access command line as free
as anytime.
 - for network console, no way to resume if the network cable gets
unplugged accidentally, or SSH connection disconnects for whatever
reason.

Because I'm new to D-I code base, I want to test the code I injected
in works alright, so I add $NETBOOT_SCREEN variable so that I can test
screen support for "one D-I image" in either serial console way (=1)
or network console way (=0).

The "one D-I image" I chose to test was netboot/network, so the
default of $NETBOOT_SCREEN is 0.
The "one D-I image" is just literally in D-I image filename, built by
same source code except with different $NETBOOT_SCREEN setting.

Maybe it's more clear to remove $NETBOOT_SCREEN after I submit my
patch, but I thought it might need to debug again some time later, so
it was kept as it was until Samuel's "Move" change.

On Sun, Nov 20, 2016 at 8:20 PM, Philip Hands <phil@hands.com> wrote:
>
> I'd think that the advantage is that one could start a serial install up
> to the point that the network comes up, and then hijack it onto the ssh
> session so that one gets to see the same install (as well as any other
> shells you might have started).
>
> That way, if you think you've preseeded all the pre-network stuff, there
> would be a session to look at via serial if it never gets to the
> network.
>
> Perhaps this is not a real scenario though (I've not played with SSH
> connections to d-i, so I don't know what happens when you log in and
> debconf is already active on the console)

This spec will be fantastic if it's able to be implemented.

On Mon, Nov 21, 2016 at 1:22 AM, Samuel Thibault <sthibault@debian.org> wrote:
>
> Mmm, that's a nice idea indeed.  I've eventually uploaded the -x fix,
> which gives us that behavior, and also allowing several people to follow
> the installation, interact, etc.

Thanks for your fixes!
I see another TERMCAP fix related to screen support. So you're really
appreciated!

I'll test the daily image on my Linkstation NAS.

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 4096R/6C6ACD6417B3ACB1

Message #72 received at 844549@bugs.debian.org (full text, mbox, reply):

From: Roger Shimizu <rogershimizu@gmail.com>

To: Samuel Thibault <sthibault@debian.org>, Martin Michlmayr <tbm@cyrius.com>, Philip Hands <phil@hands.com>

Cc: 844549@bugs.debian.org

Subject: Re: Bug#844549: network-console broken: no screen to be resumed matching sh

Date: Wed, 30 Nov 2016 23:53:31 +0900

On Tue, Nov 22, 2016 at 3:05 AM, Roger Shimizu <rogershimizu@gmail.com> wrote:
>
> I'll test the daily image on my Linkstation NAS.

I tested the daily image on my armel devices.
Both serial way and SSH way works fine. And if connect both serial and
SSH (network-console), serial/SSH seems to share the same screen
session, which is good and beyond what I expected.
It's exceeded what I have imagined.

Just one issue for SSH (network-console).
Since the SSH session shares the same screen with serial, the screen
size is limited to 80x25 (probably, I didn't count the number), which
is too small to most recent monitor devices.

Does it deserve a new bug report?
What do you think of it?

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 4096R/6C6ACD6417B3ACB1

Message #77 received at 844549@bugs.debian.org (full text, mbox, reply):

From: Samuel Thibault <sthibault@debian.org>

To: Roger Shimizu <rogershimizu@gmail.com>

Cc: Martin Michlmayr <tbm@cyrius.com>, Philip Hands <phil@hands.com>, 844549@bugs.debian.org

Subject: Re: Bug#844549: network-console broken: no screen to be resumed matching sh

Date: Wed, 30 Nov 2016 17:07:58 +0100

Roger Shimizu, on Wed 30 Nov 2016 23:53:31 +0900, wrote:
> Just one issue for SSH (network-console).
> Since the SSH session shares the same screen with serial, the screen
> size is limited to 80x25 (probably, I didn't count the number), which
> is too small to most recent monitor devices.

Sure. Since the serial console is supposed to have 80x25, you can't make
the screen session bigger, it would overflow on the serial console
output. There is no way around that.

Samuel

Send a report that this bug log contains spam.