Debian Bug report logs - #844454
autopkgtest: does not apply quilt patches when running tests from source package directory

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Florian Schlichting <fsfs@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: autopkgtest: does not apply quilt patches when running tests from source package directory

Date: Tue, 15 Nov 2016 23:39:40 +0100

Package: autopkgtest
Version: 4.2
Severity: normal

When running 'autopkgtest -s -- schroot unstable-amd64-sbuild', quilt
patches are applied when building the package, but they are not applied
in tests-tree / real-tree. Those directories look just like the current
directory when issuing the autopkgtest command, possibly with just half
the quilt series applied. This is confusing, and should be changed to
apply all patches like for the build stage.

I noticed this while working on an autopkgtest-related fix to
libhttp-throwable-perl's upstream test suite (c.f. #837140), with the
above command first succeeding and then failing for an unchanged source
package...

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (990, 'testing'), (700, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.8.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages autopkgtest depends on:
ii  apt-utils       1.3.1
ii  libdpkg-perl    1.18.14
ii  procps          2:3.3.12-2
ii  python3         3.5.1-4
ii  python3-debian  0.1.29

Versions of packages autopkgtest recommends:
ii  autodep8  0.8

Versions of packages autopkgtest suggests:
pn  lxc          <none>
pn  lxd-client   <none>
ii  qemu-system  1:2.7+dfsg-3+b1
ii  qemu-utils   1:2.7+dfsg-3+b1
ii  schroot      1.6.10-2+b2

-- no debconf information

Message #10 received at 844454@bugs.debian.org (full text, mbox, reply):

From: Martin Pitt <mpitt@debian.org>

To: Florian Schlichting <fsfs@debian.org>, 844454@bugs.debian.org

Subject: Re: Bug#844454: autopkgtest: does not apply quilt patches when running tests from source package directory

Date: Wed, 16 Nov 2016 12:22:51 +0100

Control: tag -1 pending

Hello Florian,

Florian Schlichting [2016-11-15 23:39 +0100]:
> When running 'autopkgtest -s -- schroot unstable-amd64-sbuild', quilt
> patches are applied when building the package, but they are not applied
> in tests-tree / real-tree.

Nicely spotted! I did have a test case for this already, but for a
slightly different scenario. I reproduced this in two more tests
and fixed the remaining cases:

  https://anonscm.debian.org/cgit/autopkgtest/autopkgtest.git/commit/?id=7d49515

Now your command succeeds in a libhttp-throwable-perl-0.026/ directory
with unapplied patches.

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

Message #17 received at 844454@bugs.debian.org (full text, mbox, reply):

From: Florian Schlichting <fsfs@debian.org>

To: Martin Pitt <mpitt@debian.org>

Cc: 844454@bugs.debian.org

Subject: Re: Bug#844454: autopkgtest: does not apply quilt patches when running tests from source package directory

Date: Wed, 16 Nov 2016 14:34:27 +0100

On Wed, Nov 16, 2016 at 12:22:51PM +0100, Martin Pitt wrote:
>   https://anonscm.debian.org/cgit/autopkgtest/autopkgtest.git/commit/?id=7d49515
> 
> Now your command succeeds in a libhttp-throwable-perl-0.026/ directory
> with unapplied patches.

awesome, thanks!

Florian

Message #22 received at 844454-close@bugs.debian.org (full text, mbox, reply):

From: Martin Pitt <mpitt@debian.org>

To: 844454-close@bugs.debian.org

Subject: Bug#844454: fixed in autopkgtest 4.2.1

Date: Wed, 23 Nov 2016 22:52:57 +0000

Source: autopkgtest
Source-Version: 4.2.1

We believe that the bug you reported is fixed in the latest version of
autopkgtest, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 844454@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Martin Pitt <mpitt@debian.org> (supplier of updated autopkgtest package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 23 Nov 2016 22:49:59 +0100
Source: autopkgtest
Binary: autopkgtest
Architecture: source all
Version: 4.2.1
Distribution: unstable
Urgency: medium
Maintainer: Autopkgtest team <autopkgtest-devel@lists.alioth.debian.org>
Changed-By: Martin Pitt <mpitt@debian.org>
Description:
 autopkgtest - automatic as-installed testing for Debian packages
Closes: 844454
Changes:
 autopkgtest (4.2.1) unstable; urgency=medium
 .
   * Fix trailing '\' in test command  with ssh runner
   * ssh: Filter out trailing spaces from commands in auxverb
   * Apply patches for tests with unbuilt-tree (Closes: #844454)
   * setup-commands/setup-testbed: Install dpkg-dev
   * Fix stray ')' in --apt-pocket handling
   * Adjust expected cpu_model in NullRunner.test_tree_output_dir()
   * PEP-8 fixes
   * Robustify tests against kernel versions with trailing space
Checksums-Sha1:
 4035b94d4a18e7c23c6f66d6a58a4b61a63ddf36 1871 autopkgtest_4.2.1.dsc
 967bd258e63bf3b2e21d1c21e7b275657256d3c2 170740 autopkgtest_4.2.1.tar.xz
 fd4555742822ec637df0796bff443e423f77ba81 183854 autopkgtest_4.2.1_all.deb
 26bf452f2319a61894868981e3973b7137e578e0 5279 autopkgtest_4.2.1_amd64.buildinfo
Checksums-Sha256:
 dee5ace37360b67062ee1d140cd5902178d025de5689d5b36e0cc72f61e1015b 1871 autopkgtest_4.2.1.dsc
 8e41ff66c60607af8192ed66489c4b6950ee13d019f2af18ff9b347f3c9033c4 170740 autopkgtest_4.2.1.tar.xz
 1fb9fdc459c077f61847be5cb1e662274008d6e1b1bc3296f6104a92ddedf31f 183854 autopkgtest_4.2.1_all.deb
 aca11b42a750ed9b1f19d7a12224b5ed70681e5850d86f683231f25f6a133272 5279 autopkgtest_4.2.1_amd64.buildinfo
Files:
 8d5ac7cad27a1cd18ac54541ef70b61a 1871 devel optional autopkgtest_4.2.1.dsc
 ccb797b30b55de89f5cf12abac411e10 170740 devel optional autopkgtest_4.2.1.tar.xz
 0ad0299cf02313e0d44ceea3bd17a8be 183854 devel optional autopkgtest_4.2.1_all.deb
 3e51d6ae39289ccb2b95834c17f61282 5279 devel optional autopkgtest_4.2.1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJYNhLiAAoJENFO8V2v4RNHBIUP/0ugx1ltSC84GECy2j7MWVCY
b4Szvd5O2KER32ml89AH/FK0R/6YMSB793Ml7sRNqLoKAZRWQmPUxPOVa+HiiPYS
mZD0WWHLeuQWray/bpO4NJ8mof6VQlH5tW824pQ7aS24Xadqy2OpqNRAANxiPVTn
cCAwAnr2kRqTpMTAW4bBQarIyZemcWCPrvhYUqN8PqnvwrjRCbRaar+VBhZQ8qvA
h21MqslnBJGp5bbExxJ/d3Fyr5v+A3vBEhc1c3r+JMQVOnzwAlLhucymxqH4QNUR
uGwnT4o+eijqTiBwmVuRAsEnSlX9v06undlFrgAR4R3QvBRyeL5Nuxpk8bDPq6+j
KfoiqQp7PsFViphKfoZoSyfFfNQekEsj5P56+hPEyr7t8r02O2Gjmvw0sQ1xhWym
tg3/kRDXUrxW5Mtn30j3M3JBtNGRbrE2Jy0R3bxkqL4oNSGIt7A0Af1LCrKqqZao
1A99GlHwEzssogvKU3cRqD38tPD6aoPMBs00MLQTg0BJAp1TR5CjO2IJOoWFkrIj
hGjG0S3spPfdwHuOq4i9dgnlb1SW0EC+eXeQoL831mLASId7HlpNaTIr56tvFVRi
pmkHNoBbbwxOEekeg1TPPRHDNSsiXYhxaVg+0AV5XelkWRJ3N7U+gCZRG5Ia+g8r
Q74+fyPHSDFjKk5+lo6s
=K0pU
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.