Debian Bug report logs - #844275
mysql_config injects build flags which breaks the build for other packages

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <biebl@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: mysql_config injects build flags which breaks the build for other packages

Date: Mon, 14 Nov 2016 00:39:50 +0100

Package: libmysqlclient-dev
Version: 5.7.16-1
Severity: serious
File: /usr/bin/mysql_config

Hi,

I just tried to build the rsyslog package, which resulted in a build
failure:

libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I../../runtime
-I../.. -I../../grammar -I/usr/include/libfastjson -W -Wall
-Wformat-security -Wshadow -Wcast-align -Wpointer-arith
-Wmissing-format-attribute -Werror=implicit-function-declaration -g
-I/usr/include/mysql
-fdebug-prefix-map=/build/mysql-5.7-lG4h93/mysql-5.7-5.7.16=. .specs
-fabi-version=2 -fno-omit-frame-pointer -pthread -Wdate-time
-D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/build/rsyslog-8.22.0=.
-fstack-protector-strong -Wformat -Werror=format-security -W -Wall
-Wformat-security -Wshadow -Wcast-align -Wpointer-arith
-Wmissing-format-attribute -g -c ommysql.c  -fPIC -DPIC -o
.libs/ommysql_la-ommysql.o
gcc: error: .specs: No such file or directory


Looking a bit closer, this is a bug in mysql_config, which injects bogus
build flags.

# mysql_config --cflags
# mysql_config --cflags
-I/usr/include/mysql -fdebug-prefix-map=/build/mysql-5.7-Q0jPG6/mysql-5.7-5.7.16=. .specs -fabi-version=2 -fno-omit-frame-pointer -fno-expensive-optimizations

Marking as RC, as this breaks the build for other packages.



-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.8.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages libmysqlclient-dev depends on:
ii  libmysqlclient20  5.7.16-1
ii  zlib1g-dev        1:1.2.8.dfsg-2+b3

libmysqlclient-dev recommends no packages.

libmysqlclient-dev suggests no packages.

-- no debconf information

Message #12 received at 844275@bugs.debian.org (full text, mbox, reply):

From: Peter van Dijk <habbie@gmail.com>

To: 844275@bugs.debian.org

Subject: Re: mysql_config injects build flags which breaks the build for other packages

Date: Mon, 14 Nov 2016 13:12:10 +0100

Hi,

On Mon, 14 Nov 2016 00:39:50 +0100 Michael Biebl <biebl@debian.org> 
wrote:
> Looking a bit closer, this is a bug in mysql_config, which injects 
> bogus
> build flags.
>
> # mysql_config --cflags
> # mysql_config --cflags
> -I/usr/include/mysql 
> -fdebug-prefix-map=/build/mysql-5.7-Q0jPG6/mysql-5.7-5.7.16=. .specs 
> -fabi-version=2 -fno-omit-frame-pointer -fno-expensive-optimizations
>
> Marking as RC, as this breaks the build for other packages.

Using --include instead may help here.

Peter

Message #61 received at 844275@bugs.debian.org (full text, mbox, reply):

From: "Norvald H. Ryeng" <norvald.ryeng@oracle.com>

To: 844275@bugs.debian.org

Subject: Re: [debian-mysql] Bug#844275: mysql_config injects build flags which breaks the build for other packages

Date: Wed, 23 Nov 2016 11:10:16 +0100

[Message part 1 (text/plain, inline)]

mysql_config and mysqlclient.pc pick up compile flags from the build
environment. We have a fix for this upstream, and I've backported it to
5.7.16 (see attachment).

I haven't tested it with sbuild/dpkg, so when applying this, please
verify that mysql_config and mysqlclient.pc don't pick up any flags
they shouldn't.

Regards,

Norvald

[mysql_config-5.7.16.patch (text/x-patch, attachment)]

Message #68 received at 844275@bugs.debian.org (full text, mbox, reply):

From: Lars Tangvald <lars.tangvald@oracle.com>

To: "Norvald H. Ryeng" <norvald.ryeng@oracle.com>, 844275@bugs.debian.org

Subject: Re: [debian-mysql] Bug#844275: Bug#844275: mysql_config injects build flags which breaks the build for other packages

Date: Thu, 24 Nov 2016 12:09:11 +0100

[Message part 1 (text/plain, inline)]

On 11/23/2016 11:10 AM, Norvald H. Ryeng wrote:
> mysql_config and mysqlclient.pc pick up compile flags from the build
> environment. We have a fix for this upstream, and I've backported it to
> 5.7.16 (see attachment).
>
> I haven't tested it with sbuild/dpkg, so when applying this, please
> verify that mysql_config and mysqlclient.pc don't pick up any flags
> they shouldn't.
>
> Regards,
>
> Norvald
>
I've verified that libmysqlclient-dev built with this patch fixes the 
rsyslog build, so hopefully we can get a build uploaded that fixes this 
fairly soon.

--
Lars


>
> _______________________________________________
> pkg-mysql-maint mailing list
> pkg-mysql-maint@lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-mysql-maint

[Message part 2 (text/html, inline)]

Message #81 received at 844275@bugs.debian.org (full text, mbox, reply):

From: Lars Tangvald <lars.tangvald@oracle.com>

To: Michael Biebl <biebl@debian.org>, 844275@bugs.debian.org

Cc: Debian MySQL Maintainers <pkg-mysql-maint@lists.alioth.debian.org>

Subject: Re: [debian-mysql] Bug#844275: mysql_config injects build flags which breaks the build for other packages

Date: Tue, 13 Dec 2016 09:47:28 +0100

Hi,

We've had a fix for this prepared for some time now, but haven't been 
able to find anyone to sponsor an upload to unstable. Do you know anyone 
who might be able to help?
It's ready to go from the mysql-5.7/debian/master branch at 
https://anonscm.debian.org/cgit/pkg-mysql/mysql.git

--
Lars

On 11/14/2016 12:39 AM, Michael Biebl wrote:
> Package: libmysqlclient-dev
> Version: 5.7.16-1
> Severity: serious
> File: /usr/bin/mysql_config
>
> Hi,
>
> I just tried to build the rsyslog package, which resulted in a build
> failure:
>
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I../../runtime
> -I../.. -I../../grammar -I/usr/include/libfastjson -W -Wall
> -Wformat-security -Wshadow -Wcast-align -Wpointer-arith
> -Wmissing-format-attribute -Werror=implicit-function-declaration -g
> -I/usr/include/mysql
> -fdebug-prefix-map=/build/mysql-5.7-lG4h93/mysql-5.7-5.7.16=. .specs
> -fabi-version=2 -fno-omit-frame-pointer -pthread -Wdate-time
> -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/build/rsyslog-8.22.0=.
> -fstack-protector-strong -Wformat -Werror=format-security -W -Wall
> -Wformat-security -Wshadow -Wcast-align -Wpointer-arith
> -Wmissing-format-attribute -g -c ommysql.c  -fPIC -DPIC -o
> .libs/ommysql_la-ommysql.o
> gcc: error: .specs: No such file or directory
>
>
> Looking a bit closer, this is a bug in mysql_config, which injects bogus
> build flags.
>
> # mysql_config --cflags
> # mysql_config --cflags
> -I/usr/include/mysql -fdebug-prefix-map=/build/mysql-5.7-Q0jPG6/mysql-5.7-5.7.16=. .specs -fabi-version=2 -fno-omit-frame-pointer -fno-expensive-optimizations
>
> Marking as RC, as this breaks the build for other packages.
>
>
>
> -- System Information:
> Debian Release: stretch/sid
>    APT prefers unstable
>    APT policy: (500, 'unstable'), (200, 'experimental')
> Architecture: amd64 (x86_64)
> Foreign Architectures: i386
>
> Kernel: Linux 4.8.0-1-amd64 (SMP w/4 CPU cores)
> Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
>
> Versions of packages libmysqlclient-dev depends on:
> ii  libmysqlclient20  5.7.16-1
> ii  zlib1g-dev        1:1.2.8.dfsg-2+b3
>
> libmysqlclient-dev recommends no packages.
>
> libmysqlclient-dev suggests no packages.
>
> -- no debconf information
>
> _______________________________________________
> pkg-mysql-maint mailing list
> pkg-mysql-maint@lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-mysql-maint

Message #86 received at 844275-close@bugs.debian.org (full text, mbox, reply):

From: Lars Tangvald <lars.tangvald@oracle.com>

To: 844275-close@bugs.debian.org

Subject: Bug#844275: fixed in mysql-5.7 5.7.16-2

Date: Tue, 03 Jan 2017 19:34:56 +0000

Source: mysql-5.7
Source-Version: 5.7.16-2

We believe that the bug you reported is fixed in the latest version of
mysql-5.7, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 844275@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Lars Tangvald <lars.tangvald@oracle.com> (supplier of updated mysql-5.7 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 03 Jan 2017 07:44:43 +0100
Source: mysql-5.7
Binary: libmysqlclient20 libmysqld-dev libmysqlclient-dev mysql-client-core-5.7 mysql-client-5.7 mysql-server-core-5.7 mysql-server-5.7 mysql-server mysql-client mysql-testsuite mysql-testsuite-5.7 mysql-source-5.7
Architecture: source
Version: 5.7.16-2
Distribution: unstable
Urgency: medium
Maintainer: Debian MySQL Maintainers <pkg-mysql-maint@lists.alioth.debian.org>
Changed-By: Lars Tangvald <lars.tangvald@oracle.com>
Description:
 libmysqlclient-dev - MySQL database development files
 libmysqlclient20 - MySQL database client library
 libmysqld-dev - MySQL embedded database development files
 mysql-client - MySQL database client (metapackage depending on the latest versio
 mysql-client-5.7 - MySQL database client binaries
 mysql-client-core-5.7 - MySQL database core client binaries
 mysql-server - MySQL database server (metapackage depending on the latest versio
 mysql-server-5.7 - MySQL database server binaries and system database setup
 mysql-server-core-5.7 - MySQL database server binaries
 mysql-source-5.7 - MySQL source
 mysql-testsuite - MySQL regression tests
 mysql-testsuite-5.7 - MySQL 5.7 testsuite
Closes: 841592 844275 847231
Changes:
 mysql-5.7 (5.7.16-2) unstable; urgency=medium
 .
   * Fix the test main.grant_user_lock when run as root
     The test was to log in as anonymous user, but would use the current system
     user. This was ok in most cases, but failed when the test was run as root
     since root has its own mysql user by default.
     (Closes: #841592)
   * Fix invalid build flags being used by mysql_config
     mysql_config was pulling in build flags from the build environment, causing
     build failures in other packages if the environment contained invalid flags.
     It now uses a whitelist system instead.
     (Closes: #844275)
   * Limit number of mtr parallel tests based on aio-max-nr system setting
     On systems with many cores the test suite could fail or be unstable because
     each server needs a certain number of aio slots. Build now limits max test
     parallelization based on the max number of slots available on the system.
   * Fix upgrade issue from mysql-5.5 in Jessie
     An innochecksum file was moved from server to server-core in 5.7, causing
     file conflicts when upgrading.
     (Closes: #847231)
   * Added patch to fix failing test main.events_2
     The test uses a hardcoded date (2017-01-01), and fails after that date.
     The patch is temporary pending upstream fix of the test.
Checksums-Sha1:
 0249b7d7f891272350eb0dfd4e9cb1538ab0acd3 3213 mysql-5.7_5.7.16-2.dsc
 2dfc780382d3762e1b59b3b370085d8d9e1b7d85 3389688 mysql-5.7_5.7.16-2.debian.tar.xz
Checksums-Sha256:
 56aa64b6bf356f068e9e41fca92204ed5d38d1b284f931184a097b8b4cb14c5f 3213 mysql-5.7_5.7.16-2.dsc
 f936a2846fb61e0ec29e488fc8f4dc03503430bf508f8c5960fadbccffc609fb 3389688 mysql-5.7_5.7.16-2.debian.tar.xz
Files:
 940567923538855719705aa7b8f7c47e 3213 database optional mysql-5.7_5.7.16-2.dsc
 f835061f73c144a72eb483ae675c8b54 3389688 database optional mysql-5.7_5.7.16-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJYa/cjAAoJEMAFfnFNaU+yf0QQANaAwyvgV/wHSHtRtrjSoWVE
TPBfGACvjChdN6Jo13wlJD6tiu+6VUTsQPecbclxSQQ9CZn3KylDUcvoz0w9czLy
MRj4QrEcnBpaV+yf1dGNfzG+VMoOJ0YhdU7yVmhqj3yt0TGOP39mXrEmf8IJteRh
zeMJ953CQTaZrFtclCgKFGeyP566VS/ByME/G02RPVFnOzHCjwrEsbO3M6CRRyxD
jLzceiMU4xkV2Bcd4ibuZ3hfQlrMy4i08SMUKkoLVuk/a7Fk4DXj7HQ1sc1Mes/x
ri9xvBlqsSe8+Oy1/dlUXzK9JRd2qfqIakRMymM3JM74rUFP8Mm3K3LgRXcPdWn5
/oXDFB9kcajvvc/k7thlmPg/OECF/NU6NZnrAXjZtzWxtKF9dINgJ/ZMXf2wZlN5
nB5I8ht2H2Z4JlqweekpalJ/OKXlkH0tUoKXTzqTq2LjzL4QGUkKuKGyGqwgu5dc
P6bMCdVrvemO310rlWZackr3qTcBOEiNx7RqyCR8fjpEmXMgM7KKjM/6cY13dDnz
ogohYKzNjnfZOvBxzaFdZuazOKOOGWiNYmfscsb+W0zLzMxWMV+xbE5/2VW2CQG0
KR1By0fNE366YRg8LI/to/Pybvl7MSXP4aX0vqkBtVGPp56AYM9Mg78xrvL0ejZC
z8iTQhJf8gJYhjNpjbhG
=vfew
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.