Debian Bug report logs - #842237
zfs-share.service tries to call /usr/sbin/rm

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Fabian Grünbichler <f.gruenbichler@proxmox.com>

To: submit@bugs.debian.org

Subject: zfs-share.service tries to call /usr/sbin/rm

Date: Thu, 27 Oct 2016 10:41:17 +0200

Package: zfsutils-linux
Version: 0.6.5.7-2
Severity: normal

Bug #832938 changed the bindir macro to /usr/sbin in order to move the
arc* python scripts there. Unfortunately, this macro is also used in the
zfs-share.service.in file as the location of the "rm" binary - which is
installed to /bin on Debian systems.

This leads to the following error message:
Oct 26 14:00:20 srv04 systemd[3046]: Failed at step EXEC spawning /usr/sbin/rm: No such file or directory

and the file /etc/df/sharetab is not deleted on boot (/service start).

The correct approach seems to be to patch the arc* script automake files
to use the sbindir macro (although that currently gets set to /sbin ,
not /usr/sbin , so maybe the scripts need some special casing here),
and not to change the bindir macro to point to an sbin directory.

The quick and dirty fix is to hardcode /bin/rm in zfs-share.service.in.

Message #10 received at 842237@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@hungry.com>

To: 842237@bugs.debian.org

Subject: Re: Bug#842237: zfs-share.service tries to call /usr/sbin/rm

Date: Thu, 27 Oct 2016 11:28:47 +0200

[Fabian Grünbichler]
> Bug #832938 changed the bindir macro to /usr/sbin in order to move the
> arc* python scripts there. Unfortunately, this macro is also used in the
> zfs-share.service.in file as the location of the "rm" binary - which is
> installed to /bin on Debian systems.
>
> This leads to the following error message:
> Oct 26 14:00:20 srv04 systemd[3046]: Failed at step EXEC spawning /usr/sbin/rm: No such file or directory
>
> and the file /etc/df/sharetab is not deleted on boot (/service start).

Thank you for letting us know.

> The correct approach seems to be to patch the arc* script automake files
> to use the sbindir macro (although that currently gets set to /sbin ,
> not /usr/sbin , so maybe the scripts need some special casing here),
> and not to change the bindir macro to point to an sbin directory.
>
> The quick and dirty fix is to hardcode /bin/rm in
> zfs-share.service.in.

If I understand you correctly, you propose this change, which make sense
to me if the tools should only be executable by root, independent of the
rm problem at hand:

diff --git a/cmd/arc_summary/Makefile.am b/cmd/arc_summary/Makefile.am
index 815af3b..defa4b2 100644
--- a/cmd/arc_summary/Makefile.am
+++ b/cmd/arc_summary/Makefile.am
@@ -1 +1 @@
-dist_bin_SCRIPTS = arc_summary.py
+dist_sbin_SCRIPTS = arc_summary.py
diff --git a/cmd/arcstat/Makefile.am b/cmd/arcstat/Makefile.am
index 8987b24..71e4125 100644
--- a/cmd/arcstat/Makefile.am
+++ b/cmd/arcstat/Makefile.am
@@ -1 +1 @@
-dist_bin_SCRIPTS = arcstat.py
+dist_sbin_SCRIPTS = arcstat.py
diff --git a/cmd/dbufstat/Makefile.am b/cmd/dbufstat/Makefile.am
index 19bffb0..1a4b4ef 100644
--- a/cmd/dbufstat/Makefile.am
+++ b/cmd/dbufstat/Makefile.am
@@ -1 +1 @@
-dist_bin_SCRIPTS = dbufstat.py
+dist_sbin_SCRIPTS = dbufstat.py
diff --git a/debian/rules b/debian/rules
index 15e0592..9c7d462 100755
--- a/debian/rules
+++ b/debian/rules
@@ -48,7 +48,7 @@ endif
 
        @# Build the userland, but don't build the kernel modules.
        dh_auto_configure -- \
-         --bindir=/usr/sbin \
+         --bindir=/usr/bin \
          --sbindir=/sbin \
          --libdir=/lib \
          --with-udevdir=/lib/udev \

But given that rm by definition always is available in /bin/,
independent of how zfs was compiled, I believe this change make more
sense to fix this exact problem:

diff --git a/etc/systemd/system/zfs-share.service.in b/etc/systemd/system/zfs-share.service.in
index 688731e..494f5cb 100644
--- a/etc/systemd/system/zfs-share.service.in
+++ b/etc/systemd/system/zfs-share.service.in
@@ -9,7 +9,7 @@ PartOf=smb.service
 [Service]
 Type=oneshot
 RemainAfterExit=yes
-ExecStartPre=-@bindir@/rm -f /etc/dfs/sharetab
+ExecStartPre=-/bin/rm -f /etc/dfs/sharetab
 ExecStart=@sbindir@/zfs share -a
 
 [Install]

Perhaps we should commit both?
-- 
Happy hacking
Petter Reinholdtsen

Message #15 received at 842237@bugs.debian.org (full text, mbox, reply):

From: Fabian Grünbichler <f.gruenbichler@proxmox.com>

To: Petter Reinholdtsen <pere@hungry.com>, 842237@bugs.debian.org

Subject: Re: Bug#842237: zfs-share.service tries to call /usr/sbin/rm

Date: Thu, 27 Oct 2016 11:59:35 +0200

On Thu, Oct 27, 2016 at 11:28:47AM +0200, Petter Reinholdtsen wrote:
> [Fabian Grünbichler]
> > The correct approach seems to be to patch the arc* script automake files
> > to use the sbindir macro (although that currently gets set to /sbin ,
> > not /usr/sbin , so maybe the scripts need some special casing here),
> > and not to change the bindir macro to point to an sbin directory.
> >
> > The quick and dirty fix is to hardcode /bin/rm in
> > zfs-share.service.in.
> 
> If I understand you correctly, you propose this change, which make sense
> to me if the tools should only be executable by root, independent of the
> rm problem at hand:
> 
> diff --git a/cmd/arc_summary/Makefile.am b/cmd/arc_summary/Makefile.am
> index 815af3b..defa4b2 100644
> --- a/cmd/arc_summary/Makefile.am
> +++ b/cmd/arc_summary/Makefile.am
> @@ -1 +1 @@
> -dist_bin_SCRIPTS = arc_summary.py
> +dist_sbin_SCRIPTS = arc_summary.py
> diff --git a/cmd/arcstat/Makefile.am b/cmd/arcstat/Makefile.am
> index 8987b24..71e4125 100644
> --- a/cmd/arcstat/Makefile.am
> +++ b/cmd/arcstat/Makefile.am
> @@ -1 +1 @@
> -dist_bin_SCRIPTS = arcstat.py
> +dist_sbin_SCRIPTS = arcstat.py
> diff --git a/cmd/dbufstat/Makefile.am b/cmd/dbufstat/Makefile.am
> index 19bffb0..1a4b4ef 100644
> --- a/cmd/dbufstat/Makefile.am
> +++ b/cmd/dbufstat/Makefile.am
> @@ -1 +1 @@
> -dist_bin_SCRIPTS = dbufstat.py
> +dist_sbin_SCRIPTS = dbufstat.py
> diff --git a/debian/rules b/debian/rules
> index 15e0592..9c7d462 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -48,7 +48,7 @@ endif
>  
>         @# Build the userland, but don't build the kernel modules.
>         dh_auto_configure -- \
> -         --bindir=/usr/sbin \
> +         --bindir=/usr/bin \
>           --sbindir=/sbin \
>           --libdir=/lib \
>           --with-udevdir=/lib/udev \
> 

IMHO, that's a step in the right direction, especially for preventing
future misplaced files (bindir should not be set to [/usr]/sbin). But
note that this moves the scripts from their current location in
/usr/sbin to just /sbin (not sure whether this is worth spending extra
effort on, especially since usr merge seems to be happening soon?).

> But given that rm by definition always is available in /bin/,
> independent of how zfs was compiled, I believe this change make more
> sense to fix this exact problem:
> 
> diff --git a/etc/systemd/system/zfs-share.service.in b/etc/systemd/system/zfs-share.service.in
> index 688731e..494f5cb 100644
> --- a/etc/systemd/system/zfs-share.service.in
> +++ b/etc/systemd/system/zfs-share.service.in
> @@ -9,7 +9,7 @@ PartOf=smb.service
>  [Service]
>  Type=oneshot
>  RemainAfterExit=yes
> -ExecStartPre=-@bindir@/rm -f /etc/dfs/sharetab
> +ExecStartPre=-/bin/rm -f /etc/dfs/sharetab
>  ExecStart=@sbindir@/zfs share -a
>  
>  [Install]
> 

This is what we've done in our downstream package, I did not send a
patch because the change is so trivial ;)

> Perhaps we should commit both?

Sounds good to me. Thanks for the quick response btw!

Message #20 received at 842237@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@hungry.com>

To: Fabian Grünbichler <f.gruenbichler@proxmox.com>, 842237@bugs.debian.org

Subject: Re: Bug#842237: zfs-share.service tries to call /usr/sbin/rm

Date: Thu, 27 Oct 2016 12:11:12 +0200

[Fabian Grünbichler]
> IMHO, that's a step in the right direction, especially for preventing
> future misplaced files (bindir should not be set to [/usr]/sbin). But
> note that this moves the scripts from their current location in
> /usr/sbin to just /sbin (not sure whether this is worth spending extra
> effort on, especially since usr merge seems to be happening soon?).

I do not know the code well enough to say if it make sense or not, and
hope others on the team can have an opinion here.  But given that the
change is in the automake files, I anyhow believe these changes should
go into upstream if them make sense.  Perhaps you can try to submit them
there?

-- 
Vennlig hilsen
Petter Reinholdtsen

Message #25 received at 842237@bugs.debian.org (full text, mbox, reply):

From: Fabian Grünbichler <f.gruenbichler@proxmox.com>

To: Petter Reinholdtsen <pere@hungry.com>, 842237@bugs.debian.org

Subject: Re: Bug#842237: zfs-share.service tries to call /usr/sbin/rm

Date: Thu, 27 Oct 2016 14:40:05 +0200

On Thu, Oct 27, 2016 at 12:11:12PM +0200, Petter Reinholdtsen wrote:
> [Fabian Grünbichler]
> > IMHO, that's a step in the right direction, especially for preventing
> > future misplaced files (bindir should not be set to [/usr]/sbin). But
> > note that this moves the scripts from their current location in
> > /usr/sbin to just /sbin (not sure whether this is worth spending extra
> > effort on, especially since usr merge seems to be happening soon?).
> 
> I do not know the code well enough to say if it make sense or not, and
> hope others on the team can have an opinion here.  But given that the
> change is in the automake files, I anyhow believe these changes should
> go into upstream if them make sense.  Perhaps you can try to submit them
> there?
> 

Not sure whether that is desired upstream - all three scripts don't
require root privileges, so it might make sense to put them into
bin_dir (by default). I know that regular users can of course also do
/usr/sbin/arc_summary.py , but AFAIK by default $PATH will not include
/usr/sbin for regular users, which might mean that they miss this
helpful debugging tool.

With the zfs-share.service.in file patched with a hard-coded rm path,
setting bin_dir to '/usr/bin' might actually be the most sane compromise
between Debian and upstream? Anyway, where the python scripts end up and
how they get there is IMHO rather low priority compared to the broken
zfs-share service file.

Anyway, I opened an issue on github[1], waiting for more team and
upstream input seems appropriate.

1: https://github.com/zfsonlinux/zfs/issues/5344

Message #30 received at 842237@bugs.debian.org (full text, mbox, reply):

From: Richard Laager <rlaager@wiktel.com>

To: Fabian Grünbichler <f.gruenbichler@proxmox.com>, 842237@bugs.debian.org

Cc: Petter Reinholdtsen <pere@hungry.com>

Subject: Re: [Pkg-zfsonlinux-devel] Bug#842237: zfs-share.service tries to call /usr/sbin/rm

Date: Thu, 27 Oct 2016 08:44:41 -0500

FWIW, the Debian package can put these wherever with a simple mv in debian/rules. Choices are not limited by the upstream autoconf setup.

-- 
Richard

Message #35 received at 842237@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@hungry.com>

To: Fabian Grünbichler <f.gruenbichler@proxmox.com>, 842237@bugs.debian.org

Subject: Re: [Pkg-zfsonlinux-devel] Bug#842237: zfs-share.service tries to call /usr/sbin/rm

Date: Thu, 27 Oct 2016 16:04:17 +0200

[Richard Laager]
> FWIW, the Debian package can put these wherever with a simple mv in
> debian/rules. Choices are not limited by the upstream autoconf setup.

Absolutely.  On the other hand, I believe we are doing zfs users a
service if the binaries are placed the same place across Linux and unix*
distributions.  It make life for IT support and documentation writers
easier.
 
--
Happy hacking
Petter Reinholdtsen

Message #40 received at 842237@bugs.debian.org (full text, mbox, reply):

From: Richard Laager <rlaager@wiktel.com>

To: Petter Reinholdtsen <pere@hungry.com>, 842237@bugs.debian.org

Subject: Re: [Pkg-zfsonlinux-devel] Bug#842237: Bug#842237: zfs-share.service tries to call /usr/sbin/rm

Date: Thu, 27 Oct 2016 09:11:59 -0500

On 10/27/2016 09:04 AM, Petter Reinholdtsen wrote:
> [Richard Laager]
>> FWIW, the Debian package can put these wherever with a simple mv in
>> debian/rules. Choices are not limited by the upstream autoconf setup.
> 
> Absolutely.  On the other hand, I believe we are doing zfs users a
> service if the binaries are placed the same place across Linux and unix*
> distributions.  It make life for IT support and documentation writers
> easier.

I really wouldn't worry about that. 1) That's why we have PATH. 2) Down
this road lies madness. You can't have a self-consistent Debian system
and also be consistent with every upstream.

-- 
Richard

Message #45 received at 842237@bugs.debian.org (full text, mbox, reply):

From: Fabian Grünbichler <f.gruenbichler@proxmox.com>

To: Petter Reinholdtsen <pere@hungry.com>, 842237@bugs.debian.org

Subject: Re: [Pkg-zfsonlinux-devel] Bug#842237: zfs-share.service tries to call /usr/sbin/rm

Date: Fri, 28 Oct 2016 11:49:37 +0200

[Message part 1 (text/plain, inline)]

On Thu, Oct 27, 2016 at 04:04:17PM +0200, Petter Reinholdtsen wrote:
> [Richard Laager]
> > FWIW, the Debian package can put these wherever with a simple mv in
> > debian/rules. Choices are not limited by the upstream autoconf setup.
> 
> Absolutely.  On the other hand, I believe we are doing zfs users a
> service if the binaries are placed the same place across Linux and unix*
> distributions.  It make life for IT support and documentation writers
> easier.
>  

Attached patch reverts the bindir = /usr/sbin change in favour of moving
the scripts in debian/rules (reusing the 'mv' that already happens in
master because of the dropped '.py' suffix).

I checked and none of the file paths in the built binary packages
changes, so this only reverts to the default bindir for future binaries
introduced in newer upstream versions.

Ubuntu seems to have opted for symlinking the non-'.py' paths instead of
moving the scripts (I assume for compatibility with existing scripts /
callers), if that is planned for the Debian packages as well the "mv to
rename" and "mv to move" calls need to be split of course.

[0001-fix-python-script-install-path.patch (text/x-diff, attachment)]

Message #50 received at 842237@bugs.debian.org (full text, mbox, reply):

From: Richard Laager <rlaager@wiktel.com>

To: Fabian Grünbichler <f.gruenbichler@proxmox.com>, 842237@bugs.debian.org, Petter Reinholdtsen <pere@hungry.com>

Subject: Re: [Pkg-zfsonlinux-devel] Bug#842237: Bug#842237: zfs-share.service tries to call /usr/sbin/rm

Date: Fri, 28 Oct 2016 05:01:07 -0500

On 10/28/2016 04:49 AM, Fabian Grünbichler wrote:
> Ubuntu seems to have opted for symlinking the non-'.py' paths instead of
> moving the scripts (I assume for compatibility with existing scripts /
> callers), if that is planned for the Debian packages as well the "mv to
> rename" and "mv to move" calls need to be split of course.

Ubuntu is only doing the symlinks because they (against my advice in
advance!) shipped them with .py extensions for a month or so. This
violates Debian/Ubuntu Policy, so they fixed it, but they didn't want to
regress anyone who was using those paths. The symlinks, from what I
understand (though I haven't checked) were only going to exist in
Xenial. There's no need for them in Debian.

-- 
Richard

Message #55 received at 842237-close@bugs.debian.org (full text, mbox, reply):

From: Aron Xu <aron@debian.org>

To: 842237-close@bugs.debian.org

Subject: Bug#842237: fixed in zfs-linux 0.6.5.9-1

Date: Tue, 07 Feb 2017 06:33:43 +0000

Source: zfs-linux
Source-Version: 0.6.5.9-1

We believe that the bug you reported is fixed in the latest version of
zfs-linux, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 842237@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Aron Xu <aron@debian.org> (supplier of updated zfs-linux package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 06 Feb 2017 15:57:50 +0800
Source: zfs-linux
Binary: libnvpair1linux libuutil1linux libzfslinux-dev libzfs2linux libzpool2linux zfs-dkms zfs-initramfs zfs-dracut zfsutils-linux zfs-zed zfs-dbg
Architecture: source amd64 all
Version: 0.6.5.9-1
Distribution: unstable
Urgency: medium
Maintainer: Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>
Changed-By: Aron Xu <aron@debian.org>
Description:
 libnvpair1linux - Solaris name-value library for Linux
 libuutil1linux - Solaris userland utility library for Linux
 libzfs2linux - OpenZFS filesystem library for Linux
 libzfslinux-dev - OpenZFS filesystem development files for Linux
 libzpool2linux - OpenZFS pool library for Linux
 zfs-dbg    - Debugging symbols for OpenZFS userland libraries and tools
 zfs-dkms   - OpenZFS filesystem kernel modules for Linux
 zfs-dracut - OpenZFS root filesystem capabilities for Linux - dracut
 zfs-initramfs - OpenZFS root filesystem capabilities for Linux - initramfs
 zfs-zed    - OpenZFS Event Daemon
 zfsutils-linux - command-line tools to manage OpenZFS filesystems
Closes: 842237 849969 851513
Changes:
 zfs-linux (0.6.5.9-1) unstable; urgency=medium
 .
   [ Aron Xu ]
   * Imported Upstream version 0.6.5.9 (Closes: #851513)
 .
   [ Lukas Wunner ]
   * Cherry picks for root zpool with dracut (Closes: #849969)
   * Fix installation path of systemd files
   * Fix build breakage caused by nonstandard umask
 .
   [ Fabian Grünbichler ]
   * fix python script install path (Closes: #842237)
Checksums-Sha1:
 d34e86e53aeb3c6872f19d2703e9c50e8174cf21 2593 zfs-linux_0.6.5.9-1.dsc
 6c580575691e346bd97c31959148921ea9df8c26 2610650 zfs-linux_0.6.5.9.orig.tar.gz
 76e6bc928a1b902f910254b3baddabe6a0ae4703 51380 zfs-linux_0.6.5.9-1.debian.tar.xz
 af8e56e3fefa522bc0b96f2bd5b89d16b1dec8c5 44182 libnvpair1linux_0.6.5.9-1_amd64.deb
 b0b5886aa4c3f95ddf83cbaa9755b35b9b2974be 47178 libuutil1linux_0.6.5.9-1_amd64.deb
 e0ae55e156e063654b01174ee459967f916eee1b 125776 libzfs2linux_0.6.5.9-1_amd64.deb
 0427979b007a2422e9b9a96efe37c0764fc4e20d 813844 libzfslinux-dev_0.6.5.9-1_amd64.deb
 eb96537aa5dc86a2882e8f7ac9299ff8b9964750 401064 libzpool2linux_0.6.5.9-1_amd64.deb
 e46585f7110fdd50f5e1a8faea2454534716c347 2646752 zfs-dbg_0.6.5.9-1_amd64.deb
 59ba7542c3c804290393c98a6a50f156691b58a8 1079392 zfs-dkms_0.6.5.9-1_all.deb
 a5008c9f21f7a64dd52045d510936ab1a59e6493 19900 zfs-dracut_0.6.5.9-1_all.deb
 a906c3582f442557b3a566efae5fc4ea755fb0a7 23010 zfs-initramfs_0.6.5.9-1_all.deb
 253142a517fc3e56f1c47aaac2bd46f0ed496335 8138 zfs-linux_0.6.5.9-1_amd64.buildinfo
 4e2900841f7359452e1cc0af50cee906e939c9cf 42870 zfs-zed_0.6.5.9-1_amd64.deb
 4dae69d4d38efcb723f6a870c12c4f936fd4cb4c 335112 zfsutils-linux_0.6.5.9-1_amd64.deb
Checksums-Sha256:
 399a936eec1134186edd27851647b2d7ae3ddcd9b8bbbd06385df2e8762112b9 2593 zfs-linux_0.6.5.9-1.dsc
 b724b57dbddae59246fdc15f88f1224061c712945bb36412a2087e0c7760d77f 2610650 zfs-linux_0.6.5.9.orig.tar.gz
 73c7681830aafd5e6a64fbeccbd2928f38e9917ed54503e6ccc0f8b969efa131 51380 zfs-linux_0.6.5.9-1.debian.tar.xz
 2bfba6d2fd80799609d98a0c2f3f884ca5ed4442a0d3184555593b3cf76fc3a2 44182 libnvpair1linux_0.6.5.9-1_amd64.deb
 7e1fc815e4eaa8e62f8778c13a09050fceb74f4c7ed3fe66746d56fd7fb4ca12 47178 libuutil1linux_0.6.5.9-1_amd64.deb
 bf1a96af9975fcdf7a5b4fa6754a9f13bdc601cf5f4186f102b5175832fc2330 125776 libzfs2linux_0.6.5.9-1_amd64.deb
 08bf42729e0546374cb17d8e52b2301f39a32c59a03c02dff0198ab4a6123669 813844 libzfslinux-dev_0.6.5.9-1_amd64.deb
 963980518913e9ce5b21437348ef028a5fcf041b38a9c9fb064a92358ae9b0bc 401064 libzpool2linux_0.6.5.9-1_amd64.deb
 3fa4a0dd7e262ce6e5b8ca9e7e55b7d9cc870f179e58de4ac19aa939fca9b091 2646752 zfs-dbg_0.6.5.9-1_amd64.deb
 8cc731849ff7f7924f4a7962b01579ceb8a1d73cb107e0f0a31f4d6ac230985f 1079392 zfs-dkms_0.6.5.9-1_all.deb
 041d862a5b31cfca271e6e30fd71ed68331084b265f8ec42dfdc9b7839f02ce3 19900 zfs-dracut_0.6.5.9-1_all.deb
 62dd622e18d6c9fdd11f5c360a209250779ce02c56aa25dc61bf750434176029 23010 zfs-initramfs_0.6.5.9-1_all.deb
 5820c139d8c8fd100e087138dff4d25ea0dd2a6f0fd849da60e4f5683f51e88f 8138 zfs-linux_0.6.5.9-1_amd64.buildinfo
 f81e4d3a302f68b350e0ac4184f892d5ff4ae9158b01cd231c50c6562a5b306c 42870 zfs-zed_0.6.5.9-1_amd64.deb
 37412dd74f045cd8f412e64a988da2d4017ae1b60f9ab64e44a713452620fb93 335112 zfsutils-linux_0.6.5.9-1_amd64.deb
Files:
 9de9e4d1b52b8850c00db7ace373bb2a 2593 contrib/kernel optional zfs-linux_0.6.5.9-1.dsc
 9dceb3930be4e1a8cf35bcc40e48e527 2610650 contrib/kernel optional zfs-linux_0.6.5.9.orig.tar.gz
 8c16e9ac1d3b1882a8c08fe6fd5c027f 51380 contrib/kernel optional zfs-linux_0.6.5.9-1.debian.tar.xz
 10ea1b7b210ace6505140c34c81fe183 44182 contrib/libs optional libnvpair1linux_0.6.5.9-1_amd64.deb
 9456629567bd0485e82b91026dab1715 47178 contrib/libs optional libuutil1linux_0.6.5.9-1_amd64.deb
 a708b41748de1662cebc7bb4fd4c60a9 125776 contrib/libs optional libzfs2linux_0.6.5.9-1_amd64.deb
 f661a48a790b8b6442ae5f885e649e98 813844 contrib/libdevel optional libzfslinux-dev_0.6.5.9-1_amd64.deb
 2c6bde4311897a9c898da423548a95bc 401064 contrib/libs optional libzpool2linux_0.6.5.9-1_amd64.deb
 4f3020a5c7e8817135a873d26a1c969b 2646752 contrib/debug extra zfs-dbg_0.6.5.9-1_amd64.deb
 5f8492d14eebbe4814fc0c0c82dce4c3 1079392 contrib/kernel optional zfs-dkms_0.6.5.9-1_all.deb
 03f0523cb69188a44c3ee0ffaf175d0e 19900 contrib/kernel optional zfs-dracut_0.6.5.9-1_all.deb
 65b4f5e0cfdaf08e99ce0fc3883c29a1 23010 contrib/kernel optional zfs-initramfs_0.6.5.9-1_all.deb
 ebe62071f1008d5e5468ec89f7423752 8138 contrib/kernel optional zfs-linux_0.6.5.9-1_amd64.buildinfo
 53a41171d1f6bc76d8841640d8366677 42870 contrib/admin optional zfs-zed_0.6.5.9-1_amd64.deb
 fa945c8e4f67e561725c65a082b3e11f 335112 contrib/admin optional zfsutils-linux_0.6.5.9-1_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEET3MbhxKET+7/a6zdW0gHVdEZ6o4FAliZZccACgkQW0gHVdEZ
6o7BbAf6A/g+L/0157mpXm/2SD4COLjdqm4KBvG4s1j6YDO/37jVCHVLiSCt1wD5
oE7C7TQ1UzaQRzAKsU0k6pC50/9bgVTF9rBbayYRZb8557uVtwjz2J9orNvWelh8
8TGZSSor4+Xf51yy+vm4StUtf0wcdN4nN/RQrGpq2QajsCFBx6E5S0eG18KzvxNA
FOB4P8mRvXX5oE2npSrr+m39CTba0Wr2nRm/nYXsduRLt2RPo+NIcziRGcHAncZu
2lqrrHsgLJYCQg3dvqfqWw3BeJPVT7dApFaLpUslhF/IYHziMtnIb3LD8YnMjFc1
i2G7RsEYhzMdvIwiiC3yUOBh9CUdGw==
=JMyR
-----END PGP SIGNATURE-----

Message #60 received at 842237@bugs.debian.org (full text, mbox, reply):

From: Mike Fiedler <paziu@yahoo.com>

To: Debian Bug Tracking System <842237@bugs.debian.org>

Subject: zfsutils-linux: 0.6.5.9-2 still fails - zfs-share.service

Date: Mon, 13 Mar 2017 14:22:16 -0400

Package: zfsutils-linux
Version: 0.6.5.9-2
Followup-For: Bug #842237

Dear Maintainer,

zfs-share.service fails to start:

<
Mar 13 13:40:34 deb01 systemd[1]: Starting ZFS file system shares...
-- Subject: Unit zfs-share.service has begun start-up
-- Defined-By: systemd
-- Support: https://www.debian.org/support
--
-- Unit zfs-share.service has begun starting up.
Mar 13 13:40:34 deb01 zed[11499]: eid=2 class=config.sync pool=rpool
Mar 13 13:40:34 deb01 systemd[11500]: zfs-share.service: Failed at step EXEC spawning /usr/bin/rm: No such file or directory
-- Subject: Process /usr/bin/rm could not be executed
-- Defined-By: systemd
-- Support: https://www.debian.org/support
--
-- The process /usr/bin/rm could not be executed and failed.
--
-- The error number returned by this process is 2.
>

I checked the changelog for 0.6.5.9-3 and I also do not see  /bin/rm  changed/added for the x86 32&64 arch for "dh_auto_configure"

Thank you!

Mike



-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-1-amd64 (SMP w/32 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages zfsutils-linux depends on:
ii  init-system-helpers  1.47
ii  libblkid1            2.29.1-1
ii  libc6                2.24-9
ii  libnvpair1linux      0.6.5.9-2
ii  libuuid1             2.29.1-1
ii  libuutil1linux       0.6.5.9-2
ii  libzfs2linux         0.6.5.9-2
ii  libzpool2linux       0.6.5.9-2
ii  python3              3.5.3-1
pn  python3:any          <none>
ii  zlib1g               1:1.2.8.dfsg-5

Versions of packages zfsutils-linux recommends:
ii  lsb-base                9.20161125
ii  zfs-dkms [zfs-modules]  0.6.5.9-2
ii  zfs-zed                 0.6.5.9-2

Versions of packages zfsutils-linux suggests:
pn  nfs-kernel-server  <none>
pn  samba-common-bin   <none>
ii  zfs-initramfs      0.6.5.9-2

-- no debconf information

Message #65 received at 842237@bugs.debian.org (full text, mbox, reply):

From: Fabian Grünbichler <f.gruenbichler@proxmox.com>

To: Mike Fiedler <paziu@yahoo.com>, 842237@bugs.debian.org

Subject: Re: Bug#842237: zfsutils-linux: 0.6.5.9-2 still fails - zfs-share.service

Date: Fri, 21 Apr 2017 08:38:19 +0200

[Message part 1 (text/plain, inline)]

On Mon, Mar 13, 2017 at 02:22:16PM -0400, Mike Fiedler wrote:
> Package: zfsutils-linux
> Version: 0.6.5.9-2
> Followup-For: Bug #842237
> 
> Dear Maintainer,
> 
> zfs-share.service fails to start:
> 
> <
> Mar 13 13:40:34 deb01 systemd[1]: Starting ZFS file system shares...
> -- Subject: Unit zfs-share.service has begun start-up
> -- Defined-By: systemd
> -- Support: https://www.debian.org/support
> --
> -- Unit zfs-share.service has begun starting up.
> Mar 13 13:40:34 deb01 zed[11499]: eid=2 class=config.sync pool=rpool
> Mar 13 13:40:34 deb01 systemd[11500]: zfs-share.service: Failed at step EXEC spawning /usr/bin/rm: No such file or directory
> -- Subject: Process /usr/bin/rm could not be executed
> -- Defined-By: systemd
> -- Support: https://www.debian.org/support
> --
> -- The process /usr/bin/rm could not be executed and failed.
> --
> -- The error number returned by this process is 2.
> >
> 
> I checked the changelog for 0.6.5.9-3 and I also do not see  /bin/rm  changed/added for the x86 32&64 arch for "dh_auto_configure"
> 
> Thank you!
> 
> Mike
> 
> 
> 

I think 0.6.5.9-1 closed this one prematurely - only the second part of
my proposed fixes was applied, the first one (hardcoding "/bin/rm"
instead of "@bindir@/rm" was missed (I attached a full patch again this
time).

[0001-fix-rm-path-in-zfs-share.service.patch (text/x-diff, attachment)]

Message #76 received at 842237@bugs.debian.org (full text, mbox, reply):

From: James Youngman <james@youngman.org>

To: Debian Bug Tracking System <842237@bugs.debian.org>

Subject: zfsutils-linux: Not fixed: still affects stretch

Date: Sun, 9 Jul 2017 08:53:55 +0100

Package: zfsutils-linux
Version: 0.6.5.9-5
Followup-For: Bug #842237

[...]
Jul 09 08:19:00 orbital systemd[1113]: zfs-share.service: Failed at
step EXEC spawning /usr/bin/rm: No such file or directory
Jul 09 08:19:00 orbital zed[1111]: ZFS Event Daemon 0.6.5.9-5 (PID 1111)
Jul 09 08:19:00 orbital zed[1111]: Processing events since eid=0
[...]

-- System Information:
Debian Release: 9.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_IE.UTF-8, LC_CTYPE=en_IE.UTF-8 (charmap=UTF-8),
LANGUAGE=en_IE:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages zfsutils-linux depends on:
ii  init-system-helpers  1.48
ii  libblkid1            2.29.2-1
ii  libc6                2.24-11+deb9u1
ii  libnvpair1linux      0.6.5.9-5
ii  libuuid1             2.29.2-1
ii  libuutil1linux       0.6.5.9-5
ii  libzfs2linux         0.6.5.9-5
ii  libzpool2linux       0.6.5.9-5
ii  python3              3.5.3-1
ii  zlib1g               1:1.2.8.dfsg-5

Versions of packages zfsutils-linux recommends:
ii  lsb-base                9.20161125
ii  zfs-dkms [zfs-modules]  0.6.5.9-5
ii  zfs-zed                 0.6.5.9-5

Versions of packages zfsutils-linux suggests:
pn  nfs-kernel-server           <none>
ii  samba-common-bin            2:4.5.8+dfsg-2
pn  zfs-initramfs | zfs-dracut  <none>

-- Configuration Files:
/etc/sudoers.d/zfs [Errno 13] Permission denied: '/etc/sudoers.d/zfs'

-- no debconf information

Message #83 received at 842237@bugs.debian.org (full text, mbox, reply):

From: dchrist <dchrist19811@gmail.com>

To: Debian Bug Tracking System <842237@bugs.debian.org>

Subject: zfsutils-linux: zfs-share.service still tries to call /usr/bin/rm on Debian stable

Date: Sat, 07 Oct 2017 21:20:51 +0200

Package: zfsutils-linux
Version: 0.6.5.9-5
Followup-For: Bug #842237

Dear Maintainer,

the systemd unit zfs-share.service still tries to run /usr/bin/rm on ExecStartPre, 
which does not exist. 

This leads to following journal error: 

Okt 07 19:01:41 nas systemd[1617]: zfs-share.service: Failed at step EXEC spawning /usr/bin/rm: No such file or directory

-- System Information:
Debian Release: 9.1
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages zfsutils-linux depends on:
ii  init-system-helpers  1.48
ii  libblkid1            2.29.2-1
ii  libc6                2.24-11+deb9u1
ii  libnvpair1linux      0.6.5.9-5
ii  libuuid1             2.29.2-1
ii  libuutil1linux       0.6.5.9-5
ii  libzfs2linux         0.6.5.9-5
ii  libzpool2linux       0.6.5.9-5
ii  python3              3.5.3-1
ii  zlib1g               1:1.2.8.dfsg-5

Versions of packages zfsutils-linux recommends:
ii  lsb-base                9.20161125
ii  zfs-dkms [zfs-modules]  0.6.5.9-5
ii  zfs-zed                 0.6.5.9-5

Versions of packages zfsutils-linux suggests:
pn  nfs-kernel-server           <none>
ii  samba-common-bin            2:4.5.12+dfsg-2
pn  zfs-initramfs | zfs-dracut  <none>

-- Configuration Files:
/etc/cron.d/zfsutils-linux [Errno 2] Datei oder Verzeichnis nicht gefunden: '/etc/cron.d/zfsutils-linux'
/etc/sudoers.d/zfs [Errno 13] Keine Berechtigung: '/etc/sudoers.d/zfs'

-- no debconf information

Message #92 received at 842237@bugs.debian.org (full text, mbox, reply):

From: Fabian Grünbichler <f.gruenbichler@proxmox.com>

To: 842237@bugs.debian.org

Subject: Re: zfsutils-linux: zfs-share.service still tries to call /usr/bin/rm on Debian stable

Date: Sun, 8 Oct 2017 08:31:00 +0200 (CEST)

On Sat, 07 Oct 2017 21:20:51 +0200 dchrist <dchrist19811@gmail.com> wrote:
> Package: zfsutils-linux
> Version: 0.6.5.9-5
> Followup-For: Bug #842237
> 
> Dear Maintainer,
> 
> the systemd unit zfs-share.service still tries to run /usr/bin/rm on ExecStartPre, 
> which does not exist. 
> 
> This leads to following journal error: 
> 
> Okt 07 19:01:41 nas systemd[1617]: zfs-share.service: Failed at step EXEC spawning /usr/bin/rm: No such file or directory
> 

(not maintainer), but

this has been fixed in 0.6.5.11-1, which is available in stretch-backports and jessie-backports as well.

Message #97 received at 842237-close@bugs.debian.org (full text, mbox, reply):

From: Aron Xu <aron@debian.org>

To: 842237-close@bugs.debian.org, 915576-close@bugs.debian.org

Date: Sun, 3 Feb 2019 19:50:45 +0800

The correct /bin/rm is being referenced now, closing these two reports.

Cheers,
Aron

Send a report that this bug log contains spam.