Debian Bug report logs - #841783
patchutils: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Reiner Herrmann <reiner@reiner-h.de>

To: submit@bugs.debian.org

Subject: patchutils: please make the build reproducible

Date: Sun, 23 Oct 2016 15:29:36 +0200

[Message part 1 (text/plain, inline)]

Source: patchutils
Version: 0.3.4-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that patchutils could not be built reproducibly.
It does not use CFLAGS provided by dpkg-buildflags for building, which
would set -fdebug-prefix-map to prevent the full build path from being
included in debugging symbols.

The attached patch fixes that by using dpkg-buildflags for setting CFLAGS.
Due to -Werror=format-security, which is then also set by dpkg-buildflags,
the build failed because of a format string issue.
A patch for this is also included.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds

[patchutils.patch (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 841783@bugs.debian.org (full text, mbox, reply):

From: Reiner Herrmann <reiner@reiner-h.de>

To: 841783@bugs.debian.org

Cc: reproducible-builds@lists.alioth.debian.org

Subject: Re: Bug#841783: patchutils: please make the build reproducible

Date: Sun, 23 Oct 2016 16:08:39 +0200

[Message part 1 (text/plain, inline)]

On Sun, Oct 23, 2016 at 03:29:36PM +0200, Reiner Herrmann wrote:
> --- a/debian/rules
> +++ b/debian/rules
> @@ -13,7 +13,7 @@ else
>  CONFFLAGS = --build $(DEB_BUILD_GNU_TYPE) --host $(DEB_HOST_GNU_TYPE)
>  endif
>  
> -CFLAGS = -g
> +CFLAGS = $(shell dpkg-buildflags --get CFLAGS)
>  
>  ifeq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
>  CFLAGS += -O2

Niels Thykier suggested another approach.
dh_auto_configure already handles CFLAGS and cross-building, so the
rules can be simplified a bit.
An updated patch is attached.

[patchutils.patch (text/x-diff, attachment)]

Message #15 received at 841783@bugs.debian.org (full text, mbox, reply):

From: Niels Thykier <niels@thykier.net>

To: 841783@bugs.debian.org

Subject: Re: Bug#841783: patchutils: please make the build reproducible

Date: Sun, 23 Oct 2016 14:13:00 +0000

On Sun, 23 Oct 2016 16:08:39 +0200 Reiner Herrmann <reiner@reiner-h.de>
wrote:
> On Sun, Oct 23, 2016 at 03:29:36PM +0200, Reiner Herrmann wrote:
> > --- a/debian/rules
> > +++ b/debian/rules
> > @@ -13,7 +13,7 @@ else
> >  CONFFLAGS = --build $(DEB_BUILD_GNU_TYPE) --host $(DEB_HOST_GNU_TYPE)
> >  endif
> >  
> > -CFLAGS = -g
> > +CFLAGS = $(shell dpkg-buildflags --get CFLAGS)
> >  
> >  ifeq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
> >  CFLAGS += -O2
> 
> Niels Thykier suggested another approach.
> dh_auto_configure already handles CFLAGS and cross-building, so the
> rules can be simplified a bit.
> An updated patch is attached.

FTR, the rationale for dropping the "cross-build" guard around the test
can be found in #726967 (dh_auto_test should *not* be automatically
skipped for cross-building)

Thanks,
~Niels

Message #20 received at 841783@bugs.debian.org (full text, mbox, reply):

From: László Böszörményi (GCS) <gcs@debian.org>

To: Reiner Herrmann <reiner@reiner-h.de>, 841783@bugs.debian.org

Cc: reproducible-builds@lists.alioth.debian.org

Subject: Re: Bug#841783: patchutils: please make the build reproducible

Date: Sun, 23 Oct 2016 16:14:11 +0200

On Sun, Oct 23, 2016 at 4:08 PM, Reiner Herrmann <reiner@reiner-h.de> wrote:
> On Sun, Oct 23, 2016 at 03:29:36PM +0200, Reiner Herrmann wrote:
> Niels Thykier suggested another approach.
> dh_auto_configure already handles CFLAGS and cross-building, so the
> rules can be simplified a bit.
> An updated patch is attached.
 Already uploaded the package with your patch. :( Checking if I may
still delete it from the queue...

Laszlo/GCS

Message #25 received at 841783-close@bugs.debian.org (full text, mbox, reply):

From: Laszlo Boszormenyi (GCS) <gcs@debian.org>

To: 841783-close@bugs.debian.org

Subject: Bug#841783: fixed in patchutils 0.3.4-2

Date: Sun, 23 Oct 2016 23:32:14 +0000

Source: patchutils
Source-Version: 0.3.4-2

We believe that the bug you reported is fixed in the latest version of
patchutils, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 841783@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Laszlo Boszormenyi (GCS) <gcs@debian.org> (supplier of updated patchutils package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 23 Oct 2016 15:36:30 +0200
Source: patchutils
Binary: patchutils
Architecture: source amd64
Version: 0.3.4-2
Distribution: unstable
Urgency: low
Maintainer: Laszlo Boszormenyi (GCS) <gcs@debian.org>
Changed-By: Laszlo Boszormenyi (GCS) <gcs@debian.org>
Description:
 patchutils - Utilities to work with patches
Closes: 794592 841783
Changes:
 patchutils (0.3.4-2) unstable; urgency=low
 .
   * Add gawk to Build-Depends.
   * Update Standards-Version to 3.9.8 .
 .
   [ Reiner Herrmann <reiner@reiner-h.de> ]
   * Make the build reproducible (closes: #841783).
   * Add patch for don't pass error message directly as format string to
     error().
 .
   [ Niels Thykier <niels@thykier.net> ]
   * Use dh_auto_configure instead of direct call of configure.
   * Drop the "cross-build" guard around the test.
 .
   [ Helmut Grohne <helmut@subdivi.de> ]
   * Drop rpm from Build-Depends as gendiff tests work without gendiff now
     (closes: #794592).
Checksums-Sha1:
 5ad3e2474ff3a4b5f9b10779d966f6263f88a289 1876 patchutils_0.3.4-2.dsc
 4a3abadb1847d9c7064703debc210bd6ee0ba6f1 6540 patchutils_0.3.4-2.debian.tar.xz
 8d9aff367aec86681974e9b86faba0594041779f 125068 patchutils-dbgsym_0.3.4-2_amd64.deb
 0ab32cb8d6390bb2039370e272e8f546ac0f93f6 90436 patchutils_0.3.4-2_amd64.deb
Checksums-Sha256:
 985510e61acd180722dc614495df1e04619d28d9c4c4606614e9df6f6aae7fe8 1876 patchutils_0.3.4-2.dsc
 6e00ab9afae706816657e62c89a405f2ae4110cbe8fac8a2db134a904abd00cc 6540 patchutils_0.3.4-2.debian.tar.xz
 1c5d88b6716ebd2cc380250f86de5d26f75e795e8b545a289a50587573b8b04f 125068 patchutils-dbgsym_0.3.4-2_amd64.deb
 245ca64d31ec65a330ce28f77c0428c82b2cadb78c14434abe984a44f5fa3526 90436 patchutils_0.3.4-2_amd64.deb
Files:
 fd0be19689db0a5adca22ce318f65ff2 1876 text optional patchutils_0.3.4-2.dsc
 8a4a485696b5ff711c842ebf8a16eaf6 6540 text optional patchutils_0.3.4-2.debian.tar.xz
 e047fb85c290ea588718850a291e616a 125068 debug extra patchutils-dbgsym_0.3.4-2_amd64.deb
 082053897187417f4893f1a2c82c7e72 90436 text optional patchutils_0.3.4-2_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJYDSFeAAoJENzjEOeGTMi/6UQP/17ZTZOv17GBfLPxrKLJj03k
w2FgIqn6rA07Of447e/1RDkOA9iWhDKkqBQ+zi+MzTZogfvpqnkEvicsu51kfFy/
qC0d/mUapsXsEo5ioYRxNXvOLpvwX4E5eTfykz0qAf3d5cKQEirUZngIiHe6mjvm
8hRMlFqXtbmLYUcnY7VT+iU2+nAeBzBMjDS+KVBsyZME8fKy2C5GmLXUrTD4xYih
8zk7+jD9zVyNM7TcOsuGffrlb+7/Gcv1AVMKj8YGHrQWAXqA+FB3l5EwKd82Dt9J
QSv6zm7z3hFBlSzEBrv9Q2e8srz8BhWe6itHuEMO+6PkuAts51iH9GY1mddjn+Jt
ZmjIaZmnERvTO9FjWSiKa0dvEWm+pxhR0VMmCdltS3/1EG4VzcAs5kLKFhnL09z8
u55WVNqMwUSuJx3WhhleyirOhmY8aXrhOBlBfixFQMc3M0JgPyfLOxBZn5VE+1SK
PsIHpER0wLDw2zjljnxnty50ZyfA078JKmuKXvcPte+BsR/SKriA8uTTwvIogyTv
066pbThm7h4OaWSYpq8mbbZAMB6BHXZ9EqzlYa047C8HV5k5vqBlfEWNWN5Y6m0p
29u1B0Eks/LHe1bihX8+TcrGQVRwytPDWxbHujEq/rb1kY755LNCvYV2mbFYMHUy
LwpnTgiWgpFvgA+YiEOp
=k3o2
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.