Debian Bug report logs - #841319
notmuch: testsuite fails with TERM=unknown

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Gianfranco Costamagna <locutusofborg@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: notmuch: testsuite fails with TERM=unknown

Date: Wed, 19 Oct 2016 15:19:34 +0000 (UTC)

source: notmuch
version: 0.23-2
severity: normal
tags: patch

Hi dear maintainer, seems that the testsuite fails when TERM=unknown.


I propose you to apply this patch

override_dh_auto_test:
ifeq ($(DEB_HOST_ARCH),armhf)
 TERM=vt100 dh_auto_test || true
else
 TERM=vt100 dh_auto_test
endif

or
override_dh_auto_test:
 TERM=vt100 dh_auto_test
endif

in case you don't care about the Ubuntu armhf issue (but you will probably
have it in Debian too when gdb will be updated)

thanks for caring!

Gianfranco

Message #10 received at 841319@bugs.debian.org (full text, mbox, reply):

From: David Bremner <david@tethera.net>

To: Gianfranco Costamagna <locutusofborg@debian.org>, 841319@bugs.debian.org, notmuch@notmuchmail.org

Subject: Re: Bug#841319: notmuch: testsuite fails with TERM=unknown

Date: Wed, 19 Oct 2016 14:02:47 -0300

Gianfranco Costamagna <locutusofborg@debian.org> writes:

> source: notmuch
> version: 0.23-2
> severity: normal
> tags: patch
>
> Hi dear maintainer, seems that the testsuite fails when TERM=unknown.
>

more precisely,

Use "make V=1" to print test headings and PASSing results.
INFO: using 2 minute timeout for tests
FATAL: ./T160-json.sh: interrupted by signal 15

Looks like one of the invokations of emacs hangs when TERM=unknown

> I propose you to apply this patch
>
> override_dh_auto_test:
> ifeq ($(DEB_HOST_ARCH),armhf)
>  TERM=vt100 dh_auto_test || true
> else
>  TERM=vt100 dh_auto_test
> endif
> or
> override_dh_auto_test:
>  TERM=vt100 dh_auto_test
> endif

Hopefully we can fix this upstream; it's not a Debian specific issue.

> in case you don't care about the Ubuntu armhf issue (but you will probably
> have it in Debian too when gdb will be updated)

It looks like a snapshot version of gdb in yakkety, so I'm reluctant to
invest much effort into it. In particular 7.12 is already released upstream.

A nicer way to skip only those tests that are broken with that
particular version of gdb is is drop the build depends on gdb for armhf.
We already do this in debian for a variety of architectures.

In the not-implausible case that gdb 7.12 also causes problems for the
test suite on armhf, I'll disable those tests there (unless they are
fixable, of course).

Message #19 received at 841319@bugs.debian.org (full text, mbox, reply):

From: Gianfranco Costamagna <locutusofborg@debian.org>

To: David Bremner <david@tethera.net>, "841319@bugs.debian.org" <841319@bugs.debian.org>, "notmuch@notmuchmail.org" <notmuch@notmuchmail.org>, Steve Langasek <steve.langasek@canonical.com>

Subject: Re: Bug#841319: notmuch: testsuite fails with TERM=unknown

Date: Wed, 19 Oct 2016 18:36:17 +0000 (UTC)

Hi David

>Use "make V=1" to print test headings and PASSing results.
>INFO: using 2 minute timeout for tests
>FATAL: ./T160-json.sh: interrupted by signal 15
>
>Looks like one of the invokations of emacs hangs when TERM=unknown


yes, the same in Ubuntu

>Hopefully we can fix this upstream; it's not a Debian specific issue.


thanks for confirming this, "much" appreciated :)

>It looks like a snapshot version of gdb in yakkety, so I'm reluctant to
>invest much effort into it. In particular 7.12 is already released upstream.

>

now Ubuntu has gdb 7.12, I asked Steve to re-enable armhf testsuite, to
see how it goes

https://launchpad.net/ubuntu/+source/gdb/7.12-0ubuntu1

>A nicer way to skip only those tests that are broken with that>particular version of gdb is is drop the build depends on gdb for armhf.
>We already do this in debian for a variety of architectures.


this makes really easier to keep the patch minimal, thanks!

>In the not-implausible case that gdb 7.12 also causes problems for the
>test suite on armhf, I'll disable those tests there (unless they are

>fixable, of course).

thanks in advance for the great help!

Gianfranco

Message #22 received at 841319@bugs.debian.org (full text, mbox, reply):

From: Tomi Ollila <tomi.ollila@iki.fi>

To: notmuch@notmuchmail.org

Cc: tomi.ollila@iki.fi

Subject: [PATCH 1/2] test-lib.sh: rename $DTACH_TERM to $SMART_TERM

Date: Thu, 20 Oct 2016 11:19:44 +0300

---
 test/test-lib.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/test-lib.sh b/test/test-lib.sh
index bda8a80..77879c2 100644
--- a/test/test-lib.sh
+++ b/test/test-lib.sh
@@ -57,7 +57,7 @@ ORIGINAL_TERM=$TERM
 
 # dtach(1) provides more capable terminal environment to anything
 # that requires more than dumb terminal...
-[ x"${TERM:-dumb}" = xdumb ] && DTACH_TERM=vt100 || DTACH_TERM=$TERM
+[ x"${TERM:-dumb}" = xdumb ] && SMART_TERM=vt100 || SMART_TERM=$TERM
 
 # For repeatability, reset the environment to known value.
 LANG=C
@@ -1171,7 +1171,7 @@ test_emacs () {
 		# user's TERM (or 'vt100' in case user's TERM is unset, empty
 		# or 'dumb') is given to dtach which assumes a minimally
 		# VT100-compatible terminal -- and emacs inherits that
-		TERM=$DTACH_TERM dtach -n "$TEST_TMPDIR/emacs-dtach-socket.$$" \
+		TERM=$SMART_TERM dtach -n "$TEST_TMPDIR/emacs-dtach-socket.$$" \
 			sh -c "stty rows 24 cols 80; exec '$TMP_DIRECTORY/run_emacs' \
 				--no-window-system \
 				$load_emacs_tests \
-- 
2.10.0

_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Message #25 received at 841319@bugs.debian.org (full text, mbox, reply):

From: Tomi Ollila <tomi.ollila@iki.fi>

To: notmuch@notmuchmail.org

Cc: tomi.ollila@iki.fi

Subject: [PATCH 2/2] test: use vt100 as "smart" terminal for known dumb/unknown terminals

Date: Thu, 20 Oct 2016 11:19:45 +0300

Otherwise use whatever user environment has set for TERM so
that there is more chance to test on users' actual environments.
---
 test/test-lib.sh | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/test/test-lib.sh b/test/test-lib.sh
index 77879c2..e7b8339 100644
--- a/test/test-lib.sh
+++ b/test/test-lib.sh
@@ -55,9 +55,15 @@ export PS4='+(${BASH_SOURCE}:${LINENO}): ${FUNCNAME[0]:+${FUNCNAME[0]}(): }'
 # Keep the original TERM for say_color and test_emacs
 ORIGINAL_TERM=$TERM
 
-# dtach(1) provides more capable terminal environment to anything
-# that requires more than dumb terminal...
-[ x"${TERM:-dumb}" = xdumb ] && SMART_TERM=vt100 || SMART_TERM=$TERM
+# Set SMART_TERM to vt100 for known dumb/unknown terminal.
+# Otherwise use whatever TERM is currently used so that
+# users' actual TERM environments are being used in tests.
+case ${TERM-} in
+	'' | dumb | unknown )
+		SMART_TERM=vt100 ;;
+	*)
+		SMART_TERM=$TERM ;;
+esac
 
 # For repeatability, reset the environment to known value.
 LANG=C
@@ -1168,8 +1174,8 @@ test_emacs () {
 		fi
 		server_name="notmuch-test-suite-$$"
 		# start a detached session with an emacs server
-		# user's TERM (or 'vt100' in case user's TERM is unset, empty
-		# or 'dumb') is given to dtach which assumes a minimally
+		# user's TERM (or 'vt100' in case user's TERM is known dumb
+		# or unknown) is given to dtach which assumes a minimally
 		# VT100-compatible terminal -- and emacs inherits that
 		TERM=$SMART_TERM dtach -n "$TEST_TMPDIR/emacs-dtach-socket.$$" \
 			sh -c "stty rows 24 cols 80; exec '$TMP_DIRECTORY/run_emacs' \
-- 
2.10.0

_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Message #30 received at 841319@bugs.debian.org (full text, mbox, reply):

From: Gianfranco Costamagna <locutusofborg@debian.org>

To: David Bremner <david@tethera.net>, "841319@bugs.debian.org" <841319@bugs.debian.org>, "notmuch@notmuchmail.org" <notmuch@notmuchmail.org>, Steve Langasek <steve.langasek@canonical.com>

Subject: Re: Bug#841319: notmuch: testsuite fails with TERM=unknown

Date: Thu, 20 Oct 2016 17:14:01 +0000 (UTC)

Hi David!


>It looks like a snapshot version of gdb in yakkety, so I'm reluctant to

>invest much effort into it. In particular 7.12 is already released upstream.
>
>A nicer way to skip only those tests that are broken with that
>particular version of gdb is is drop the build depends on gdb for armhf.
>We already do this in debian for a variety of architectures.
>
>In the not-implausible case that gdb 7.12 also causes problems for the
>test suite on armhf, I'll disable those tests there (unless they are
>fixable, of course).
https://launchpad.net/ubuntu/+source/notmuch/0.23-2ubuntu1/+build/11044876

still failing with 7.12

thanks!

Gianfranco

Message #37 received at 841319-close@bugs.debian.org (full text, mbox, reply):

From: David Bremner <bremner@debian.org>

To: 841319-close@bugs.debian.org

Subject: Bug#841319: fixed in notmuch 0.23.1-1

Date: Mon, 24 Oct 2016 05:28:04 +0000

Source: notmuch
Source-Version: 0.23.1-1

We believe that the bug you reported is fixed in the latest version of
notmuch, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 841319@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
David Bremner <bremner@debian.org> (supplier of updated notmuch package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 23 Oct 2016 22:06:12 -0300
Source: notmuch
Binary: notmuch libnotmuch4 libnotmuch-dev python-notmuch python3-notmuch ruby-notmuch notmuch-emacs notmuch-vim notmuch-mutt notmuch-dbg
Architecture: source
Version: 0.23.1-1
Distribution: unstable
Urgency: medium
Maintainer: Carl Worth <cworth@debian.org>
Changed-By: David Bremner <bremner@debian.org>
Description:
 libnotmuch-dev - thread-based email index, search and tagging (development)
 libnotmuch4 - thread-based email index, search and tagging (runtime)
 notmuch    - thread-based email index, search and tagging
 notmuch-dbg - thread-based email index, search and tagging - debugging symbols
 notmuch-emacs - thread-based email index, search and tagging (emacs interface)
 notmuch-mutt - thread-based email index, search and tagging (Mutt interface)
 notmuch-vim - thread-based email index, search and tagging (vim interface)
 python-notmuch - python interface to the notmuch mail search and index library
 python3-notmuch - Python 3 interface to the notmuch mail search and index library
 ruby-notmuch - Ruby interface to the notmuch mail search and index library
Closes: 841319
Changes:
 notmuch (0.23.1-1) unstable; urgency=medium
 .
   * New upstream bugfix release
   * Fix test suite for Emacs 25.1
   * Fix some Emacs customization regressions introduced in 0.23
   * Bug fix: "testsuite fails with TERM=unknown", thanks to Gianfranco
     Costamagna (Closes: #841319).
Checksums-Sha1:
 06f7df5dbaa1655a29131975927db646f4feea38 2790 notmuch_0.23.1-1.dsc
 556cd9dc0236256e19fa31cbfef79e25157cd69f 690069 notmuch_0.23.1.orig.tar.gz
 1e1a0dd00c89912aab052926645445effc4f5299 15724 notmuch_0.23.1-1.debian.tar.xz
Checksums-Sha256:
 bb6387f8ec8eb2046064e0e5fd2409c6201a6db39b51e20ad19844f39e08fd88 2790 notmuch_0.23.1-1.dsc
 e8012a1aa9afa47dfeb78f826610577e6bf9714e0933f28139c8611aad96d180 690069 notmuch_0.23.1.orig.tar.gz
 1154531409f427be6e56cdf820b21bd46667e26549b5053805ae796cffba61c3 15724 notmuch_0.23.1-1.debian.tar.xz
Files:
 020e51f45c6ee967b78934455be3a4ed 2790 mail optional notmuch_0.23.1-1.dsc
 9517874242ea929c11f754b493bc8186 690069 mail optional notmuch_0.23.1.orig.tar.gz
 3b26e098f4683cdc45ac3548f0fa1c64 15724 mail optional notmuch_0.23.1-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQGcBAEBCAAGBQJYDWKBAAoJEPIClx2kp54sgSsL/RPnk8XrNhvoXqBFdwg0ZNTV
2M77DVKWeR68jy3slvMhNn+7/ZRvEvJTxJ5nX16TcXeGA4Y0fio321Ts/fukd6tj
7kQNAKyx8tVkwT6+8UHG0oaF1j90gFp8rZ4A2iCRamoK3dJafKx+Bx2emXOqbTlg
DYG7As79w7RN+89BmsNlAu7Ap1H4miIOoFulglrvPD7pE4FtYp76x1xWORDmZIYH
pQaYeaUAyFLMipm8fLNpweieVWL3BFere9TLrTYsz8632C4mpxH3sPbeCTS2L4E4
RyD6onb0/UFOKs9gB9VrJGrE3q5XbZB9NrW9A/5ECCv4RC/yJ7J4SKfxXW9Xn46k
YTjPGh1FCb1uRL7fKP+iW5efOM7nz1jaAv+9M0vcIPEW5wmE9Ms9j8fiPzYKgAuU
95doGMucw2nMXJFtYXn9gUGszHObIajrgKCgpeO4713ch5swzDJT4ZQm827ptg2X
dC/W6wv67r+QNhKAC53c4xAEoADJuOfSGEuuGbuH8Q==
=jl/O
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.