Debian Bug report logs - #840230
When installing to rootfs on LVM, an empty subvol= is appended to rootflags

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Philipp Kern <pkern@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: When installing to rootfs on LVM, an empty subvol= is appended to rootflags

Date: Sun, 09 Oct 2016 20:34:27 +0200

Package: zipl-installer
Version: 0.0.33
Severity: serious

zipl-installer 0.0.33 breaks installation for normal non-btrfs root
filesystems.

  (initramfs) cat /proc/cmdline
  root=/dev/mapper/vg-root rootflags=subvol= BOOT_IMAGE=0 

The empty subvol= makes mount barf as it's not a valid ext4 flag. The code
does not seem too healthy to me either:

  if subvol="$(btrfs subvolume show /target 2>/dev/null | sed -n '2s/.*:[\t ]*//p')"
  then
      info "Root filesystem on btrfs subvolume ${subvol}"
      PARAMETER="$PARAMETER rootflags=subvol=${subvol}"
  fi

It'd have been more helpful to take the output and compare it to the empty
string instead.

Message #10 received at 840230@bugs.debian.org (full text, mbox, reply):

From: Dimitri John Ledkov <xnox@ubuntu.com>

To: Philipp Kern <pkern@debian.org>, 840230@bugs.debian.org

Subject: Re: Bug#840230: When installing to rootfs on LVM, an empty subvol= is appended to rootflags

Date: Sun, 9 Oct 2016 19:47:12 +0100

[Message part 1 (text/plain, inline)]

I think I did fix this before....

http://launchpadlibrarian.net/251885735/zipl-installer_0.0.33ubuntu1_0.0.33ubuntu2.diff.gz

I guess it did not make over to debian. Will fix soon.

Regards,

Dimitri.


On 9 October 2016 at 19:34, Philipp Kern <pkern@debian.org> wrote:

> Package: zipl-installer
> Version: 0.0.33
> Severity: serious
>
> zipl-installer 0.0.33 breaks installation for normal non-btrfs root
> filesystems.
>
>   (initramfs) cat /proc/cmdline
>   root=/dev/mapper/vg-root rootflags=subvol= BOOT_IMAGE=0
>
> The empty subvol= makes mount barf as it's not a valid ext4 flag. The code
> does not seem too healthy to me either:
>
>   if subvol="$(btrfs subvolume show /target 2>/dev/null | sed -n
> '2s/.*:[\t ]*//p')"
>   then
>       info "Root filesystem on btrfs subvolume ${subvol}"
>       PARAMETER="$PARAMETER rootflags=subvol=${subvol}"
>   fi
>
> It'd have been more helpful to take the output and compare it to the empty
> string instead.
>



-- 
Regards,

Dimitri.

[Message part 2 (text/html, inline)]

Message #15 received at 840230-close@bugs.debian.org (full text, mbox, reply):

From: Philipp Kern <pkern@debian.org>

To: 840230-close@bugs.debian.org

Subject: Bug#840230: fixed in zipl-installer 0.0.35

Date: Sun, 23 Oct 2016 23:49:06 +0000

Source: zipl-installer
Source-Version: 0.0.35

We believe that the bug you reported is fixed in the latest version of
zipl-installer, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 840230@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Philipp Kern <pkern@debian.org> (supplier of updated zipl-installer package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 23 Oct 2016 23:25:37 +0200
Source: zipl-installer
Binary: zipl-installer
Architecture: source s390x
Version: 0.0.35
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Philipp Kern <pkern@debian.org>
Description:
 zipl-installer - Make DASD bootable (udeb)
Closes: 840230
Changes:
 zipl-installer (0.0.35) unstable; urgency=medium
 .
   * Copy Ubuntu's fix-up for the btrfs subvolume check from 0.0.33ubuntu2.
     (Closes: #840230)
Checksums-Sha1:
 be89448c61727659a11a95995425dee9b34f404f 1353 zipl-installer_0.0.35.dsc
 77317ffefb821e20cd1a8e4508afb63d3fced7dc 22540 zipl-installer_0.0.35.tar.xz
 e9a47eddcb43626ffcf3c081ef2c2f2f42576b72 4916 zipl-installer_0.0.35_s390x.udeb
Checksums-Sha256:
 ad52e17d7d4ea2e91522dd81acf0fd4137e821aaa22c2d046604921e9276a8be 1353 zipl-installer_0.0.35.dsc
 6fd0d45bf975b3c48d082311b1c41e0c526f4839b249fac44476492540e1d5c7 22540 zipl-installer_0.0.35.tar.xz
 df46026f84f7defb62c7f7fc8304b281296b2a62c11c34746a9644867fde08d8 4916 zipl-installer_0.0.35_s390x.udeb
Files:
 2664aaa0cb419b3c2f03be456d4dbc0f 1353 debian-installer standard zipl-installer_0.0.35.dsc
 5fbf03ccddd733e608c16c14a0da0084 22540 debian-installer standard zipl-installer_0.0.35.tar.xz
 20b236791456cff8cdddd2035fe20d78 4916 debian-installer standard zipl-installer_0.0.35_s390x.udeb

-----BEGIN PGP SIGNATURE-----

iQEuBAEBCAAYBQJYDSssERxwa2VybkBkZWJpYW4ub3JnAAoJEERuJUU10FbseQMI
ALPjYQyhtqUZA1hTwV1Y6GnjI2M3BTg/9Jku9AsbwqeTG58kdRl+tW+aGUHaTSg8
wghnwaBGgRRwJ6TdrT/lFPslNtWHt+/+Ttm+QUSG4BWDQNpZFbTVPPQFk2KSMxiC
K5mN9U6Oyv22Vuy2Pi826jN92XhJpEvWPXhAyzhTFG1G/Gh6iPM+vLsN+7ZhYxel
WVPKRX9UGP4fYEQGlaSF8wNBdgMPPXCmhgHdFzgCTD8vlvWsjjA4EeOH7dTnXP6R
hiTd+jMY7+O6YBnqWC/WZ0KSgNwjGW99iZAAdqtidwKZOwLugfedpiOVydQTGUyI
JC6d6lqI2aF1WmWb35Dljvs=
=1Igk
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.