Debian Bug report logs - #839218
nama: FTBFS because of perl's lack of stack reference counting

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: submit@bugs.debian.org

Subject: nama: FTBFS: Failed 1/7 test programs. 0/91 subtests failed.Bad plan. You planned 126 tests but ran 57.

Date: Fri, 30 Sep 2016 10:09:01 +0100

[Message part 1 (text/plain, inline)]

Source: nama
Version: 1.208-1
Severity: serious
Justification: fails to build from source
User: reproducible-builds@lists.alioth.debian.org
Usertags: ftbfs
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Dear Maintainer,

nama fails to build from source in unstable/amd64:

  [..]

  Setting up libterm-termkey-perl (0.16-3+b1) ...
  Setting up libtext-diff-perl (1.44-1) ...
  Setting up libjson-xs-perl (3.020-1+b1) ...
  Setting up libtest-pod-coverage-perl (1.10-2) ...
  Setting up libanyevent-termkey-perl (0.02-2) ...
  Setting up libmodule-implementation-perl (0.09-1) ...
  Setting up libb-hooks-endofscope-perl (0.21-1) ...
  Setting up libpackage-stash-perl (0.37-1) ...
  Setting up libnamespace-clean-perl (0.27-1) ...
  Setting up libgit-repository-perl (1.320-1) ...
  Setting up nama-build-deps (1.208-1) ...
  
  **************************************************************************************
  ** Environment                                                                      **
  **************************************************************************************
  
  PATH=/home/lamby/git/projects/dotfiles/dotfiles/..//bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
  HOSTNAME=f419542bf8bd
  TERM=xterm
  PAGER=more
  DISPLAY=:0
  DOCKER_IMAGE=lamby-debian-sid
  DEB_BUILD_OPTIONS=parallel=9
  PIP_DOWNLOAD_CACHE=/home/lamby/.cache/pip
  HOME=/home/lamby
  LOGNAME=lamby
  SHLVL=1
  PWD=/home/lamby/temp/cdt.20160930095107.55GhkE5sL3.db.nama/nama-1.208
  OLDPWD=/home/lamby/temp/cdt.20160930095107.55GhkE5sL3.db.nama
  GPG_TTY=/dev/console
  QUILT_PATCHES=debian/patches
  QUILT_NO_DIFF_INDEX=1
  QUILT_REFRESH_ARGS=-p ab --no-timestamps --no-index
  DEBEMAIL=lamby@debian.org
  DEBFULLNAME=Chris Lamb
  EDITOR=vim
  LESS=-cgiFx4M
  GPG_KEY=1E953E27D4311E58
  BLASTER=A220 I5 D1 H5 P330 T6
  _=/usr/bin/env
  
  **************************************************************************************
  ** Building nama 1.208-1 on amd64                                                   **
  **************************************************************************************
  
   dpkg-buildpackage -rfakeroot -D -us -uc -b
  dpkg-buildpackage: info: source package nama
  dpkg-buildpackage: info: source version 1.208-1
  dpkg-buildpackage: info: source distribution unstable
  dpkg-buildpackage: info: source changed by Lucas Kanashiro <kanashiro.duarte@gmail.com>
   dpkg-source --before-build nama-1.208
  dpkg-buildpackage: info: host architecture amd64
   fakeroot debian/rules clean
  dh clean
     dh_testdir
     dh_auto_clean
     dh_clean
   debian/rules build
  dh build
     dh_testdir
     dh_update_autotools_config
     dh_auto_configure
  	perl -I. Makefile.PL INSTALLDIRS=vendor "OPTIMIZE=-g -O2 -fdebug-prefix-map=/home/lamby/temp/cdt.20160930095107.55GhkE5sL3.db.nama/nama-1.208=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2" "LD=x86_64-linux-gnu-gcc -g -O2 -fdebug-prefix-map=/home/lamby/temp/cdt.20160930095107.55GhkE5sL3.db.nama/nama-1.208=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro"
  Checking if your kit is complete...
  Warning: the following files are missing in your kit:
  	t/03_wav.t
  Please inform the author.
  Generating a Unix-style Makefile
  Writing Makefile for Audio::Nama
  Writing MYMETA.yml and MYMETA.json
     dh_auto_build
  	make -j1
  make[1]: Entering directory '/home/lamby/temp/cdt.20160930095107.55GhkE5sL3.db.nama/nama-1.208'
  cp lib/Audio/Nama/Edit.pm blib/lib/Audio/Nama/Edit.pm
  cp lib/Audio/Nama/Graphical.pm blib/lib/Audio/Nama/Graphical.pm
  cp lib/Audio/Nama/Sequence.pm blib/lib/Audio/Nama/Sequence.pm
  cp lib/Audio/Nama/Memoize.pm blib/lib/Audio/Nama/Memoize.pm
  cp lib/Audio/Nama/Bunch.pm blib/lib/Audio/Nama/Bunch.pm
  cp lib/Audio/Nama/Initializations.pm blib/lib/Audio/Nama/Initializations.pm
  cp lib/Audio/Nama/Options.pm blib/lib/Audio/Nama/Options.pm
  cp lib/Audio/Nama/Graph.pm blib/lib/Audio/Nama/Graph.pm
  cp lib/Audio/Nama/Assign.pm blib/lib/Audio/Nama/Assign.pm
  cp lib/Audio/Nama/Log.pm blib/lib/Audio/Nama/Log.pm
  cp lib/Audio/Nama/Lat.pm blib/lib/Audio/Nama/Lat.pm
  cp lib/Audio/Nama/Bus.pm blib/lib/Audio/Nama/Bus.pm
  cp lib/Audio/Nama/Modes.pm blib/lib/Audio/Nama/Modes.pm
  cp lib/Audio/Nama/Mark.pm blib/lib/Audio/Nama/Mark.pm
  cp lib/Audio/Nama/Globals.pm blib/lib/Audio/Nama/Globals.pm
  cp lib/Audio/Nama/Config.pm blib/lib/Audio/Nama/Config.pm
  cp lib/Audio/Nama/Grammar.pm blib/lib/Audio/Nama/Grammar.pm
  cp lib/Audio/Nama/EngineRun.pm blib/lib/Audio/Nama/EngineRun.pm
  cp lib/Audio/Nama/AnalyseLV2.pm blib/lib/Audio/Nama/AnalyseLV2.pm
  cp lib/Audio/Nama/Git.pm blib/lib/Audio/Nama/Git.pm
  cp lib/Audio/Nama/Fade.pm blib/lib/Audio/Nama/Fade.pm
  cp lib/Audio/Nama/Custom.pm blib/lib/Audio/Nama/Custom.pm
  cp lib/Audio/Nama/Effect.pm blib/lib/Audio/Nama/Effect.pm
  cp lib/Audio/Nama/Midi.pm blib/lib/Audio/Nama/Midi.pm
  cp lib/Audio/Nama/EngineSetup.pm blib/lib/Audio/Nama/EngineSetup.pm
  cp lib/Audio/Nama/EngineCleanup.pm blib/lib/Audio/Nama/EngineCleanup.pm
  cp lib/Audio/Nama/Insert.pm blib/lib/Audio/Nama/Insert.pm
  cp lib/Audio/Nama/ChainSetup.pm blib/lib/Audio/Nama/ChainSetup.pm
  cp lib/Audio/Nama/Persistence.pm blib/lib/Audio/Nama/Persistence.pm
  cp lib/Audio/Nama/EffectsRegistry.pm blib/lib/Audio/Nama/EffectsRegistry.pm
  cp lib/Audio/Nama/Plug.pm blib/lib/Audio/Nama/Plug.pm
  cp lib/Audio/Nama/IO.pm blib/lib/Audio/Nama/IO.pm
  cp lib/Audio/Nama/Help.pm blib/lib/Audio/Nama/Help.pm
  cp lib/Audio/Nama.pm blib/lib/Audio/Nama.pm
  cp lib/Audio/Nama/RegionComp.pm blib/lib/Audio/Nama/RegionComp.pm
  cp lib/Audio/Nama/Object.pm blib/lib/Audio/Nama/Object.pm
  cp lib/Audio/Nama/CacheTrack.pm blib/lib/Audio/Nama/CacheTrack.pm
  cp lib/Audio/Nama/Latency.pm blib/lib/Audio/Nama/Latency.pm
  cp lib/Audio/Nama/Mix.pm blib/lib/Audio/Nama/Mix.pm
  cp lib/Audio/Nama/Jack.pm blib/lib/Audio/Nama/Jack.pm
  cp lib/Audio/Nama/Regions.pm blib/lib/Audio/Nama/Regions.pm
  cp lib/Audio/Nama/MuteSoloFade.pm blib/lib/Audio/Nama/MuteSoloFade.pm
  cp lib/Audio/Nama/Engine.pm blib/lib/Audio/Nama/Engine.pm
  cp lib/Audio/Nama/Project.pm blib/lib/Audio/Nama/Project.pm
  cp lib/Audio/Nama/EffectChain.pm blib/lib/Audio/Nama/EffectChain.pm
  cp lib/Audio/Nama/Terminal.pm blib/lib/Audio/Nama/Terminal.pm
  cp lib/Audio/Nama/Wavinfo.pm blib/lib/Audio/Nama/Wavinfo.pm
  cp lib/Audio/Nama/Util.pm blib/lib/Audio/Nama/Util.pm
  cp lib/Audio/Nama/Wav.pm blib/lib/Audio/Nama/Wav.pm
  cp lib/Audio/Nama/Text.pm blib/lib/Audio/Nama/Text.pm
  cp lib/Audio/Nama/Track.pm blib/lib/Audio/Nama/Track.pm
  cp script/nama blib/script/nama
  "/usr/bin/perl" "-Iinc" -MExtUtils::MY -e 'MY->fixin(shift)' -- blib/script/nama
  Manifying 1 pod document
  Manifying 3 pod documents
  make[1]: Leaving directory '/home/lamby/temp/cdt.20160930095107.55GhkE5sL3.db.nama/nama-1.208'
     dh_auto_test
  	make -j1 test TEST_VERBOSE=1
  make[1]: Entering directory '/home/lamby/temp/cdt.20160930095107.55GhkE5sL3.db.nama/nama-1.208'
  PERL_DL_NONLAZY=1 PERL_USE_UNSAFE_INC=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(1, 'inc', 'blib/lib', 'blib/arch')" t/*.t
  t/01_symbols.t .. 
  1..3
  ok 1 - use Audio::Nama::Globals;
  ok 2 - global variable import
  ok 3 - global variable-all-tag import
  ok
  t/02_assign.t ... 
  1..18
  ok 1 - use Audio::Nama::Assign;
  ok 2 - Scalar number assignment
  ok 3 - Scalar string assignment
  ok 4 - Array assignment
  ok 5 - Hash assignment
  ok 6 - Serialization round trip
  ok 7 - Scalar number assignment
  ok 8 - Scalar string assignment
  ok 9 - Array assignment
  ok 10 - Hash assignment
  ok 11 - Serialization round trip
  ok 12 - Scalar number assignment
  ok 13 - Scalar string assignment
  ok 14 - Array assignment
  ok 15 - Hash assignment
  ok 16 - Serialization round trip
  ok 17 - Null array assignment
  ok 18 - Null hash assignment
  ok
  t/04_object.t ... 
  1..4
  ok 1 - use Audio::Nama::Object;
  ok 2 - instantiation
  ok 3 - accessor
  ok 4 - mutator
  ok
  t/06_latency.t .. 
  1..6
  ok 1 - Latency object instantiation
  ok 2 - Stringify object
  ok 3 - Min latency accessor
  ok 4 - Latency addition
  ok 5 - Latency addition, overloading '+' operator
  ok 6 - Exception on Max greater than Min
  ok
  t/11_mark.t ..... 
  1..2
  ok 1 - use Audio::Nama::Mark;
  ok 2 - Object creation
  ok
  t/12_nama.t ..... 
  1..126
  reading config file /dev/null
  Starting dummy engine only
  project_root /tmp/nama-test specified on command line
  ok 1 - Read mix_to_disk_format
  ok 2 - 1 => soundcard
  ok 3 - Fluidsynth => jack_client
  ok 4 - MPlayer [20120]:out_0 => jack_client
  ok 5 - drumkit.ports => jack_ports_list
  ok 6 - manual => jack_manual
  ok 7 - jack => jack_manual
  ok 8 - bus => bus
  ok 9 - null => null
  ok 10 - loop,16 => loop
  ok 11 - loop,Master => loop
  : file not found
  ok 12 - establish project directory
  ok 13 - Bus initializtion
  ok 14 - from_null ecs_string
  ok 15 - to_null ecs_string
  ok 16 - to_wav ecs_string
  ok 17 - from_wav ecs_string
  ok 18 - from_loop ecs_string
  ok 19 - to_loop ecs_string
  ok 20 - to_alsa_soundcard_device ecs_string
  ok 21 - from_alsa_soundcard_device ecs_string
  ok 22 - from_soundcard ecs_string
  ok 23 - to_soundcard ecs_string
  ok 24 - to_jack_port ecs_string
  ok 25 - from_jack_port ecs_string
  ok 26 - from_jack_client ecs_string
  ok 27 - to_jack_client ecs_string
  ok 28 - to_jack_multi ecs_string
  ok 29 - from_jack_multi ecs_string
  ok 30 - track creation
  ok 31 - current track assignment
  ok 32 - apply volume control
  Added E, time_reverb3
  ok 33 - apply preset
  ok 34 - positioned before vol/pan faders
  Added F, Decimator
  ok 35 - apply LADSPA effect
  ok 36 - position before faders, after other effects
  ok 37 - modify effect
  E - C - D - F
   No. Name       Requested  Status  Source                Destination   Vol   Pan
  ================================================================================
    3  sax                   MON     1                     Main           -2    50
  Signal width: mono
  E: time_reverb3, pn:time_reverb3, sax
  C: Pan, epp, sax
      1. Level %: 50
  D: Volume, eadb, sax
      1. Level db: -2
  F: Decimator, el:decimator, sax
      1. Bit depth: 1
      2. Sample rate (Hz): 2
  ok 38 - position effect at end, using ZZZ pseudo-id
  E - C - F - D
   No. Name       Requested  Status  Source                Destination   Vol   Pan
  ================================================================================
    3  sax                   MON     1                     Main           -2    50
  Signal width: mono
  E: time_reverb3, pn:time_reverb3, sax
  C: Pan, epp, sax
      1. Level %: 50
  F: Decimator, el:decimator, sax
      1. Bit depth: 1
      2. Sample rate (Hz): 2
  D: Volume, eadb, sax
      1. Level db: -2
  ok 39 - position effect before another effect
  removing effect F: Decimator, el:decimator, sax
  ok 40 - remove effect
  Track sax: source set to soundcard channel 2
  ok 41 - set soundcard input
  ok 42 - set input channel
  Track sax: soundcard channel 5 is now a send target
  ok 43 - set soundcard output
  ok 44 - set soundcard output
  ok 45 - IO base class object
  ok 46 - IO to_alsa_soundcard_device 1
  ok 47 - IO to_alsa_soundcard_device 2
  ok 48 - IO to_soundcard 1
  ok 49 - IO to_soundcard 2
  ok 50 - sound system ALSA/JACK detection: input
  ok 51 - IO from_soundcard: jack 1
  ok 52 - IO from_soundcard: jack 2
  ok 53 - sound system ALSA/JACK detection: output
  ok 54 - IO to_soundcard: jack 1
  ok 55 - IO to_soundcard: jack 2
  ok 56 - value overrides method call
  Track sax set to mono, but JACK source "Horgand" is stereo.
  Track sax: source set to JACK client Horgand
  ok 57 - set JACK client as input
  sax: JACK source port is sax_in. Make connections manually.
  
  Track sax: source set to JACK manual port sax_in
  Failed 69/126 subtests 
  t/13_io.t ....... 
  1..1
  ok 1 - use Audio::Nama::IO;
  ok
  
  Test Summary Report
  -------------------
  t/12_nama.t   (Wstat: 139 Tests: 57 Failed: 0)
    Non-zero wait status: 139
    Parse errors: Bad plan.  You planned 126 tests but ran 57.
  Files=7, Tests=91,  5 wallclock secs ( 0.03 usr  0.01 sys +  2.29 cusr  0.43 csys =  2.76 CPU)
  Result: FAIL
  Failed 1/7 test programs. 0/91 subtests failed.
  Makefile:930: recipe for target 'test_dynamic' failed
  make[1]: *** [test_dynamic] Error 255
  make[1]: Leaving directory '/home/lamby/temp/cdt.20160930095107.55GhkE5sL3.db.nama/nama-1.208'
  dh_auto_test: make -j1 test TEST_VERBOSE=1 returned exit code 2
  debian/rules:4: recipe for target 'build' failed
  make: *** [build] Error 2

  [..]

The full build log is attached.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[nama.1.208-1.unstable.amd64.log.txt.gz (application/octet-stream, attachment)]

Message #14 received at 839218@bugs.debian.org (full text, mbox, reply):

From: Balint Reczey <balint.reczey@canonical.com>

To: 839218@bugs.debian.org

Subject: Re: nama: FTBFS: Failed 1/7 test programs. 0/91 subtests failed.Bad plan. You planned 126 tests but ran 57.

Date: Tue, 21 Mar 2017 13:14:53 +0100

Control: reassign -1 perl 5.24.0~rc3-1
Control: affects -1 nama
Control: retitle -1 perl: Perl 24 makes nama FTBFS due to segfault

Dear Perl Maintainers,

On Fri, 30 Sep 2016 10:09:01 +0100 Chris Lamb <lamby@debian.org> wrote:
> Source: nama
> Version: 1.208-1
> Severity: serious
> Justification: fails to build from source
> User: reproducible-builds@lists.alioth.debian.org
> Usertags: ftbfs
> X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org
> 
> Dear Maintainer,
> 
> nama fails to build from source in unstable/amd64:
> 
>   [..]
> 
>   ok 57 - set JACK client as input
>   sax: JACK source port is sax_in. Make connections manually.
>   
>   Track sax: source set to JACK manual port sax_in
>   Failed 69/126 subtests 
>   t/13_io.t ....... 
>   1..1
>   ok 1 - use Audio::Nama::IO;
>   ok
>   
>   Test Summary Report
>   -------------------
>   t/12_nama.t   (Wstat: 139 Tests: 57 Failed: 0)
>     Non-zero wait status: 139
>     Parse errors: Bad plan.  You planned 126 tests but ran 57.
>   Files=7, Tests=91,  5 wallclock secs ( 0.03 usr  0.01 sys +  2.29 cusr  0.43 csys =  2.76 CPU)
>   Result: FAIL
>   Failed 1/7 test programs. 0/91 subtests failed.
>   Makefile:930: recipe for target 'test_dynamic' failed
>   make[1]: *** [test_dynamic] Error 255
>   make[1]: Leaving directory '/home/lamby/temp/cdt.20160930095107.55GhkE5sL3.db.nama/nama-1.208'
>   dh_auto_test: make -j1 test TEST_VERBOSE=1 returned exit code 2
>   debian/rules:4: recipe for target 'build' failed
>   make: *** [build] Error 2
> 
>   [..]


This looks like a problem in perl itself possibly causing random crashes
elsewhere, too.

Reproduction with the perl-debug package shows the internal assertion:

sudo apt-get install perl-debug
sudo apt-get build-dep nama
apt source nama
cd nama-*
dpkg-buildpackage
...
ok 57 - set JACK client as input
sax: JACK source port is sax_in. Make connections manually.

Track sax: source set to JACK manual port sax_in
Failed 69/126 subtests
t/13_io.t .......
1..1
ok 1 - use Audio::Nama::IO;
ok
..

PERL_DL_NONLAZY=1 PERL_USE_UNSAFE_INC=1 "/usr/bin/debugperl" \
"-MExtUtils::Command::MM" "-MTest::Harness" "-e" " test_harness(1, \
'inc', 'blib/lib', 'blib/arch')" t/12_nama.t

...

ok 57 - set JACK client as input
sax: JACK source port is sax_in. Make connections manually.
Track sax: source set to JACK manual port sax_in
debugperl: sv.c:6438: Perl_sv_clear: Assertion `SvTYPE(sv) !=
(svtype)SVTYPEMASK' failed.
Failed 69/126 subtests
...

Address Sanitizer shows the crash with non-debug perl:

LD_PRELOAD=libasan.so.3 PERL_DL_NONLAZY=1 PERL_USE_UNSAFE_INC=1 \
"/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "
test_harness(1, 'inc', 'blib/lib', 'blib/arch')" t/12_nama.t
...
sax: JACK source port is sax_in. Make connections manually.
Track sax: source set to JACK manual port sax_in
ASAN:DEADLYSIGNAL
=================================================================
==13877==ERROR: AddressSanitizer: SEGV on unknown address 0x00ff00000012
(pc 0x559191b15fd8 bp 0x62100013f578 sp 0x7fffaa838b00 T0)
    #0 0x559191b15fd7  (/usr/bin/perl+0xd9fd7)
    #1 0x559191b1616d in Perl_sv_unmagic (/usr/bin/perl+0xda16d)
    #2 0x559191b1513a in Perl_sv_clear (/usr/bin/perl+0xd913a)
    #3 0x559191b15a8f in Perl_sv_free2 (/usr/bin/perl+0xd9a8f)
    #4 0x559191b4624e in Perl_leave_scope (/usr/bin/perl+0x10a24e)
    #5 0x559191b49707  (/usr/bin/perl+0x10d707)
    #6 0x559191b4ebab in Perl_die_unwind (/usr/bin/perl+0x112bab)
    #7 0x559191aea518 in Perl_vcroak (/usr/bin/perl+0xae518)
    #8 0x559191aeafb3 in Perl_croak (/usr/bin/perl+0xaefb3)
    #9 0x559191b1d592 in Perl_sv_setsv_flags (/usr/bin/perl+0xe1592)
    #10 0x559191b08ca9 in Perl_pp_sassign (/usr/bin/perl+0xccca9)
    #11 0x559191b08605 in Perl_runops_standard (/usr/bin/perl+0xcc605)
    #12 0x559191a8e6c8 in perl_run (/usr/bin/perl+0x526c8)
    #13 0x559191a6787c in main (/usr/bin/perl+0x2b87c)
    #14 0x7fa31be502b0 in __libc_start_main
(/lib/x86_64-linux-gnu/libc.so.6+0x202b0)
    #15 0x559191a678b9 in _start (/usr/bin/perl+0x2b8b9)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV (/usr/bin/perl+0xd9fd7)
==13877==ABORTING
Dubious, test returned 1 (wstat 256, 0x100)
Failed 69/126 subtests

Cheers,
Balint

Message #29 received at 839218@bugs.debian.org (full text, mbox, reply):

From: gregor herrmann <gregoa@debian.org>

To: Balint Reczey <balint.reczey@canonical.com>, 839218@bugs.debian.org

Subject: Re: Bug#839218: nama: FTBFS: Failed 1/7 test programs. 0/91 subtests failed.Bad plan. You planned 126 tests but ran 57.

Date: Tue, 21 Mar 2017 13:31:32 +0100

Control: retitle -1 Perl 5.24 makes nama FTBFS due to segfault
# or "Perl 5, version 24, ..."

On Tue, 21 Mar 2017 13:14:53 +0100, Balint Reczey wrote:

> Control: reassign -1 perl 5.24.0~rc3-1
> Control: affects -1 nama
> Control: retitle -1 perl: Perl 24 makes nama FTBFS due to segfault

> This looks like a problem in perl itself possibly causing random crashes
> elsewhere, too.

I wonder why you picked 5.24.0~rc3-1 as the broken perl version,
since this version doesn't exist in debian anymore (and actually was
only in experimental, and for exactly one day in April 2016).

Does this problem also show up with 5.24.1-1 in testing and/or
5.24.1-2 in unstable?
 

Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at/ - Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   BOFH excuse #215:  High nuclear activity in your area. 

Message #36 received at 839218@bugs.debian.org (full text, mbox, reply):

From: gregor herrmann <gregoa@debian.org>

To: Balint Reczey <balint.reczey@canonical.com>, 839218@bugs.debian.org

Subject: Re: Bug#839218: nama: FTBFS: Failed 1/7 test programs. 0/91 subtests failed.Bad plan. You planned 126 tests but ran 57.

Date: Tue, 21 Mar 2017 13:36:49 +0100

On Tue, 21 Mar 2017 13:31:32 +0100, gregor herrmann wrote:

> > This looks like a problem in perl itself possibly causing random crashes
> > elsewhere, too.
> Does this problem also show up with 5.24.1-1 in testing and/or
> 5.24.1-2 in unstable?

Looking at the upstream ticket at
https://rt.cpan.org/Public/Bug/Display.html?id=109852
it seems that the segfaults started with perl 5.23.x, that a perl bug
was fixed in 5.24.0, and that nama still segfaults. -- So not sure
where the problem lies; my guess would be nama.


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at/ - Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   BOFH excuse #407:  Route flapping at the NAP. 

Message #41 received at 839218@bugs.debian.org (full text, mbox, reply):

From: Balint Reczey <balint.reczey@canonical.com>

To: gregor herrmann <gregoa@debian.org>

Cc: 839218@bugs.debian.org

Subject: Re: Bug#839218: nama: FTBFS: Failed 1/7 test programs. 0/91 subtests failed.Bad plan. You planned 126 tests but ran 57.

Date: Tue, 21 Mar 2017 16:05:43 +0100

Hi Gregor,

On Tue, Mar 21, 2017 at 1:36 PM, gregor herrmann <gregoa@debian.org> wrote:
> On Tue, 21 Mar 2017 13:31:32 +0100, gregor herrmann wrote:
>
>> > This looks like a problem in perl itself possibly causing random crashes
>> > elsewhere, too.
>> Does this problem also show up with 5.24.1-1 in testing and/or
>> 5.24.1-2 in unstable?

Yes, in every later version.
I chose the first version BTS knew about.

> Looking at the upstream ticket at
> https://rt.cpan.org/Public/Bug/Display.html?id=109852
> it seems that the segfaults started with perl 5.23.x, that a perl bug
> was fixed in 5.24.0, and that nama still segfaults. -- So not sure
> where the problem lies; my guess would be nama.

As I read the report there have been numerous fixes after the following
commit:

 https://github.com/Perl/perl5/commit/a5f48505593c7e1ca478de383e24d5cc2541f3ca

       re-implement OPpASSIGN_COMMON mechanism

 This commit almost completely replaces the current mechanism
 for detecting and handing common vars in list assignment, e.g.
 ...

It looks like not all regression are fixed after the re-implementation
and the one
affecting nama is one of them.

I think it should be impossible to trigger an internal assertion in
Perl with pure
Perl code like nama.

Cheers,
Balint

>
>
> Cheers,
> gregor
>
> --
>  .''`.  https://info.comodo.priv.at/ - Debian Developer https://www.debian.org
>  : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
>  `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
>    `-   BOFH excuse #407:  Route flapping at the NAP.



-- 
--
Balint Reczey
Debian & Ubuntu Developer

Message #46 received at 839218@bugs.debian.org (full text, mbox, reply):

From: Niko Tyni <ntyni@debian.org>

To: Balint Reczey <balint.reczey@canonical.com>, 839218@bugs.debian.org

Cc: gregor herrmann <gregoa@debian.org>

Subject: Re: Bug#839218: nama: FTBFS: Failed 1/7 test programs. 0/91 subtests failed.Bad plan. You planned 126 tests but ran 57.

Date: Wed, 22 Mar 2017 21:53:01 +0200

On Tue, Mar 21, 2017 at 04:05:43PM +0100, Balint Reczey wrote:

> It looks like not all regression are fixed after the re-implementation
> and the one affecting nama is one of them.

Some effort on a reduced test case would have been appreciated; the nama
code base is rather big.

While I haven't made it to the bottom of this yet, I note that there's
this code in lib/Audio/Nama/Effect.pm:

                my $perl_version = $^V;
                my ($minor_version) = $perl_version =~ /^v5\.(\d+)/;
                my @new_list = grep  { $_ ne $id  } @ops_list;
                #say "new_list: @new_list";
                if ($minor_version <= 14) 
                     {    $track->{ops}   = [ @new_list  ] }
                else { @{ $track->{ops} } =   @new_list    }

and if I patch that to take the <= 14 code path, the segfault goes away
here and all tests pass. What's the history behind this version check?
-- 
Niko Tyni   ntyni@debian.org

Message #51 received at 839218@bugs.debian.org (full text, mbox, reply):

From: Balint Reczey <balint.reczey@canonical.com>

To: Niko Tyni <ntyni@debian.org>

Cc: 839218@bugs.debian.org, gregor herrmann <gregoa@debian.org>

Subject: Re: Bug#839218: nama: FTBFS: Failed 1/7 test programs. 0/91 subtests failed.Bad plan. You planned 126 tests but ran 57.

Date: Thu, 23 Mar 2017 15:51:45 +0100

Hi Niko,

On Wed, Mar 22, 2017 at 8:53 PM, Niko Tyni <ntyni@debian.org> wrote:
> On Tue, Mar 21, 2017 at 04:05:43PM +0100, Balint Reczey wrote:
>
>> It looks like not all regression are fixed after the re-implementation
>> and the one affecting nama is one of them.
>
> Some effort on a reduced test case would have been appreciated; the nama
> code base is rather big.

I worked on reducing the test, but I could not reach reasonable size and
thought someone familiar with Perl internals could potentially spot the
problem easily from the segfault/assert.

I just found a perl test reducer, I'll give it a try:
https://github.com/blekko/perl-reduce

>
> While I haven't made it to the bottom of this yet, I note that there's
> this code in lib/Audio/Nama/Effect.pm:
>
>                 my $perl_version = $^V;
>                 my ($minor_version) = $perl_version =~ /^v5\.(\d+)/;
>                 my @new_list = grep  { $_ ne $id  } @ops_list;
>                 #say "new_list: @new_list";
>                 if ($minor_version <= 14)
>                      {    $track->{ops}   = [ @new_list  ] }
>                 else { @{ $track->{ops} } =   @new_list    }
>
> and if I patch that to take the <= 14 code path, the segfault goes away
> here and all tests pass. What's the history behind this version check?

Funny story, it was added to work around a segfault in older perl:
https://github.com/bolangi/nama/commit/8ecdbd5ad0b8ac67b7e4adab2ee1100fbf29aa1f

The line you found looks very much like a corner case for the assignment
reimplementation.

Should I forward it to Perl upstream?

Cheers,
Balint

Message #56 received at 839218@bugs.debian.org (full text, mbox, reply):

From: Niko Tyni <ntyni@debian.org>

To: Balint Reczey <balint.reczey@canonical.com>, 839218@bugs.debian.org

Cc: gregor herrmann <gregoa@debian.org>

Subject: Re: Bug#839218: nama: FTBFS: Failed 1/7 test programs. 0/91 subtests failed.Bad plan. You planned 126 tests but ran 57.

Date: Fri, 24 Mar 2017 11:30:11 +0200

On Thu, Mar 23, 2017 at 03:51:45PM +0100, Balint Reczey wrote:
> On Wed, Mar 22, 2017 at 8:53 PM, Niko Tyni <ntyni@debian.org> wrote:
> > On Tue, Mar 21, 2017 at 04:05:43PM +0100, Balint Reczey wrote:
> >
> >> It looks like not all regression are fixed after the re-implementation
> >> and the one affecting nama is one of them.
> >
> > Some effort on a reduced test case would have been appreciated; the nama
> > code base is rather big.
> 
> I worked on reducing the test, but I could not reach reasonable size and
> thought someone familiar with Perl internals could potentially spot the
> problem easily from the segfault/assert.
> 
> I just found a perl test reducer, I'll give it a try:
> https://github.com/blekko/perl-reduce

Cool, thanks & sorry for being a bit cranky. FWIW I got maybe halfway
there reducing the thing manually before I spotted the Perl version check.

> >                 if ($minor_version <= 14)
> >                      {    $track->{ops}   = [ @new_list  ] }
> >                 else { @{ $track->{ops} } =   @new_list    }
> >
> > and if I patch that to take the <= 14 code path, the segfault goes away
> > here and all tests pass. What's the history behind this version check?
> 
> Funny story, it was added to work around a segfault in older perl:
> https://github.com/bolangi/nama/commit/8ecdbd5ad0b8ac67b7e4adab2ee1100fbf29aa1f

Heh. Thanks for digging that up.

> The line you found looks very much like a corner case for the assignment
> reimplementation.

Yeah. I tried to devise a test case from scratch involving similar
assignments but couldn't get it to happen so it doesn't seem to be
anything trivial.

> Should I forward it to Perl upstream?

That would be nice, thanks. I'm sure they'd also prefer a minimal test case,
but maybe the assert details are enough for them.

I'll also work a bit on reducing the test further when I find the time.
-- 
Niko

Message #61 received at 839218@bugs.debian.org (full text, mbox, reply):

From: Balint Reczey <balint.reczey@canonical.com>

To: Niko Tyni <ntyni@debian.org>, 839218@bugs.debian.org

Cc: gregor herrmann <gregoa@debian.org>

Subject: Re: Bug#839218: nama: FTBFS: Failed 1/7 test programs. 0/91 subtests failed.Bad plan. You planned 126 tests but ran 57.

Date: Fri, 24 Mar 2017 18:06:05 +0100

Control: forwarded -1 https://rt.perl.org/Ticket/Display.html?id=131054
Control: tags -1 upstream

On 03/24/2017 10:30 AM, Niko Tyni wrote:
>> Should I forward it to Perl upstream?
> That would be nice, thanks. I'm sure they'd also prefer a minimal test case,
> but maybe the assert details are enough for them.
>
> I'll also work a bit on reducing the test further when I find the time.

Done.

Cheers,

Balint

Message #70 received at 839218@bugs.debian.org (full text, mbox, reply):

From: Niko Tyni <ntyni@debian.org>

To: Balint Reczey <balint.reczey@canonical.com>, 839218@bugs.debian.org

Cc: gregor herrmann <gregoa@debian.org>

Subject: Re: Bug#839218: nama: FTBFS: Failed 1/7 test programs. 0/91 subtests failed.Bad plan. You planned 126 tests but ran 57.

Date: Sun, 26 Mar 2017 21:23:53 +0300

On Fri, Mar 24, 2017 at 11:30:11AM +0200, Niko Tyni wrote:
 
> I'll also work a bit on reducing the test further when I find the time.

I got it down to this:

  my $a = [ 0, 1 ];
  sub f {
    my $arg = shift;
    my @a1 = @$a;
    @$a = @a1;
    return();
  }
  map{ f($_) } @$a;


This looks to me like an instance of the general stack-not-refcounted
issue, see https://rt.perl.org/Public/Bug/Display.html?id=77706 et al.

But let's see what upstream says, I'll follow up there as well.
-- 
Niko Tyni   ntyni@debian.org

Message #75 received at 839218@bugs.debian.org (full text, mbox, reply):

From: Balint Reczey <balint.reczey@canonical.com>

To: Niko Tyni <ntyni@debian.org>

Cc: 839218@bugs.debian.org, gregor herrmann <gregoa@debian.org>

Subject: Re: Bug#839218: nama: FTBFS: Failed 1/7 test programs. 0/91 subtests failed.Bad plan. You planned 126 tests but ran 57.

Date: Mon, 27 Mar 2017 09:33:29 +0200

[Message part 1 (text/plain, inline)]

Control: tags -1 patch

Hi Niko,

On Sun, Mar 26, 2017 at 8:23 PM, Niko Tyni <ntyni@debian.org> wrote:
> On Fri, Mar 24, 2017 at 11:30:11AM +0200, Niko Tyni wrote:
>
>> I'll also work a bit on reducing the test further when I find the time.
>
> I got it down to this:
>
>   my $a = [ 0, 1 ];
>   sub f {
>     my $arg = shift;
>     my @a1 = @$a;
>     @$a = @a1;
>     return();
>   }
>   map{ f($_) } @$a;
>
>
> This looks to me like an instance of the general stack-not-refcounted
> issue, see https://rt.perl.org/Public/Bug/Display.html?id=77706 et al.
>
> But let's see what upstream says, I'll follow up there as well.

Thanks!

Seeing that they confirmed that and the refcounting issue is rather old
I think it would be reasonable to apply a workaround in nama.
The attached patch made nama build in current unstable.

Cheers,
Balint

-- 
Balint Reczey
Debian & Ubuntu Developer

[workaround-perl-stack-not-refcounted-crash.patch (text/x-patch, attachment)]

Message #88 received at 839218@bugs.debian.org (full text, mbox, reply):

From: Dominic Hargreaves <dom@earth.li>

To: Balint Reczey <balint.reczey@canonical.com>, 839218@bugs.debian.org

Cc: Niko Tyni <ntyni@debian.org>, gregor herrmann <gregoa@debian.org>, 582925@bugs.debian.org

Subject: Re: Bug#839218: nama: FTBFS: Failed 1/7 test programs. 0/91 subtests failed.Bad plan. You planned 126 tests but ran 57.

Date: Mon, 27 Mar 2017 10:50:04 +0100

Control: reassign 839218 nama
Control: retitle 839218 nama: FTBFS because of perl's lack of stack reference counting

On Mon, Mar 27, 2017 at 09:33:29AM +0200, Balint Reczey wrote:
> Control: tags -1 patch
> 
> Hi Niko,
> 
> On Sun, Mar 26, 2017 at 8:23 PM, Niko Tyni <ntyni@debian.org> wrote:
> > On Fri, Mar 24, 2017 at 11:30:11AM +0200, Niko Tyni wrote:
> >
> >> I'll also work a bit on reducing the test further when I find the time.
> >
> > I got it down to this:
> >
> >   my $a = [ 0, 1 ];
> >   sub f {
> >     my $arg = shift;
> >     my @a1 = @$a;
> >     @$a = @a1;
> >     return();
> >   }
> >   map{ f($_) } @$a;
> >
> >
> > This looks to me like an instance of the general stack-not-refcounted
> > issue, see https://rt.perl.org/Public/Bug/Display.html?id=77706 et al.
> >
> > But let's see what upstream says, I'll follow up there as well.
> 
> Thanks!
> 
> Seeing that they confirmed that and the refcounting issue is rather old
> I think it would be reasonable to apply a workaround in nama.
> The attached patch made nama build in current unstable.

Thanks, reassigning back to Nama so the workaround can be considered.
The underlying problem in perl is tracked in #582925.

Dominic.

Message #91 received at 839218@bugs.debian.org (full text, mbox, reply):

From: pkg-perl-maintainers@lists.alioth.debian.org

To: 839218@bugs.debian.org, 839218-submitter@bugs.debian.org

Subject: Pending fixes for bugs in the nama package

Date: Mon, 27 Mar 2017 15:56:07 +0000

tag 839218 + pending
thanks

Some bugs in the nama package are closed in revision
a1c92168c0b43ba0aae6a792ade51a647b18eb4c in branch 'master' by Balint
Reczey

The full diff can be seen at
https://anonscm.debian.org/cgit/pkg-perl/packages/nama.git/commit/?id=a1c9216

Commit message:

    Add patch to work around Perl crash.
    
    The construct used in nama triggers a segfault in Perl which surfaced
    recently in 5.23.3.
    
    Closes: #839218

Message #101 received at 839218-close@bugs.debian.org (full text, mbox, reply):

From: gregor herrmann <gregoa@debian.org>

To: 839218-close@bugs.debian.org

Subject: Bug#839218: fixed in nama 1.208-2

Date: Mon, 27 Mar 2017 16:19:10 +0000

Source: nama
Source-Version: 1.208-2

We believe that the bug you reported is fixed in the latest version of
nama, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 839218@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
gregor herrmann <gregoa@debian.org> (supplier of updated nama package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 27 Mar 2017 17:53:38 +0200
Source: nama
Binary: nama
Architecture: source
Version: 1.208-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Perl Group <pkg-perl-maintainers@lists.alioth.debian.org>
Changed-By: gregor herrmann <gregoa@debian.org>
Closes: 839218
Description: 
 nama       - Ecasound-based multitrack recorder/mixer
Changes:
 nama (1.208-2) unstable; urgency=medium
 .
   [ Salvatore Bonaccorso ]
   * debian/control: Use HTTPS transport protocol for Vcs-Git URI
 .
   [ gregor herrmann ]
   * debian/copyright: change Copyright-Format 1.0 URL to HTTPS.
   * Remove Joel Roth from Uploaders. Thanks for your work!
 .
   [ Balint Reczey ]
   * Add patch to work around Perl crash. The construct used in nama
     triggers a segfault in Perl which surfaced recently in 5.23.3.
     (Closes: #839218)
 .
   [ gregor herrmann ]
   * Add /me to Uploaders.
   * debian/control: use HTTPS in Homepage field.
   * Add a patch to fix spelling mistakes in the POD.
   * Declare compliance with Debian Policy 3.9.8.
Checksums-Sha1: 
 c3d4dbc3b3d02f56a389faae88ba8691782bf384 2639 nama_1.208-2.dsc
 fa7d3b6d078a3d1b997cfeae8334bf7f3d3395cc 5320 nama_1.208-2.debian.tar.xz
Checksums-Sha256: 
 aa1beb89cf011e97d9120f29497bfd86c430210580384a15027eda778bdb6f8c 2639 nama_1.208-2.dsc
 261acbcf59bf601df67101046c5c64456c9bc7a965d49a446873ebcb09e5621e 5320 nama_1.208-2.debian.tar.xz
Files: 
 0517ba94b2cf4be3151e09aa5aaec8a6 2639 sound optional nama_1.208-2.dsc
 e8f41a5bcf0f69d088f7199fb3b1f624 5320 sound optional nama_1.208-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAljZNf1fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx
RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ
qgYh5w/+LsYGKYTEysQ5Xj1fAJHUrL1kxouBYTIIfFqxdtCgNpxf0tQasP8BtInn
viNztDl9MsolMbUelJCTPlHEFnORnTlg1rVZxGagHygSvtIKeKrNl8G15L4yBctV
YJPZSUWsd5mRkfTRdiFtrvKWRe7GmR8SwZziU4dR0MklXROJlbzjcYtoae9mT2K1
ZIfmKOFgoexFkA1GPjyUbvuAHyxYN/sqeKDB4VMPOYTtQyzrvITE9RRoYSIUvXPX
OKbS9ADR9+A7e/UtiR8oWRa8EqX+8LxazH2sG8yKLQotxGBI2CnP86t4IFfx7qcg
qRuAEgcXL2L2kSb1O10hEvFqZSJ7kg620X4Bcz5eFtjgR+WsbbcRakVZTDBK+EGY
p1sFh/5ny+6urOoxYdxokKiQpVeYG7HHAqRzPxPXMuHlLHUk4EC2g8Pwsz24j5ke
rWsqgIGRkHKSIxg3YjR50bxvAPvxBkLkrg+Vva1qpl2DNUFg2EDEaocVaZL3q7FB
rKo9aaRL5D5GzOM6eyyJ1DXXMDzTtCEt6hVH+XoORS04Zdfd4qd8Ca5hVPRzmfHs
l9/ooXPLjCfH6T0BzySVEOJrcjYrnBnGIiW7k1XUNOvxHouAT+nUBEXsJTLDwJ/U
fWxMFGkAsELS06Zxy51NluXF9wmhaft6C9J5c4gnbIHv+knJTm0=
=1gIj
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.