Debian Bug report logs - #838829
valac: Feature Regression in vala 0.34

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Sebastian Reichel <sre@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: valac: Feature Regression in vala 0.34

Date: Sun, 25 Sep 2016 16:02:53 +0200

Package: valac
Version: 0.34.0-1
Severity: serious
Tags: upstream
Justification: upstream regression causes FTBFS in other package(s)

Hi,

valac no longer supports abstract functions with generics. This
construct is used by the freesmartphone.org stack, which is
packaged for Debian and FTBFS with valac > 0.34.0-1. This has
been reported in Debian Bug #838705.

The below standalone testcase, which compiles warning free
in vala 0.32, no longer works in vala 0.34 and demonstrates the
problem.

As far as I can see the regression has been introduced by the
following change:
https://mail.gnome.org/archives/commits-list/2016-July/msg02876.html

---------------------------------------------------------
public abstract class basecl : Object {
	public abstract void test<T>(T parameter);
}

public class inheritcl : basecl {
	public override void test<T>(T parameter) {
		stdout.printf("Just a test!\n");
	}
}

int main(string[] args) {
	var obj = new inheritcl();
	obj.test<string>("test");
	return 0;
}
---------------------------------------------------------

-- Sebastian

Message #16 received at 838829@bugs.debian.org (full text, mbox, reply):

From: Daniel Espinosa <esodan@gmail.com>

To: 838829@bugs.debian.org

Subject: Try to add Generics declaration to class definition

Date: Tue, 27 Sep 2016 06:36:12 -0500

[Message part 1 (text/plain, inline)]

As for bug:

https://bugzilla.gnome.org/show_bug.cgi?id=770449

Valac have started to check types in other places and if GitHub manual is
used to check generic classes declaration, as for:

https://github.com/valadate-project/the-vala-manual/blob/master/en/generics-examples.md

then your example should be:

public abstract class basecl<T> : Object {
  public abstract void test<T>(T parameter);
}

public class inheritcl<T> : basecl {
  public override void test<T>(T parameter) {
    stdout.printf("Just a test!\n");
  }
}

May you want to test this code and change this bug, as this may it is not,
but a code update required due to recent additional checks in valac.

[Message part 2 (text/html, inline)]

Message #21 received at 838829@bugs.debian.org (full text, mbox, reply):

From: Sebastian Reichel <sre@debian.org>

To: Daniel Espinosa <esodan@gmail.com>, 838829@bugs.debian.org

Subject: Re: Bug#838829: Try to add Generics declaration to class definition

Date: Tue, 27 Sep 2016 15:02:08 +0200

[Message part 1 (text/plain, inline)]

Hi,

On Tue, Sep 27, 2016 at 06:36:12AM -0500, Daniel Espinosa wrote:
> As for bug:
> 
> https://bugzilla.gnome.org/show_bug.cgi?id=770449
> 
> Valac have started to check types in other places and if GitHub manual is
> used to check generic classes declaration, as for:
> 
> https://github.com/valadate-project/the-vala-manual/blob/master/en/generics-examples.md
> 
> then your example should be:
> 
> public abstract class basecl<T> : Object {
>   public abstract void test<T>(T parameter);
> }
> 
> public class inheritcl<T> : basecl {
>   public override void test<T>(T parameter) {
>     stdout.printf("Just a test!\n");
>   }
> }
> 
> May you want to test this code and change this bug, as this may it is not,
> but a code update required due to recent additional checks in valac.

No. Your code also fails with valac 0.34.0. In vala 0.34.0 you can't
override generic methods. Note that it already has been fixed
upstream:

https://git.gnome.org/browse/vala/commit/?h=0.34&id=9e0e03f2ca48eeef4d16067cca21426b240cd5c5

vala 0.32.0 and vala 0.34.0 with that fix applied compiles my
testcode from above without any problems. Also the libfsoframework
no longer FTBFS.

-- Sebastian

[signature.asc (application/pgp-signature, inline)]

Message #26 received at 838829-close@bugs.debian.org (full text, mbox, reply):

From: Sebastian Reichel <sre@debian.org>

To: 838829-close@bugs.debian.org

Subject: Bug#838829: fixed in vala 0.34.0-3

Date: Tue, 27 Sep 2016 17:15:48 +0000

Source: vala
Source-Version: 0.34.0-3

We believe that the bug you reported is fixed in the latest version of
vala, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 838829@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Sebastian Reichel <sre@debian.org> (supplier of updated vala package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 27 Sep 2016 17:33:18 +0200
Source: vala
Binary: valac valac-0.34-vapi vala-0.34-doc libvala-0.34-0 libvala-0.34-dev
Architecture: source amd64 all
Version: 0.34.0-3
Distribution: unstable
Urgency: medium
Maintainer: Maintainers of Vala packages <pkg-vala-maintainers@lists.alioth.debian.org>
Changed-By: Sebastian Reichel <sre@debian.org>
Description:
 libvala-0.34-0 - C# like language for the GObject system - library
 libvala-0.34-dev - C# like language for the GObject system - development headers
 vala-0.34-doc - C# like language for the GObject system - documentation
 valac      - C# like language for the GObject system
 valac-0.34-vapi - C# like language for the GObject system - vapi files
Closes: 838829
Changes:
 vala (0.34.0-3) unstable; urgency=medium
 .
   * cherry-pick upstream patch fixing support for abstract
     methods with generics (Closes: #838829)
Checksums-Sha1:
 ab29ea52eb8caccd1d2638fb6de8360dc18adb9f 2559 vala_0.34.0-3.dsc
 f218b61f55fc6d1c203aabddefeab90135bd45b7 26864 vala_0.34.0-3.debian.tar.xz
 2d5692999d1bacb12bdcce92c7f10081baa416bd 5084786 libvala-0.34-0-dbgsym_0.34.0-3_amd64.deb
 7304d139852ae1a50c112863aa82b9454278468c 941540 libvala-0.34-0_0.34.0-3_amd64.deb
 97aad60426a869c93e92a8b0efa0cebafad75cc8 203106 libvala-0.34-dev_0.34.0-3_amd64.deb
 a8ef01b24956713693ac6e67bd47cf67f40f3b08 164328 vala-0.34-doc_0.34.0-3_all.deb
 be203bd0e4c43b124bdd8d60bbff36432bd856f0 862670 valac-0.34-vapi_0.34.0-3_all.deb
 d2ab3ca22caaaca20fa2c057dc95f0ce842f8a0a 591934 valac-dbgsym_0.34.0-3_amd64.deb
 25ea7da7532b86e30794da932f30863257036d26 273300 valac_0.34.0-3_amd64.deb
Checksums-Sha256:
 d3dbb95a71acf310abfe3cc7465b2b6aa256618ad97a702a65f6d17aab5c3057 2559 vala_0.34.0-3.dsc
 be8a15e82d0aeff79eb9fa0a1afb2f719fee3c3a8f9ef10a26f1bc9ebf9e8756 26864 vala_0.34.0-3.debian.tar.xz
 79d6f014c71199072f3065f39ec446cf481b27db7ddcd4a65bba05facfac637a 5084786 libvala-0.34-0-dbgsym_0.34.0-3_amd64.deb
 0f97a18508c20b9a2f97019a08e640420dc2f2788bbf1452f1e2d8c5fe04e492 941540 libvala-0.34-0_0.34.0-3_amd64.deb
 6a5c55ba1374842fbbaedac7b3e6037b8f2d3f40aafb33d51ed00bffb2738034 203106 libvala-0.34-dev_0.34.0-3_amd64.deb
 42682b6790f978359a91a2389d2439714608cf120403fddff871e7c2c13ecea8 164328 vala-0.34-doc_0.34.0-3_all.deb
 d62fcc43f9c5ee14b7b9758fc7bf62407b90ae8b7713a12c6fc136e936e7d8b3 862670 valac-0.34-vapi_0.34.0-3_all.deb
 74339a6be024a2bd68b60c1edd50a9eb2af48f911e292146ee10536b1d28e2d0 591934 valac-dbgsym_0.34.0-3_amd64.deb
 f537dfc7b58de485c1fb3b4766a08f3c9e60ae3bc80a03730084243ffee88cd6 273300 valac_0.34.0-3_amd64.deb
Files:
 2be63a59083f1c99b9c448dfa0decf29 2559 devel optional vala_0.34.0-3.dsc
 60499f63c38eeea011a5a844389bcc13 26864 devel optional vala_0.34.0-3.debian.tar.xz
 ee89c5ee8aa082d030ef2c08eb7e9122 5084786 debug extra libvala-0.34-0-dbgsym_0.34.0-3_amd64.deb
 4bd98e0917cca2a4efc21e0213facdbe 941540 libs optional libvala-0.34-0_0.34.0-3_amd64.deb
 9d8bef40ba73a64b498f3c2bff9669dc 203106 libdevel optional libvala-0.34-dev_0.34.0-3_amd64.deb
 66ec97c8fc215b3a2b11b640a51e6259 164328 doc optional vala-0.34-doc_0.34.0-3_all.deb
 cf50e920a772e4ca1e019cea0c81147a 862670 devel optional valac-0.34-vapi_0.34.0-3_all.deb
 b38354d6bf63a8589f9355baa2805f21 591934 debug extra valac-dbgsym_0.34.0-3_amd64.deb
 821b35932e5915fa4c3e95413ef60bb0 273300 devel optional valac_0.34.0-3_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJX6pVGAAoJENju1/PIO/qaENsP+wT8GC52CW1+bFQFLziYga7M
JTGL0kPAGKNpRSSu/mO5jxFVDy7E+ST3Z+9yO3f9VqQxGHRFRJKnCUW/0RIlkCtL
EYNMIAUX5H9NTym/N7p9WaI6jl6PgIZ4F7wZhiEdpVChGa/4ogSnOezmiCRUxr7U
fzPIZKAqkRUtSy5DZKvaXFa1J5Yxfp9GiJPUlfmwxoL4p/nP6pscjJQWsPpq7jGv
jYp/l5QWttm7n8Nk2a6mgSqmVrX7hzmOGyjRRrS938Ob1994vIu+CzpyIOOv951o
GHEgxmpv5f+WVi+bZhgX3SyD7eO9izTwDhQQNbDblkLU1sHKeo2MQsWb18ajLChD
u2+dYhPstWiKuHtI9zfF81b4UCMQDMvE8cb3euhxAbqtC7EPItCeEbp/RhQSibou
Xtlu/Hx0naMaIVB7429eNHdsMHoxYlr8luojUm+I0txakQQFMl8fhWnVj45jSaz3
cZGRI4fHTF/wn/UQwEchRa3W5vQJy/ukfv3UKTHAFqxS1EIqztHbSUxiSsgwRH4R
2cH1We4km1Jx7J3BWzgpP6JsjJBUk+lWQaGXrJuWMSgGMVTu37LDOtvkkgrKNxDc
8MIRDNAeQDcTDT36x4HQ4SjBaKJWYMDMbAjZBb+S+KFj+nW32+qoKJD9nWIgMzNg
8oubx6WOnrKEqETNcsBI
=+z0c
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.