Debian Bug report logs - #838706
spl-dkms should require dkms > 2.2.0 as of 0.6.5.8

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Rich <rercola@acm.jhu.edu>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: spl-dkms should require dkms > 2.2.0 as of 0.6.5.8

Date: Fri, 23 Sep 2016 14:52:00 -0400

Package: spl-dkms
Version: 0.6.5.8-1
Severity: normal

Dear Maintainer,

I tried building and installing the new spl-dkms from testing/unstable on my
Jessie system, which built fine, and reportedly installed fine.

Unfortunately, the fix for #836578 breaks the package for DKMS < 2.2.1.0,
resulting in an apparently successful install, but the zfs-dkms package will
spin forever waiting for .../module/spl_config.h to exist.

Please either include a workaround for DKMS < 2.2.1.0 (I'd offer one but I
don't know enough about how these systems function to guess how it might
work) or mark the package as requiring DKMS > 2.2.1.0.

-- System Information:
Debian Release: 8.5
  APT prefers stable
  APT policy: (1000, 'stable'), (900, 'testing'), (500, 'testing-debug'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.5.0-0.bpo.2-amd64 (SMP w/16 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages spl-dkms depends on:
ii  dkms                  2.2.0.3-2
ii  file                  1:5.22+15-2+deb8u1
ii  libc6-dev [libc-dev]  2.19-18+deb8u4
ii  lsb-release           4.1+Debian13+nmu1

Versions of packages spl-dkms recommends:
ii  spl  0.6.5.8-1

spl-dkms suggests no packages.

-- no debconf information

Message #10 received at 838706@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@hungry.com>

To: Rich <rercola@acm.jhu.edu>, 838706@bugs.debian.org, Dynamic Kernel Modules Support Team <pkg-dkms-maint@lists.alioth.debian.org>

Subject: Re: [Pkg-zfsonlinux-devel] Bug#838706: spl-dkms should require dkms > 2.2.0 as of 0.6.5.8

Date: Sat, 24 Sep 2016 07:20:58 +0200

Hi, and thank you for bringing up this issue.

[Rich]
> I tried building and installing the new spl-dkms from testing/unstable on my
> Jessie system, which built fine, and reportedly installed fine.
>
> Unfortunately, the fix for #836578 breaks the package for DKMS < 2.2.1.0,
> resulting in an apparently successful install, but the zfs-dkms package will
> spin forever waiting for .../module/spl_config.h to exist.
>
> Please either include a workaround for DKMS < 2.2.1.0 (I'd offer one but I
> don't know enough about how these systems function to guess how it might
> work) or mark the package as requiring DKMS > 2.2.1.0.

I expected the small change applied to fix
<URL: https://bugs.debian.org/836578 > to work also on older dkms
versions, but I do not really know the inner workings of dkms.

Perhaps one of the dkms maintainers can explain how the following patch
can be made to work with both new and old dkms versions?

--- usr/src/spl-0.6.5.7/dkms.conf	2016-05-25 15:42:03.000000000 +1000
+++ usr/src/spl-0.6.5.7/dkms.conf.orig	2016-09-09 10:37:43.482388086 +1000
@@ -20,7 +20,7 @@
                  esac)
   --with-linux-obj=${kernel_source_dir}
 "
-POST_INSTALL="cp
+POST_BUILD="cp
   ${dkms_tree}/${PACKAGE_NAME}/${PACKAGE_VERSION}/build/spl_config.h
   ${dkms_tree}/${PACKAGE_NAME}/${PACKAGE_VERSION}/build/module/Module.symvers
   ${dkms_tree}/${PACKAGE_NAME}/${PACKAGE_VERSION}/${kernelver}/${arch}/
-- 
Happy hacking
Petter Reinholdtsen

Message #15 received at 838706@bugs.debian.org (full text, mbox, reply):

From: Rich <rercola@acm.jhu.edu>

To: Petter Reinholdtsen <pere@hungry.com>

Cc: 838706@bugs.debian.org, Dynamic Kernel Modules Support Team <pkg-dkms-maint@lists.alioth.debian.org>

Subject: Re: [Pkg-zfsonlinux-devel] Bug#838706: spl-dkms should require dkms > 2.2.0 as of 0.6.5.8

Date: Sat, 24 Sep 2016 03:22:47 -0400

[Message part 1 (text/plain, inline)]

If the issue is that only POST_INSTALL runs on DKMS < 2.2.1 and both run on
DKMS >= 2.2.1, couldn't we modify POST_INSTALL to include an existence
check for the build dir before attempting the cp, and then include both
POST_INSTALL and POST_BUILD steps?

That way, the POST_INSTALL step will silently bail on DKMS >= 2.2.1
(because the existence check for
${dkms_tree}/${PACKAGE_NAME}/${PACKAGE_VERSION}/build
would fail), and POST_BUILD would copy the files over, while on DKMS <
2.2.1, POST_INSTALL would happily succeed?

Something like

POST_INSTALL="if [ -d \"${dkms_tree}/${PACKAGE_NAME}/${PACKAGE_VERSION}/build\"
]; then cp ...;fi"
POST_BUILD="cp ..."

?

- Rich

On Sat, Sep 24, 2016 at 1:20 AM, Petter Reinholdtsen <pere@hungry.com>
wrote:

>
> Hi, and thank you for bringing up this issue.
>
> [Rich]
> > I tried building and installing the new spl-dkms from testing/unstable
> on my
> > Jessie system, which built fine, and reportedly installed fine.
> >
> > Unfortunately, the fix for #836578 breaks the package for DKMS < 2.2.1.0,
> > resulting in an apparently successful install, but the zfs-dkms package
> will
> > spin forever waiting for .../module/spl_config.h to exist.
> >
> > Please either include a workaround for DKMS < 2.2.1.0 (I'd offer one but
> I
> > don't know enough about how these systems function to guess how it might
> > work) or mark the package as requiring DKMS > 2.2.1.0.
>
> I expected the small change applied to fix
> <URL: https://bugs.debian.org/836578 > to work also on older dkms
> versions, but I do not really know the inner workings of dkms.
>
> Perhaps one of the dkms maintainers can explain how the following patch
> can be made to work with both new and old dkms versions?
>
> --- usr/src/spl-0.6.5.7/dkms.conf       2016-05-25 15:42:03.000000000 +1000
> +++ usr/src/spl-0.6.5.7/dkms.conf.orig  2016-09-09 10:37:43.482388086
> +1000
> @@ -20,7 +20,7 @@
>                   esac)
>    --with-linux-obj=${kernel_source_dir}
>  "
> -POST_INSTALL="cp
> +POST_BUILD="cp
>    ${dkms_tree}/${PACKAGE_NAME}/${PACKAGE_VERSION}/build/spl_config.h
>    ${dkms_tree}/${PACKAGE_NAME}/${PACKAGE_VERSION}/build/
> module/Module.symvers
>    ${dkms_tree}/${PACKAGE_NAME}/${PACKAGE_VERSION}/${kernelver}/${arch}/
> --
> Happy hacking
> Petter Reinholdtsen
>

[Message part 2 (text/html, inline)]

Message #20 received at 838706@bugs.debian.org (full text, mbox, reply):

From: Bernhard Schmidt <berni@debian.org>

To: Rich <rercola@acm.jhu.edu>, 838706@bugs.debian.org

Cc: Petter Reinholdtsen <pere@hungry.com>, Al Nikolov <clown@debian.org>, Dynamic Kernel Modules Support Team <pkg-dkms-maint@lists.alioth.debian.org>

Subject: Re: Bug#838706: [Pkg-zfsonlinux-devel] Bug#838706: spl-dkms should require dkms > 2.2.0 as of 0.6.5.8

Date: Tue, 4 Oct 2016 23:18:18 +0200

[Message part 1 (text/plain, inline)]

Hi,

I just hit the very same problem with spl-linux from bpo on a Jessie
system (with dkms 2.2.0.3-2). 

It builds fine with dkms 2.2.0.3-4~bpo8+1. I assume this could be
changed by this (in 2.2.0.3-3)

  [ Aron Xu ]
  * Added patches from Darik Horn and Ubuntu:
    - Correct handling of POST_BUILD (Closes: #704989)

Obviously I have no clue of dkms, but in my test it fixed the issue.

If this is correct I'd suggest to raise the versioned dependency for
dkms on spl-dkms and zfs-dkms to (>= 2.2.0.3-3~), which should be a
no-op in sid and will just pull in dkms from jessie-backports on systems
installing ZFS from jessie-backports.

Alternatively this change could be done only for the backported package
(Ccing Al for his input here)

Bernhard

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 838706@bugs.debian.org (full text, mbox, reply):

From: Al Nikolov <clown@debian.org>

To: Bernhard Schmidt <berni@debian.org>

Cc: Rich <rercola@acm.jhu.edu>, 838706@bugs.debian.org, Petter Reinholdtsen <pere@hungry.com>, Dynamic Kernel Modules Support Team <pkg-dkms-maint@lists.alioth.debian.org>

Subject: Re: Bug#838706: [Pkg-zfsonlinux-devel] Bug#838706: spl-dkms should require dkms > 2.2.0 as of 0.6.5.8

Date: Wed, 05 Oct 2016 14:17:09 +0300

[Message part 1 (text/plain, inline)]

Control: tags -1 + patch

В Вт, 04/10/2016 в 23:18 +0200, Bernhard Schmidt пишет:

> I just hit the very same problem with spl-linux from bpo on a Jessie
> system (with dkms 2.2.0.3-2). 

Please, be aware, that I uploaded spl-linux 0.6.5.8-2~bpo8+2 with the
old dkms compatibility restored (should still be working with the new
one, as well).

I don't know shall I close this bug though.

[signature.asc (application/pgp-signature, inline)]

Message #34 received at 838706-close@bugs.debian.org (full text, mbox, reply):

From: Aron Xu <aron@debian.org>

To: 838706-close@bugs.debian.org

Date: Tue, 17 Jan 2017 22:46:06 +0800

Source-Version: 0.6.5.8-2

This should be fixed in 0.6.5.8-2.

Regards,
Aron

Send a report that this bug log contains spam.