Debian Bug report logs - #837581
xfslibs-dev: Don't put the .so symlink to /lib/*.so

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Balint Reczey <balint@balintreczey.hu>

To: submit@bugs.debian.org

Subject: xfsdump: FTBFS with bindnow and PIE enabled

Date: Mon, 12 Sep 2016 16:43:00 +0200

Source: xfsdump
Version: 3.1.6+nmu1
Severity: important
User: balint@balintreczey.hu
Usertags: pie-bindnow-20160906
Justification: FTBFS on amd64 with extra hardening

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64 with patched GCC and dpkg.

The rebuild tested if packages are ready for a transition
enabling PIE and bindnow for amd64.

For more information about the changes to sid's dpkg and GCC please
visit:
 https://wiki.debian.org/Hardening/PIEByDefaultTransition

Relevant part (hopefully):
...
checking for xfs/handle.h... yes
checking for open_by_fshandle in -lhandle... no

FATAL ERROR: could not find a current XFS handle library.
Install or upgrade the XFS library package.
Alternatively, run "make install-dev" from the xfsprogs source.
Makefile:78: recipe for target 'include/builddefs' failed
make[1]: *** [include/builddefs] Error 1
...

The full build log is available from:
 https://people.debian.org/~rbalint/build-logs/pie-bindnow-20160906/xfsdump_3.1.6+nmu1_amd64.build.gz

Thanks,
Balint

Message #12 received at 837581@bugs.debian.org (full text, mbox, reply):

From: Adrian Bunk <bunk@stusta.de>

To: 837581@bugs.debian.org

Subject: Move to the correct package

Date: Fri, 21 Oct 2016 21:40:28 +0300

Control: reassign -1 xfslibs-dev
Control: retitle -1 xfslibs-dev: Don't put the .so symlink to /lib/*.so
Control: affects -1 src:xfsdump

The root cause of this bug is that /usr/lib/libhandle.a is being used 
instead of /lib/libhandle.so

This was already not right before, but now it became fatal.

The correct solution for this bug is:
- move libhandle.so.1 to /lib/<multiarch>/
- move libhandle.so to /usr/lib/<multiarch>/

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Message #31 received at 837581@bugs.debian.org (full text, mbox, reply):

From: Florian Schlichting <fsfs@debian.org>

To: 837581@bugs.debian.org

Subject: Re: xfslibs-dev: Don't put the .so symlink to /lib/*.so

Date: Sat, 25 Feb 2017 19:30:07 +0100

Hi, Berlin BSP here.

I can't reproduce this bug on amd64. I notice that since the upload of
xfsprogs 4.9.0, xfsdump does not FTBFS any more on amd64. It does
however still FTBFS on i386 and armhf, albeit with a different error:

...
checking xfs/xfs.h usability... no
checking xfs/xfs.h presence... yes
configure: WARNING: xfs/xfs.h: present but cannot be compiled
configure: WARNING: xfs/xfs.h:     check for missing prerequisite headers?
configure: WARNING: xfs/xfs.h: see the Autoconf documentation
configure: WARNING: xfs/xfs.h:     section "Present But Cannot Be Compiled"
configure: WARNING: xfs/xfs.h: proceeding with the compiler's result
checking for xfs/xfs.h... no

FATAL ERROR: cannot find a valid <xfs/xfs.h> header file.
Install or upgrade the XFS development package.
Alternatively, run "make install-dev" from the xfsprogs source.
Makefile:78: recipe for target 'include/builddefs' failed
make[1]: *** [include/builddefs] Error 1
make[1]: Leaving directory '/build/1st/xfsdump-3.1.6+nmu1'
debian/rules:23: recipe for target '.census' failed
...

see https://tests.reproducible-builds.org/debian/rb-pkg/unstable/i386/xfsdump.html
or https://tests.reproducible-builds.org/debian/rb-pkg/unstable/armhf/xfsdump.html

The relevant test fails with

/usr/include/xfs/xfs.h:53:12: error: size of array 'xfs_assert_largefile' is too large
 extern int xfs_assert_largefile[sizeof(off_t)-8];
            ^~~~~~~~~~~~~~~~~~~~

While -D_FILE_OFFSET_BITS=64 is correctly set in include/builddefs.in,
this is not known to configure and thus it fails when testing xfs.h on
32bit systems.

A similar thing seems to have happened to CEPH, see
https://anonscm.debian.org/cgit/pkg-ceph/ceph.git/commit/?h=debian/10.2.5-5&id=f4675da14d1b38f907079e522d9da7a0e23037fb
but I couldn't get that patch to work. for xfsdump. However the
following patch (to xfsdump) seems to fix the FTBFS in my i386 chroot:

--- a/debian/rules
+++ b/debian/rules
@@ -1,6 +1,7 @@
 #!/usr/bin/make -f
 
 export DH_VERBOSE=1
+export LOCAL_CONFIGURE_OPTIONS=CFLAGS=-D_FILE_OFFSET_BITS=64
 
 package=xfsdump

Florian

Message #44 received at 837581@bugs.debian.org (full text, mbox, reply):

From: Florian Schlichting <fsfs@debian.org>

To: 837581@bugs.debian.org

Subject: xfsdump: diff for NMU version 3.1.6+nmu2

Date: Sun, 26 Feb 2017 14:49:04 +0100

[Message part 1 (text/plain, inline)]

Control: tags 837581 + patch
Control: tags 837581 + pending

Dear maintainer,

I've prepared an NMU for xfsdump (versioned as 3.1.6+nmu2) and
uploaded it to DELAYED/2. Please feel free to tell me if I
should delay it longer.

Regards.
Florian

[xfsdump-3.1.6+nmu2-nmu.diff (text/x-diff, attachment)]

Message #53 received at 837581-close@bugs.debian.org (full text, mbox, reply):

From: Florian Schlichting <fsfs@debian.org>

To: 837581-close@bugs.debian.org

Subject: Bug#837581: fixed in xfsdump 3.1.6+nmu2

Date: Tue, 28 Feb 2017 14:54:51 +0000

Source: xfsdump
Source-Version: 3.1.6+nmu2

We believe that the bug you reported is fixed in the latest version of
xfsdump, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 837581@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Florian Schlichting <fsfs@debian.org> (supplier of updated xfsdump package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 25 Feb 2017 19:47:46 +0100
Source: xfsdump
Binary: xfsdump
Architecture: source amd64
Version: 3.1.6+nmu2
Distribution: unstable
Urgency: medium
Maintainer: Nathan Scott <nathans@debian.org>
Changed-By: Florian Schlichting <fsfs@debian.org>
Description:
 xfsdump    - Administrative utilities for the XFS filesystem
Closes: 837581
Changes:
 xfsdump (3.1.6+nmu2) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * Set -D_FILE_OFFSET_BITS=64 in configure, where the value from
     include/builddefs.in is not yet active. This fixes the xfs.h test on 32bit
     systems (closes: #837581)
Checksums-Sha1:
 35438480ad65268825518bb70e6f0cc80757d738 1618 xfsdump_3.1.6+nmu2.dsc
 f5da073d88e07416d10e54b30edb7724c137c000 854590 xfsdump_3.1.6+nmu2.tar.gz
 9e3aa13c0247861e0f3f0cb60e35fe7b87cf9905 639062 xfsdump-dbgsym_3.1.6+nmu2_amd64.deb
 6e9de4c0b2e5c490233b3e0a3ef59c66b204f5ae 5163 xfsdump_3.1.6+nmu2_amd64.buildinfo
 54863d5991319c73fa1a7b65b89c934db5d7fe1e 255048 xfsdump_3.1.6+nmu2_amd64.deb
Checksums-Sha256:
 48bdda4fde7fba3635e175fed71e678dcdcf035f3a788e9a8d46ba40864956b0 1618 xfsdump_3.1.6+nmu2.dsc
 b92e8cb7f8881414fb79ac5e745717515794e37344f2a4a43da26b620265f610 854590 xfsdump_3.1.6+nmu2.tar.gz
 b20ef9d8a54a6e10436c96b18b033d6397209153f86f4f7655c6322a4140c66c 639062 xfsdump-dbgsym_3.1.6+nmu2_amd64.deb
 db82c77bab6fe45d41672557be174f38135ef0c37d0482dc8d88af30f455772c 5163 xfsdump_3.1.6+nmu2_amd64.buildinfo
 3cb8aabaf280ba4b49822235c29a57edc9b83f285f4fc64643cd8ff0194c92ba 255048 xfsdump_3.1.6+nmu2_amd64.deb
Files:
 cbe4dce6509d7cd8a1a7710165e9d02b 1618 admin optional xfsdump_3.1.6+nmu2.dsc
 ec58d6169a257b48622a1325a23d22d8 854590 admin optional xfsdump_3.1.6+nmu2.tar.gz
 26c52c48b1ee6c172a7f0b76ab60587d 639062 debug extra xfsdump-dbgsym_3.1.6+nmu2_amd64.deb
 09045406330b237dd3ad295bb954fe40 5163 admin optional xfsdump_3.1.6+nmu2_amd64.buildinfo
 82b57053e0bcefc3fe75e96f07ec4689 255048 admin optional xfsdump_3.1.6+nmu2_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEMLI8i05qOwnqprZSEpc7bnLcB7UFAliy2moACgkQEpc7bnLc
B7XrIg/8Co5sPDPzFviapbATynyO/166DBvgwdggk2KstOjwWnTnIEZ8uiu52lE/
4ihQeW4mPYc4DoP/k0A1BqYqRybiJnxz975BpVIESgX5Vq+lS1mbu6m8QC+Du8rC
XZ3eSZW2CjZruoEhvz8hAXxWCKLt/tbwn5EyB26LEdCd93XdNJK2tPQfTYcaVMlF
GBtSG9b6SH2jfC8scJmrY8bowk10HboeQA1/jbLBwiQ4rFJIAXqHLDi6d6xF/CSO
tPYAR7c9pnzlD6UDeksvw8to/J28wNbhKLZSHgBD9tRgP0K1AWRXwYmCpYLgbXIf
DUfS0cXQDTNgQCmpc46a455uw1El9SDP15TKViBlhCxYZUGL9Pl8E0SbJ9hkznAj
SfwXJN6BPnzGD3PLyvlll4w2eTdNGkCW9jpMrKLtqpnjmq63vVUZR9ku6vIB1E/L
hXz3f4Q5Eoo3UTVW75y5bpv/KaKGpLs8+UQcK2AkFf89avl51QQ24eCfT47whDCq
ScNCsmPITAX8bUwu2CaR11wcN57HKoVbWyamcDgCk1Pg9xghftg081wW47KIAEIm
aE8w4RrK8TuAzg1nOybipWd0W8+Nxkxh0kJgd47S4dqenQ+64LzuSh1nBik/OHvk
KVnCcWBU9tluOj3HUtkM3OA/7tOHvPBKlPZV0Lluhrt9zv53mFE=
=qPHJ
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.