Debian Bug report logs - #836699
Add dh --with-indep, for sequence addons pulled in through Build-Depends-Indep

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Anders Kaseorg <andersk@mit.edu>

To: submit@bugs.debian.org

Subject: Add dh --with-indep, for sequence addons pulled in through Build-Depends-Indep

Date: Sun, 4 Sep 2016 15:57:55 -0400 (EDT)

Package: debhelper
Version: 9.20160814

It would be useful to have dh $@ --with-indep ADDON, an analogue of dh $@ 
--with ADDON that only loads the addon when Architecture: all packages are 
being built.

See https://bugs.debian.org/818115 for the full background, but the 
summary is that the multiarch interpreter problem prevents python-sphinx 
from satisfying build dependencies for cross builds, so it must used only 
for building Architecture: all packages and pulled in through 
Build-Depends-Indep: python-sphinx.  That means the sphinxdoc sequence 
addon cannot be used as dh $@ --with sphinxdoc, unless 
Debhelper::Sequence::sphinxdoc is pulled in separately through

  Build-Depends-Indep: python-sphinx
  Build-Depends: sphinx-common

or the rules file goes through other contortions such as

  %-arch:
          dh $@
  %:
          dh $@ --with sphinxdoc

Because of this complexity, the doxygen maintainer has been reluctant to 
provide a corresponding doxygen sequence addon, and instead requires 
dh_doxygen to be called in an override target for specific packages 
(https://bugs.debian.org/799543).

If we could write

  %:
          dh $@ --with-indep sphinxdoc

such that dh_sphinxdoc -i is called after dh_installdocs when 
Architecture: all packages are built, and Debhelper::Sequence::sphinxdoc 
is not loaded when they are not, the complexity would be alleviated.

Anders

Message #12 received at 836699@bugs.debian.org (full text, mbox, reply):

From: Niels Thykier <niels@thykier.net>

To: 836699@bugs.debian.org, Anders Kaseorg <andersk@mit.edu>

Cc: Helmut Grohne <helmut@subdivi.de>

Subject: Re: Add dh --with-indep, for sequence addons pulled in through Build-Depends-Indep

Date: Sun, 07 Jan 2018 18:45:00 +0000

On Sun, 4 Sep 2016 15:57:55 -0400 (EDT) Anders Kaseorg <andersk@mit.edu>
wrote:
> Package: debhelper
> Version: 9.20160814
> 
> It would be useful to have dh $@ --with-indep ADDON, an analogue of dh $@ 
> --with ADDON that only loads the addon when Architecture: all packages are 
> being built.
> 
> [...]
> 
> Anders
> 
> 

Hi,

I learned earlier today that it is possible to implement this via make.
The following snippet is from file's d/rules file:

"""
> %:
> 	dh $@ $(DH_ADDONS)
> binary-arch build-arch install-arch: DH_ADDONS=--with autoreconf
> binary-indep build-indep install-indep: DH_ADDONS=--with python2,python3
> binary build install: DH_ADDONS=--with autoreconf,python2,python3
"""

(If it is any help, remember that dh accepts multiple --with parameters,
which might be useful in simplifying your case)



I admit it is not as simple or trivial as the thing you requested, but
it is available now (and backportable).

Thanks,
~Niels

Message #19 received at 836699@bugs.debian.org (full text, mbox, reply):

From: Niels Thykier <niels@thykier.net>

To: 836699@bugs.debian.org, Anders Kaseorg <andersk@mit.edu>, Helmut Grohne <helmut@subdivi.de>, "Paul R. Tagliamonte" <paultag@gmail.com>

Subject: Re: Add dh --with-indep, for sequence addons pulled in through Build-Depends-Indep

Date: Wed, 14 Aug 2019 12:03:00 +0000

Control: tags -1 patch

On Sun, 07 Jan 2018 18:45:00 +0000 Niels Thykier <niels@thykier.net> wrote:
> On Sun, 4 Sep 2016 15:57:55 -0400 (EDT) Anders Kaseorg <andersk@mit.edu>
> wrote:
> > Package: debhelper
> > Version: 9.20160814
> > 
> > It would be useful to have dh $@ --with-indep ADDON, an analogue of dh $@ 
> > --with ADDON that only loads the addon when Architecture: all packages are 
> > being built.
> > 
> > [...]
> > 
> > Anders
> > 
> > 
> 
> [...]

Hi,

An update on this (Helmut and Paul already heard some of this on IRC
yesterday).  I have written a possible solution to this problem in the
form of the following branch:

 * https://salsa.debian.org/debian/debhelper/tree/sequence-with-indep

I am hoping for testing/feedback on this before I merge it.

 => Notably, does this resolve your issues/needs in this area?




# From a add-on provider's perspective

Ensure the package that containing the add-on provides the
pseudo-package "dh-sequence-ADDON" where ADDON is the name of the
sequence add-on.  E.g. "dh-sequence-sphinxdoc" for sphinx.

The addon will be restricted to only adding commands and only when it
happens in the relevant sequence (*-indep for Build-Depends-Indep).
This is to ensure that the result is deterministic.  A notably
restriction is that it *cannot* alter the clean target (as the sequence
is not guaranteed to be available during clean as it is not an -indep
target).




# From a user/packager's perspective:

Use the dh-sequence-ADDON solely in Build-Depends-Indep.  Concrete
example being:

  Build-Depends-Indep: dh-sequence-sphinxdoc


Note that this can be combined with build-profiles a la:

  Build-Depends-Indep: dh-sequence-sphinxdoc <!nodocs>

Or

  Build-Depends-Indep: dh-sequence-dhpython <!nopython>
  (Ditto for Build-Depends)

(Subject to spelling mistakes; I did not double check all the names)



# How come this and not --with-indep

We already supported dh-sequarence-ADDON in Build-Depends (admittedly it
is fairly new).  Adding Build-Depends-Indep is a reasonably declarative
and DRY to request a sequence only during -indep targets.  Furthermore,
it can also naturally support build-profiles and other optional
build-dependency markers without having the packager duplicate the logic
in d/rules (this has been done in the branch as well).

The downside is sphinxdoc and doxygen will need an upload to add a
provides for their sequence.  I think this is acceptable (in
particularly because doxygen will need an upload anyway to make
dh_doxygen work in this case any way as I understand #799543)


# End remarks

The Build-profile support can most likely be "extracted" and applied to
debhelper master *without* the rest if the other parts are not relevant.
 Though I am only considering this if we believe that the proposed
approach for handling indep-only add-on sequences is flawed or if the
work on this drags on.


Thanks,
~Niels

Message #28 received at 836699-close@bugs.debian.org (full text, mbox, reply):

From: Niels Thykier <niels@thykier.net>

To: 836699-close@bugs.debian.org

Subject: Bug#836699: fixed in debhelper 12.5

Date: Sat, 17 Aug 2019 11:04:52 +0000

Source: debhelper
Source-Version: 12.5

We believe that the bug you reported is fixed in the latest version of
debhelper, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 836699@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Niels Thykier <niels@thykier.net> (supplier of updated debhelper package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 17 Aug 2019 10:54:08 +0000
Source: debhelper
Architecture: source
Version: 12.5
Distribution: unstable
Urgency: medium
Maintainer: Debhelper Maintainers <debhelper@packages.debian.org>
Changed-By: Niels Thykier <niels@thykier.net>
Closes: 836699 907061 934889 934891
Changes:
 debhelper (12.5) unstable; urgency=medium
 .
   [ Niels Thykier ]
   * dh_strip: Skip stripping of guile-2.2 files by skipping all
     all files matching "/guile/.*\.go$".  Thanks to Jeremy Bicha
     and Rob Browning.  (Closes: #907061)
   * dh_auto_*: Officially adopt --sourcedir and --builddir as official
     parameters.  They have always worked since debhelper defaulted to
     supporting auto-abbreviated parameters, so this is simply documenting
     fait accompli for the most common abbreviation.
   * dh_*: Disable auto-abbreviation of command line parameters in compat
     13.
   * dh: Optimize out redundant helpers even when passed long options in
     compat 13.
   * dh_builddeb: Remove --destdir.  It has never been useful as everyone
     excepts the debs to be placed in "..".
   * Dh_Lib.pm: Add a hint to resolve the error caused by having the
     compat level specified both as a build-dependency and in
     debian/compat.  Thanks to Alessandro Grassi for reporting the issue
     on IRC.
   * dh_makeshlibs: Fix bug where --no-add-udeb could trigger the
     auto-detection code.  (Closes: #934891)
   * dh_makeshlibs: When using the auto-detection of udeb, automatically
     exclude "udeb:" lines for libraries omitted from the udeb.  At the
     same time, verbosely fail if the udeb contains a library not present
     in the deb (overridable with --add-udeb).  (Closes: #934889)
   * dh: Support making "dh-sequence-ADDON" Build-Depends relation
     conditional on build-profiles (etc.).  If the relation is ignored due
     to the current build-profiles (etc.), then addon is silently skipped.
   * dh: Support running addons in "arch-only" or "indep-only" mode by
     adding "dh-sequence-ADDON" in Build-Depends-Arch or
     Build-Depends-Indep (respectively).  Not all addons support this and
     will trigger an error at load time.  Addon providers should ensure
     that their package provde "dh-sequence-ADDON" and review the
     doc/PROGRAMMING document (in the debhelper source) if they are
     considering to make their addon compatible with these requirements.
     (Closes: #836699)
   * dh,elf_tools.pm: Extract the ELF related debhelper tools (dh_strip,
     dh_dwz, dh_makeshlibs, dh_shlibdeps) into their own addon called
     "elf-tools" enabled by the default.
   * debian/control: Provide dh-sequence-elf-tools.
   * dh: In compat 13, the "elf-tools" addon is considered an implicit
     "arch-only" addon (i.e. they are only available in "-arch" sequences
     and are always passed a "-a").  If you need the ELF tools for arch:all
     packages, please add an explicit Builds-Depends on dh-sequence-elf-tools.
 .
   [ Frank Schaefer ]
   * dh_installmodules: Also look for compressed kernel modules
     in addition to uncompressed kernel modules (gz, bz2 or xz).
 .
   [ Adam Borowski ]
   * d/s/lintian-overrides: Override lintian warning about debhelper
     not using debhelper.
Checksums-Sha1:
 1e788d83f228b1e6036fa8bdeb14a67ddb93a900 1706 debhelper_12.5.dsc
 9f5bf39bd8168c95f7c1a465eb8b693d4403e2e0 499340 debhelper_12.5.tar.xz
 adc5df29c6da442085b72a4c9fefaa79a7fac59a 4461 debhelper_12.5_source.buildinfo
Checksums-Sha256:
 ff33e48bbed7871b330285a1f60236be970a91619f6f78d63a1b46154b808f0b 1706 debhelper_12.5.dsc
 ec7570ce1b1cd7007403505babcf9b66710231bdf35a0348dc69a8aa41f6d765 499340 debhelper_12.5.tar.xz
 37fec0d2b47221838beee963210ab80f6cd9520a5d3e0a9a3be82f05dafdf96f 4461 debhelper_12.5_source.buildinfo
Files:
 8ff4d3018b8b5a6c9f5718e6d10a079d 1706 devel optional debhelper_12.5.dsc
 fcd0ff36ded195fd362868d4679064af 499340 devel optional debhelper_12.5.tar.xz
 0a2289652f3c046b45c7d00d3d5e8a19 4461 devel optional debhelper_12.5_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJGBAEBCgAwFiEE8f9dDX4ALfD+VfsMplt42+Z8eqwFAl1X3QUSHG5pZWxzQHRo
eWtpZXIubmV0AAoJEKZbeNvmfHqs1U8P/2lxs27cVkdG/RM4xvJU2igi3InkgbLa
E6zWikIFBteEnwZzem67/nn0qq+XbRgJrL7wmS7ucGI+kvrBm/naHldqp258BJ8o
0P40LmBZKi1pneoBNbpi6A+ZzYr68L1smgIH1fiTXKF9hkrffXd9DqO/FEYmv1VH
hNaQzp6j1SHIqYVmzo/jUoqaJs0MyuhPbvlMAIUyaxemsc+/DkEEPU6AKCpkzZzH
YkZn/XSYolDmC/x/MsIRow/9TELfu81OastHZo0fpy1cN1iLIySGXjWUsMhtEBXf
6mvuLPzFWb0qCcP2vuZtqjSdPeSSQs86KuKUeYVJ6GQHT80lF/y9UnF2MgNEaGIF
8N7imUmwSOecmUXTIbVaSennCo0koHLR+JBK5+omhpkV41hb93bkBRga/jQqOdLz
mm/Bf7xNZ64KcHtZsD9KJ0L3rOQhgwCuO8wNggUAXOAOZZs7iIDwnJdnI/2jHYz/
QoncG0fRSLK7C17L7W0bSmJiPrNcJbktvo8NUc6IRfjv/bxtUVdH4muCePlkHkwE
l5Nqx7RoJXihyrTXacQlR3LAGLLVHWPo7S1SNsyo0oAV2+EBy2ijfOH8UcKdr5kY
E6iQCNhJa3YDjwupiaEJUzGMjaDj+I19vHNkNjAaCoqtOQOseSPYLb+UVhwQfnl4
mOvl9dz8Tm2b
=QBQM
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.