Debian Bug report logs - #836285
pcp: please use dbus-run-session, or dbus-daemon directly, in tests

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at maintonly@bugs.debian.org (full text, mbox, reply):

From: Simon McVittie <smcv@debian.org>

To: maintonly@bugs.debian.org

Subject: pcp: please use dbus-run-session, or dbus-daemon directly, in tests

Date: Thu, 1 Sep 2016 12:27:53 +0100

Source: pcp
Version: 3.11.3.1
Severity: normal
Tags: upstream
User: dbus@packages.debian.org
Usertags: dbus-launch dbus-launch-for-tests

As described in <https://lists.debian.org/debian-devel/2016/08/msg00554.html>
I'm trying to reduce how much dbus-launch is used in Debian.
This package currently uses dbus-launch if it exists (without a dependency
on dbus-x11, so it is not guaranteed to exist) in what appear to be some
sort of regression tests, in "./qa/common.qt".

This is really an upstream issue, and I'm not sure whether these tests are
even run in Debian.

This Flatpak commit illustrates how (the equivalent of) eval `dbus-launch`
can be replaced by invoking dbus-daemon directly, avoiding the X11-specific
and semi-deprecated dbus-launch executable:
<https://github.com/flatpak/flatpak/commit/6cc8062cfb3f9410d54a27e7ccca77c103e441e8>.

Alternatively, the test executable could be run through
dbus-run-session(1), which is available since dbus 1.8, the upstream
"old stable" branch available since early 2014, and currently the
oldest branch with security support:

    dbus-run-session -- some-test

That would allow removal of all the special code to start and stop
the dbus-daemon.

Thanks,
    S

Message #10 received at 836285-maintonly@bugs.debian.org (full text, mbox, reply):

From: Ken McDonell <kenj@internode.on.net>

To: Simon McVittie <smcv@debian.org>, 836285-maintonly@bugs.debian.org, maintonly@bugs.debian.org

Cc: PCP <pcp@oss.sgi.com>

Subject: Re: [pcp] Bug#836285: pcp: please use dbus-run-session, or dbus-daemon directly, in tests

Date: Sat, 3 Sep 2016 07:35:22 +1000

On 01/09/16 21:27, Simon McVittie wrote:
> Source: pcp
> Version: 3.11.3.1
> Severity: normal
> Tags: upstream
> User: dbus@packages.debian.org
> Usertags: dbus-launch dbus-launch-for-tests
>
> As described in <https://lists.debian.org/debian-devel/2016/08/msg00554.html>
> I'm trying to reduce how much dbus-launch is used in Debian.
> This package currently uses dbus-launch if it exists (without a dependency
> on dbus-x11, so it is not guaranteed to exist) in what appear to be some
> sort of regression tests, in "./qa/common.qt".

Thanks for this Simon.

I've removed references to dbus-launch in the PCP qa/common.qt file and 
replaced this with a variant of the "flatpack" change.

After local QA this will flow upstream to the official PCP repository.

Send a report that this bug log contains spam.