Debian Bug report logs - #835887
gnome-session: don't run dbus-launch if XDG_RUNTIME_DIR/bus is available

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at maintonly@bugs.debian.org (full text, mbox, reply):

From: Simon McVittie <smcv@debian.org>

To: maintonly@bugs.debian.org

Subject: gnome-session: don't run dbus-launch if XDG_RUNTIME_DIR/bus is available

Date: Mon, 29 Aug 2016 01:52:07 +0100

Source: gnome-session
Version: 3.20.2-1
Severity: normal
Tags: upstream
User: dbus@packages.debian.org
Usertags: dbus-launch dbus-launch-unless-dsba

As described in <https://lists.debian.org/debian-devel/2016/08/msg00554.html>
I'm trying to reduce how much dbus-launch is used in Debian.
gnome-session has code that explicitly runs dbus-launch if
DBUS_SESSION_BUS_ADDRESS isn't set.

The major D-Bus implementations (libdbus, GDBus, sd-bus) now have a
fallback code path, before trying X11 autolaunch, when
DBUS_SESSION_BUS_ADDRESS is unset: if XDG_RUNTIME_DIR is set, and
XDG_RUNTIME_DIR/bus exists, is a socket and is owned by the
process's uid, then they will use it. In particular, dbus-user-session
sets up that situation.

For the moment, dbus-user-session does make sure DBUS_SESSION_BUS_ADDRESS
is set, to be nice to packages that don't have this fallback path.
However, I'd like to avoid requiring that in future, by adapting
the dbus-launch code in gnome-session and its forks to look for
XDG_RUNTIME_DIR/bus before trying dbus-launch.

I'll open an upstream bug after doing this MBF.

Thanks,
    S

Message #10 received at 835887@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <biebl@debian.org>

To: 835887@bugs.debian.org, Simon McVittie <smcv@debian.org>

Subject: Re: gnome-session: don't run dbus-launch if XDG_RUNTIME_DIR/bus is available

Date: Sat, 10 Sep 2016 05:57:58 +0200

[Message part 1 (text/plain, inline)]

Hi Simon

On Mon, 29 Aug 2016 01:52:07 +0100 Simon McVittie <smcv@debian.org> wrote:
> For the moment, dbus-user-session does make sure DBUS_SESSION_BUS_ADDRESS
> is set, to be nice to packages that don't have this fallback path.
> However, I'd like to avoid requiring that in future, by adapting
> the dbus-launch code in gnome-session and its forks to look for
> XDG_RUNTIME_DIR/bus before trying dbus-launch.
> 
> I'll open an upstream bug after doing this MBF.

Have you filed such a bugreport in the mean time?

Regards,
Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

[signature.asc (application/pgp-signature, attachment)]

Message #15 received at 835887@bugs.debian.org (full text, mbox, reply):

From: Simon McVittie <smcv@debian.org>

To: Michael Biebl <biebl@debian.org>

Cc: 835887@bugs.debian.org

Subject: Re: gnome-session: don't run dbus-launch if XDG_RUNTIME_DIR/bus is available

Date: Sat, 10 Sep 2016 08:53:22 +0100

Control: forwarded 835887 https://bugzilla.gnome.org/show_bug.cgi?id=694472

On Sat, 10 Sep 2016 at 05:57:58 +0200, Michael Biebl wrote:
> On Mon, 29 Aug 2016 01:52:07 +0100 Simon McVittie <smcv@debian.org> wrote:
> > I'll open an upstream bug after doing this MBF.
> 
> Have you filed such a bugreport in the mean time?

Thanks for the reminder. I've been preparing to move house, so following up
on this MBF hasn't been my top priority :-)

Turns out I opened an upstream bug 3.5 years ago, with a patch (which
isn't 100% right, but should be reasonably straightforward to adapt if
someone wants to pick it up).
<https://bugzilla.gnome.org/show_bug.cgi?id=694472>

Things that need fixing in that patch before it can be applied:
<https://bugzilla.gnome.org/show_bug.cgi?id=694472#c8>

    S

Send a report that this bug log contains spam.