Debian Bug report logs - #835447
libmodule-build-withxspp-perl: please make the output reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: submit@bugs.debian.org

Subject: libmodule-build-withxspp-perl: please make the output reproducible

Date: Thu, 25 Aug 2016 20:10:48 +0100

[Message part 1 (text/plain, inline)]

Source: libmodule-build-withxspp-perl
Version: 0.14-2
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: build-path
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], I noticed that
libmodule-build-withxspp-perl was causing packages to not build
reproducibly (eg. libboost-geometry-utils-perl).

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[libmodule-build-withxspp-perl.diff.txt (text/plain, attachment)]

Message #10 received at 835447@bugs.debian.org (full text, mbox, reply):

From: gregor herrmann <gregoa@debian.org>

To: Chris Lamb <lamby@debian.org>, 835447@bugs.debian.org

Subject: Re: Bug#835447: libmodule-build-withxspp-perl: please make the output reproducible

Date: Thu, 25 Aug 2016 21:18:53 +0200

[Message part 1 (text/plain, inline)]

On Thu, 25 Aug 2016 20:10:48 +0100, Chris Lamb wrote:

> Whilst working on the Reproducible Builds effort [0], I noticed that
> libmodule-build-withxspp-perl was causing packages to not build
> reproducibly (eg. libboost-geometry-utils-perl).
> 
> Patch attached.

The patch lacks headers or a commit message :)
For forwarding it upstream it would be good to have a description of
the problem and the solution.
 
> @@ -228,11 +229,11 @@ MODULE = $module_name	PACKAGE = $module_name
>  HERE
>  
>    my $typemap_args = '';
> -  $typemap_args .= '-t "' . _naive_shell_escape(Cwd::abs_path($_)) . '" ' foreach keys %$xspt_files;
> +  $typemap_args .= '-t "' . _naive_shell_escape(File::Spec->abs2rel($_, $this->build_dir)) . '" ' foreach keys %$xspt_files;
>  
>    foreach my $xsp_file (keys %$xsp_files) {
> -    my $full_path_file = _naive_shell_escape( Cwd::abs_path($xsp_file) );
> -    my $cmd = qq{INCLUDE_COMMAND: \$^X -MExtUtils::XSpp::Cmd -e xspp -- $typemap_args "$full_path_file"\n\n};
> +    my $relative_path_file = _naive_shell_escape( File::Spec->abs2rel($xsp_file, $this->build_dir) );
> +    my $cmd = qq{INCLUDE_COMMAND: \$^X -MExtUtils::XSpp::Cmd -e xspp -- $typemap_args "$relative_path_file"\n\n};
>      $xs_code .= $cmd;
>    }

I assume the problem that the full (and thereby arbitrary/random)
path is includeded/used somewhere and your patch changes this to a
path relative to the build directory. Is this correct?  


Cheers,
gregor

-- 
 .''`.  Homepage https://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer -  https://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Aimee Mann: Red Vines

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 835447@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: gregor herrmann <gregoa@debian.org>, 835447@bugs.debian.org

Subject: Re: Bug#835447: libmodule-build-withxspp-perl: please make the output reproducible

Date: Thu, 25 Aug 2016 20:37:23 +0100

Hi gregor,

> I assume the problem that the full (and thereby arbitrary/random)
> path is includeded/used somewhere and your patch changes this to a
> path relative to the build directory.

Exactly. The call to Cwd::abs_path introduces the build directory into
target:

  http://i.imgur.com/IYdackI.jpg

There's a fair amount of indirection going on here as the INCLUDE_COMMAND
is actually executed later on in the build.

Simply dropping the abs_path call would not work as the typemap files are
not present within the build directory when XS actually evaluates the line.

Hope that helps.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #20 received at 835447@bugs.debian.org (full text, mbox, reply):

From: gregor herrmann <gregoa@debian.org>

To: Chris Lamb <lamby@debian.org>

Cc: 835447@bugs.debian.org

Subject: Re: Bug#835447: libmodule-build-withxspp-perl: please make the output reproducible

Date: Fri, 26 Aug 2016 20:05:19 +0200

[Message part 1 (text/plain, inline)]

On Thu, 25 Aug 2016 20:37:23 +0100, Chris Lamb wrote:

> > I assume the problem that the full (and thereby arbitrary/random)
> > path is includeded/used somewhere and your patch changes this to a
> > path relative to the build directory.
> 
> Exactly. The call to Cwd::abs_path introduces the build directory into
> target:
> 
>   http://i.imgur.com/IYdackI.jpg

[..]
 
> Hope that helps.

It does, thanks :)


Patch applied and ...

... and then the package doesn't build for me, the tests fail with:

   dh_auto_test
    perl Build test --verbose 1

#   Failed test 'use Module::Build::WithXSpp;'
#   at t/001_load.t line 6.
#     Tried to use 'Module::Build::WithXSpp'.
#     Error:  Global symbol "$this" requires explicit package name (did you forget to declare "my $this"?) at /build/libmodule-build-withxspp-perl-0.14/blib/lib/Module/Build/WithXSpp.pm line 232.
# Global symbol "$this" requires explicit package name (did you forget to declare "my $this"?) at /build/libmodule-build-withxspp-perl-0.14/blib/lib/Module/Build/WithXSpp.pm line 235.
# Compilation failed in require at t/001_load.t line 6.
# BEGIN failed--compilation aborted at t/001_load.t line 6.
# Looks like you failed 1 test of 1.
t/001_load.t .. 
1..1
not ok 1 - use Module::Build::WithXSpp;
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests 

Test Summary Report
-------------------
t/001_load.t (Wstat: 256 Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
Files=1, Tests=1,  0 wallclock secs ( 0.01 usr  0.01 sys +  0.09 cusr  0.00 csys =  0.11 CPU)
Result: FAIL
Failed 1/1 test programs. 1/1 subtests failed.




Cheers,
gregor

-- 
 .''`.  Homepage https://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer -  https://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Status Quo: Ol Rag Blues

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 835447@bugs.debian.org (full text, mbox, reply):

From: pkg-perl-maintainers@lists.alioth.debian.org

To: 835447@bugs.debian.org, 835447-submitter@bugs.debian.org

Subject: Pending fixes for bugs in the libmodule-build-withxspp-perl package

Date: Fri, 26 Aug 2016 18:07:25 +0000

tag 835447 + pending
thanks

Some bugs in the libmodule-build-withxspp-perl package are closed in
revision 6b58431ff197857eae8737009712d2c31586e709 in branch 'master'
by gregor herrmann

The full diff can be seen at
https://anonscm.debian.org/cgit/pkg-perl/packages/libmodule-build-withxspp-perl.git/commit/?id=6b58431

Commit message:

    Add patch to make output reproducible.
    
    Thanks: Chris Lamb <lamby@debian.org> for the bug report and the patch.
    Closes: #835447

Message #33 received at 835447@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: gregor herrmann <gregoa@debian.org>

Cc: 835447@bugs.debian.org

Subject: Re: Bug#835447: libmodule-build-withxspp-perl: please make the output reproducible

Date: Sat, 27 Aug 2016 11:34:18 +0100

[Message part 1 (text/plain, inline)]

gregor herrmann wrote:

> Patch applied and ...
> 
> ... and then the package doesn't build for me, the tests fail with:

My sincere apologies; I tidied the patch prior to sending and made a stupid
typo. An apdated —  tested — patch is attached.

If it helps, interdiff is just /$this/$self/.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[reproducible-output.patch (text/x-patch, attachment)]

Message #38 received at 835447@bugs.debian.org (full text, mbox, reply):

From: gregor herrmann <gregoa@debian.org>

To: Chris Lamb <lamby@debian.org>

Cc: 835447@bugs.debian.org

Subject: Re: Bug#835447: libmodule-build-withxspp-perl: please make the output reproducible

Date: Sat, 27 Aug 2016 13:19:35 +0200

[Message part 1 (text/plain, inline)]

On Sat, 27 Aug 2016 11:34:18 +0100, Chris Lamb wrote:

> > Patch applied and ...
> > ... and then the package doesn't build for me, the tests fail with:
> My sincere apologies; I tidied the patch prior to sending and made a stupid
> typo. An apdated —  tested — patch is attached.

No worries, and thanks for the quick update.
 
> If it helps, interdiff is just /$this/$self/.

Oh, right, I could have spotted this myself.
 

Now really forwarded upstream and uploaded.


Cheers,
gregor

-- 
 .''`.  Homepage https://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer -  https://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: The Who: Who Are You

[signature.asc (application/pgp-signature, inline)]

Message #43 received at 835447-close@bugs.debian.org (full text, mbox, reply):

From: gregor herrmann <gregoa@debian.org>

To: 835447-close@bugs.debian.org

Subject: Bug#835447: fixed in libmodule-build-withxspp-perl 0.14-3

Date: Sat, 27 Aug 2016 11:19:59 +0000

Source: libmodule-build-withxspp-perl
Source-Version: 0.14-3

We believe that the bug you reported is fixed in the latest version of
libmodule-build-withxspp-perl, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 835447@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
gregor herrmann <gregoa@debian.org> (supplier of updated libmodule-build-withxspp-perl package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 27 Aug 2016 13:17:32 +0200
Source: libmodule-build-withxspp-perl
Binary: libmodule-build-withxspp-perl
Architecture: source
Version: 0.14-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Perl Group <pkg-perl-maintainers@lists.alioth.debian.org>
Changed-By: gregor herrmann <gregoa@debian.org>
Closes: 835447
Description: 
 libmodule-build-withxspp-perl - XS++ enhanced flavour of Module::Build
Changes:
 libmodule-build-withxspp-perl (0.14-3) unstable; urgency=medium
 .
   * Team upload.
 .
   [ Salvatore Bonaccorso ]
   * debian/control: Use HTTPS transport protocol for Vcs-Git URI
 .
   [ gregor herrmann ]
   * debian/copyright: change Copyright-Format 1.0 URL to HTTPS.
   * Add patch to make output reproducible.
     Thanks to Chris Lamb for the bug report and the patch.
     (Closes: #835447)
   * Bump debhelper compatibility level to 9.
   * Declare compliance with Debian Policy 3.9.8.
Checksums-Sha1: 
 39570dac46d656d33239be6940ceab36fafb1474 2457 libmodule-build-withxspp-perl_0.14-3.dsc
 b9c8528d37cde79b15427f97a884899793606361 2696 libmodule-build-withxspp-perl_0.14-3.debian.tar.xz
Checksums-Sha256: 
 2469724fba9204d45c53ab977fde4ea4e5ee30c931694e61ff6b6e5be276c9c0 2457 libmodule-build-withxspp-perl_0.14-3.dsc
 138d6a131325bc20b91170949158ba87e613f7e8ee3fe9e41ebc5987eaf1470c 2696 libmodule-build-withxspp-perl_0.14-3.debian.tar.xz
Files: 
 cc4385090183c13cec01e7feef56cb36 2457 perl optional libmodule-build-withxspp-perl_0.14-3.dsc
 ec7eed30cea8914d0a856fef3a2d5b02 2696 perl optional libmodule-build-withxspp-perl_0.14-3.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQJ8BAEBCgBmBQJXwXcoXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREMUUxMzE2RTkzQTc2MEE4MTA0RDg1RkFC
QjNBNjgwMTg2NDlBQTA2AAoJELs6aAGGSaoG8T0P/2OewNia+rQShadTlZ3Lyr7W
RbLtM4kXcWjBZA/VnsPji7SYh3rSH4nDyaocVsAWLny3ftBRVwP5EhMA+MfB42Kl
Eu0IbLeoHc361XqHmK5nNiwmAf9N/Ph9Ej35ec8G6JYVg16cpdiyOHGf7hmirg8m
yrpZ4Hxb7hBRJN/6oQmoUNYfLJ0ysGZi+ou6yGFHRpe6IHzPRlpm5xc6KI4fxH6w
NXtKgxnhPkvSjRUHsvKSzFAfSvzcz45NimAF5o5JJZZizBqzbkLn033Q9ALI4tFw
9+e3uMNyedJOQxky9D4lOQJ8hpxMtOTmsGoO8CkB2qCmMueYmuXZ3BcDvywkmhWS
BEKdk/6MjSnzmNRoJ34Kni29jUdAmN8pDA9LQiperue4DSB/fllbBnrXcUeJGmaP
T0w5watIeEYP5F41l+5FDFMMPFsWy4XJjJZq2DLPQDw4iE8Ts5/783e06wG2dInS
0CcObV4N/Wqo++DEtDKS7Zn4LOBh9/VfzQqeWj6oFT49PvKkddgHeFhkjwn+fJ9m
afPWLf2/MFTGtnPpTE4WE8MnW7Nrvg2evAhN0c6uL+0PjyVduJfGHsTRqN8QlfuJ
7b4YFOkOgOX18B7r+3wASCKZeAfGZobUVd/SXYpWdtqZvt36OyK0MqvmzMtFlrqP
SWZVOOp4tTWoTijNqmXt
=RQbN
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.