Debian Bug report logs - #835371
dispcalgui: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: submit@bugs.debian.org

Subject: dispcalgui: please make the build reproducible

Date: Wed, 24 Aug 2016 23:36:40 +0100

[Message part 1 (text/plain, inline)]

Source: dispcalgui
Version: 3.1.5.0-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], I noticed
that dispcalgui could not be built reproducibly.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[dispcalgui.diff.txt (text/plain, attachment)]

Message #10 received at 835371@bugs.debian.org (full text, mbox, reply):

From: Florian Höch <fh@hoech.net>

To: 835371@bugs.debian.org

Subject: Re: dispcalgui: please make the build reproducible

Date: Fri, 26 Aug 2016 15:09:37 +0200

I'm a bit befuddled by this:

Since DisplayCAL 3.1.5, the 'lastmod_time' variable is populated from
the value recorded statically in the file DisplayCAL/__version__.py that
is part of the source archive, so the build is (and was) reproducible
already [1], and the patch was unneeded. I see that the current build of
DisplayCAL 3.1.6 is not reproducible in Debian testing, and the reason
for this appears to be that the build does not use the pristine sources
(probably the unneeded patch is being applied?).

So TLDR: Use the unmodified sources and all will be well.

[1]
http://download.opensuse.org/repositories/home:/fhoech/Debian_8.0/amd64/
http://download.opensuse.org/repositories/home:/fhoech:/testing/Debian_8.0/amd64/

Message #15 received at 835371@bugs.debian.org (full text, mbox, reply):

From: Christian Marillat <marillat@free.fr>

To: Florian Höch <fh@hoech.net>

Cc: 835371@bugs.debian.org

Subject: Re: Bug#835371: dispcalgui: please make the build reproducible

Date: Mon, 29 Aug 2016 14:56:48 +0200

On 26 août 2016 15:09, Florian Höch <fh@hoech.net> wrote:

> I'm a bit befuddled by this:
>
> Since DisplayCAL 3.1.5, the 'lastmod_time' variable is populated from
> the value recorded statically in the file DisplayCAL/__version__.py that
> is part of the source archive, so the build is (and was) reproducible
> already [1], and the patch was unneeded. I see that the current build of
> DisplayCAL 3.1.6 is not reproducible in Debian testing, and the reason
> for this appears to be that the build does not use the pristine sources
> (probably the unneeded patch is being applied?).
>
> So TLDR: Use the unmodified sources and all will be well.

You are really sure ?

Christian

Message #20 received at 835371@bugs.debian.org (full text, mbox, reply):

From: Florian Höch <fh@hoech.net>

To: Christian Marillat <marillat@free.fr>

Cc: 835371@bugs.debian.org

Subject: Re: Bug#835371: dispcalgui: please make the build reproducible

Date: Mon, 29 Aug 2016 15:24:40 +0200

Am 29.08.2016 um 14:56 schrieb Christian Marillat:
> You are really sure ?

All the patch seems to do in essence is use a different static timestamp
value, which for all intents and purposes is fine, it just looks redundant.

Message #25 received at 835371@bugs.debian.org (full text, mbox, reply):

From: Christian Marillat <marillat@free.fr>

To: Florian Höch <fh@hoech.net>

Cc: 835371@bugs.debian.org

Subject: Re: Bug#835371: dispcalgui: please make the build reproducible

Date: Mon, 29 Aug 2016 15:38:48 +0200

On 29 août 2016 15:24, Florian Höch <fh@hoech.net> wrote:

> Am 29.08.2016 um 14:56 schrieb Christian Marillat:
>> You are really sure ?
>
> All the patch seems to do in essence is use a different static timestamp
> value, which for all intents and purposes is fine, it just looks redundant.

OK, I've removed this patch. No new upload, I'm waiting for the next
upstream release.

Christian

Message #30 received at 835371-close@bugs.debian.org (full text, mbox, reply):

From: Christian Marillat <marillat@debian.org>

To: 835371-close@bugs.debian.org

Subject: Bug#835371: fixed in dispcalgui 3.1.6.0-2

Date: Wed, 31 Aug 2016 16:21:21 +0000

Source: dispcalgui
Source-Version: 3.1.6.0-2

We believe that the bug you reported is fixed in the latest version of
dispcalgui, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 835371@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christian Marillat <marillat@debian.org> (supplier of updated dispcalgui package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 31 Aug 2016 17:13:03 +0200
Source: dispcalgui
Binary: dispcalgui
Architecture: source i386
Version: 3.1.6.0-2
Distribution: unstable
Urgency: medium
Maintainer: Christian Marillat <marillat@debian.org>
Changed-By: Christian Marillat <marillat@debian.org>
Description:
 dispcalgui - Graphical user interface for the Argyll CMS.
Closes: 835371
Changes:
 dispcalgui (3.1.6.0-2) unstable; urgency=medium
 .
   * Remove (not needed) reproducible patch (Closes: #835371)
Checksums-Sha1:
 9a96fb77e2269befef2627a639d27edcdffa3af2 1830 dispcalgui_3.1.6.0-2.dsc
 c2158b0ca754e3d53d0f3447dc74ae6cd28efb18 8224 dispcalgui_3.1.6.0-2.debian.tar.xz
 a6fe0caa41723fcbad1bcca873b51d46aefe3ad1 18114 dispcalgui-dbgsym_3.1.6.0-2_i386.deb
 4c6914e86ebac42fbd4faa5de4668c5c85fb3a0d 6345052 dispcalgui_3.1.6.0-2_i386.deb
Checksums-Sha256:
 358f7ecb60ba65b751743c657f6c473ef06e989562043c7cf49363a7da0d6095 1830 dispcalgui_3.1.6.0-2.dsc
 8b07c61373fdc1606658d775b72620ca540a4ded74e3b43efc6f8faaceed2ba1 8224 dispcalgui_3.1.6.0-2.debian.tar.xz
 5d0cda7cc0306fd4830860a065c9753402d63d6c351997b91c7a331ca1516b4a 18114 dispcalgui-dbgsym_3.1.6.0-2_i386.deb
 d00896e8a5bfc2b661b8674e8d9363f67ba0c30e85b4f7a5b3c5fe2ea32da70a 6345052 dispcalgui_3.1.6.0-2_i386.deb
Files:
 1d5e37541684b7c768bf8415ce776e6d 1830 graphics extra dispcalgui_3.1.6.0-2.dsc
 363bc73e75c3d802bcd01078a7bdf104 8224 graphics extra dispcalgui_3.1.6.0-2.debian.tar.xz
 36bc4804ca67ab773736c047e6515be8 18114 debug extra dispcalgui-dbgsym_3.1.6.0-2_i386.deb
 f673b4c73df61e7b0aceb3a99412b437 6345052 graphics extra dispcalgui_3.1.6.0-2_i386.deb

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJXxvRPAAoJEFyAjCtlVYEX5b4P/1EAO9M9r6MxVX002iSZa+8z
VFoibIb6Pc7oPGJpb+l4THK5LADmMFKD6Q2rOhC2KXiR7FI1LoB6QZ5GpKJ4dTwh
03fWvwCTXJEMwAx/c5HLJrU63cyVibbz27nU4pA9It3yr+vroxQxI/yWco82onlF
0NIZJs9wEEvvI7Hk5xh7TSqO/TDmO2e/tADc+Pz+Vp3FukCUOqBBSwzrPwIeVj4Y
kl4/0jn5fdYkIeiSZsqbgEtPqzbAsTBBTL0qst6syvR3LhLWF/v6REuwz+KPdHRL
bcSxVL7iExEZFg6jZo4wklEQ4QgA6e00Q/tLi26FTvyJYD3bX1AlALxaNCOzTn76
YlrsQ7b8BCp8nK4+FW4sNUD5Vcm278O9cywd/+XkRbYMAQPe0+0Lhc+2EOB2GeNH
ba1aHYfHpbCm+KzWrMCa1UhrN0rqzJ0M4Xtm1vov5++IHGIhbFPpLbDPcbSC0yOx
I6fk2LRWlho+6ElqqT0kyx4sF0Q55XfP6r3YdNrxWqks+uvvf3ViwKPeBnIVVcda
YdVCch8511Rok7M2xIaB9w1onbtx1LKJ2A6zZddd/i/WQzJVxVjZro56UERZYhvF
toz5ZNStyXVg5WL3vwSt2YlwXWhvI/MdvlZNGCqSqQQhlKgyH22gDWHaGQiRyYwB
7Iin9VvrIjQPzUWZ0pLg
=Uuvo
-----END PGP SIGNATURE-----

Message #35 received at 835371@bugs.debian.org (full text, mbox, reply):

From: Florian Höch <fh@hoech.net>

To: Christian Marillat <marillat@free.fr>

Cc: 835371@bugs.debian.org

Subject: Re: Bug#835371: dispcalgui: please make the build reproducible

Date: Sat, 3 Sep 2016 14:48:19 +0200

[Message part 1 (text/plain, inline)]

Am 29.08.2016 um 15:38 schrieb Christian Marillat:
> OK, I've removed this patch. No new upload, I'm waiting for the next
> upstream release.

I see now what the problem is. I was using time.mktime() to convert the
static timestamp to seconds since epoch for insertion into the appdata
XML file, but mktime operates on local time, not UTC, so system timezone
and DST influenced the conversion. This wasn't intended, and the correct
thing to do for me is use calendar.timegm() instead which operates in
UTC. The reason it didn't show on OBS was probably because the build
bots ran in the same timezone. Patch attached, this will also be in the
next upstream release.

Florian.

[setup.py.time_utc.patch (text/plain, attachment)]

Send a report that this bug log contains spam.