Debian Bug report logs - #834988
twitter-bootstrap3: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: submit@bugs.debian.org

Subject: twitter-bootstrap3: please make the build reproducible

Date: Sun, 21 Aug 2016 11:56:56 +0100

[Message part 1 (text/plain, inline)]

Source: twitter-bootstrap3
Version: 3.3.6+dfsg-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], I noticed
that twitter-bootstrap3 could not be built reproducibly.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[twitter-bootstrap3.diff.txt (text/plain, attachment)]

Message #10 received at 834988@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 834988@bugs.debian.org

Subject: Re: Bug#834988: twitter-bootstrap3: please make the build reproducible

Date: Mon, 24 Oct 2016 06:42:07 +0100

Dear Maintainer,

> Source: twitter-bootstrap3
> Version: 3.3.6+dfsg-1
> Tags: patch

There hasn't seem to be any update on this bug in 63 days, in which
time the Reproducible Builds effort has come on a long way. :)

Would you consider applying this patch and uploading?


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #15 received at 834988@bugs.debian.org (full text, mbox, reply):

From: Antonio Terceiro <terceiro@debian.org>

To: Chris Lamb <lamby@debian.org>, 834988@bugs.debian.org

Subject: Re: Bug#834988: twitter-bootstrap3: please make the build reproducible

Date: Mon, 24 Oct 2016 10:46:39 -0200

[Message part 1 (text/plain, inline)]

On Mon, Oct 24, 2016 at 06:42:07AM +0100, Chris Lamb wrote:
> Dear Maintainer,
> 
> > Source: twitter-bootstrap3
> > Version: 3.3.6+dfsg-1
> > Tags: patch
> 
> There hasn't seem to be any update on this bug in 63 days, in which
> time the Reproducible Builds effort has come on a long way. :)
> 
> Would you consider applying this patch and uploading?

Unfortunately this patch does not fix the issue as the file it changes
is not actually used in the Debian build.

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 834988-close@bugs.debian.org (full text, mbox, reply):

From: Antonio Terceiro <terceiro@debian.org>

To: 834988-close@bugs.debian.org

Subject: Bug#834988: fixed in twitter-bootstrap3 3.3.7+dfsg-2

Date: Mon, 24 Oct 2016 13:07:58 +0000

Source: twitter-bootstrap3
Source-Version: 3.3.7+dfsg-2

We believe that the bug you reported is fixed in the latest version of
twitter-bootstrap3, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 834988@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Antonio Terceiro <terceiro@debian.org> (supplier of updated twitter-bootstrap3 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 24 Oct 2016 10:45:58 -0200
Source: twitter-bootstrap3
Binary: libjs-bootstrap
Architecture: source
Version: 3.3.7+dfsg-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Javascript Maintainers <pkg-javascript-devel@lists.alioth.debian.org>
Changed-By: Antonio Terceiro <terceiro@debian.org>
Description:
 libjs-bootstrap - HTML, CSS and JS framework
Closes: 834988
Changes:
 twitter-bootstrap3 (3.3.7+dfsg-2) unstable; urgency=medium
 .
   * Team upload
   * debian/upstream/changelog: update with changelog entries for 3.3.7
   * debian/rules: produce reproducible copyright message in
     dist/js/bootstrap3.js (Closes: #834988)
Checksums-Sha1:
 a584ff46bf766346e905acf6d2d468d19a07b0b5 2083 twitter-bootstrap3_3.3.7+dfsg-2.dsc
 09272cc25ef497ed546ada4b00606dd0ff36ddf7 50848 twitter-bootstrap3_3.3.7+dfsg-2.debian.tar.xz
Checksums-Sha256:
 dba58e1913851adc310853c6170f34517374a2d786e280c889eab84d2cade512 2083 twitter-bootstrap3_3.3.7+dfsg-2.dsc
 cf0e92daccb1cc5456641eb67d5b43aa6a1d396ddca4e4005deb4cf2d3c32548 50848 twitter-bootstrap3_3.3.7+dfsg-2.debian.tar.xz
Files:
 2c2149d9136ad273afea3b01bec837c2 2083 web optional twitter-bootstrap3_3.3.7+dfsg-2.dsc
 897c4caea2e57dff4da847ceebbaf312 50848 web optional twitter-bootstrap3_3.3.7+dfsg-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJYDgMkAAoJEPwNsbvNRgveErUP/jxX+EN/nhWSC8WCnrq5CTu1
sAr9npbg2aBXmFSnw9nS3ikAgcIy6EiW0aOPIQHuYxayHTo1vQArO97qceoq9IwD
q1CYYoiPKxQDMsUm4xjjVRJ6Jnnbv8oxWI9GpMxDO9MPLSBYJ3cXGt9/v9staQKe
K2ivZ9lcFe1YLnOtJT9ieebxEwB9Gb82nhAmyf5m22YSWppB5U69tfE6GOlkaJhD
VLbydjc5o4ptqtwCfBZjZHsHSNbZtn82O9wkctjDPOVTW8qT8843k9lzHrA7DSVr
LDA4PJP7iCzQWAbdRptPMCZ2wQcsdYJDdWD7SI+aQpqKsLE32/qy0VjAtUXj+rPk
ZhgYJ6OBGBzxBBJe+xazeHaja81LtnbAz+fZlmGnvOrQfAE5Y9cHlEQHmjJuPsjW
i5WuPVCtsSfZxRpInCNCAhg3mlO+Mf90C2audEv57V2lqroaCu7+NHIh0Fo+0u4V
wMVwxqGi0MpuxVMdlF48liXxSJD7qUCQGbUxbOX1HHTe3tMSKRLr9jAw/yvHFqyx
GFVwG2ZY/dgEU79FKoKWhNeqTpzBZM+oTEpMBSn2TWFlHan2LL75pfIXl88QZcPw
WANK2Pmb1bb/+ZVDOjkX26hupgEEyspF2hl95L37VmRsbsHxduBmk+e9887w7Esi
Hj0lz82a5+m5ZjCq0xl8
=MHft
-----END PGP SIGNATURE-----

Message #25 received at 834988@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: Antonio Terceiro <terceiro@debian.org>, 834988@bugs.debian.org

Subject: Re: Bug#834988: twitter-bootstrap3: please make the build reproducible

Date: Mon, 24 Oct 2016 22:52:58 +0100

Antonio Terceiro wrote:

> Unfortunately this patch does not fix the issue as the file it changes
> is not actually used in the Debian build.

Interesting. Could you elaborate? I would have tested it at the time, I
would hope!


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #30 received at 834988@bugs.debian.org (full text, mbox, reply):

From: Antonio Terceiro <terceiro@debian.org>

To: Chris Lamb <lamby@debian.org>, 834988@bugs.debian.org

Subject: Re: Bug#834988: twitter-bootstrap3: please make the build reproducible

Date: Tue, 25 Oct 2016 09:26:51 -0200

[Message part 1 (text/plain, inline)]

On Mon, Oct 24, 2016 at 10:52:58PM +0100, Chris Lamb wrote:
> Antonio Terceiro wrote:
> 
> > Unfortunately this patch does not fix the issue as the file it changes
> > is not actually used in the Debian build.
> 
> Interesting. Could you elaborate?

At some point in the past the upstream build for a number of existing
packages (jquery and bootstrap come to mind) switched to using grunt,
which is not packaged in Debian and has a gazillion dependencies.

Both on jquery and on twitter-bootstrap3, the grunt build has to be
emulated by other means, and in twitter-bootstrap3, the code that
actually generates that unreproducible copyright message in is
debian/rules:

https://anonscm.debian.org/cgit/pkg-javascript/twitter-bootstrap.git/commit/?id=7ebbdfe1e51ec5460b66c30ace8b913c8c48332f

> I would have tested it at the time, I would hope!

You might have tested with the upstream build using grunt, which can't
be used in Debian at the moment.

[signature.asc (application/pgp-signature, inline)]

Message #35 received at 834988@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: Antonio Terceiro <terceiro@debian.org>, 834988@bugs.debian.org

Subject: Re: Bug#834988: twitter-bootstrap3: please make the build reproducible

Date: Tue, 25 Oct 2016 12:33:23 +0100

Hi Antonio,

Thanks for the explanation. Looking at the patch quickly:

  year := $(shell date -d @$(SOURCE_DATE_EPOCH) +%Y)

This should actually be:

  year := $(shell date -u -d @$(SOURCE_DATE_EPOCH) +%Y)

… otherwise it will not be reproducible "on" New Years Eve or New Year's Day
due to timezones. :)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #40 received at 834988@bugs.debian.org (full text, mbox, reply):

From: Antonio Terceiro <terceiro@debian.org>

To: Chris Lamb <lamby@debian.org>, 834988@bugs.debian.org

Subject: Re: Bug#834988: twitter-bootstrap3: please make the build reproducible

Date: Tue, 25 Oct 2016 11:06:21 -0200

[Message part 1 (text/plain, inline)]

On Tue, Oct 25, 2016 at 12:33:23PM +0100, Chris Lamb wrote:
> Hi Antonio,
> 
> Thanks for the explanation. Looking at the patch quickly:
> 
>   year := $(shell date -d @$(SOURCE_DATE_EPOCH) +%Y)
> 
> This should actually be:
> 
>   year := $(shell date -u -d @$(SOURCE_DATE_EPOCH) +%Y)
> 
> … otherwise it will not be reproducible "on" New Years Eve or New Year's Day
> due to timezones. :)

right. I pushed an update, but won't upload just for that. thanks

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.