Debian Bug report logs - #834957
flashrom: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: submit@bugs.debian.org

Subject: flashrom: please make the build reproducible

Date: Sun, 21 Aug 2016 00:34:08 +0100

[Message part 1 (text/plain, inline)]

Source: flashrom
Version: 0.9.9+r1954-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], I noticed
that flashrom could not be built reproducibly.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[flashrom.diff.txt (text/plain, attachment)]

Message #10 received at 834957@bugs.debian.org (full text, mbox, reply):

From: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>

To: Chris Lamb <lamby@debian.org>, 834957@bugs.debian.org

Subject: Re: Bug#834957: flashrom: please make the build reproducible

Date: Sun, 21 Aug 2016 10:37:05 +0200

On Sun, 21 Aug 2016 00:34:08 +0100
Chris Lamb <lamby@debian.org> wrote:

> Source: flashrom
> Version: 0.9.9+r1954-1
> Severity: wishlist
> Tags: patch
> User: reproducible-builds@lists.alioth.debian.org
> Usertags: timestamps
> X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org
> 
> Hi,
> 
> Whilst working on the Reproducible Builds effort [0], I noticed
> that flashrom could not be built reproducibly.

Hi Chris,

if I read the specs right then the date formatting should not happen at
build time but at runtime to catch user locales.

"Formatting MUST be deferred until runtime if an end user should
observe the value in their own locale or timezone."

That would make your patch not fully complying.
I'll try to improve on that upstream for the next release. Thanks for
the pointer.

-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner

Message #15 received at 834957@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>, 834957@bugs.debian.org

Subject: Re: Bug#834957: flashrom: please make the build reproducible

Date: Sun, 21 Aug 2016 10:56:34 +0100

Stefan Tauner wrote:

> "Formatting MUST be deferred until runtime if an end user should
> observe the value in their own locale or timezone."

Personally, I don't think this should be a MUST especially because — 
as you are noticing — it requires a more-invasive patch for not much
value.

I have already proposed this be relaxed.

In the meantime, I would focus on the conditional clause, ie.:

  … if an end user should observe the value in their own locale
  or timezone.

I feel I can interpret this as "the user should not observe a *build*
timestamp in their own locale timezone as that defeats the point of
it being a quasi-unique identifier. Therefore, there is no need to
defer formatting until runtime.

If it helps, I am not sure I have seen any package implement the
SOURCE_DATE_EPOCH variable by deferring. :)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #20 received at 834957@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 834957@bugs.debian.org

Subject: Re: Bug#834957: flashrom: please make the build reproducible

Date: Sun, 05 Mar 2017 09:29:40 +0000

> Would you consider applying this patch and uploading?

Friendly ping on this :)


Best wishes,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #25 received at 834957-done@bugs.debian.org (full text, mbox, reply):

From: Gürkan Myczko <gurkan@phys.ethz.ch>

To: 834957-done@bugs.debian.org

Subject: flashrom 1.0-1

Date: Thu, 21 Feb 2019 10:22:32 +0100

I just checked, this is already fixed upstream, without your patch.
Closing...

Send a report that this bug log contains spam.