Debian Bug report logs - #834773
gkrellm: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: submit@bugs.debian.org

Subject: gkrellm: please make the build reproducible

Date: Thu, 18 Aug 2016 23:19:57 +0100

[Message part 1 (text/plain, inline)]

Source: gkrellm
Version: 2.3.7-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: shell
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], I noticed
that gkrellm could not be built reproducibly.

Quite an interesting case really; when built under bash, the existing
code resulted in "\n" instead of literal newlines. Dash would
technically do the wrong thing and print literal newlines.

To fix the issue, we must force the use of bash and use "echo -e".

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[gkrellm.diff.txt (text/plain, attachment)]

Message #10 received at 834773@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 834773@bugs.debian.org

Subject: Re: gkrellm: please make the build reproducible

Date: Thu, 18 Aug 2016 23:45:27 +0100

[Message part 1 (text/plain, inline)]

Hi,

> Patch attached.

Better patch attached. Thanks to Reiner Herrmann.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[gkrellm.diff.txt (text/plain, attachment)]

Message #15 received at 834773@bugs.debian.org (full text, mbox, reply):

From: Daniel Shahaf <danielsh@apache.org>

To: Chris Lamb <lamby@debian.org>

Cc: 834773@bugs.debian.org

Subject: Re: gkrellm: please make the build reproducible

Date: Thu, 18 Aug 2016 23:25:30 +0000

Chris Lamb wrote on Thu, Aug 18, 2016 at 23:45:27 +0100:
>  gkrellm.pc: Makefile
> -	echo 'prefix=$(INSTALLROOT)\n'\
> +	printf 'prefix=$(INSTALLROOT)\n'\
>  	'Name: GKrellM\n'\
>  	'Description: Extensible GTK system monitoring application\n'\
>  	'Version: $(VERSION)\n'\
>  	'Requires: gtk+-2.0 >= 2.4.0\n'\
>  	'Cflags: -I$(INCLUDEDIR)\n'\
> -	'$(GKRELLM_PC_EXTRA)' > gkrellm.pc
> +	'$(GKRELLM_PC_EXTRA)\n' > gkrellm.pc

Note this patch assumes that there are no '%' signs in the values of the
interpolated makefile parameters.

If that is a concern, I would suggest the following:

--- gkrellm-2.3.7.orig/Makefile
+++ gkrellm-2.3.7/Makefile
@@ -131,13 +131,13 @@ all gkrellm: gkrellm.pc
 	(cd server && ${MAKE} gkrellmd)
 
 gkrellm.pc: Makefile
-	echo 'prefix=$(INSTALLROOT)\n'\
-	'Name: GKrellM\n'\
-	'Description: Extensible GTK system monitoring application\n'\
-	'Version: $(VERSION)\n'\
-	'Requires: gtk+-2.0 >= 2.4.0\n'\
-	'Cflags: -I$(INCLUDEDIR)\n'\
-	'$(GKRELLM_PC_EXTRA)' > gkrellm.pc
+	echo  >$@ 'prefix=$(INSTALLROOT)'
+	echo >>$@ 'Name: GKrellM'
+	echo >>$@ 'Description: Extensible GTK system monitoring application'
+	echo >>$@ 'Version: $(VERSION)'
+	echo >>$@ 'Requires: gtk+-2.0 >= 2.4.0'
+	echo >>$@ 'Cflags: -I$(INCLUDEDIR)'
+	printf >>$@ '%%s\n' '$(GKRELLM_PC_EXTRA)'
 
 install: install_gkrellm.pc
 	(cd po && ${MAKE} install)

Cheers,

Daniel

Message #20 received at 834773@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 834773@bugs.debian.org

Subject: Re: Bug#834773: gkrellm: please make the build reproducible

Date: Fri, 16 Sep 2016 09:51:04 +0100

Dear Maintainer,

> Source: gkrellm
> Version: 2.3.5-3
> Tags: patch

There hasn't seem to be any update on this bug in 28 days, in which
time the Reproducible Builds effort has come on a long way. :)

Would you consider applying this patch and uploading?


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #25 received at 834773@bugs.debian.org (full text, mbox, reply):

From: Sandro Tosi <morph@debian.org>

To: Chris Lamb <lamby@debian.org>, 834773@bugs.debian.org

Subject: Re: Bug#834773: gkrellm: please make the build reproducible

Date: Fri, 16 Sep 2016 09:55:31 +0100

> Would you consider applying this patch and uploading?

yeah i'll do soon, when i'll upload the new upstream release

-- 
Sandro "morph" Tosi
My website: http://sandrotosi.me/
Me at Debian: http://wiki.debian.org/SandroTosi
G+: https://plus.google.com/u/0/+SandroTosi

Message #30 received at 834773-close@bugs.debian.org (full text, mbox, reply):

From: Sandro Tosi <morph@debian.org>

To: 834773-close@bugs.debian.org

Subject: Bug#834773: fixed in gkrellm 2.3.8-1

Date: Wed, 28 Sep 2016 06:48:49 +0000

Source: gkrellm
Source-Version: 2.3.8-1

We believe that the bug you reported is fixed in the latest version of
gkrellm, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 834773@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Sandro Tosi <morph@debian.org> (supplier of updated gkrellm package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 28 Sep 2016 07:18:01 +0100
Source: gkrellm
Binary: gkrellm gkrellmd
Architecture: source amd64
Version: 2.3.8-1
Distribution: unstable
Urgency: medium
Maintainer: Sandro Tosi <morph@debian.org>
Changed-By: Sandro Tosi <morph@debian.org>
Description:
 gkrellm    - GNU Krell Monitors
 gkrellmd   - GNU Krell Monitors Server
Closes: 812185 834773
Changes:
 gkrellm (2.3.8-1) unstable; urgency=medium
 .
   * [446a39b] Imported Upstream version 2.3.8; Closes: #812185, #834773
   * [1d8272f] use HTTPS in Vcs-* fields
Checksums-Sha1:
 6e775d39c0a55fc5119998f2ff7f62502ac780a5 1975 gkrellm_2.3.8-1.dsc
 169249191b8062062747c1a33f58386fb329faf1 1128292 gkrellm_2.3.8.orig.tar.gz
 9885740440c2b6f6794cd62138539e7d147285de 15200 gkrellm_2.3.8-1.debian.tar.xz
 515d91fa1c57fbccea4ed3718a33952520edbf93 832160 gkrellm-dbgsym_2.3.8-1_amd64.deb
 3f9ae1ec9619df43781692261bdc09f74808b7da 590656 gkrellm_2.3.8-1_amd64.deb
 2e3d388cc212caa3bf14acabc386e1b7c8e2ea2b 129556 gkrellmd-dbgsym_2.3.8-1_amd64.deb
 850975b1f15e4c0e26f863c7466748697d3f6122 115732 gkrellmd_2.3.8-1_amd64.deb
Checksums-Sha256:
 592cb7d29970567fa1b224ed4528812a23101b3cf6b7e399caf2077b315e7aa6 1975 gkrellm_2.3.8-1.dsc
 084a9ab03ea7b87aaa2ae9e22e4aa9480395a871afe34c1e9332d06b6388b88c 1128292 gkrellm_2.3.8.orig.tar.gz
 e24f5f1eaf4af268308fdc587e246c3f58f60b04692fd59492ec5a5147b398ef 15200 gkrellm_2.3.8-1.debian.tar.xz
 d3cf0ea6956c3afe476d13397fc125b638ec6b3e608f59dff6c4a437e79e1a59 832160 gkrellm-dbgsym_2.3.8-1_amd64.deb
 8b7a5fe5243f0bc9e3fa3f5769e5895d8a5cf50e8d292bb7c709fe6a012c74d6 590656 gkrellm_2.3.8-1_amd64.deb
 b6b1cfcad487caac4d1797b1bb1121620299744c3b8dc76309f29cbf1d0dc3a8 129556 gkrellmd-dbgsym_2.3.8-1_amd64.deb
 c41d38808a98a0fffe3ac86bfe2fd163121ad7e7765910fa2dbd776525620d6a 115732 gkrellmd_2.3.8-1_amd64.deb
Files:
 bddebb4273575d2b41628cd7152c85a2 1975 x11 optional gkrellm_2.3.8-1.dsc
 513f2ecaaa2f48eb6302a592b9f6258e 1128292 x11 optional gkrellm_2.3.8.orig.tar.gz
 30743dfdb4e30bfbbf78efa41e819b1f 15200 x11 optional gkrellm_2.3.8-1.debian.tar.xz
 97feea15a6026768878e9d4c4e5a20f8 832160 debug extra gkrellm-dbgsym_2.3.8-1_amd64.deb
 a17f3202f6cd07afa09b776d0cc00dea 590656 x11 optional gkrellm_2.3.8-1_amd64.deb
 ec34ad4c69c26388fbcc441b3eff4e7d 129556 debug extra gkrellmd-dbgsym_2.3.8-1_amd64.deb
 ec44bfb8c8f7be8126615a552fc67dc2 115732 x11 optional gkrellmd_2.3.8-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJX62QKAAoJEIefPJk4AalPdikP/jSEwi5gm008cVOMHL/GKwFd
izA2o/fVnctvF8ehi02mRs/46/QpADqfCo8Ky8L1UZGOqqAymsTOSHvcIfr7sf/d
r0IOQMGxKDSuXwlMieEvKFKrTr10uwNZrT+166pPCZpD3kzAlvsHlr+bEpxoqH8s
zG4qvcfnYG9kj73S9iQ8HoHiAphKdiId0JlumPUsO56g7pOdXNWmCwMcOg/ZO3Ie
wMdPLF0KX9TiZeywZKOqIwhla8s4g3zQPqinBnbtWJnE6tGNCuqMebBCMDWmDRQ4
puDO/4Tsr0S6hscw0yawxYz+yehDVvivU19m8//UD3KjhgGAcXSlGVp2oPSCpYAf
HGV3TBIHBJD3k16E5qXuR2vEDlL9wHizmH4LPI9V6Hh7J9PR8Fob2SXf/YHciCKw
eju3iuX+ZZcSJsigbQAJ3rql9G5TICh8kHzLqftl6s4PtPK2ho5igHOGvn7XC3qo
Awh2kUF7r6FPtL1Wa28RAD0aTkTQJiUBn7Xo5WrxHY18bRC7PGT4VzwwPt0tIQc5
/M++rkpy+tZcX4B7Ui91UYRkjT8WvrLGAEIl1Whwvtr2Qenebf0dRxz9G2Xt6EJt
ibCBfdF/2IbNwZaDE++sZDq9AgON52RCVQTFfTBbU9k5R3gBgG+EXwwZUKOSVqks
446B5NPt5uQtvliyPLyC
=K0KU
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.