Debian Bug report logs - #834204
libsdl1.2: Nonfree file: src/video/fbcon/riva_mmio.h

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Legimet <legimet.calc@gmail.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: libsdl1.2: Nonfree file: src/video/fbcon/riva_mmio.h

Date: Fri, 12 Aug 2016 22:44:49 -0400

Source: libsdl1.2
Version: 1.2.15+dfsg1-4
Severity: serious
Justification: Policy 2.1

Dear Maintainer,

The file src/video/fbcon/riva_mmio.h has a nonfree license that does not
explicitly allow modification. The file is from xf86-video-nv, and has
subsequently been relicensed under the MIT/Expat license:
https://cgit.freedesktop.org/xorg/driver/xf86-video-nv/tree/src/riva_hw.h

It should be possible to use the newer version of the file.

Thanks,
Legimet

-- System Information:
Debian Release: 8.5
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.6.0-0.bpo.1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Message #10 received at 834204@bugs.debian.org (full text, mbox, reply):

From: "Manuel A. Fernandez Montecelo" <manuel.montezelo@gmail.com>

To: Legimet <legimet.calc@gmail.com>, 834204@bugs.debian.org, Debian FTP masters <ftpmaster@debian.org>

Subject: Re: Bug#834204: libsdl1.2: Nonfree file: src/video/fbcon/riva_mmio.h

Date: Sat, 13 Aug 2016 10:50:03 +0100

Hi,

2016-08-13 3:44 GMT+01:00 Legimet <legimet.calc@gmail.com>:
> Source: libsdl1.2
> Version: 1.2.15+dfsg1-4
> Severity: serious
> Justification: Policy 2.1
>
> Dear Maintainer,
>
> The file src/video/fbcon/riva_mmio.h has a nonfree license that does not
> explicitly allow modification.

Thanks for the report.

I am copying FTP-masters to know their opinion.

This file has been present in Debian for the best part of 2 decades,
so possibly the people who reviewed and approved this initially are
not around anymore or, if they are, that they don't recall the details
if they were discussed.

From my understanding, despite the brevity of the wording but given
the context, with "using this code in individual and commercial
software" is implicit the possibility of modification, as in "use in
any way you wish" -- modifications might be needed due to changes in
compiler/toolchain or to integrate in the bigger "commercial" software
(e.g. changing names to avoid clashes).

These licenses are usually to prevent that the source code is
leaked/accessible to the outside world, or used in commercial software
without being paid.  Since this license prevents neither, I don't
think that prevent modification is of any use to the copyright
holders...

.... but it's true that it doesn't explicitly allow modification or
says anything beyond "use".


> The file is from xf86-video-nv, and has
> subsequently been relicensed under the MIT/Expat license:
> https://cgit.freedesktop.org/xorg/driver/xf86-video-nv/tree/src/riva_hw.h
>
> It should be possible to use the newer version of the file.

The code is not identical, for example the "NV_" macros in the
beginning of the old file are not present in the second.

The "struct _riva_hw_inst" is different in both versions as well (e.g.
fields Architecture and Version present in the first file, but not in
the second), so not API nor ABI compatible.

So it needs to be handled with some care in any case.


(BTW, it would be nice to discuss this with upstream if it needs to be
removed/updated, unfortunately I don't have much time in the next few
weeks, so if somebody beats me to it I will not complain :) .  They
should also have access to some nice legal department, being developed
by Steam now).


Cheers.
-- 
Manuel A. Fernandez Montecelo <manuel.montezelo@gmail.com>

Message #15 received at 834204@bugs.debian.org (full text, mbox, reply):

From: Ivo De Decker <ivodd@debian.org>

To: "Manuel A. Fernandez Montecelo" <manuel.montezelo@gmail.com>

Cc: Legimet <legimet.calc@gmail.com>, 834204@bugs.debian.org, Debian FTP masters <ftpmaster@debian.org>

Subject: Re: Bug#834204: libsdl1.2: Nonfree file: src/video/fbcon/riva_mmio.h

Date: Sun, 19 Mar 2017 14:46:10 +0100

Control: tags -1 stretch-ignore

Hi,

On Sat, Aug 13, 2016 at 10:50:03AM +0100, Manuel A. Fernandez Montecelo wrote:
> > The file src/video/fbcon/riva_mmio.h has a nonfree license that does not
> > explicitly allow modification.
> 
> Thanks for the report.
> 
> I am copying FTP-masters to know their opinion.
> 
> This file has been present in Debian for the best part of 2 decades,
> so possibly the people who reviewed and approved this initially are
> not around anymore or, if they are, that they don't recall the details
> if they were discussed.
> 
> From my understanding, despite the brevity of the wording but given
> the context, with "using this code in individual and commercial
> software" is implicit the possibility of modification, as in "use in
> any way you wish" -- modifications might be needed due to changes in
> compiler/toolchain or to integrate in the bigger "commercial" software
> (e.g. changing names to avoid clashes).
> 
> These licenses are usually to prevent that the source code is
> leaked/accessible to the outside world, or used in commercial software
> without being paid.  Since this license prevents neither, I don't
> think that prevent modification is of any use to the copyright
> holders...
> 
> .... but it's true that it doesn't explicitly allow modification or
> says anything beyond "use".
> 
> 
> > The file is from xf86-video-nv, and has
> > subsequently been relicensed under the MIT/Expat license:
> > https://cgit.freedesktop.org/xorg/driver/xf86-video-nv/tree/src/riva_hw.h
> >
> > It should be possible to use the newer version of the file.
> 
> The code is not identical, for example the "NV_" macros in the
> beginning of the old file are not present in the second.
> 
> The "struct _riva_hw_inst" is different in both versions as well (e.g.
> fields Architecture and Version present in the first file, but not in
> the second), so not API nor ABI compatible.
> 
> So it needs to be handled with some care in any case.

Based on the fact that the license for the newer version of the file is OK,
and that we shipped the old version for a long time, I think it's better to
leave it the way it is for stretch, to avoid breaking things this late in the
freeze. Tagging accordingly. This issue should be fixed after the stretch
release.

Cheers,

Ivo

Message #22 received at 834204@bugs.debian.org (full text, mbox, reply):

From: Jonas Smedegaard <dr@jones.dk>

To: Debian Bug Tracking System <834204@bugs.debian.org>

Subject: Re: libsdl1.2: Nonfree file: src/video/fbcon/riva_mmio.h

Date: Mon, 17 Jul 2017 20:10:18 +0200

[Message part 1 (text/plain, inline)]

Source: libsdl1.2
Followup-For: Bug #834204

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Attached is a patch from Parabola to avoid using the baguely licensed
file, to survive a repackaging with it stripped.

 - Jonas

- -- System Information:
Debian Release: buster/sid
  APT prefers buildd-unstable
  APT policy: (500, 'buildd-unstable'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.11.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEn+Ppw2aRpp/1PMaELHwxRsGgASEFAlls/YYACgkQLHwxRsGg
ASHVjA//ZhhUBmIThagxO9c8uLjHsRi0a9QmWrG11FSn6nkDlUyuAURKLs3FTRCD
5D42XtSf86xfVXcnMY/EACurhWB0zWB+y1h03tIOYHSodfTnMpk0yiTv/i9TkfBL
7jYtezOpehfqV8xVyBR9lye2tqPqpVy2l+INlDmEdutV+MMZk2r7CGETcVcunt8E
LsxCJOMmvQmlCt0GN5+7gh3JHJHDEk/36P7Qaj1q/rVSEH6xNm81nIQH8DNca0cB
+CFin5WBw9NogS3Gaf9pv6RM6NawXLp/WxE94nf1+0F7Wd78nES5YrH3CycL7ssO
vZqlsgKDs2r+tEnWNtNB9g4JakUah/QHBma5gf4ksNiSrKC54oyh9Lb1fnVl0Srm
LGrALFvIglpjKpFuyRLUHbucZURac1KN6RiOe2KGAuHLgiJA70IrWWpZC1a0eF/U
1EWk7eCPr+KN5ORasf59Q1yOX36NIsGL3mzwXW4uiEcM0GCjHKXl6/RaLxTJnCNQ
13t2fWHI1JLxn/szHG79X9LFvRIqftl8M/+a+eWWdgSHBWzbUm5rcuuFyjCeoAQR
IPAeItMRON/iBUQMeb3pmxhwbEKeLJ9DDpsPml3Yq9YM3RvltEheAnt8QuO40cNI
d/x/h7O8sShPuWNbLQDHViy8RqImsaZAEu+hbv3qBBgkvBH+vhY=
=dZcH
-----END PGP SIGNATURE-----

[avoid_maybe_non-DFSG_file.patch (text/plain, attachment)]

Message #27 received at 834204@bugs.debian.org (full text, mbox, reply):

From: Jonas Smedegaard <dr@jones.dk>

To: Debian Bug Tracking System <834204@bugs.debian.org>

Subject: Re: libsdl1.2: Nonfree file: src/video/fbcon/riva_mmio.h

Date: Tue, 18 Jul 2017 14:14:24 +0200

Package: src:libsdl1.2
Followup-For: Bug #834204

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

I have prepared an NMU and queued for release in 5 days.

Attached is the diff.

I made the changes in git locally, and can push that to Alioth if
granted write access to the repository (my account is js).
Alternatively I can put my git public somewhere for you to clone if you
prefer.

 - Jonas

- -- System Information:
Debian Release: buster/sid
  APT prefers buildd-unstable
  APT policy: (500, 'buildd-unstable'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.11.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEn+Ppw2aRpp/1PMaELHwxRsGgASEFAllt+50ACgkQLHwxRsGg
ASHhCxAAj1GSl6n3oAmymMiX9CI1uFPZAefNs/+8chmlX0pbZKYAjvw9W2Lu35eS
eWLE9BBPOXjKsSqRnW6uM9xnaySu4zOlyYeEv/h/GZm8u4tunmr6OtCZpDQSI+Cy
DxHmt4fw6WhZ+/e3EmehKUni8QIX+h5GqZ/OCt7/MsqNMIuyvd1rhpbqGRXXtqVe
uEg/l1uHKzNdjNjUIpGCPJCumCnQRLPNDva/2A90Xam5twEV4NnnTuEn4P1m0kCm
NvkhhAVIN18xvkqQHyJRBgeuBEWaxT8OU+doSyQFvW/YVu8wFiJh39/MMcy4jnJ3
+/JzPWwa59KD7SiIoQO24P1KFXrRfekemiLqYUPHdK9WiGtd6oF02LQSVfp02Di8
TWvXS9KClIk/AverR1aTPuBXzK8cApWQ4pCcpFWrlrAGHlyfS1pe9tv0PP8nayhi
y+el3volYY2Z90m2GXWL3GDdjo76MrM1XbB2GdS37TDWXPwekC7I0W8LSuw2xPZu
N8l2MsxpRS6Zr4ybxxjTOAq/qiTp5N3f6SiiRDu5ZM1RkK6ASzLqS9VQ5tMcJOgx
S9IDenznNqsooVKpmQGUG6DYs/N4p+5Es2Ee7Ggk2UQ03iSGFhDyghXsDzb9mgIC
ozTIWQXfVNFiEWUdoqYimIVj5iGfG3QiaAS3LQaqmaPxHiq8tr8=
=Wl8e
-----END PGP SIGNATURE-----

Message #32 received at 834204@bugs.debian.org (full text, mbox, reply):

From: Jonas Smedegaard <dr@jones.dk>

To: Debian Bug Tracking System <834204@bugs.debian.org>

Subject: Re: libsdl1.2: Nonfree file: src/video/fbcon/riva_mmio.h

Date: Tue, 18 Jul 2017 14:15:45 +0200

[Message part 1 (text/plain, inline)]

Package: src:libsdl1.2
Followup-For: Bug #834204

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Whoops - forgot to acutally attach the diff.

 - Jonas

- -- System Information:
Debian Release: buster/sid
  APT prefers buildd-unstable
  APT policy: (500, 'buildd-unstable'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.11.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEn+Ppw2aRpp/1PMaELHwxRsGgASEFAllt+/EACgkQLHwxRsGg
ASGtXg//fTrFEtoLczPWhkKQ3A2YuiGqjkpgJhIvdFRcJsLa29ixrh9hraWGeN1j
FMfaYABS7aoeAd1Efpn6HqE+leT9SslCSgeromLBtmyX/blusRvLMYFipOJmhCOE
LzZHsDAUo7nE6wKH9xPbHOxwFL4ZzKBoqWFZ+SKumpVkTRijld0D0+4Z4LE5kiUZ
raerilDHCLqQrWZr9Vof/p4HyYgapYHYXZ+h9foRm48kzZuUIHQs75KtXO2PCdQn
pz28AwpAIaOMukZ9eq462Z4agDoarasHJMjDXHLxxxz2gti76iCMbKEKOJGcVj9t
TKVqMD0x2rqKJ0S3eiXfMv0Cf00yGj1y4PCA3aFfS2QdIw6OV9eBsPRDA1Gglzcu
stxB73dYYKibqLHgUgU01RsSXd8aIZcb42Y3mW1lKRImJm3XqTpMgu1Ye4jUgYVE
NHydJNt+1rZq8RyXhuUzFRFM+ow/t+ukPaRBGcJ1uHuKOHEjvMOX0xuT4W+BUA0W
FUDNUgVsPTndXDZ12VODlxCEMBpp3/vsbInMjOof1LUK0vTdQ6WrbA9eFKz33cwh
sc8++C5hJZ90emkQfMe2/0VtXpQ3uasv8WgVGmFUX1PsVOzV4Q+VHCJi3y2/02br
XE0ZqLDCV7Ei1a7PGjTchHnZsLENqivZXzhPm4G8F6sEDwMSWO0=
=tCu0
-----END PGP SIGNATURE-----

[nmu.diff (application/octet-stream, attachment)]

Message #37 received at 834204@bugs.debian.org (full text, mbox, reply):

From: "Manuel A. Fernandez Montecelo" <manuel.montezelo@gmail.com>

To: Jonas Smedegaard <dr@jones.dk>

Cc: Debian Bug Tracking System <834204@bugs.debian.org>

Subject: Re: libsdl1.2: Nonfree file: src/video/fbcon/riva_mmio.h

Date: Wed, 19 Jul 2017 00:46:24 +0200

Hi Jonas,

2017-07-18 14:14 Jonas Smedegaard:
>Package: src:libsdl1.2
>Followup-For: Bug #834204
>
>-----BEGIN PGP SIGNED MESSAGE-----
>Hash: SHA512
>
>I have prepared an NMU and queued for release in 5 days.
>
>Attached is the diff.

Thanks.  I am in the midst of a snowstorm, metaphorically speaking, so I
didn't have time (and neither I will have in the next few days) to
review this in depth, but in principle I trust your good judgement so
all fine by me, including the NMU.


>I made the changes in git locally, and can push that to Alioth if
>granted write access to the repository (my account is js).
>Alternatively I can put my git public somewhere for you to clone if you
>prefer.

If you want to become a somewhat-regular contributor / maintainer the
first option is preferrable, otherwise I think that the output of
format-path is intended for this kind of situations, and preserves
authorship and all that (?).  Whatever you prefer, really.


... and big thanks for caring and fixing this bug.


PS: (Would be super if you contact upstream about it, but it's fine if
   you don't want to get so involved.  I'll try to remember in the next
   revision of the package).


-- 
Manuel A. Fernandez Montecelo <manuel.montezelo@gmail.com>

Message #42 received at 834204-close@bugs.debian.org (full text, mbox, reply):

From: Jonas Smedegaard <dr@jones.dk>

To: 834204-close@bugs.debian.org

Subject: Bug#834204: fixed in libsdl1.2 1.2.15+dfsg2-0.1

Date: Sun, 23 Jul 2017 12:34:32 +0000

Source: libsdl1.2
Source-Version: 1.2.15+dfsg2-0.1

We believe that the bug you reported is fixed in the latest version of
libsdl1.2, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 834204@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jonas Smedegaard <dr@jones.dk> (supplier of updated libsdl1.2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 18 Jul 2017 13:46:21 +0200
Source: libsdl1.2
Binary: libsdl1.2debian libsdl1.2-dev
Architecture: source
Version: 1.2.15+dfsg2-0.1
Distribution: unstable
Urgency: medium
Maintainer: Debian SDL packages maintainers <pkg-sdl-maintainers@lists.alioth.debian.org>
Changed-By: Jonas Smedegaard <dr@jones.dk>
Description:
 libsdl1.2-dev - Simple DirectMedia Layer development files
 libsdl1.2debian - Simple DirectMedia Layer
Closes: 834204 857670
Changes:
 libsdl1.2 (1.2.15+dfsg2-0.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
 .
   [ Manuel A. Fernandez Montecelo ]
   * Do not build-depend on libaudiofile, unused.
     Closes: #857670
 .
   [ Jonas Smedegaard ]
   * Add script to check copyright and licensing of source.
   * Update copyright info:
     + Rewrite copyright file in machine-readable format.
     + Fix cover many secondary copyright holders and licenses.
   * Repackage upstream source to exclude more potentially non-DFSG code,
     and add patch to avoid missing code.
     Closes: Bug#834204.
   * Update watch file:
     + Bump to version 4.
     + Add usage comment.
     + Set repacksuffix.
   * Drop repackaging hints from git-buildpackage config: Handled by
     uscan + machine-readable copyright file.
   * Add lintian overrides regarding license in License-Reference field.
     See bug#786450.
   * Add lintian overrides regarding license name used both alone an in
     composition.
Checksums-Sha1:
 8fcf754fe6dbd2a803b708201842e5b5a9bd6c92 2372 libsdl1.2_1.2.15+dfsg2-0.1.dsc
 84f62ffd04d6288f92308c692bef7e412f97d121 2955622 libsdl1.2_1.2.15+dfsg2.orig.tar.gz
 fd7ae83a1b4c7b4eda8e9039985a95224fd873c2 45536 libsdl1.2_1.2.15+dfsg2-0.1.debian.tar.xz
 5363b9d88a403bc0d772551099bb6fbd42fcd1d0 9465 libsdl1.2_1.2.15+dfsg2-0.1_amd64.buildinfo
Checksums-Sha256:
 cc0de1cb2673e2ce212b2717e50a498ec35f985c458c6cf843de9e54a46e81ec 2372 libsdl1.2_1.2.15+dfsg2-0.1.dsc
 ec4d5ea4714b92f840aafcf8c759cf7914827f632e19f42b18ba6f6489f0f5e9 2955622 libsdl1.2_1.2.15+dfsg2.orig.tar.gz
 d7ec0f5e12dbbd5415f4bb87cb147a8be3c0fca99dc4dfd1a76f88fb021a6b61 45536 libsdl1.2_1.2.15+dfsg2-0.1.debian.tar.xz
 176e3868045954e4bb40dc452be513dfe616cc78cb0951b9abd8400be3941e4c 9465 libsdl1.2_1.2.15+dfsg2-0.1_amd64.buildinfo
Files:
 fe3d2b926aaa94ee37f1aa14fbaff343 2372 libs optional libsdl1.2_1.2.15+dfsg2-0.1.dsc
 45057035b4dea8c84995411bbcbf62d8 2955622 libs optional libsdl1.2_1.2.15+dfsg2.orig.tar.gz
 92e64a6c1e57e6cfa8546a48b8be18dd 45536 libs optional libsdl1.2_1.2.15+dfsg2-0.1.debian.tar.xz
 117274b389c32ec5e89684b72dc3e844 9465 libs optional libsdl1.2_1.2.15+dfsg2-0.1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEn+Ppw2aRpp/1PMaELHwxRsGgASEFAllt+EgACgkQLHwxRsGg
ASGAtBAAmRq7adu/C7RxjVQPe4UwGgjWcReHw2wCVXZBDgCLgAITih27c39hle/G
NxR1JwJXbwQBmg3G88ULipmKaD9XquiZZodWp5VOZ9oB+SX73nlhERbb3ByxYGye
gy9TnfviMwfGKJhXMbLWXKBK/4O5XrjOryywtOn4ZzeMeiv+YbZZANYth2ZuHt6E
NPdw8c9YrQclNBq+c7Em08eMrFfR7xg0IHP6fvLqIW8gFINrj8p97aKzFayKNfOY
7DTvX9UsQvDrLjU7U07V/BCIxtkLFUUVrMKay2wX+ZSxgKu9MkpMzQY33jlBcyDr
Ng4+/2oh6SuOePyyDc85pX8Smac4qE396OtuJ4SsY0GCw08voQlLyLNp8k+lJJna
R0e8Yk+36JuA8RaAo5yxXOkcunsevlUJs6ATVyYFcDPNWyMQa9NewJOgTGEmr/9S
D3qmsNaRIJv7QLHY/sG5+uahpFL1XuI7xERYJj00kuogKq1/6Vbyu6+cFG8SPx03
3RyKR0JvgiO1peBh5cLCckWDo25OtFAw7E02O+dLfS7wcnuk41rZ58IP1Ma0Ktjp
yKpXP0ptDbgsUqmXz0R7ZhREW8VukLW597wlK2qu2kczpqC/sPaR0MQtTT9Qqv9o
sUsAtZEgdCT/bbK/jbfAaIOWAi3OmHgG9/rYfxSCaPrQ7GGFSEE=
=VTpB
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.