Debian Bug report logs - #834016
ddd: please make the build reproducible

version graph

Package: src:ddd; Maintainer for src:ddd is Daniel Schepler <schepler@debian.org>;

Reported by: Chris Lamb <lamby@debian.org>

Date: Thu, 11 Aug 2016 13:09:02 UTC

Severity: wishlist

Tags: patch

Found in version ddd/1:3.3.12-5.1

Fixed in version ddd/1:3.3.12-5.4

Done: Vagrant Cascadian <vagrant@reproducible-builds.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-builds@lists.alioth.debian.org, Daniel Schepler <schepler@debian.org>:
Bug#834016; Package src:ddd. (Thu, 11 Aug 2016 13:09:05 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Lamb <lamby@debian.org>:
New Bug report received and forwarded. Copy sent to reproducible-builds@lists.alioth.debian.org, Daniel Schepler <schepler@debian.org>. (Thu, 11 Aug 2016 13:09:05 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>
To: submit@bugs.debian.org
Subject: ddd: please make the build reproducible
Date: Thu, 11 Aug 2016 14:04:46 +0100
[Message part 1 (text/plain, inline)]
Source: ddd
Version: 1:3.3.12-5.1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi,

Whilst working on the "reproducible builds" effort [0], we noticed
that ddd could not be built reproducibly.

Patch attached.

 [0] https://wiki.debian.org/ReproducibleBuilds


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-
[ddd.diff.txt (text/plain, attachment)]

Information forwarded to debian-bugs-dist@lists.debian.org, Daniel Schepler <schepler@debian.org>:
Bug#834016; Package src:ddd. (Thu, 11 Aug 2016 14:24:04 GMT) (full text, mbox, link).


Acknowledgement sent to Vagrant Cascadian <vagrant@debian.org>:
Extra info received and forwarded to list. Copy sent to Daniel Schepler <schepler@debian.org>. (Thu, 11 Aug 2016 14:24:04 GMT) (full text, mbox, link).


Message #10 received at 834016@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@debian.org>
To: Chris Lamb <lamby@debian.org>, 834016@bugs.debian.org, Reproducible Builds discussion list <reproducible-builds@lists.alioth.debian.org>
Subject: Re: Bug#834016: ddd: please make the build reproducible
Date: Thu, 11 Aug 2016 07:21:30 -0700
[Message part 1 (text/plain, inline)]
On 2016-08-11, Chris Lamb wrote:
> +--- ddd-3.3.12.orig/ddd/config-info
> ++++ ddd-3.3.12/ddd/config-info
> +@@ -59,6 +59,10 @@ esac
> + month=`date '+%m'`
> + day=`date '+%d'`
> + date=${year}-${month}-${day}
> ++if [ -n "${SOURCE_DATE_EPOCH}" ]
> ++then
> ++	date=`date --utc --date="@${SOURCE_DATE_EPOCH}" '+%Y-%m-%d'`
> ++fi
> + (
> +     echo "@(#)Built $date by $userinfo"
> +     if $features; then

Wouldn't this also require the "month" and "day" variables to be set
using SOURE_DATE_EPOCH?


live well,
  vagrant
[signature.asc (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, Daniel Schepler <schepler@debian.org>:
Bug#834016; Package src:ddd. (Thu, 11 Aug 2016 15:33:08 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Lamb <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Daniel Schepler <schepler@debian.org>. (Thu, 11 Aug 2016 15:33:08 GMT) (full text, mbox, link).


Message #15 received at 834016@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>
To: Vagrant Cascadian <vagrant@debian.org>, 834016@bugs.debian.org, Reproducible Builds discussion list <reproducible-builds@lists.alioth.debian.org>
Subject: Re: Bug#834016: ddd: please make the build reproducible
Date: Thu, 11 Aug 2016 16:28:34 +0100
> > + month=`date '+%m'`
> > + day=`date '+%d'`
> > + date=${year}-${month}-${day}
> > ++if [ -n "${SOURCE_DATE_EPOCH}" ]
> > ++then
> > ++	date=`date --utc --date="@${SOURCE_DATE_EPOCH}" '+%Y-%m-%d'`
> > ++fi
> 
> Wouldn't this also require the "month" and "day" variables to be set
> using SOURE_DATE_EPOCH?

$month and $day only appear to be used in constructing $date, so simply
setting $date results in the smallest and thus more maintainable patch
for a Debian package.

(If I were upstream I would drop the whole thing.)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-



Information forwarded to debian-bugs-dist@lists.debian.org, Daniel Schepler <schepler@debian.org>:
Bug#834016; Package src:ddd. (Sat, 12 Sep 2020 23:03:06 GMT) (full text, mbox, link).


Acknowledgement sent to "Chris Lamb" <lamby@debian.org>:
Extra info received and forwarded to list. Copy sent to Daniel Schepler <schepler@debian.org>. (Sat, 12 Sep 2020 23:03:06 GMT) (full text, mbox, link).


Message #20 received at 834016@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>
To: 834016@bugs.debian.org, reproducible-bugs@lists.alioth.debian.org
Subject: Re: Bug#834016: ddd: please make the build reproducible
Date: Sat, 12 Sep 2020 22:58:05 -0000
Chris Lamb wrote:

> [..]

Gentle ping on this?


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-



Information forwarded to debian-bugs-dist@lists.debian.org, Daniel Schepler <schepler@debian.org>:
Bug#834016; Package src:ddd. (Thu, 17 Nov 2022 20:57:02 GMT) (full text, mbox, link).


Acknowledgement sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
Extra info received and forwarded to list. Copy sent to Daniel Schepler <schepler@debian.org>. (Thu, 17 Nov 2022 20:57:02 GMT) (full text, mbox, link).


Message #25 received at 834016@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>
To: Chris Lamb <lamby@debian.org>, 834016@bugs.debian.org
Subject: Re: Bug#834016: ddd: please make the build reproducible
Date: Thu, 17 Nov 2022 12:53:41 -0800
[Message part 1 (text/plain, inline)]
Control: tags 834016 pending

> Whilst working on the "reproducible builds" effort [0], we noticed
> that ddd could not be built reproducibly.

I have pushed the fix to git:

  https://salsa.debian.org/debian/ddd/-/commit/3aa51771bacd797f68cbcf23b5f62b834148a2f6
  
And uploaded an NMU to DELAYED/10 fixing this and another fix already
included in git:

diff -Nru ddd-3.3.12/debian/changelog ddd-3.3.12/debian/changelog
--- ddd-3.3.12/debian/changelog	2021-02-10 13:05:37.000000000 -0800
+++ ddd-3.3.12/debian/changelog	2022-11-17 12:13:34.000000000 -0800
@@ -1,3 +1,16 @@
+ddd (1:3.3.12-5.4) unstable; urgency=medium
+
+  * Non-maintainer upload.
+
+  [ Debian Janitor ]
+  * Apply multi-arch hints.
+    + ddd-doc: Add Multi-Arch: foreign.
+
+  [ Chris Lamb ]
+  * Make the build reproducible. (Closes: #834016)
+
+ -- Vagrant Cascadian <vagrant@reproducible-builds.org>  Thu, 17 Nov 2022 12:13:34 -0800
+
 ddd (1:3.3.12-5.3) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru ddd-3.3.12/debian/control ddd-3.3.12/debian/control
--- ddd-3.3.12/debian/control	2021-02-10 12:59:52.000000000 -0800
+++ ddd-3.3.12/debian/control	2022-11-17 12:09:44.000000000 -0800
@@ -39,6 +39,7 @@
 Depends: ${misc:Depends}
 Recommends: pdf-viewer, postscript-viewer, ddd
 Replaces: ddd (<< 3.1.90)
+Multi-Arch: foreign
 Description: Additional documentation for the Data Display Debugger
  The "Debugging with DDD" and "Writing DDD Themes" User's Guide and 
  Reference Manual in PDF format ("info" versions are included in the "ddd"
diff -Nru ddd-3.3.12/debian/patches/007_reproducible_build.diff ddd-3.3.12/debian/patches/007_reproducible_build.diff
--- ddd-3.3.12/debian/patches/007_reproducible_build.diff	1969-12-31 16:00:00.000000000 -0800
+++ ddd-3.3.12/debian/patches/007_reproducible_build.diff	2022-11-17 12:10:26.000000000 -0800
@@ -0,0 +1,17 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby@debian.org>
+Last-Update: 2016-08-11
+
+--- ddd-3.3.12.orig/ddd/config-info
++++ ddd-3.3.12/ddd/config-info
+@@ -59,6 +59,10 @@ esac
+ month=`date '+%m'`
+ day=`date '+%d'`
+ date=${year}-${month}-${day}
++if [ -n "${SOURCE_DATE_EPOCH}" ]
++then
++	date=`date --utc --date="@${SOURCE_DATE_EPOCH}" '+%Y-%m-%d'`
++fi
+ (
+     echo "@(#)Built $date by $userinfo"
+     if $features; then
diff -Nru ddd-3.3.12/debian/patches/series ddd-3.3.12/debian/patches/series
--- ddd-3.3.12/debian/patches/series	2021-02-10 12:59:52.000000000 -0800
+++ ddd-3.3.12/debian/patches/series	2022-11-17 12:10:26.000000000 -0800
@@ -8,3 +8,4 @@
 tinfo_support.diff
 remove_broken_ICE_MOTIF_DIALOGS_OWN_SELECTION_LIST.diff
 fix-ftbfs-gcc-9.patch
+007_reproducible_build.diff


live well,
  vagrant
[signature.asc (application/pgp-signature, inline)]

Added tag(s) pending. Request was from Vagrant Cascadian <vagrant@reproducible-builds.org> to 834016-submit@bugs.debian.org. (Thu, 17 Nov 2022 20:57:02 GMT) (full text, mbox, link).


Reply sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
You have taken responsibility. (Sun, 27 Nov 2022 21:57:05 GMT) (full text, mbox, link).


Notification sent to Chris Lamb <lamby@debian.org>:
Bug acknowledged by developer. (Sun, 27 Nov 2022 21:57:05 GMT) (full text, mbox, link).


Message #32 received at 834016-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
To: 834016-close@bugs.debian.org
Subject: Bug#834016: fixed in ddd 1:3.3.12-5.4
Date: Sun, 27 Nov 2022 21:54:54 +0000
Source: ddd
Source-Version: 1:3.3.12-5.4
Done: Vagrant Cascadian <vagrant@reproducible-builds.org>

We believe that the bug you reported is fixed in the latest version of
ddd, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 834016@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@reproducible-builds.org> (supplier of updated ddd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 17 Nov 2022 12:13:34 -0800
Source: ddd
Architecture: source
Version: 1:3.3.12-5.4
Distribution: unstable
Urgency: medium
Maintainer: Daniel Schepler <schepler@debian.org>
Changed-By: Vagrant Cascadian <vagrant@reproducible-builds.org>
Closes: 834016
Changes:
 ddd (1:3.3.12-5.4) unstable; urgency=medium
 .
   * Non-maintainer upload.
 .
   [ Debian Janitor ]
   * Apply multi-arch hints.
     + ddd-doc: Add Multi-Arch: foreign.
 .
   [ Chris Lamb ]
   * Make the build reproducible. (Closes: #834016)
Checksums-Sha1:
 754ec74db6c674ae86917cf9ba833c0576d0d65e 1364 ddd_3.3.12-5.4.dsc
 750a663c6800afe6b0a78df4d438006a3b64b024 23660 ddd_3.3.12-5.4.debian.tar.xz
 8fb92488316468e85e39e79525eec07bc07be7fc 8089 ddd_3.3.12-5.4_arm64.buildinfo
Checksums-Sha256:
 003c2916cf6db0a3318793f74f4c69a42f9ac3b8cc7015ffda7ee965e4809974 1364 ddd_3.3.12-5.4.dsc
 c41075eeae181680e82988789caa3f379077724f0ca0c845cf05820e132fb414 23660 ddd_3.3.12-5.4.debian.tar.xz
 3d8539eec5d7fe0997fbef0ef04293ff9dd0103be40f88096d0cbbb66fa36013 8089 ddd_3.3.12-5.4_arm64.buildinfo
Files:
 d45f23fd72274839215afaeb1bfab916 1364 devel optional ddd_3.3.12-5.4.dsc
 70ca0885bbc3c9bd9c9f6272740cf98a 23660 devel optional ddd_3.3.12-5.4.debian.tar.xz
 47df25b10be6def537e98fad00c028f3 8089 devel optional ddd_3.3.12-5.4_arm64.buildinfo

-----BEGIN PGP SIGNATURE-----

iJYEARYKAD4WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCY3adeCAcdmFncmFudEBy
ZXByb2R1Y2libGUtYnVpbGRzLm9yZwAKCRDcUY/If5cWqvSbAP9SI0ybx6lWiDEQ
h9vQR4LD6aj6QwUiH82lZWdxvZ9DagEArll+tbj5Wc9pLUUPkSaSOk4ZVI0FXG5a
OBD3RGXgOA8=
=IQ6X
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Sat, 31 Dec 2022 07:26:43 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Wed May 17 11:31:52 2023; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.